mirror of
https://github.com/rustfs/rustfs.git
synced 2026-08-06 21:33:14 +00:00
cb977c4c5a
fix(admin): report unreachable info members as `unknown` with balanced drive counts `GET /rustfs/admin/v3/info` synthesizes an entry for every peer, but a peer whose properties RPC failed below the offline threshold with no cached snapshot was reported as `initializing` with an empty drive list. That drive list being empty meant its drives disappeared from the backend summary entirely, so `onlineDisks + offlineDisks` no longer equaled `totalDrivesPerSet` (an operator sees `onlineDisks: 3, offlineDisks: 0` for a 4-drive set), and `initializing` is a misleading state for a member that has been running for hours — it reads like a node was ejected when nothing is wrong (upstream rustfs/rustfs#4566). Changes: - madmin: add `ItemState::Unknown` ("unknown") and an `unknownDisks` bucket on `ErasureBackend` (serde `default`, so older payloads still deserialize). - ecstore diagnostics: `get_online_offline_disks_stats` now returns a third `unknown` bucket instead of folding those drives into `offline`, keeping `online + offline + unknown == totalDrivesPerSet`. - ecstore notification_sys: a probe miss below the failure threshold with no cache is now reported as `unknown` (not `initializing`) and carries the host's drives from the pool topology (tagged `unknown`) so the summary stays balanced; drive synthesis is factored into `synthesized_disks(host, endpoints, state)`, shared by the offline and unknown paths. Tracked in rustfs/backlog#1049 (P1-A + P0-A). Co-authored-by: heihutu <heihutu@gmail.com>
496 lines
18 KiB
Rust
496 lines
18 KiB
Rust
// Copyright 2024 RustFS Team
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
use crate::cluster::rpc::{TonicInterceptor, gen_tonic_signature_interceptor, node_service_time_out_client};
|
|
use crate::data_usage::{DATA_USAGE_CACHE_NAME, DATA_USAGE_ROOT, load_data_usage_from_backend};
|
|
use crate::error::{Error, Result};
|
|
use crate::{disk::endpoint::Endpoint, runtime::sources as runtime_sources};
|
|
|
|
use crate::data_usage::load_data_usage_cache;
|
|
use crate::storage_api_contracts::admin::StorageAdminApi;
|
|
use rustfs_common::heal_channel::DriveState;
|
|
use rustfs_madmin::{
|
|
BackendDisks, Disk, ErasureSetInfo, ITEM_INITIALIZING, ITEM_OFFLINE, ITEM_ONLINE, ITEM_UNKNOWN, InfoMessage, MemStats,
|
|
ServerProperties,
|
|
};
|
|
use rustfs_protos::{
|
|
models::{PingBody, PingBodyBuilder},
|
|
proto_gen::node_service::{PingRequest, PingResponse},
|
|
};
|
|
use std::{
|
|
collections::{HashMap, HashSet},
|
|
time::Duration,
|
|
};
|
|
use time::OffsetDateTime;
|
|
use tokio::time::timeout;
|
|
use tonic::Request;
|
|
use tracing::warn;
|
|
|
|
use shadow_rs::shadow;
|
|
|
|
shadow!(build);
|
|
|
|
const SERVER_PING_TIMEOUT: Duration = Duration::from_secs(1);
|
|
|
|
// pub const ITEM_OFFLINE: &str = "offline";
|
|
// pub const ITEM_INITIALIZING: &str = "initializing";
|
|
// pub const ITEM_ONLINE: &str = "online";
|
|
|
|
// #[derive(Debug, Default, Serialize, Deserialize)]
|
|
// pub struct MemStats {
|
|
// alloc: u64,
|
|
// total_alloc: u64,
|
|
// mallocs: u64,
|
|
// frees: u64,
|
|
// heap_alloc: u64,
|
|
// }
|
|
|
|
// #[derive(Debug, Default, Serialize, Deserialize)]
|
|
// pub struct ServerProperties {
|
|
// pub state: String,
|
|
// pub endpoint: String,
|
|
// pub scheme: String,
|
|
// pub uptime: u64,
|
|
// pub version: String,
|
|
// pub commit_id: String,
|
|
// pub network: HashMap<String, String>,
|
|
// pub disks: Vec<madmin::Disk>,
|
|
// pub pool_number: i32,
|
|
// pub pool_numbers: Vec<i32>,
|
|
// pub mem_stats: MemStats,
|
|
// pub max_procs: u64,
|
|
// pub num_cpu: u64,
|
|
// pub runtime_version: String,
|
|
// pub rustfs_env_vars: HashMap<String, String>,
|
|
// }
|
|
|
|
async fn is_server_resolvable(endpoint: &Endpoint) -> Result<()> {
|
|
let addr = format!(
|
|
"{}://{}:{}",
|
|
endpoint.url.scheme(),
|
|
endpoint.url.host_str().expect("URL should have host"),
|
|
// `Url::port()` is None when the URL uses the scheme's default port
|
|
// (e.g. http on 80 / https on 443); fall back to the scheme default.
|
|
endpoint.url.port_or_known_default().expect("URL should have port")
|
|
);
|
|
|
|
let ping_task = async {
|
|
let mut fbb = flatbuffers::FlatBufferBuilder::new();
|
|
let payload = fbb.create_vector(b"hello world");
|
|
|
|
let mut builder = PingBodyBuilder::new(&mut fbb);
|
|
builder.add_payload(payload);
|
|
let root = builder.finish();
|
|
fbb.finish(root, None);
|
|
|
|
let finished_data = fbb.finished_data();
|
|
|
|
let decoded_payload = flatbuffers::root::<PingBody>(finished_data);
|
|
assert!(decoded_payload.is_ok());
|
|
|
|
let mut client = node_service_time_out_client(&addr, TonicInterceptor::Signature(gen_tonic_signature_interceptor()))
|
|
.await
|
|
.map_err(|err| Error::other(format!("can not get client, err: {err}")))?;
|
|
|
|
let request = Request::new(PingRequest {
|
|
version: 1,
|
|
body: bytes::Bytes::copy_from_slice(finished_data),
|
|
});
|
|
|
|
let response: PingResponse = client.ping(request).await?.into_inner();
|
|
|
|
let ping_response_body = flatbuffers::root::<PingBody>(&response.body);
|
|
if let Err(e) = ping_response_body {
|
|
eprintln!("{e}");
|
|
} else {
|
|
println!("ping_resp:body(flatbuffer): {ping_response_body:?}");
|
|
}
|
|
|
|
Ok(())
|
|
};
|
|
|
|
timeout(SERVER_PING_TIMEOUT, ping_task)
|
|
.await
|
|
.map_err(|_| Error::other("server ping timeout"))?
|
|
}
|
|
|
|
pub async fn get_local_server_property() -> ServerProperties {
|
|
let addr = runtime_sources::local_node_name().await;
|
|
let mut pool_numbers = HashSet::new();
|
|
let mut network = HashMap::new();
|
|
let (mem_stats, max_procs, num_cpu) = collect_runtime_server_stats();
|
|
|
|
let endpoints = match runtime_sources::endpoint_pools() {
|
|
Some(eps) => eps,
|
|
None => {
|
|
return ServerProperties {
|
|
state: ITEM_INITIALIZING.to_string(),
|
|
endpoint: addr,
|
|
uptime: runtime_sources::boot_uptime_secs(),
|
|
version: get_commit_id(),
|
|
mem_stats,
|
|
max_procs,
|
|
num_cpu,
|
|
..Default::default()
|
|
};
|
|
}
|
|
};
|
|
for ep in endpoints.as_ref().iter() {
|
|
for endpoint in ep.endpoints.as_ref().iter() {
|
|
let node_name = match endpoint.url.host_str() {
|
|
Some(s) => s.to_string(),
|
|
None => addr.clone(),
|
|
};
|
|
if endpoint.is_local {
|
|
pool_numbers.insert(endpoint.pool_idx + 1);
|
|
network.insert(node_name, ITEM_ONLINE.to_string());
|
|
continue;
|
|
}
|
|
if let std::collections::hash_map::Entry::Vacant(e) = network.entry(node_name) {
|
|
if is_server_resolvable(endpoint).await.is_err() {
|
|
e.insert(ITEM_OFFLINE.to_string());
|
|
} else {
|
|
e.insert(ITEM_ONLINE.to_string());
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
let mut props = ServerProperties {
|
|
endpoint: addr,
|
|
uptime: runtime_sources::boot_uptime_secs(),
|
|
network,
|
|
version: get_commit_id(),
|
|
mem_stats,
|
|
max_procs,
|
|
num_cpu,
|
|
..Default::default()
|
|
};
|
|
|
|
for pool_num in pool_numbers.iter() {
|
|
props.pool_numbers.push(*pool_num);
|
|
}
|
|
props.pool_numbers.sort();
|
|
props.pool_number = if props.pool_numbers.len() == 1 {
|
|
props.pool_numbers[0]
|
|
} else {
|
|
i32::MAX
|
|
};
|
|
|
|
// let mut sensitive = HashSet::new();
|
|
// sensitive.insert(rustfs_config::ENV_RUSTFS_ACCESS_KEY.to_string());
|
|
// sensitive.insert(rustfs_config::ENV_RUSTFS_SECRET_KEY.to_string());
|
|
if let Some(store) = runtime_sources::object_store_handle() {
|
|
let storage_info = StorageAdminApi::local_storage_info(store.as_ref()).await;
|
|
props.state = ITEM_ONLINE.to_string();
|
|
props.disks = storage_info.disks;
|
|
} else {
|
|
props.state = ITEM_INITIALIZING.to_string();
|
|
};
|
|
|
|
props
|
|
}
|
|
|
|
fn collect_runtime_server_stats() -> (MemStats, u64, u64) {
|
|
let num_cpu = u64::try_from(num_cpus::get()).unwrap_or(u64::MAX);
|
|
let max_procs = std::thread::available_parallelism()
|
|
.map(|parallelism| u64::try_from(parallelism.get()).unwrap_or(u64::MAX))
|
|
.unwrap_or(num_cpu.max(1));
|
|
|
|
(rustfs_madmin::health::collect_mem_stats(), max_procs, num_cpu)
|
|
}
|
|
|
|
pub async fn get_server_info(get_pools: bool) -> InfoMessage {
|
|
let nowt: OffsetDateTime = OffsetDateTime::now_utc();
|
|
|
|
warn!("get_server_info start {:?}", nowt);
|
|
|
|
let local = get_local_server_property().await;
|
|
|
|
let after1 = OffsetDateTime::now_utc();
|
|
|
|
warn!("get_local_server_property end {:?}", after1 - nowt);
|
|
|
|
let mut servers = {
|
|
if let Some(sys) = runtime_sources::notification_sys() {
|
|
sys.server_info().await
|
|
} else {
|
|
vec![]
|
|
}
|
|
};
|
|
|
|
let after2 = OffsetDateTime::now_utc();
|
|
|
|
warn!("server_info end {:?}", after2 - after1);
|
|
servers.push(local);
|
|
|
|
let mut buckets = rustfs_madmin::Buckets::default();
|
|
let mut objects = rustfs_madmin::Objects::default();
|
|
let mut versions = rustfs_madmin::Versions::default();
|
|
let mut delete_markers = rustfs_madmin::DeleteMarkers::default();
|
|
let mut usage = rustfs_madmin::Usage::default();
|
|
let mut mode = ITEM_INITIALIZING;
|
|
let mut backend = rustfs_madmin::ErasureBackend::default();
|
|
let mut pools: HashMap<i32, HashMap<i32, ErasureSetInfo>> = HashMap::new();
|
|
|
|
if let Some(store) = runtime_sources::object_store_handle() {
|
|
mode = ITEM_ONLINE;
|
|
match load_data_usage_from_backend(store.clone()).await {
|
|
Ok(res) => {
|
|
buckets.count = res.buckets_count;
|
|
objects.count = res.objects_total_count;
|
|
versions.count = res.versions_total_count;
|
|
delete_markers.count = res.delete_markers_total_count;
|
|
usage.size = res.objects_total_size;
|
|
}
|
|
Err(err) => {
|
|
buckets.error = Some(err.to_string());
|
|
objects.error = Some(err.to_string());
|
|
versions.error = Some(err.to_string());
|
|
delete_markers.error = Some(err.to_string());
|
|
usage.error = Some(err.to_string());
|
|
}
|
|
}
|
|
|
|
let after3 = OffsetDateTime::now_utc();
|
|
|
|
warn!("load_data_usage_from_backend end {:?}", after3 - after2);
|
|
|
|
let backend_info = StorageAdminApi::backend_info(store.as_ref()).await;
|
|
|
|
let after4 = OffsetDateTime::now_utc();
|
|
|
|
warn!("backend_info end {:?}", after4 - after3);
|
|
|
|
let mut all_disks: Vec<Disk> = Vec::new();
|
|
for server in servers.iter() {
|
|
all_disks.extend(server.disks.clone());
|
|
}
|
|
let (online_disks, offline_disks, unknown_disks) = get_online_offline_disks_stats(&all_disks);
|
|
|
|
let after5 = OffsetDateTime::now_utc();
|
|
|
|
warn!("get_online_offline_disks_stats end {:?}", after5 - after4);
|
|
backend = rustfs_madmin::ErasureBackend {
|
|
backend_type: rustfs_madmin::BackendType::ErasureType,
|
|
online_disks: online_disks.sum(),
|
|
offline_disks: offline_disks.sum(),
|
|
unknown_disks: unknown_disks.sum(),
|
|
standard_sc_parity: backend_info.standard_sc_parity,
|
|
rr_sc_parity: backend_info.rr_sc_parity,
|
|
total_sets: backend_info.total_sets,
|
|
drives_per_set: backend_info.drives_per_set,
|
|
};
|
|
if get_pools {
|
|
pools = get_pools_info(&all_disks).await.unwrap_or_default();
|
|
let after6 = OffsetDateTime::now_utc();
|
|
|
|
warn!("get_pools_info end {:?}", after6 - after5);
|
|
}
|
|
}
|
|
|
|
let services = rustfs_madmin::Services::default();
|
|
|
|
InfoMessage {
|
|
mode: Some(mode.to_string()),
|
|
domain: None,
|
|
region: None,
|
|
sqs_arn: None,
|
|
deployment_id: runtime_sources::deployment_id(),
|
|
buckets: Some(buckets),
|
|
objects: Some(objects),
|
|
versions: Some(versions),
|
|
delete_markers: Some(delete_markers),
|
|
usage: Some(usage),
|
|
backend: Some(backend),
|
|
services: Some(services),
|
|
servers: Some(servers),
|
|
pools: Some(pools),
|
|
}
|
|
}
|
|
|
|
/// Classify every drive into online / offline / unknown buckets.
|
|
///
|
|
/// `unknown` holds drives synthesized for a member whose properties RPC could
|
|
/// not be answered this cycle but which is not confirmed offline. Keeping them
|
|
/// out of the `offline` bucket means a transient probe miss no longer inflates
|
|
/// the offline count for a healthy member, while `online + offline + unknown`
|
|
/// still sums to the pool's total drive count (rustfs/backlog#1049).
|
|
fn get_online_offline_disks_stats(disks_info: &[Disk]) -> (BackendDisks, BackendDisks, BackendDisks) {
|
|
let mut online_disks: HashMap<String, usize> = HashMap::new();
|
|
let mut offline_disks: HashMap<String, usize> = HashMap::new();
|
|
let mut unknown_disks: HashMap<String, usize> = HashMap::new();
|
|
|
|
for disk in disks_info {
|
|
let ep = &disk.endpoint;
|
|
offline_disks.entry(ep.clone()).or_insert(0);
|
|
online_disks.entry(ep.clone()).or_insert(0);
|
|
unknown_disks.entry(ep.clone()).or_insert(0);
|
|
}
|
|
|
|
for disk in disks_info {
|
|
let ep = &disk.endpoint;
|
|
let state = &disk.state;
|
|
if *state == ITEM_UNKNOWN {
|
|
*unknown_disks.get_mut(ep).expect("endpoint should be in disk map") += 1;
|
|
continue;
|
|
}
|
|
if *state != DriveState::Ok.to_string() && *state != DriveState::Unformatted.to_string() {
|
|
*offline_disks.get_mut(ep).expect("endpoint should be in disk map") += 1;
|
|
continue;
|
|
}
|
|
*online_disks.get_mut(ep).expect("endpoint should be in disk map") += 1;
|
|
}
|
|
|
|
let mut root_disk_count = 0;
|
|
for di in disks_info {
|
|
if di.root_disk {
|
|
root_disk_count += 1;
|
|
}
|
|
}
|
|
|
|
// When every non-offline, non-unknown drive is a root mount, leave the
|
|
// online tally as-is instead of demoting all of them (matches the prior
|
|
// behavior; the unknown bucket is simply carried through untouched).
|
|
if disks_info.len() == (root_disk_count + offline_disks.values().sum::<usize>() + unknown_disks.values().sum::<usize>()) {
|
|
return (BackendDisks(online_disks), BackendDisks(offline_disks), BackendDisks(unknown_disks));
|
|
}
|
|
|
|
for disk in disks_info {
|
|
let ep = &disk.endpoint;
|
|
if disk.root_disk {
|
|
*offline_disks.get_mut(ep).expect("endpoint should be in disk map") += 1;
|
|
*online_disks.get_mut(ep).expect("endpoint should be in disk map") -= 1;
|
|
}
|
|
}
|
|
|
|
(BackendDisks(online_disks), BackendDisks(offline_disks), BackendDisks(unknown_disks))
|
|
}
|
|
|
|
async fn get_pools_info(all_disks: &[Disk]) -> Result<HashMap<i32, HashMap<i32, ErasureSetInfo>>> {
|
|
let Some(store) = runtime_sources::object_store_handle() else {
|
|
return Err(Error::other("ServerNotInitialized"));
|
|
};
|
|
|
|
let mut pools_info: HashMap<i32, HashMap<i32, ErasureSetInfo>> = HashMap::new();
|
|
for d in all_disks {
|
|
let pool_info = pools_info.entry(d.pool_index).or_default();
|
|
let erasure_set = pool_info.entry(d.set_index).or_default();
|
|
|
|
if erasure_set.id == 0 {
|
|
erasure_set.id = d.set_index;
|
|
if let Ok(cache) = load_data_usage_cache(
|
|
&store.pools[d.pool_index as usize].disk_set[d.set_index as usize].clone(),
|
|
DATA_USAGE_CACHE_NAME,
|
|
)
|
|
.await
|
|
{
|
|
let data_usage_info = cache.dui(DATA_USAGE_ROOT, &Vec::<String>::new());
|
|
erasure_set.objects_count = data_usage_info.objects_total_count;
|
|
erasure_set.versions_count = data_usage_info.versions_total_count;
|
|
erasure_set.delete_markers_count = data_usage_info.delete_markers_total_count;
|
|
erasure_set.usage = data_usage_info.objects_total_size;
|
|
};
|
|
}
|
|
|
|
erasure_set.raw_capacity += d.total_space;
|
|
erasure_set.raw_usage += d.used_space;
|
|
if d.healing {
|
|
erasure_set.heal_disks = 1;
|
|
}
|
|
}
|
|
Ok(pools_info)
|
|
}
|
|
|
|
#[allow(clippy::const_is_empty)]
|
|
pub fn get_commit_id() -> String {
|
|
let ver = if !build::TAG.is_empty() {
|
|
build::TAG.to_string()
|
|
} else if !build::SHORT_COMMIT.is_empty() {
|
|
build::SHORT_COMMIT.to_string()
|
|
} else {
|
|
build::PKG_VERSION.to_string()
|
|
};
|
|
|
|
format!("{}@{}", build::COMMIT_DATE_3339, ver)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use serial_test::serial;
|
|
|
|
use crate::runtime::sources as runtime_sources;
|
|
use rustfs_madmin::{Disk, ITEM_OFFLINE, ITEM_UNKNOWN};
|
|
|
|
use super::{get_local_server_property, get_online_offline_disks_stats, get_server_info};
|
|
|
|
fn disk_with_state(endpoint: &str, state: &str) -> Disk {
|
|
Disk {
|
|
endpoint: endpoint.to_string(),
|
|
state: state.to_string(),
|
|
..Default::default()
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn disk_stats_split_unknown_into_its_own_bucket() {
|
|
// A member whose properties RPC could not be answered contributes
|
|
// drives tagged `unknown`. They must land in the unknown bucket, not
|
|
// inflate `offline`, and the three buckets must still account for every
|
|
// drive so the summary stays balanced (rustfs/backlog#1049).
|
|
//
|
|
// A live drive reports the DriveState string "ok"; only "ok"/"unformatted"
|
|
// count as online.
|
|
let disks = vec![
|
|
disk_with_state("http://n1:9000/data", "ok"),
|
|
disk_with_state("http://n2:9000/data", "ok"),
|
|
disk_with_state("http://n3:9000/data", ITEM_OFFLINE),
|
|
disk_with_state("http://n4:9000/data", ITEM_UNKNOWN),
|
|
];
|
|
|
|
let (online, offline, unknown) = get_online_offline_disks_stats(&disks);
|
|
|
|
assert_eq!(online.sum(), 2, "the two healthy drives are online");
|
|
assert_eq!(offline.sum(), 1, "only the confirmed-offline drive is offline");
|
|
assert_eq!(unknown.sum(), 1, "the unreachable member's drive is unknown, not offline");
|
|
assert_eq!(
|
|
online.sum() + offline.sum() + unknown.sum(),
|
|
disks.len(),
|
|
"online + offline + unknown must equal the total drive count"
|
|
);
|
|
}
|
|
|
|
#[serial]
|
|
#[tokio::test]
|
|
async fn server_info_includes_global_deployment_id() {
|
|
let expected_deployment_id = runtime_sources::deployment_id();
|
|
let info = get_server_info(false).await;
|
|
|
|
assert_eq!(info.deployment_id, expected_deployment_id);
|
|
}
|
|
|
|
#[serial]
|
|
#[tokio::test]
|
|
async fn local_server_property_includes_runtime_stats_without_endpoint_pools() {
|
|
let props = get_local_server_property().await;
|
|
|
|
assert!(props.num_cpu > 0);
|
|
assert!(props.max_procs > 0);
|
|
assert!(
|
|
props.mem_stats.alloc > 0 || props.mem_stats.total_alloc > 0 || props.mem_stats.heap_alloc > 0,
|
|
"memory stats should not remain fixed placeholders"
|
|
);
|
|
}
|
|
}
|