houseme 48bdf87e53 refactor(obs): drop the dial9 S3 config left stranded by the upload revert (#4700) ...

#4663 added a full S3 upload path (config fields + env parsing + wiring), then
reverted the wiring when its dependency turned out to carry RUSTSEC advisories
(D9-14). The revert stopped at enabled.rs and left the config layer half torn
down: `Dial9Config` still carried `s3_bucket`/`s3_prefix` with no consumer, plus
a dead `s3_upload_requested()`, and `Dial9SessionGuard::config()` was likewise
never called. All three are zero-consumer dead code.

Since S3 upload cannot be built at all, the config type should not model it.
Drop the two fields and both accessors. `from_env` still reads the S3 env vars
and warns about them (an operator who set them deserves to know why they do
nothing — that warning is deliberate and stays), but drops the values instead
of storing configuration nothing reads.

While here, collapse `from_env`'s two `record_config` calls into one by
extracting `from_env_enabled`, so the enabled/disabled paths share a single
publish point.

No behavior change: the S3 warning fires identically, and every other field is
untouched. Net -13 lines, and `Dial9Config` drops from 8 fields to 6.

Co-authored-by: heihutu <heihutu@gmail.com>

2026-07-10 19:44:07 +00:00

..

config.rs

refactor(obs): drop the dial9 S3 config left stranded by the upload revert (#4700)

2026-07-10 19:44:07 +00:00

disabled.rs

test(cache): end-to-end regressions for the body-cache hook P0s (#4675)

2026-07-10 12:17:20 +00:00

enabled.rs

refactor(obs): drop the dial9 S3 config left stranded by the upload revert (#4700)

2026-07-10 19:44:07 +00:00

mod.rs

fix(obs): remove the dial9 task-dump switch that could never work; correct measured claims (#4688)

2026-07-10 17:34:59 +00:00

state.rs

refactor(obs): make dial9 telemetry opt-in and actually record events (#4663)

2026-07-10 10:52:48 +00:00