// Copyright 2024 RustFS Team // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. use crate::error::Error as IamError; use crate::error::is_err_no_such_account; use crate::error::is_err_no_such_temp_account; use crate::error::{Error, Result}; use crate::manager::IamCache; use crate::manager::extract_jwt_claims; use crate::manager::get_default_policyes; use crate::store::GroupInfo; use crate::store::MappedPolicy; use crate::store::Store; use crate::store::UserType; use crate::utils::extract_claims; use rustfs_credentials::{Credentials, EMBEDDED_POLICY_TYPE, INHERITED_POLICY_TYPE, get_global_action_cred}; use rustfs_ecstore::notification_sys::get_global_notification_sys; use rustfs_madmin::AddOrUpdateUserReq; use rustfs_madmin::GroupDesc; use rustfs_policy::arn::ARN; use rustfs_policy::auth::{ ACCOUNT_ON, UserIdentity, contains_reserved_chars, create_new_credentials_with_metadata, generate_credentials, is_access_key_valid, is_secret_key_valid, }; use rustfs_policy::policy::Args; use rustfs_policy::policy::opa; use rustfs_policy::policy::{Policy, PolicyDoc, iam_policy_claim_name_sa}; use serde_json::Value; use serde_json::json; use std::collections::HashMap; use std::sync::Arc; use std::sync::OnceLock; use time::OffsetDateTime; use tokio::sync::RwLock; use tracing::{error, info, warn}; pub const MAX_SVCSESSION_POLICY_SIZE: usize = 4096; pub const STATUS_ENABLED: &str = "enabled"; pub const STATUS_DISABLED: &str = "disabled"; pub const POLICYNAME: &str = "policy"; pub const SESSION_POLICY_NAME: &str = "sessionPolicy"; pub const SESSION_POLICY_NAME_EXTRACTED: &str = "sessionPolicy-extracted"; static POLICY_PLUGIN_CLIENT: OnceLock>>> = OnceLock::new(); fn get_policy_plugin_client() -> Arc>> { POLICY_PLUGIN_CLIENT.get_or_init(|| Arc::new(RwLock::new(None))).clone() } pub struct IamSys { store: Arc>, roles_map: HashMap, } impl IamSys { /// Create a new IamSys instance with the given IamCache store /// /// # Arguments /// * `store` - An Arc to the IamCache instance /// /// # Returns /// A new instance of IamSys pub fn new(store: Arc>) -> Self { tokio::spawn(async move { match opa::lookup_config().await { Ok(conf) => { if conf.enable() { Self::set_policy_plugin_client(opa::AuthZPlugin::new(conf)).await; info!("OPA plugin enabled"); } } Err(e) => { error!("Error loading OPA configuration err:{}", e); } }; }); Self { store, roles_map: HashMap::new(), } } /// Check if the IamSys has a watcher configured /// /// # Returns /// `true` if a watcher is configured, `false` otherwise pub fn has_watcher(&self) -> bool { self.store.api.has_watcher() } pub async fn set_policy_plugin_client(client: rustfs_policy::policy::opa::AuthZPlugin) { let policy_plugin_client = get_policy_plugin_client(); let mut guard = policy_plugin_client.write().await; *guard = Some(client); } pub async fn get_policy_plugin_client() -> Option { let policy_plugin_client = get_policy_plugin_client(); let guard = policy_plugin_client.read().await; guard.clone() } pub async fn load_group(&self, name: &str) -> Result<()> { self.store.group_notification_handler(name).await } pub async fn load_groups(&self, m: &mut HashMap) -> Result<()> { self.store.api.load_groups(m).await } pub async fn load_policy(&self, name: &str) -> Result<()> { self.store.policy_notification_handler(name).await } pub async fn load_policy_mapping(&self, name: &str, user_type: UserType, is_group: bool) -> Result<()> { self.store .policy_mapping_notification_handler(name, user_type, is_group) .await } pub async fn load_user(&self, name: &str, user_type: UserType) -> Result<()> { self.store.user_notification_handler(name, user_type).await } pub async fn load_users(&self, user_type: UserType, m: &mut HashMap) -> Result<()> { self.store.api.load_users(user_type, m).await?; Ok(()) } pub async fn load_service_account(&self, name: &str) -> Result<()> { self.store.user_notification_handler(name, UserType::Svc).await } pub async fn delete_policy(&self, name: &str, notify: bool) -> Result<()> { for k in get_default_policyes().keys() { if k == name { return Err(Error::other("system policy can not be deleted")); } } self.store.delete_policy(name, notify).await?; if !notify || self.has_watcher() { return Ok(()); } if let Some(notification_sys) = get_global_notification_sys() { let resp = notification_sys.delete_policy(name).await; for r in resp { if let Some(err) = r.err { warn!("notify delete_policy failed: {}", err); } } } Ok(()) } pub async fn info_policy(&self, name: &str) -> Result { let d = self.store.get_policy_doc(name).await?; let pdata = serde_json::to_string(&d.policy)?; Ok(rustfs_madmin::PolicyInfo { policy_name: name.to_string(), policy: json!(pdata), create_date: d.create_date, update_date: d.update_date, }) } pub async fn load_mapped_policies( &self, user_type: UserType, is_group: bool, m: &mut HashMap, ) -> Result<()> { self.store.api.load_mapped_policies(user_type, is_group, m).await } pub async fn list_polices(&self, bucket_name: &str) -> Result> { self.store.list_polices(bucket_name).await } pub async fn list_policy_docs(&self, bucket_name: &str) -> Result> { self.store.list_policy_docs(bucket_name).await } pub async fn set_policy(&self, name: &str, policy: Policy) -> Result { let updated_at = self.store.set_policy(name, policy).await?; if !self.has_watcher() && let Some(notification_sys) = get_global_notification_sys() { let resp = notification_sys.load_policy(name).await; for r in resp { if let Some(err) = r.err { warn!("notify load_policy failed: {}", err); } } } Ok(updated_at) } pub async fn get_role_policy(&self, arn_str: &str) -> Result<(ARN, String)> { let Some(arn) = ARN::parse(arn_str).ok() else { return Err(Error::other("Invalid ARN")); }; let Some(policy) = self.roles_map.get(&arn) else { return Err(Error::other("No such role")); }; Ok((arn, policy.clone())) } pub async fn delete_user(&self, name: &str, notify: bool) -> Result<()> { self.store.delete_user(name, UserType::Reg).await?; if notify && !self.has_watcher() && let Some(notification_sys) = get_global_notification_sys() { let resp = notification_sys.delete_user(name).await; for r in resp { if let Some(err) = r.err { warn!("notify delete_user failed: {}", err); } } } Ok(()) } async fn notify_for_user(&self, name: &str, is_temp: bool) { if self.has_watcher() { return; } // Fire-and-forget notification to peers - don't block auth operations // This is critical for cluster recovery: login should not wait for dead peers let name = name.to_string(); tokio::spawn(async move { if let Some(notification_sys) = get_global_notification_sys() { let resp = notification_sys.load_user(&name, is_temp).await; for r in resp { if let Some(err) = r.err { warn!("notify load_user failed (non-blocking): {}", err); } } } }); } async fn notify_for_service_account(&self, name: &str) { if self.has_watcher() { return; } // Fire-and-forget notification to peers - don't block service account operations let name = name.to_string(); tokio::spawn(async move { if let Some(notification_sys) = get_global_notification_sys() { let resp = notification_sys.load_service_account(&name).await; for r in resp { if let Some(err) = r.err { warn!("notify load_service_account failed (non-blocking): {}", err); } } } }); } pub async fn current_policies(&self, name: &str) -> String { self.store.merge_policies(name).await.0 } pub async fn list_bucket_users(&self, bucket_name: &str) -> Result> { self.store.get_bucket_users(bucket_name).await } pub async fn list_users(&self) -> Result> { self.store.get_users().await } pub async fn set_temp_user(&self, name: &str, cred: &Credentials, policy_name: Option<&str>) -> Result { let updated_at = self.store.set_temp_user(name, cred, policy_name).await?; self.notify_for_user(&cred.access_key, true).await; Ok(updated_at) } pub async fn is_temp_user(&self, name: &str) -> Result<(bool, String)> { let Some(u) = self.store.get_user(name).await else { return Err(IamError::NoSuchUser(name.to_string())); }; if u.credentials.is_temp() { Ok((true, u.credentials.parent_user)) } else { Ok((false, "".to_string())) } } pub async fn is_service_account(&self, name: &str) -> Result<(bool, String)> { let Some(u) = self.store.get_user(name).await else { return Err(IamError::NoSuchUser(name.to_string())); }; if u.credentials.is_service_account() { Ok((true, u.credentials.parent_user)) } else { Ok((false, "".to_string())) } } pub async fn get_user_info(&self, name: &str) -> Result { self.store.get_user_info(name).await } pub async fn set_user_status(&self, name: &str, status: rustfs_madmin::AccountStatus) -> Result { let updated_at = self.store.set_user_status(name, status).await?; self.notify_for_user(name, false).await; Ok(updated_at) } pub async fn new_service_account( &self, parent_user: &str, groups: Option>, opts: NewServiceAccountOpts, ) -> Result<(Credentials, OffsetDateTime)> { if parent_user.is_empty() { return Err(IamError::InvalidArgument); } if !opts.access_key.is_empty() && opts.secret_key.is_empty() { return Err(IamError::NoSecretKeyWithAccessKey); } if !opts.secret_key.is_empty() && opts.access_key.is_empty() { return Err(IamError::NoAccessKeyWithSecretKey); } if parent_user == opts.access_key { return Err(IamError::IAMActionNotAllowed); } if opts.expiration.is_none() { return Err(IamError::InvalidExpiration); } // TODO: check allow_site_replicator_account let policy_buf = if let Some(policy) = opts.session_policy { policy.validate()?; let buf = serde_json::to_vec(&policy)?; if buf.len() > MAX_SVCSESSION_POLICY_SIZE { return Err(IamError::PolicyTooLarge); } buf } else { Vec::new() }; let mut m: HashMap = HashMap::new(); m.insert("parent".to_owned(), Value::String(parent_user.to_owned())); if !policy_buf.is_empty() { m.insert( SESSION_POLICY_NAME.to_owned(), Value::String(base64_simd::URL_SAFE_NO_PAD.encode_to_string(&policy_buf)), ); m.insert(iam_policy_claim_name_sa(), Value::String(EMBEDDED_POLICY_TYPE.to_owned())); } else { m.insert(iam_policy_claim_name_sa(), Value::String(INHERITED_POLICY_TYPE.to_owned())); } if let Some(claims) = opts.claims { for (k, v) in claims.iter() { if !m.contains_key(k) { m.insert(k.to_owned(), v.to_owned()); } } } // set expiration time default to 1 hour m.insert( "exp".to_string(), Value::Number(serde_json::Number::from( opts.expiration .map_or(OffsetDateTime::now_utc().unix_timestamp() + 3600, |t| t.unix_timestamp()), )), ); let (access_key, secret_key) = if !opts.access_key.is_empty() || !opts.secret_key.is_empty() { (opts.access_key, opts.secret_key) } else { generate_credentials()? }; let mut cred = create_new_credentials_with_metadata(&access_key, &secret_key, &m, &secret_key)?; cred.parent_user = parent_user.to_owned(); cred.groups = groups; cred.status = ACCOUNT_ON.to_owned(); cred.name = opts.name; cred.description = opts.description; cred.expiration = opts.expiration; let create_at = self.store.add_service_account(cred.clone()).await?; self.notify_for_service_account(&cred.access_key).await; Ok((cred, create_at)) } pub async fn update_service_account(&self, name: &str, opts: UpdateServiceAccountOpts) -> Result { let updated_at = self.store.update_service_account(name, opts).await?; self.notify_for_service_account(name).await; Ok(updated_at) } pub async fn list_service_accounts(&self, access_key: &str) -> Result> { self.store.list_service_accounts(access_key).await } pub async fn list_temp_accounts(&self, access_key: &str) -> Result> { self.store.list_temp_accounts(access_key).await } pub async fn list_sts_accounts(&self, access_key: &str) -> Result> { self.store.list_sts_accounts(access_key).await } pub async fn get_service_account(&self, access_key: &str) -> Result<(Credentials, Option)> { let (mut da, policy) = self.get_service_account_internal(access_key).await?; da.credentials.secret_key.clear(); da.credentials.session_token.clear(); Ok((da.credentials, policy)) } async fn get_service_account_internal(&self, access_key: &str) -> Result<(UserIdentity, Option)> { let (sa, claims) = match self.get_account_with_claims(access_key).await { Ok(res) => res, Err(err) => { if is_err_no_such_account(&err) { return Err(IamError::NoSuchServiceAccount(access_key.to_string())); } return Err(err); } }; if !sa.credentials.is_service_account() { return Err(IamError::NoSuchServiceAccount(access_key.to_string())); } let op_pt = claims.get(&iam_policy_claim_name_sa()); let op_sp = claims.get(SESSION_POLICY_NAME); if let (Some(pt), Some(sp)) = (op_pt, op_sp) && pt == EMBEDDED_POLICY_TYPE { let policy = serde_json::from_slice(&base64_simd::URL_SAFE_NO_PAD.decode_to_vec(sp.as_str().unwrap_or_default().as_bytes())?)?; return Ok((sa, Some(policy))); } Ok((sa, None)) } async fn get_account_with_claims(&self, access_key: &str) -> Result<(UserIdentity, HashMap)> { let Some(acc) = self.store.get_user(access_key).await else { return Err(IamError::NoSuchAccount(access_key.to_string())); }; let m = extract_jwt_claims(&acc)?; Ok((acc, m)) } pub async fn get_temporary_account(&self, access_key: &str) -> Result<(Credentials, Option)> { let (mut sa, policy) = match self.get_temp_account(access_key).await { Ok(res) => res, Err(err) => { if is_err_no_such_temp_account(&err) { // TODO: load_user match self.get_temp_account(access_key).await { Ok(res) => res, Err(err) => return Err(err), }; } return Err(err); } }; sa.credentials.secret_key.clear(); sa.credentials.session_token.clear(); Ok((sa.credentials, policy)) } async fn get_temp_account(&self, access_key: &str) -> Result<(UserIdentity, Option)> { let (sa, claims) = match self.get_account_with_claims(access_key).await { Ok(res) => res, Err(err) => { if is_err_no_such_account(&err) { return Err(IamError::NoSuchTempAccount(access_key.to_string())); } return Err(err); } }; if !sa.credentials.is_temp() { return Err(IamError::NoSuchTempAccount(access_key.to_string())); } let op_pt = claims.get(&iam_policy_claim_name_sa()); let op_sp = claims.get(SESSION_POLICY_NAME); if let (Some(pt), Some(sp)) = (op_pt, op_sp) && pt == EMBEDDED_POLICY_TYPE { let policy = serde_json::from_slice(&base64_simd::URL_SAFE_NO_PAD.decode_to_vec(sp.as_str().unwrap_or_default().as_bytes())?)?; return Ok((sa, Some(policy))); } Ok((sa, None)) } pub async fn get_claims_for_svc_acc(&self, access_key: &str) -> Result> { let Some(u) = self.store.get_user(access_key).await else { return Err(IamError::NoSuchServiceAccount(access_key.to_string())); }; if !u.credentials.is_service_account() { return Err(IamError::NoSuchServiceAccount(access_key.to_string())); } extract_jwt_claims(&u) } pub async fn delete_service_account(&self, access_key: &str, notify: bool) -> Result<()> { let Some(u) = self.store.get_user(access_key).await else { return Ok(()); }; if !u.credentials.is_service_account() { return Ok(()); } self.store.delete_user(access_key, UserType::Svc).await?; if notify && !self.has_watcher() && let Some(notification_sys) = get_global_notification_sys() { let resp = notification_sys.delete_service_account(access_key).await; for r in resp { if let Some(err) = r.err { warn!("notify delete_service_account failed: {}", err); } } } Ok(()) } async fn notify_for_group(&self, group: &str) { if self.has_watcher() { return; } // Fire-and-forget notification to peers - don't block group operations let group = group.to_string(); tokio::spawn(async move { if let Some(notification_sys) = get_global_notification_sys() { let resp = notification_sys.load_group(&group).await; for r in resp { if let Some(err) = r.err { warn!("notify load_group failed (non-blocking): {}", err); } } } }); } pub async fn create_user(&self, access_key: &str, args: &AddOrUpdateUserReq) -> Result { if !is_access_key_valid(access_key) { return Err(IamError::InvalidAccessKeyLength); } if contains_reserved_chars(access_key) { return Err(IamError::ContainsReservedChars); } if !is_secret_key_valid(&args.secret_key) { return Err(IamError::InvalidSecretKeyLength); } let updated_at = self.store.add_user(access_key, args).await?; self.notify_for_user(access_key, false).await; Ok(updated_at) } pub async fn set_user_secret_key(&self, access_key: &str, secret_key: &str) -> Result<()> { if !is_access_key_valid(access_key) { return Err(IamError::InvalidAccessKeyLength); } if !is_secret_key_valid(secret_key) { return Err(IamError::InvalidSecretKeyLength); } self.store.update_user_secret_key(access_key, secret_key).await } /// Add SSH public key for a user (for SFTP authentication) pub async fn add_user_ssh_public_key(&self, access_key: &str, public_key: &str) -> Result<()> { if !is_access_key_valid(access_key) { return Err(IamError::InvalidAccessKeyLength); } if public_key.is_empty() { return Err(IamError::InvalidArgument); } self.store.add_user_ssh_public_key(access_key, public_key).await } pub async fn check_key(&self, access_key: &str) -> Result<(Option, bool)> { if let Some(sys_cred) = get_global_action_cred() && sys_cred.access_key == access_key { return Ok((Some(UserIdentity::new(sys_cred)), true)); } match self.store.get_user(access_key).await { Some(res) => { let ok = res.credentials.is_valid(); Ok((Some(res), ok)) } None => { let _ = self.store.load_user(access_key).await; if let Some(res) = self.store.get_user(access_key).await { let ok = res.credentials.is_valid(); Ok((Some(res), ok)) } else { Ok((None, false)) } } } } pub async fn get_user(&self, access_key: &str) -> Option { match self.check_key(access_key).await { Ok((u, _)) => u, _ => None, } } pub async fn add_users_to_group(&self, group: &str, users: Vec) -> Result { if contains_reserved_chars(group) { return Err(IamError::GroupNameContainsReservedChars); } let updated_at = self.store.add_users_to_group(group, users).await?; self.notify_for_group(group).await; Ok(updated_at) } pub async fn remove_users_from_group(&self, group: &str, users: Vec) -> Result { let updated_at = self.store.remove_users_from_group(group, users).await?; self.notify_for_group(group).await; Ok(updated_at) } pub async fn set_group_status(&self, group: &str, enable: bool) -> Result { let updated_at = self.store.set_group_status(group, enable).await?; self.notify_for_group(group).await; Ok(updated_at) } pub async fn get_group_description(&self, group: &str) -> Result { self.store.get_group_description(group).await } pub async fn list_groups_load(&self) -> Result> { self.store.update_groups().await } pub async fn list_groups(&self) -> Result> { self.store.list_groups().await } pub async fn policy_db_set(&self, name: &str, user_type: UserType, is_group: bool, policy: &str) -> Result { let updated_at = self.store.policy_db_set(name, user_type, is_group, policy).await?; if !self.has_watcher() && let Some(notification_sys) = get_global_notification_sys() { let resp = notification_sys.load_policy_mapping(name, user_type.to_u64(), is_group).await; for r in resp { if let Some(err) = r.err { warn!("notify load_policy failed: {}", err); } } } Ok(updated_at) } pub async fn policy_db_get(&self, name: &str, groups: &Option>) -> Result> { self.store.policy_db_get(name, groups).await } pub async fn is_allowed_sts(&self, args: &Args<'_>, parent_user: &str) -> bool { let is_owner = matches!(get_global_action_cred(), Some(cred) if cred.access_key == parent_user); let role_arn = args.get_role_arn(); let (effective_groups, groups_source, policies) = if is_owner { (None, "owner", Vec::new()) } else if let Some(arn_str) = role_arn { let Ok(arn) = ARN::parse(arn_str) else { return false }; let p = MappedPolicy::new(self.roles_map.get(&arn).map_or_else(String::default, |v| v.clone()).as_str()).to_slice(); (None, "role", p) } else { let (effective_groups, groups_source) = match args.groups.as_ref() { Some(g) if !g.is_empty() => (args.groups.clone(), "args"), _ => match self.store.get_user(parent_user).await { Some(u) => (u.credentials.groups.clone(), "parent_user_credentials"), None => { tracing::warn!( parent_user = %parent_user, "is_allowed_sts: groups fallback failed — parent user not found; policy evaluation will use no groups" ); (None, "parent_user_credentials") } }, }; let Ok(p) = self.policy_db_get(parent_user, &effective_groups).await else { return false }; (effective_groups, groups_source, p) }; if !is_owner && policies.is_empty() { return false; } let combined_policy = { if is_owner { Policy::default() } else { let (a, c) = self.store.merge_policies(&policies.join(",")).await; if a.is_empty() { return false; } c } }; let (has_session_policy, is_allowed_sp) = is_allowed_by_session_policy(args); tracing::debug!( "is_allowed_sts: action={:?}, has_session_policy={}, is_allowed_sp={}, is_owner={}, parent_user={}, groups_source={}, effective_groups={:?}", args.action, has_session_policy, is_allowed_sp, is_owner, parent_user, groups_source, effective_groups ); if has_session_policy { return is_allowed_sp && (is_owner || combined_policy.is_allowed(args).await); } is_owner || combined_policy.is_allowed(args).await } pub async fn is_allowed_service_account(&self, args: &Args<'_>, parent_user: &str) -> bool { let Some(p) = args.claims.get("parent") else { return false; }; if p.as_str() != Some(parent_user) { return false; } let is_owner = matches!(get_global_action_cred(), Some(cred) if cred.access_key == parent_user); let role_arn = args.get_role_arn(); let svc_policies = { if is_owner { Vec::new() } else if role_arn.is_some() { let Ok(arn) = ARN::parse(role_arn.unwrap_or_default()) else { return false }; MappedPolicy::new(self.roles_map.get(&arn).map_or_else(String::default, |v| v.clone()).as_str()).to_slice() } else { let Ok(p) = self.policy_db_get(parent_user, args.groups).await else { return false }; p } }; if !is_owner && svc_policies.is_empty() { return false; } let combined_policy = { if is_owner { Policy::default() } else { let (a, c) = self.store.merge_policies(&svc_policies.join(",")).await; if a.is_empty() { return false; } c } }; let mut parent_args = args.clone(); parent_args.account = parent_user; let Some(sa) = args.claims.get(&iam_policy_claim_name_sa()) else { return false; }; let Some(sa_str) = sa.as_str() else { return false; }; if sa_str == INHERITED_POLICY_TYPE { return is_owner || combined_policy.is_allowed(&parent_args).await; } let (has_session_policy, is_allowed_sp) = is_allowed_by_session_policy_for_service_account(args); if has_session_policy { return is_allowed_sp && (is_owner || combined_policy.is_allowed(&parent_args).await); } is_owner || combined_policy.is_allowed(&parent_args).await } pub async fn get_combined_policy(&self, policies: &[String]) -> Policy { self.store.merge_policies(&policies.join(",")).await.1 } pub async fn is_allowed(&self, args: &Args<'_>) -> bool { if args.is_owner { return true; } let opa_enable = Self::get_policy_plugin_client().await; if let Some(opa_enable) = opa_enable { return opa_enable.is_allowed(args).await; } let Ok((is_temp, parent_user)) = self.is_temp_user(args.account).await else { return false }; if is_temp { return self.is_allowed_sts(args, &parent_user).await; } let Ok((is_svc, parent_user)) = self.is_service_account(args.account).await else { return false }; if is_svc { return self.is_allowed_service_account(args, &parent_user).await; } let Ok(policies) = self.policy_db_get(args.account, args.groups).await else { return false }; if policies.is_empty() { return false; } self.get_combined_policy(&policies).await.is_allowed(args).await } /// Check if the underlying store is ready pub fn is_ready(&self) -> bool { self.store.is_ready() } } fn is_allowed_by_session_policy(args: &Args<'_>) -> (bool, bool) { let Some(policy) = args.claims.get(SESSION_POLICY_NAME_EXTRACTED) else { return (false, false); }; let has_session_policy = true; let Some(policy_str) = policy.as_str() else { return (has_session_policy, false); }; let Ok(sub_policy) = Policy::parse_config(policy_str.as_bytes()) else { return (has_session_policy, false); }; if sub_policy.version.is_empty() { return (has_session_policy, false); } let mut session_policy_args = args.clone(); session_policy_args.is_owner = false; (has_session_policy, pollster::block_on(sub_policy.is_allowed(&session_policy_args))) } fn is_allowed_by_session_policy_for_service_account(args: &Args<'_>) -> (bool, bool) { let Some(policy) = args.claims.get(SESSION_POLICY_NAME_EXTRACTED) else { return (false, false); }; let mut has_session_policy = true; let Some(policy_str) = policy.as_str() else { return (has_session_policy, false); }; let Ok(sub_policy) = Policy::parse_config(policy_str.as_bytes()) else { return (has_session_policy, false); }; if sub_policy.version.is_empty() && sub_policy.statements.is_empty() && sub_policy.id.is_empty() { has_session_policy = false; return (has_session_policy, false); } let mut session_policy_args = args.clone(); session_policy_args.is_owner = false; (has_session_policy, pollster::block_on(sub_policy.is_allowed(&session_policy_args))) } #[derive(Debug, Clone, Default)] pub struct NewServiceAccountOpts { pub session_policy: Option, pub access_key: String, pub secret_key: String, pub name: Option, pub description: Option, pub expiration: Option, pub allow_site_replicator_account: bool, pub claims: Option>, } pub struct UpdateServiceAccountOpts { pub session_policy: Option, pub secret_key: Option, pub name: Option, pub description: Option, pub expiration: Option, pub status: Option, } pub fn get_claims_from_token_with_secret(token: &str, secret: &str) -> Result> { let mut ms = extract_claims::>(token, secret).map_err(|e| Error::other(format!("extract claims err {e}")))?; if let Some(session_policy) = ms.claims.get(SESSION_POLICY_NAME) { let policy_str = session_policy.as_str().unwrap_or_default(); let policy = base64_simd::URL_SAFE_NO_PAD .decode_to_vec(policy_str.as_bytes()) .map_err(|e| Error::other(format!("base64 decode err {e}")))?; ms.claims.insert( SESSION_POLICY_NAME_EXTRACTED.to_string(), Value::String(String::from_utf8(policy).map_err(|e| Error::other(format!("utf8 decode err {e}")))?), ); } Ok(ms.claims) } #[cfg(test)] mod tests { use super::*; use crate::cache::{Cache, CacheEntity}; use crate::error::Error; use crate::manager::get_default_policyes; use crate::store::{GroupInfo, MappedPolicy, Store, UserType}; use rustfs_credentials::Credentials; use rustfs_policy::auth::UserIdentity; use rustfs_policy::policy::Args; use rustfs_policy::policy::action::{Action, S3Action}; use std::collections::HashMap; use time::OffsetDateTime; /// Mock Store that populates cache in load_all so STS temp credentials /// without args.groups still get group-attached policies via parent user (groups fallback). #[derive(Clone)] struct StsGroupsFallbackMockStore; #[async_trait::async_trait] impl Store for StsGroupsFallbackMockStore { fn has_watcher(&self) -> bool { false } async fn save_iam_config(&self, _item: Item, _path: impl AsRef + Send) -> Result<()> { Ok(()) } async fn load_iam_config(&self, _path: impl AsRef + Send) -> Result { Err(Error::ConfigNotFound) } async fn delete_iam_config(&self, _path: impl AsRef + Send) -> Result<()> { Err(Error::InvalidArgument) } async fn save_user_identity( &self, _name: &str, _user_type: UserType, _item: UserIdentity, _ttl: Option, ) -> Result<()> { Err(Error::InvalidArgument) } async fn delete_user_identity(&self, _name: &str, _user_type: UserType) -> Result<()> { Err(Error::InvalidArgument) } async fn load_user_identity(&self, _name: &str, _user_type: UserType) -> Result { Err(Error::InvalidArgument) } async fn load_user(&self, _name: &str, _user_type: UserType, _m: &mut HashMap) -> Result<()> { Ok(()) } async fn load_users(&self, _user_type: UserType, _m: &mut HashMap) -> Result<()> { Ok(()) } async fn load_secret_key(&self, _name: &str, _user_type: UserType) -> Result { Err(Error::InvalidArgument) } async fn save_group_info(&self, _name: &str, _item: GroupInfo) -> Result<()> { Err(Error::InvalidArgument) } async fn delete_group_info(&self, _name: &str) -> Result<()> { Err(Error::InvalidArgument) } async fn load_group(&self, _name: &str, _m: &mut HashMap) -> Result<()> { Err(Error::InvalidArgument) } async fn load_groups(&self, _m: &mut HashMap) -> Result<()> { Err(Error::InvalidArgument) } async fn save_policy_doc(&self, _name: &str, _item: rustfs_policy::policy::PolicyDoc) -> Result<()> { Err(Error::InvalidArgument) } async fn delete_policy_doc(&self, _name: &str) -> Result<()> { Err(Error::InvalidArgument) } async fn load_policy(&self, _name: &str) -> Result { Err(Error::InvalidArgument) } async fn load_policy_doc(&self, _name: &str, _m: &mut HashMap) -> Result<()> { Err(Error::InvalidArgument) } async fn load_policy_docs(&self, _m: &mut HashMap) -> Result<()> { Err(Error::InvalidArgument) } async fn save_mapped_policy( &self, _name: &str, _user_type: UserType, _is_group: bool, _item: MappedPolicy, _ttl: Option, ) -> Result<()> { Err(Error::InvalidArgument) } async fn delete_mapped_policy(&self, _name: &str, _user_type: UserType, _is_group: bool) -> Result<()> { Err(Error::InvalidArgument) } async fn load_mapped_policy( &self, _name: &str, _user_type: UserType, _is_group: bool, _m: &mut HashMap, ) -> Result<()> { Ok(()) } async fn load_mapped_policies( &self, _user_type: UserType, _is_group: bool, _m: &mut HashMap, ) -> Result<()> { Ok(()) } async fn load_all(&self, cache: &Cache) -> Result<()> { const PARENT_USER: &str = "sts-fallback-test-parent"; const GROUP_NAME: &str = "testgroup"; let policy_docs = get_default_policyes(); cache .policy_docs .store(Arc::new(CacheEntity::new(policy_docs).update_load_time())); let creds = Credentials { access_key: PARENT_USER.to_string(), secret_key: "longenoughsecret".to_string(), session_token: String::new(), expiration: None, status: "on".to_string(), parent_user: String::new(), groups: Some(vec![GROUP_NAME.to_string()]), claims: None, name: None, description: None, }; let parent_identity = UserIdentity { version: 1, credentials: creds, update_at: Some(OffsetDateTime::now_utc()), }; let mut users = HashMap::new(); users.insert(PARENT_USER.to_string(), parent_identity); cache.users.store(Arc::new(CacheEntity::new(users).update_load_time())); let group = GroupInfo::new(vec![PARENT_USER.to_string()]); let mut groups = HashMap::new(); groups.insert(GROUP_NAME.to_string(), group); cache.groups.store(Arc::new(CacheEntity::new(groups).update_load_time())); let group_policy = MappedPolicy::new("readwrite"); let mut group_policies = HashMap::new(); group_policies.insert(GROUP_NAME.to_string(), group_policy); cache .group_policies .store(Arc::new(CacheEntity::new(group_policies).update_load_time())); cache.user_policies.store(Arc::new(CacheEntity::default().update_load_time())); cache.sts_accounts.store(Arc::new(CacheEntity::default().update_load_time())); cache.sts_policies.store(Arc::new(CacheEntity::default().update_load_time())); cache.build_user_group_memberships(); Ok(()) } } /// Regression test: temp credentials without groups in args still receive group-attached /// policies via the parent user (groups fallback). Without the fallback, policy_db_get /// would get None for groups and the user would have no group policies, so the action /// would be denied. #[tokio::test] async fn test_sts_groups_fallback_temp_creds_receive_parent_group_policies() { let store = StsGroupsFallbackMockStore; let cache_manager = IamCache::new(store).await; let iam_sys = IamSys::new(cache_manager); let parent_user = "sts-fallback-test-parent"; let claims = HashMap::new(); let groups: Option> = None; let args = Args { account: parent_user, groups: &groups, action: Action::S3Action(S3Action::ListBucketAction), bucket: "mybucket", conditions: &HashMap::new(), is_owner: false, object: "", claims: &claims, deny_only: false, }; let allowed = iam_sys.is_allowed_sts(&args, parent_user).await; assert!( allowed, "STS temp credentials with no groups in args should still be allowed via parent user's group policy (readwrite)" ); } }