mirror of
https://github.com/rustfs/rustfs.git
synced 2026-08-22 12:26:37 +00:00
Compare commits
2 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| ce7277a334 | |||
| d5ba6b4e16 |
@@ -400,7 +400,7 @@ jobs:
|
|||||||
if: github.event_name != 'pull_request' || github.event.action != 'closed'
|
if: github.event_name != 'pull_request' || github.event.action != 'closed'
|
||||||
needs: [ quick-checks ]
|
needs: [ quick-checks ]
|
||||||
runs-on: sm-standard-4
|
runs-on: sm-standard-4
|
||||||
timeout-minutes: 90
|
timeout-minutes: 45
|
||||||
env:
|
env:
|
||||||
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
|
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
|
||||||
steps:
|
steps:
|
||||||
@@ -440,7 +440,7 @@ jobs:
|
|||||||
if: github.event_name != 'pull_request' || github.event.action != 'closed'
|
if: github.event_name != 'pull_request' || github.event.action != 'closed'
|
||||||
needs: [ quick-checks ]
|
needs: [ quick-checks ]
|
||||||
runs-on: sm-standard-4
|
runs-on: sm-standard-4
|
||||||
timeout-minutes: 90
|
timeout-minutes: 60
|
||||||
env:
|
env:
|
||||||
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
|
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
|
||||||
steps:
|
steps:
|
||||||
@@ -470,7 +470,7 @@ jobs:
|
|||||||
if: github.event_name != 'pull_request' || github.event.action != 'closed'
|
if: github.event_name != 'pull_request' || github.event.action != 'closed'
|
||||||
needs: [ quick-checks ]
|
needs: [ quick-checks ]
|
||||||
runs-on: sm-standard-4
|
runs-on: sm-standard-4
|
||||||
timeout-minutes: 90
|
timeout-minutes: 60
|
||||||
strategy:
|
strategy:
|
||||||
# On a PR, one failing protocol leg is enough to know the PR is not ready,
|
# On a PR, one failing protocol leg is enough to know the PR is not ready,
|
||||||
# so stop the sibling leg instead of paying another ~40 minutes for it.
|
# so stop the sibling leg instead of paying another ~40 minutes for it.
|
||||||
|
|||||||
@@ -585,12 +585,9 @@ impl VersionsHistogram {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Replication statistics for a single target.
|
/// Replication statistics for a single target
|
||||||
///
|
#[derive(Debug, Default, Clone, Serialize, Deserialize)]
|
||||||
/// Renamed from `ReplicationStats`; serde field names are preserved
|
pub struct ReplicationStats {
|
||||||
/// byte-identically to maintain wire compatibility with existing snapshots.
|
|
||||||
#[derive(Debug, Default, Clone, Serialize, Deserialize, PartialEq, Eq)]
|
|
||||||
pub struct ReplicationTargetUsage {
|
|
||||||
pub pending_size: u64,
|
pub pending_size: u64,
|
||||||
pub replicated_size: u64,
|
pub replicated_size: u64,
|
||||||
pub failed_size: u64,
|
pub failed_size: u64,
|
||||||
@@ -603,7 +600,7 @@ pub struct ReplicationTargetUsage {
|
|||||||
pub replicated_count: u64,
|
pub replicated_count: u64,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl ReplicationTargetUsage {
|
impl ReplicationStats {
|
||||||
pub fn is_empty(&self) -> bool {
|
pub fn is_empty(&self) -> bool {
|
||||||
let Self {
|
let Self {
|
||||||
pending_size,
|
pending_size,
|
||||||
@@ -639,7 +636,7 @@ impl ReplicationTargetUsage {
|
|||||||
/// Replication statistics for all targets
|
/// Replication statistics for all targets
|
||||||
#[derive(Debug, Default, Clone, Serialize, Deserialize)]
|
#[derive(Debug, Default, Clone, Serialize, Deserialize)]
|
||||||
pub struct ReplicationAllStats {
|
pub struct ReplicationAllStats {
|
||||||
pub targets: HashMap<String, ReplicationTargetUsage>,
|
pub targets: HashMap<String, ReplicationStats>,
|
||||||
pub replica_size: u64,
|
pub replica_size: u64,
|
||||||
pub replica_count: u64,
|
pub replica_count: u64,
|
||||||
}
|
}
|
||||||
@@ -652,7 +649,7 @@ impl ReplicationAllStats {
|
|||||||
targets,
|
targets,
|
||||||
} = self;
|
} = self;
|
||||||
|
|
||||||
*replica_size == 0 && *replica_count == 0 && targets.values().all(ReplicationTargetUsage::is_empty)
|
*replica_size == 0 && *replica_count == 0 && targets.values().all(ReplicationStats::is_empty)
|
||||||
}
|
}
|
||||||
|
|
||||||
#[deprecated(note = "use is_empty instead")]
|
#[deprecated(note = "use is_empty instead")]
|
||||||
@@ -2469,7 +2466,7 @@ mod tests {
|
|||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn replication_stats_empty_checks_every_field() {
|
fn replication_stats_empty_checks_every_field() {
|
||||||
type SetField = fn(&mut ReplicationTargetUsage);
|
type SetField = fn(&mut ReplicationStats);
|
||||||
|
|
||||||
let cases: [(&str, SetField); 10] = [
|
let cases: [(&str, SetField); 10] = [
|
||||||
("pending_size", |stats| stats.pending_size = 1),
|
("pending_size", |stats| stats.pending_size = 1),
|
||||||
@@ -2484,9 +2481,9 @@ mod tests {
|
|||||||
("replicated_count", |stats| stats.replicated_count = 1),
|
("replicated_count", |stats| stats.replicated_count = 1),
|
||||||
];
|
];
|
||||||
|
|
||||||
assert!(ReplicationTargetUsage::default().is_empty());
|
assert!(ReplicationStats::default().is_empty());
|
||||||
for (field, set_nonzero) in cases {
|
for (field, set_nonzero) in cases {
|
||||||
let mut stats = ReplicationTargetUsage::default();
|
let mut stats = ReplicationStats::default();
|
||||||
set_nonzero(&mut stats);
|
set_nonzero(&mut stats);
|
||||||
assert!(!stats.is_empty(), "{field} must make replication stats non-empty");
|
assert!(!stats.is_empty(), "{field} must make replication stats non-empty");
|
||||||
}
|
}
|
||||||
@@ -2517,17 +2514,17 @@ mod tests {
|
|||||||
}
|
}
|
||||||
|
|
||||||
let empty_targets = ReplicationAllStats {
|
let empty_targets = ReplicationAllStats {
|
||||||
targets: HashMap::from([("arn:test:empty".to_string(), ReplicationTargetUsage::default())]),
|
targets: HashMap::from([("arn:test:empty".to_string(), ReplicationStats::default())]),
|
||||||
..Default::default()
|
..Default::default()
|
||||||
};
|
};
|
||||||
assert!(empty_targets.is_empty(), "all-empty targets must keep aggregate stats empty");
|
assert!(empty_targets.is_empty(), "all-empty targets must keep aggregate stats empty");
|
||||||
|
|
||||||
let stats = ReplicationAllStats {
|
let stats = ReplicationAllStats {
|
||||||
targets: HashMap::from([
|
targets: HashMap::from([
|
||||||
("arn:test:empty".to_string(), ReplicationTargetUsage::default()),
|
("arn:test:empty".to_string(), ReplicationStats::default()),
|
||||||
(
|
(
|
||||||
"arn:test:non-empty".to_string(),
|
"arn:test:non-empty".to_string(),
|
||||||
ReplicationTargetUsage {
|
ReplicationStats {
|
||||||
pending_count: 1,
|
pending_count: 1,
|
||||||
..Default::default()
|
..Default::default()
|
||||||
},
|
},
|
||||||
@@ -2568,7 +2565,7 @@ mod tests {
|
|||||||
replication_stats: Some(ReplicationAllStats {
|
replication_stats: Some(ReplicationAllStats {
|
||||||
targets: HashMap::from([(
|
targets: HashMap::from([(
|
||||||
"arn:test:pending".to_string(),
|
"arn:test:pending".to_string(),
|
||||||
ReplicationTargetUsage {
|
ReplicationStats {
|
||||||
pending_count: 1,
|
pending_count: 1,
|
||||||
..Default::default()
|
..Default::default()
|
||||||
},
|
},
|
||||||
@@ -2717,7 +2714,7 @@ mod tests {
|
|||||||
targets: HashMap::from([
|
targets: HashMap::from([
|
||||||
(
|
(
|
||||||
"arn:self-only".to_string(),
|
"arn:self-only".to_string(),
|
||||||
ReplicationTargetUsage {
|
ReplicationStats {
|
||||||
pending_size: 7,
|
pending_size: 7,
|
||||||
pending_count: 1,
|
pending_count: 1,
|
||||||
..Default::default()
|
..Default::default()
|
||||||
@@ -2725,7 +2722,7 @@ mod tests {
|
|||||||
),
|
),
|
||||||
(
|
(
|
||||||
"arn:shared".to_string(),
|
"arn:shared".to_string(),
|
||||||
ReplicationTargetUsage {
|
ReplicationStats {
|
||||||
failed_size: 3,
|
failed_size: 3,
|
||||||
failed_count: 1,
|
failed_count: 1,
|
||||||
missed_threshold_size: 2,
|
missed_threshold_size: 2,
|
||||||
@@ -2744,7 +2741,7 @@ mod tests {
|
|||||||
targets: HashMap::from([
|
targets: HashMap::from([
|
||||||
(
|
(
|
||||||
"arn:shared".to_string(),
|
"arn:shared".to_string(),
|
||||||
ReplicationTargetUsage {
|
ReplicationStats {
|
||||||
failed_size: 5,
|
failed_size: 5,
|
||||||
failed_count: 2,
|
failed_count: 2,
|
||||||
after_threshold_size: 4,
|
after_threshold_size: 4,
|
||||||
@@ -2754,7 +2751,7 @@ mod tests {
|
|||||||
),
|
),
|
||||||
(
|
(
|
||||||
"arn:other-only".to_string(),
|
"arn:other-only".to_string(),
|
||||||
ReplicationTargetUsage {
|
ReplicationStats {
|
||||||
replicated_size: 11,
|
replicated_size: 11,
|
||||||
replicated_count: 3,
|
replicated_count: 3,
|
||||||
..Default::default()
|
..Default::default()
|
||||||
@@ -2996,9 +2993,7 @@ mod tests {
|
|||||||
fn replication_target_deserialization_preserves_large_historical_maps() {
|
fn replication_target_deserialization_preserves_large_historical_maps() {
|
||||||
let mut stats = ReplicationAllStats::default();
|
let mut stats = ReplicationAllStats::default();
|
||||||
for index in 0..=1024 {
|
for index in 0..=1024 {
|
||||||
stats
|
stats.targets.insert(format!("target-{index}"), ReplicationStats::default());
|
||||||
.targets
|
|
||||||
.insert(format!("target-{index}"), ReplicationTargetUsage::default());
|
|
||||||
}
|
}
|
||||||
let encoded = rmp_serde::to_vec_named(&stats).expect("large replication target fixture should encode");
|
let encoded = rmp_serde::to_vec_named(&stats).expect("large replication target fixture should encode");
|
||||||
let decoded = rmp_serde::from_slice::<ReplicationAllStats>(&encoded)
|
let decoded = rmp_serde::from_slice::<ReplicationAllStats>(&encoded)
|
||||||
@@ -3007,47 +3002,6 @@ mod tests {
|
|||||||
assert_eq!(decoded.targets.len(), stats.targets.len());
|
assert_eq!(decoded.targets.len(), stats.targets.len());
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Round-trip test: encoding a [`ReplicationTargetUsage`] and decoding it back
|
|
||||||
/// must produce the exact same value. This guards against accidental serde
|
|
||||||
/// field-name drift during the `ReplicationStats` -> `ReplicationTargetUsage`
|
|
||||||
/// rename. Wire-level field names are the serialized Rust field identifiers,
|
|
||||||
/// which must remain byte-identical.
|
|
||||||
#[test]
|
|
||||||
fn replication_target_usage_rmp_round_trip() {
|
|
||||||
let original = ReplicationTargetUsage {
|
|
||||||
pending_size: 100,
|
|
||||||
replicated_size: 2_000,
|
|
||||||
failed_size: 50,
|
|
||||||
failed_count: 3,
|
|
||||||
pending_count: 7,
|
|
||||||
missed_threshold_size: 11,
|
|
||||||
after_threshold_size: 22,
|
|
||||||
missed_threshold_count: 1,
|
|
||||||
after_threshold_count: 2,
|
|
||||||
replicated_count: 99,
|
|
||||||
};
|
|
||||||
|
|
||||||
let buf = rmp_serde::to_vec_named(&original).expect("encode ReplicationTargetUsage to msgpack");
|
|
||||||
let decoded: ReplicationTargetUsage = rmp_serde::from_slice(&buf).expect("decode ReplicationTargetUsage from msgpack");
|
|
||||||
assert_eq!(original, decoded, "round-trip through rmp must preserve every field");
|
|
||||||
|
|
||||||
// Also verify that encoding as an unnamed sequence and then decoding
|
|
||||||
// with named fields produces the correct mapping (this catches reordering).
|
|
||||||
let named_buf = rmp_serde::to_vec_named(&original).expect("re-encode for field-name pinning");
|
|
||||||
// Spot-check that known field names appear in the named encoding.
|
|
||||||
let named_str = String::from_utf8_lossy(&named_buf);
|
|
||||||
assert!(named_str.contains("pending_size"), "field 'pending_size' must survive the rename");
|
|
||||||
assert!(named_str.contains("replicated_size"), "field 'replicated_size' must survive the rename");
|
|
||||||
assert!(
|
|
||||||
named_str.contains("missed_threshold_size"),
|
|
||||||
"field 'missed_threshold_size' must survive the rename"
|
|
||||||
);
|
|
||||||
assert!(
|
|
||||||
named_str.contains("after_threshold_count"),
|
|
||||||
"field 'after_threshold_count' must survive the rename"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn checked_merge_rejects_noncanonical_histograms_without_mutation() {
|
fn checked_merge_rejects_noncanonical_histograms_without_mutation() {
|
||||||
let mut entry = DataUsageEntry {
|
let mut entry = DataUsageEntry {
|
||||||
|
|||||||
@@ -50,10 +50,10 @@ use rustfs_protos::evict_failed_connection;
|
|||||||
use rustfs_protos::proto_gen::node_service::RenamePartRequest;
|
use rustfs_protos::proto_gen::node_service::RenamePartRequest;
|
||||||
use rustfs_protos::proto_gen::node_service::{
|
use rustfs_protos::proto_gen::node_service::{
|
||||||
BatchReadVersionRequest, BatchReadVersionResponse, CheckPartsRequest, DeletePathsRequest, DeleteRequest,
|
BatchReadVersionRequest, BatchReadVersionResponse, CheckPartsRequest, DeletePathsRequest, DeleteRequest,
|
||||||
DeleteVersionRequest, DeleteVersionsRequest, DeleteVersionsResponse, DeleteVolumeRequest, DiskInfoRequest, ListDirRequest,
|
DeleteVersionRequest, DeleteVersionsRequest, DeleteVolumeRequest, DiskInfoRequest, ListDirRequest, ListVolumesRequest,
|
||||||
ListVolumesRequest, MakeVolumeRequest, MakeVolumesRequest, PreparePartTransactionRequest, ReadAllRequest,
|
MakeVolumeRequest, MakeVolumesRequest, PreparePartTransactionRequest, ReadAllRequest, ReadMetadataRequest,
|
||||||
ReadMetadataRequest, ReadMultipleRequest, ReadMultipleResponse, ReadPartsRequest, ReadVersionRequest, ReadXlRequest,
|
ReadMultipleRequest, ReadMultipleResponse, ReadPartsRequest, ReadVersionRequest, ReadXlRequest, RenameDataRequest,
|
||||||
RenameDataRequest, RenameFileRequest, SettlePartTransactionRequest, SnapshotLeaseReleaseRequest, SnapshotLeaseRenewRequest,
|
RenameFileRequest, SettlePartTransactionRequest, SnapshotLeaseReleaseRequest, SnapshotLeaseRenewRequest,
|
||||||
SnapshotLeaseRequest, SnapshotLeaseResponse, StatVolumeRequest, UpdateMetadataRequest, VerifyFileRequest, WriteAllRequest,
|
SnapshotLeaseRequest, SnapshotLeaseResponse, StatVolumeRequest, UpdateMetadataRequest, VerifyFileRequest, WriteAllRequest,
|
||||||
WriteMetadataRequest, node_service_client::NodeServiceClient,
|
WriteMetadataRequest, node_service_client::NodeServiceClient,
|
||||||
};
|
};
|
||||||
@@ -112,28 +112,6 @@ const EVENT_REMOTE_DISK_RPC: &str = "remote_disk_rpc";
|
|||||||
const SNAPSHOT_LEASE_PROTOCOL_VERSION: u32 = 1;
|
const SNAPSHOT_LEASE_PROTOCOL_VERSION: u32 = 1;
|
||||||
pub const REMOTE_SNAPSHOT_LEASE_TTL: Duration = Duration::from_secs(60);
|
pub const REMOTE_SNAPSHOT_LEASE_TTL: Duration = Duration::from_secs(60);
|
||||||
|
|
||||||
fn decode_delete_versions_errors(response: DeleteVersionsResponse, expected_len: usize) -> Vec<Option<Error>> {
|
|
||||||
if !response.item_errors.is_empty() {
|
|
||||||
if response.item_errors.len() != expected_len {
|
|
||||||
return vec![Some(Error::other("malformed delete_versions item errors")); expected_len];
|
|
||||||
}
|
|
||||||
return response
|
|
||||||
.item_errors
|
|
||||||
.into_iter()
|
|
||||||
.map(|error| (error.code != 0).then(|| error.into()))
|
|
||||||
.collect();
|
|
||||||
}
|
|
||||||
|
|
||||||
if response.errors.len() != expected_len {
|
|
||||||
return vec![Some(Error::other("malformed delete_versions errors")); expected_len];
|
|
||||||
}
|
|
||||||
response
|
|
||||||
.errors
|
|
||||||
.into_iter()
|
|
||||||
.map(|error| (!error.is_empty()).then(|| Error::other(error)))
|
|
||||||
.collect()
|
|
||||||
}
|
|
||||||
|
|
||||||
fn snapshot_lease_token_from_response(response: SnapshotLeaseResponse) -> Result<SnapshotLeaseToken> {
|
fn snapshot_lease_token_from_response(response: SnapshotLeaseResponse) -> Result<SnapshotLeaseToken> {
|
||||||
if !response.success {
|
if !response.success {
|
||||||
return Err(response.error.unwrap_or_default().into());
|
return Err(response.error.unwrap_or_default().into());
|
||||||
@@ -2428,6 +2406,8 @@ impl DiskAPI for RemoteDisk {
|
|||||||
return errors;
|
return errors;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// TODO(backlog): replace string errors with typed `StorageError` variants
|
||||||
|
|
||||||
let result = self
|
let result = self
|
||||||
.execute_with_timeout(
|
.execute_with_timeout(
|
||||||
|| async {
|
|| async {
|
||||||
@@ -2459,7 +2439,17 @@ impl DiskAPI for RemoteDisk {
|
|||||||
}
|
}
|
||||||
return errors;
|
return errors;
|
||||||
}
|
}
|
||||||
decode_delete_versions_errors(response, versions.len())
|
response
|
||||||
|
.errors
|
||||||
|
.iter()
|
||||||
|
.map(|error| {
|
||||||
|
if error.is_empty() {
|
||||||
|
None
|
||||||
|
} else {
|
||||||
|
Some(Error::other(error.to_string()))
|
||||||
|
}
|
||||||
|
})
|
||||||
|
.collect()
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tracing::instrument(level = "trace", skip_all)]
|
#[tracing::instrument(level = "trace", skip_all)]
|
||||||
@@ -3770,63 +3760,6 @@ mod tests {
|
|||||||
|
|
||||||
static INIT: Once = Once::new();
|
static INIT: Once = Once::new();
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn delete_versions_response_preserves_typed_item_errors() {
|
|
||||||
let errors = decode_delete_versions_errors(
|
|
||||||
DeleteVersionsResponse {
|
|
||||||
success: true,
|
|
||||||
errors: vec!["file not found".to_string(), String::new()],
|
|
||||||
error: None,
|
|
||||||
item_errors: vec![
|
|
||||||
rustfs_protos::proto_gen::node_service::Error {
|
|
||||||
code: DiskError::FileNotFound.to_u32(),
|
|
||||||
error_info: "file not found".to_string(),
|
|
||||||
},
|
|
||||||
rustfs_protos::proto_gen::node_service::Error::default(),
|
|
||||||
],
|
|
||||||
},
|
|
||||||
2,
|
|
||||||
);
|
|
||||||
|
|
||||||
assert!(matches!(errors.as_slice(), [Some(DiskError::FileNotFound), None]));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn delete_versions_response_accepts_legacy_string_errors() {
|
|
||||||
let errors = decode_delete_versions_errors(
|
|
||||||
DeleteVersionsResponse {
|
|
||||||
success: true,
|
|
||||||
errors: vec!["legacy error".to_string(), String::new()],
|
|
||||||
error: None,
|
|
||||||
item_errors: Vec::new(),
|
|
||||||
},
|
|
||||||
2,
|
|
||||||
);
|
|
||||||
|
|
||||||
assert_eq!(errors.len(), 2);
|
|
||||||
assert_eq!(errors[0].as_ref().map(ToString::to_string).as_deref(), Some("io error legacy error"));
|
|
||||||
assert!(errors[1].is_none());
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn delete_versions_response_rejects_misaligned_item_errors() {
|
|
||||||
let errors = decode_delete_versions_errors(
|
|
||||||
DeleteVersionsResponse {
|
|
||||||
success: true,
|
|
||||||
errors: vec!["file not found".to_string()],
|
|
||||||
error: None,
|
|
||||||
item_errors: vec![rustfs_protos::proto_gen::node_service::Error {
|
|
||||||
code: DiskError::FileNotFound.to_u32(),
|
|
||||||
error_info: "file not found".to_string(),
|
|
||||||
}],
|
|
||||||
},
|
|
||||||
2,
|
|
||||||
);
|
|
||||||
|
|
||||||
assert_eq!(errors.len(), 2);
|
|
||||||
assert!(errors.iter().all(Option::is_some));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn disk_mutation_digest_marks_rolling_compatibility() {
|
fn disk_mutation_digest_marks_rolling_compatibility() {
|
||||||
let mut request = Request::new(());
|
let mut request = Request::new(());
|
||||||
|
|||||||
+122
-507
@@ -36,8 +36,7 @@ use crate::disk::error::DiskError;
|
|||||||
use crate::disk::{BUCKET_META_PREFIX, RUSTFS_META_BUCKET};
|
use crate::disk::{BUCKET_META_PREFIX, RUSTFS_META_BUCKET};
|
||||||
use crate::error::{Error, Result};
|
use crate::error::{Error, Result};
|
||||||
use crate::error::{
|
use crate::error::{
|
||||||
StorageError, is_err_bucket_exists, is_err_bucket_not_found, is_err_object_not_found, is_err_operation_canceled,
|
StorageError, is_err_bucket_exists, is_err_bucket_not_found, is_err_object_not_found, is_err_version_not_found,
|
||||||
is_err_version_not_found,
|
|
||||||
};
|
};
|
||||||
use crate::layout::endpoints::EndpointServerPools;
|
use crate::layout::endpoints::EndpointServerPools;
|
||||||
use crate::object_api::{GetObjectReader, ObjectOptions};
|
use crate::object_api::{GetObjectReader, ObjectOptions};
|
||||||
@@ -90,7 +89,6 @@ const DECOMMISSION_STAGE_SOURCE_CLEANUP: &str = "source_cleanup";
|
|||||||
const DECOMMISSION_STAGE_ENTRY_FINISHED: &str = "entry_finished";
|
const DECOMMISSION_STAGE_ENTRY_FINISHED: &str = "entry_finished";
|
||||||
const DECOMMISSION_PROGRESS_SAVE_INTERVAL: Duration = Duration::seconds(30);
|
const DECOMMISSION_PROGRESS_SAVE_INTERVAL: Duration = Duration::seconds(30);
|
||||||
const DECOMMISSION_PROGRESS_SAVE_ITEM_THRESHOLD: usize = 1000;
|
const DECOMMISSION_PROGRESS_SAVE_ITEM_THRESHOLD: usize = 1000;
|
||||||
const DECOMMISSION_PROGRESS_SAVE_RETRY_BACKOFF: Duration = Duration::seconds(1);
|
|
||||||
const DECOMMISSION_BUCKET_CONCURRENCY_ENV: &str = "RUSTFS_DECOMMISSION_BUCKET_CONCURRENCY";
|
const DECOMMISSION_BUCKET_CONCURRENCY_ENV: &str = "RUSTFS_DECOMMISSION_BUCKET_CONCURRENCY";
|
||||||
const DECOMMISSION_BUCKET_CONCURRENCY_DEFAULT_CAP: usize = 4;
|
const DECOMMISSION_BUCKET_CONCURRENCY_DEFAULT_CAP: usize = 4;
|
||||||
const DECOMMISSION_TARGET_CAPACITY_OVERHEAD_PERCENT: usize = 30;
|
const DECOMMISSION_TARGET_CAPACITY_OVERHEAD_PERCENT: usize = 30;
|
||||||
@@ -640,6 +638,22 @@ fn track_decommission_current_object(meta: &mut PoolMeta, idx: usize, bucket: &s
|
|||||||
track_decommission_current_object_stage(meta, idx, bucket, object, "")
|
track_decommission_current_object_stage(meta, idx, bucket, object, "")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn touch_decommission_progress(meta: &mut PoolMeta, idx: usize) -> Result<()> {
|
||||||
|
let pool_count = meta.pools.len();
|
||||||
|
ensure_valid_decommission_pool_index(pool_count, idx)?;
|
||||||
|
|
||||||
|
let Some(pool) = meta.pools.get_mut(idx) else {
|
||||||
|
return Err(invalid_decommission_pool_index_error(pool_count, idx));
|
||||||
|
};
|
||||||
|
let Some(info) = pool.decommission.as_mut() else {
|
||||||
|
return Err(decommission_metadata_not_initialized_error("touch decommission progress"));
|
||||||
|
};
|
||||||
|
|
||||||
|
pool.last_update = OffsetDateTime::now_utc();
|
||||||
|
info.mark_progress_saved();
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
fn resolve_decommission_update_after_result(result: Result<bool>) -> Result<bool> {
|
fn resolve_decommission_update_after_result(result: Result<bool>) -> Result<bool> {
|
||||||
result.map_err(|err| Error::other(format!("decommission metadata update failed: {err}")))
|
result.map_err(|err| Error::other(format!("decommission metadata update failed: {err}")))
|
||||||
}
|
}
|
||||||
@@ -759,76 +773,7 @@ async fn load_decommission_entry_exact_versions(
|
|||||||
}
|
}
|
||||||
|
|
||||||
fn resolve_decommission_check_after_list_result(list_result: Result<()>, entry_error: Option<Error>) -> Result<()> {
|
fn resolve_decommission_check_after_list_result(list_result: Result<()>, entry_error: Option<Error>) -> Result<()> {
|
||||||
match list_result {
|
if let Some(err) = entry_error { Err(err) } else { list_result }
|
||||||
Ok(()) => entry_error.map_or(Ok(()), Err),
|
|
||||||
Err(list_err) => resolve_decommission_listing_error(Some(list_err), entry_error).map_or(Ok(()), Err),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fn resolve_decommission_listing_error(listing_error: Option<Error>, entry_error: Option<Error>) -> Option<Error> {
|
|
||||||
match (listing_error, entry_error) {
|
|
||||||
(Some(listing_error), Some(entry_error)) if is_err_operation_canceled(&listing_error) => Some(entry_error),
|
|
||||||
(Some(listing_error), Some(entry_error)) if is_err_operation_canceled(&entry_error) => Some(listing_error),
|
|
||||||
(Some(listing_error), _) => Some(listing_error),
|
|
||||||
(None, entry_error) => entry_error,
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fn decommission_unresolved_listing_error(
|
|
||||||
bucket: &str,
|
|
||||||
prefix: &str,
|
|
||||||
candidate: Option<&str>,
|
|
||||||
candidate_count: usize,
|
|
||||||
disk_error_count: usize,
|
|
||||||
pool_index: usize,
|
|
||||||
set_index: usize,
|
|
||||||
) -> Error {
|
|
||||||
let location = candidate.unwrap_or(prefix);
|
|
||||||
Error::other(format!(
|
|
||||||
"decommission listing could not resolve metadata for {bucket}/{location} on pool {pool_index} set {set_index} ({candidate_count} candidate(s), {disk_error_count} disk error(s))"
|
|
||||||
))
|
|
||||||
}
|
|
||||||
|
|
||||||
fn resolve_decommission_partial_listing_entry(
|
|
||||||
entries: MetaCacheEntries,
|
|
||||||
resolver: MetadataResolutionParams,
|
|
||||||
bucket: &str,
|
|
||||||
prefix: &str,
|
|
||||||
disk_error_count: usize,
|
|
||||||
pool_index: usize,
|
|
||||||
set_index: usize,
|
|
||||||
) -> Result<MetaCacheEntry> {
|
|
||||||
let candidate_count = entries.as_ref().iter().flatten().count();
|
|
||||||
if let Some(entry) = entries.resolve(resolver) {
|
|
||||||
return Ok(entry);
|
|
||||||
}
|
|
||||||
|
|
||||||
let candidate = entries.as_ref().iter().flatten().map(|entry| entry.name.as_str()).next();
|
|
||||||
Err(decommission_unresolved_listing_error(
|
|
||||||
bucket,
|
|
||||||
prefix,
|
|
||||||
candidate,
|
|
||||||
candidate_count,
|
|
||||||
disk_error_count,
|
|
||||||
pool_index,
|
|
||||||
set_index,
|
|
||||||
))
|
|
||||||
}
|
|
||||||
|
|
||||||
async fn record_decommission_entry_error(
|
|
||||||
entry_error: &Arc<tokio::sync::Mutex<Option<Error>>>,
|
|
||||||
rx: &CancellationToken,
|
|
||||||
err: Error,
|
|
||||||
) {
|
|
||||||
if rx.is_cancelled() {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
let mut first_err = entry_error.lock().await;
|
|
||||||
if first_err.is_none() && !rx.is_cancelled() {
|
|
||||||
*first_err = Some(err);
|
|
||||||
rx.cancel();
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
fn resolve_decommission_pool_meta_reload_result(result: Result<()>, stage: &str) -> Result<()> {
|
fn resolve_decommission_pool_meta_reload_result(result: Result<()>, stage: &str) -> Result<()> {
|
||||||
@@ -1538,7 +1483,6 @@ impl TryFrom<PersistedPoolDecommissionInfo> for PoolDecommissionInfo {
|
|||||||
terminal_reload_attempt_at: value.terminal_reload_attempt_at,
|
terminal_reload_attempt_at: value.terminal_reload_attempt_at,
|
||||||
terminal_reload_failures: value.terminal_reload_failures,
|
terminal_reload_failures: value.terminal_reload_failures,
|
||||||
progress_save_item_baseline: value.items_decommissioned.saturating_add(value.items_decommission_failed),
|
progress_save_item_baseline: value.items_decommissioned.saturating_add(value.items_decommission_failed),
|
||||||
progress_save_retry_after: None,
|
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1570,7 +1514,6 @@ impl TryFrom<LegacyPoolDecommissionInfo> for PoolDecommissionInfo {
|
|||||||
terminal_reload_attempt_at: None,
|
terminal_reload_attempt_at: None,
|
||||||
terminal_reload_failures: Vec::new(),
|
terminal_reload_failures: Vec::new(),
|
||||||
progress_save_item_baseline: value.items_decommissioned.saturating_add(value.items_decommission_failed),
|
progress_save_item_baseline: value.items_decommissioned.saturating_add(value.items_decommission_failed),
|
||||||
progress_save_retry_after: None,
|
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1684,82 +1627,6 @@ impl PoolMeta {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn decommission_progress_checkpoint(
|
|
||||||
&self,
|
|
||||||
idx: usize,
|
|
||||||
duration: Duration,
|
|
||||||
now: OffsetDateTime,
|
|
||||||
) -> Result<Option<DecommissionProgressCheckpoint>> {
|
|
||||||
let pool_count = self.pools.len();
|
|
||||||
ensure_valid_decommission_pool_index(pool_count, idx)?;
|
|
||||||
|
|
||||||
let Some(pool) = self.pools.get(idx) else {
|
|
||||||
return Err(invalid_decommission_pool_index_error(pool_count, idx));
|
|
||||||
};
|
|
||||||
let Some(info) = pool.decommission.as_ref() else {
|
|
||||||
return Err(decommission_metadata_not_initialized_error("update decommission metadata timestamp"));
|
|
||||||
};
|
|
||||||
|
|
||||||
if info.progress_save_retry_after.is_some_and(|retry_after| now < retry_after) {
|
|
||||||
return Ok(None);
|
|
||||||
}
|
|
||||||
|
|
||||||
let time_threshold_reached = now.unix_timestamp() - pool.last_update.unix_timestamp() >= duration.whole_seconds();
|
|
||||||
let item_threshold_reached = info.items_since_last_progress_save() >= DECOMMISSION_PROGRESS_SAVE_ITEM_THRESHOLD;
|
|
||||||
if !time_threshold_reached && !item_threshold_reached {
|
|
||||||
return Ok(None);
|
|
||||||
}
|
|
||||||
|
|
||||||
Ok(Some(DecommissionProgressCheckpoint {
|
|
||||||
start_time: info.start_time,
|
|
||||||
queued: info.queued,
|
|
||||||
counted_items: info.counted_items(),
|
|
||||||
checkpoint_at: now,
|
|
||||||
}))
|
|
||||||
}
|
|
||||||
|
|
||||||
fn commit_decommission_progress_checkpoint(&mut self, idx: usize, checkpoint: DecommissionProgressCheckpoint) -> bool {
|
|
||||||
let Some(pool) = self.pools.get_mut(idx) else {
|
|
||||||
return false;
|
|
||||||
};
|
|
||||||
let Some(info) = pool.decommission.as_mut() else {
|
|
||||||
return false;
|
|
||||||
};
|
|
||||||
|
|
||||||
if info.start_time != checkpoint.start_time
|
|
||||||
|| info.queued != checkpoint.queued
|
|
||||||
|| !is_decommission_active(info.complete, info.failed, info.canceled)
|
|
||||||
{
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
info.progress_save_item_baseline = info.progress_save_item_baseline.max(checkpoint.counted_items);
|
|
||||||
info.progress_save_retry_after = None;
|
|
||||||
pool.last_update = pool.last_update.max(checkpoint.checkpoint_at);
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn defer_decommission_progress_checkpoint(
|
|
||||||
&mut self,
|
|
||||||
idx: usize,
|
|
||||||
checkpoint: DecommissionProgressCheckpoint,
|
|
||||||
retry_after: OffsetDateTime,
|
|
||||||
) {
|
|
||||||
let Some(pool) = self.pools.get_mut(idx) else {
|
|
||||||
return;
|
|
||||||
};
|
|
||||||
let Some(info) = pool.decommission.as_mut() else {
|
|
||||||
return;
|
|
||||||
};
|
|
||||||
|
|
||||||
if info.start_time == checkpoint.start_time
|
|
||||||
&& info.queued == checkpoint.queued
|
|
||||||
&& is_decommission_active(info.complete, info.failed, info.canceled)
|
|
||||||
{
|
|
||||||
info.progress_save_retry_after = Some(retry_after);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fn load_from_config_data(&mut self, data: Vec<u8>) -> Result<()> {
|
fn load_from_config_data(&mut self, data: Vec<u8>) -> Result<()> {
|
||||||
if data.is_empty() {
|
if data.is_empty() {
|
||||||
return Ok(());
|
return Ok(());
|
||||||
@@ -2120,9 +1987,30 @@ impl PoolMeta {
|
|||||||
}
|
}
|
||||||
|
|
||||||
pub fn update_after(&mut self, idx: usize, duration: Duration) -> Result<bool> {
|
pub fn update_after(&mut self, idx: usize, duration: Duration) -> Result<bool> {
|
||||||
Ok(self
|
let pool_count = self.pools.len();
|
||||||
.decommission_progress_checkpoint(idx, duration, OffsetDateTime::now_utc())?
|
ensure_valid_decommission_pool_index(pool_count, idx)?;
|
||||||
.is_some())
|
|
||||||
|
let (last_update, item_threshold_reached) = match self.pools.get(idx) {
|
||||||
|
Some(pool) if let Some(info) = pool.decommission.as_ref() => (
|
||||||
|
pool.last_update,
|
||||||
|
info.items_since_last_progress_save() >= DECOMMISSION_PROGRESS_SAVE_ITEM_THRESHOLD,
|
||||||
|
),
|
||||||
|
Some(_) => {
|
||||||
|
return Err(decommission_metadata_not_initialized_error("update decommission metadata timestamp"));
|
||||||
|
}
|
||||||
|
None => return Err(invalid_decommission_pool_index_error(pool_count, idx)),
|
||||||
|
};
|
||||||
|
let now = OffsetDateTime::now_utc();
|
||||||
|
|
||||||
|
if now.unix_timestamp() - last_update.unix_timestamp() >= duration.whole_seconds() || item_threshold_reached {
|
||||||
|
let Some(pool) = self.pools.get_mut(idx) else {
|
||||||
|
return Err(invalid_decommission_pool_index_error(pool_count, idx));
|
||||||
|
};
|
||||||
|
pool.last_update = now;
|
||||||
|
return Ok(true);
|
||||||
|
}
|
||||||
|
|
||||||
|
Ok(false)
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn validate(&self, pools: Vec<Arc<Sets>>) -> Result<bool> {
|
pub fn validate(&self, pools: Vec<Arc<Sets>>) -> Result<bool> {
|
||||||
@@ -2263,16 +2151,6 @@ pub struct PoolDecommissionInfo {
|
|||||||
pub terminal_reload_failures: Vec<String>,
|
pub terminal_reload_failures: Vec<String>,
|
||||||
#[serde(skip)]
|
#[serde(skip)]
|
||||||
pub progress_save_item_baseline: usize,
|
pub progress_save_item_baseline: usize,
|
||||||
#[serde(skip)]
|
|
||||||
pub progress_save_retry_after: Option<OffsetDateTime>,
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
|
||||||
struct DecommissionProgressCheckpoint {
|
|
||||||
start_time: Option<OffsetDateTime>,
|
|
||||||
queued: bool,
|
|
||||||
counted_items: usize,
|
|
||||||
checkpoint_at: OffsetDateTime,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl PoolDecommissionInfo {
|
impl PoolDecommissionInfo {
|
||||||
@@ -2307,7 +2185,6 @@ impl PoolDecommissionInfo {
|
|||||||
|
|
||||||
fn mark_progress_saved(&mut self) {
|
fn mark_progress_saved(&mut self) {
|
||||||
self.progress_save_item_baseline = self.counted_items();
|
self.progress_save_item_baseline = self.counted_items();
|
||||||
self.progress_save_retry_after = None;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn bucket_push(&mut self, bucket: &DecomBucketInfo) {
|
pub fn bucket_push(&mut self, bucket: &DecomBucketInfo) {
|
||||||
@@ -2612,40 +2489,6 @@ impl ECStore {
|
|||||||
snapshot.save(self.pools.clone()).await
|
snapshot.save(self.pools.clone()).await
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn save_decommission_progress_checkpoint(&self, idx: usize) -> Result<bool> {
|
|
||||||
// Lock order: save gate, then the short pool metadata read/write sections. Peer
|
|
||||||
// reloads are intentionally performed by the caller after both locks are released.
|
|
||||||
let _save_guard = self.pool_meta_save_gate.lock().await;
|
|
||||||
let (snapshot, checkpoint) = {
|
|
||||||
let pool_meta = self.pool_meta.read().await;
|
|
||||||
let Some(checkpoint) = pool_meta.decommission_progress_checkpoint(
|
|
||||||
idx,
|
|
||||||
DECOMMISSION_PROGRESS_SAVE_INTERVAL,
|
|
||||||
OffsetDateTime::now_utc(),
|
|
||||||
)?
|
|
||||||
else {
|
|
||||||
return Ok(false);
|
|
||||||
};
|
|
||||||
|
|
||||||
let mut snapshot = pool_meta.clone();
|
|
||||||
let Some(pool) = snapshot.pools.get_mut(idx) else {
|
|
||||||
return Err(invalid_decommission_pool_index_error(snapshot.pools.len(), idx));
|
|
||||||
};
|
|
||||||
pool.last_update = checkpoint.checkpoint_at;
|
|
||||||
(snapshot, checkpoint)
|
|
||||||
};
|
|
||||||
|
|
||||||
if let Err(err) = snapshot.save(self.pools.clone()).await {
|
|
||||||
let retry_after = OffsetDateTime::now_utc() + DECOMMISSION_PROGRESS_SAVE_RETRY_BACKOFF;
|
|
||||||
let mut pool_meta = self.pool_meta.write().await;
|
|
||||||
pool_meta.defer_decommission_progress_checkpoint(idx, checkpoint, retry_after);
|
|
||||||
return Err(err);
|
|
||||||
}
|
|
||||||
|
|
||||||
let mut pool_meta = self.pool_meta.write().await;
|
|
||||||
Ok(pool_meta.commit_decommission_progress_checkpoint(idx, checkpoint))
|
|
||||||
}
|
|
||||||
|
|
||||||
async fn save_current_pool_meta_for_decommission_start(
|
async fn save_current_pool_meta_for_decommission_start(
|
||||||
&self,
|
&self,
|
||||||
indices: &[usize],
|
indices: &[usize],
|
||||||
@@ -3028,7 +2871,7 @@ impl ECStore {
|
|||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn track_decommission_entry_progress_stage(
|
async fn save_decommission_entry_progress_stage(
|
||||||
&self,
|
&self,
|
||||||
idx: usize,
|
idx: usize,
|
||||||
bucket: &str,
|
bucket: &str,
|
||||||
@@ -3039,6 +2882,22 @@ impl ECStore {
|
|||||||
let mut pool_meta = self.pool_meta.write().await;
|
let mut pool_meta = self.pool_meta.write().await;
|
||||||
track_decommission_current_object_stage(&mut pool_meta, idx, bucket, object, stage)
|
track_decommission_current_object_stage(&mut pool_meta, idx, bucket, object, stage)
|
||||||
.map_err(|err| with_decommission_entry_context(stage, bucket, object, err))?;
|
.map_err(|err| with_decommission_entry_context(stage, bucket, object, err))?;
|
||||||
|
touch_decommission_progress(&mut pool_meta, idx)
|
||||||
|
.map_err(|err| with_decommission_entry_context(stage, bucket, object, err))?;
|
||||||
|
}
|
||||||
|
|
||||||
|
if let Some(err) = resolve_decommission_progress_save_result(self.save_current_pool_meta().await) {
|
||||||
|
warn!(
|
||||||
|
event = EVENT_DECOMMISSION_ENTRY,
|
||||||
|
component = LOG_COMPONENT_ECSTORE,
|
||||||
|
subsystem = LOG_SUBSYSTEM_POOLS,
|
||||||
|
pool_index = idx,
|
||||||
|
bucket = %bucket,
|
||||||
|
object = %object,
|
||||||
|
stage,
|
||||||
|
error = ?err,
|
||||||
|
"Decommission progress stage save failed"
|
||||||
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
Ok(())
|
Ok(())
|
||||||
@@ -3306,7 +3165,7 @@ impl ECStore {
|
|||||||
let bucket_name = bucket.clone();
|
let bucket_name = bucket.clone();
|
||||||
let object_name = rd.object_info.name.clone();
|
let object_name = rd.object_info.name.clone();
|
||||||
|
|
||||||
self.track_decommission_entry_progress_stage(
|
self.save_decommission_entry_progress_stage(
|
||||||
idx,
|
idx,
|
||||||
bucket_name.as_str(),
|
bucket_name.as_str(),
|
||||||
object_name.as_str(),
|
object_name.as_str(),
|
||||||
@@ -3400,7 +3259,7 @@ impl ECStore {
|
|||||||
}
|
}
|
||||||
decommission_cancel_signal_result(rx.is_cancelled())?;
|
decommission_cancel_signal_result(rx.is_cancelled())?;
|
||||||
|
|
||||||
self.track_decommission_entry_progress_stage(
|
self.save_decommission_entry_progress_stage(
|
||||||
idx,
|
idx,
|
||||||
bucket.as_str(),
|
bucket.as_str(),
|
||||||
entry.name.as_str(),
|
entry.name.as_str(),
|
||||||
@@ -3408,7 +3267,7 @@ impl ECStore {
|
|||||||
)
|
)
|
||||||
.await?;
|
.await?;
|
||||||
|
|
||||||
self.track_decommission_entry_progress_stage(
|
self.save_decommission_entry_progress_stage(
|
||||||
idx,
|
idx,
|
||||||
bucket.as_str(),
|
bucket.as_str(),
|
||||||
entry.name.as_str(),
|
entry.name.as_str(),
|
||||||
@@ -3475,42 +3334,34 @@ impl ECStore {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
self.track_decommission_entry_progress_stage(
|
self.save_decommission_entry_progress_stage(idx, bucket.as_str(), entry.name.as_str(), DECOMMISSION_STAGE_ENTRY_FINISHED)
|
||||||
idx,
|
.await?;
|
||||||
bucket.as_str(),
|
|
||||||
entry.name.as_str(),
|
|
||||||
DECOMMISSION_STAGE_ENTRY_FINISHED,
|
|
||||||
)
|
|
||||||
.await?;
|
|
||||||
|
|
||||||
if should_save_progress {
|
if should_save_progress {
|
||||||
match self.save_decommission_progress_checkpoint(idx).await {
|
let save_result = self.save_current_pool_meta().await;
|
||||||
Ok(true) => {
|
if let Some(err) = resolve_decommission_progress_save_result(save_result) {
|
||||||
if let Some(notification_sys) = runtime_sources::notification_sys()
|
warn!(
|
||||||
&& let Err(err) = resolve_decommission_entry_reload_result(
|
event = EVENT_DECOMMISSION_ENTRY,
|
||||||
notification_sys.reload_pool_meta().await,
|
component = LOG_COMPONENT_ECSTORE,
|
||||||
bucket.as_str(),
|
subsystem = LOG_SUBSYSTEM_POOLS,
|
||||||
entry.name.as_str(),
|
pool_index = idx,
|
||||||
)
|
bucket = %bucket,
|
||||||
{
|
object = %entry.name,
|
||||||
warn!("{err}");
|
state = "progress_save_failed",
|
||||||
}
|
error = %err,
|
||||||
}
|
"Decommission progress save failed; continuing and will retry at the next checkpoint"
|
||||||
Ok(false) => {}
|
);
|
||||||
Err(err) => {
|
} else {
|
||||||
if let Some(err) = resolve_decommission_progress_save_result(Err(err)) {
|
let mut pool_meta = self.pool_meta.write().await;
|
||||||
warn!(
|
pool_meta.mark_decommission_progress_saved();
|
||||||
event = EVENT_DECOMMISSION_ENTRY,
|
if let Some(notification_sys) = runtime_sources::notification_sys()
|
||||||
component = LOG_COMPONENT_ECSTORE,
|
&& let Err(err) = resolve_decommission_entry_reload_result(
|
||||||
subsystem = LOG_SUBSYSTEM_POOLS,
|
notification_sys.reload_pool_meta().await,
|
||||||
pool_index = idx,
|
bucket.as_str(),
|
||||||
bucket = %bucket,
|
entry.name.as_str(),
|
||||||
object = %entry.name,
|
)
|
||||||
state = "progress_save_failed",
|
{
|
||||||
error = %err,
|
warn!("{err}");
|
||||||
"Decommission progress save failed; continuing and will retry at the next checkpoint"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -3687,7 +3538,6 @@ impl ECStore {
|
|||||||
let rx_clone = rx.clone();
|
let rx_clone = rx.clone();
|
||||||
let bi = bi.clone();
|
let bi = bi.clone();
|
||||||
let set_id = set_idx;
|
let set_id = set_idx;
|
||||||
let listing_entry_error = entry_error.clone();
|
|
||||||
let worker = tokio::spawn(async move {
|
let worker = tokio::spawn(async move {
|
||||||
let _listing_permit = listing_permit;
|
let _listing_permit = listing_permit;
|
||||||
run_decommission_listing_with_retry(
|
run_decommission_listing_with_retry(
|
||||||
@@ -3701,11 +3551,7 @@ impl ECStore {
|
|||||||
let set = set.clone();
|
let set = set.clone();
|
||||||
let rx = rx_clone.clone();
|
let rx = rx_clone.clone();
|
||||||
let bucket = bi.clone();
|
let bucket = bi.clone();
|
||||||
let entry_error = listing_entry_error.clone();
|
async move { set.list_objects_to_decommission(rx, bucket, callback).await }
|
||||||
async move {
|
|
||||||
set.list_objects_to_decommission(rx, bucket, callback, entry_error.clone(), idx, set_id)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
},
|
},
|
||||||
)
|
)
|
||||||
.await
|
.await
|
||||||
@@ -3735,7 +3581,11 @@ impl ECStore {
|
|||||||
|
|
||||||
wait_decommission_worker_drain(&workers, worker_limit).await?;
|
wait_decommission_worker_drain(&workers, worker_limit).await?;
|
||||||
|
|
||||||
if let Some(err) = resolve_decommission_listing_error(listing_worker_error, entry_error.lock().await.clone()) {
|
if let Some(err) = listing_worker_error {
|
||||||
|
return Err(err);
|
||||||
|
}
|
||||||
|
|
||||||
|
if let Some(err) = entry_error.lock().await.clone() {
|
||||||
return Err(err);
|
return Err(err);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -4341,7 +4191,7 @@ impl ECStore {
|
|||||||
let buckets = self.get_buckets_to_decommission().await?;
|
let buckets = self.get_buckets_to_decommission().await?;
|
||||||
let pool = self.pools[idx].clone();
|
let pool = self.pools[idx].clone();
|
||||||
|
|
||||||
for (set_index, set) in pool.disk_set.iter().enumerate() {
|
for set in &pool.disk_set {
|
||||||
for bucket_info in &buckets {
|
for bucket_info in &buckets {
|
||||||
let mut lifecycle_config = None;
|
let mut lifecycle_config = None;
|
||||||
let mut object_lock_config = None;
|
let mut object_lock_config = None;
|
||||||
@@ -4436,7 +4286,7 @@ impl ECStore {
|
|||||||
});
|
});
|
||||||
|
|
||||||
let list_result = set
|
let list_result = set
|
||||||
.list_objects_to_decommission(callback_rx, bucket_info.clone(), callback, entry_error.clone(), idx, set_index)
|
.list_objects_to_decommission(callback_rx, bucket_info.clone(), callback)
|
||||||
.await;
|
.await;
|
||||||
let entry_error = entry_error.lock().await.clone();
|
let entry_error = entry_error.lock().await.clone();
|
||||||
resolve_decommission_check_after_list_result(list_result, entry_error)?;
|
resolve_decommission_check_after_list_result(list_result, entry_error)?;
|
||||||
@@ -5171,15 +5021,12 @@ mod tests {
|
|||||||
pub type ListCallback = Arc<dyn Fn(MetaCacheEntry) -> BoxFuture<'static, ()> + Send + Sync + 'static>;
|
pub type ListCallback = Arc<dyn Fn(MetaCacheEntry) -> BoxFuture<'static, ()> + Send + Sync + 'static>;
|
||||||
|
|
||||||
impl SetDisks {
|
impl SetDisks {
|
||||||
#[tracing::instrument(skip(self, rx, cb_func, entry_error))]
|
#[tracing::instrument(skip(self, rx, cb_func))]
|
||||||
async fn list_objects_to_decommission(
|
async fn list_objects_to_decommission(
|
||||||
self: &Arc<Self>,
|
self: &Arc<Self>,
|
||||||
rx: CancellationToken,
|
rx: CancellationToken,
|
||||||
bucket_info: DecomBucketInfo,
|
bucket_info: DecomBucketInfo,
|
||||||
cb_func: ListCallback,
|
cb_func: ListCallback,
|
||||||
entry_error: Arc<tokio::sync::Mutex<Option<Error>>>,
|
|
||||||
pool_index: usize,
|
|
||||||
set_index: usize,
|
|
||||||
) -> Result<()> {
|
) -> Result<()> {
|
||||||
let (disks, _) = self.get_online_disks_with_healing(false).await;
|
let (disks, _) = self.get_online_disks_with_healing(false).await;
|
||||||
ensure_decommission_listing_disks_available(!disks.is_empty(), &bucket_info.name)?;
|
ensure_decommission_listing_disks_available(!disks.is_empty(), &bucket_info.name)?;
|
||||||
@@ -5194,12 +5041,6 @@ impl SetDisks {
|
|||||||
};
|
};
|
||||||
|
|
||||||
let cb1 = cb_func.clone();
|
let cb1 = cb_func.clone();
|
||||||
let unresolved_error = entry_error.clone();
|
|
||||||
let unresolved_rx = rx.clone();
|
|
||||||
let unresolved_bucket = bucket_info.name.clone();
|
|
||||||
let unresolved_prefix = bucket_info.prefix.clone();
|
|
||||||
let unresolved_pool_index = pool_index;
|
|
||||||
let unresolved_set_index = set_index;
|
|
||||||
|
|
||||||
list_path_raw(
|
list_path_raw(
|
||||||
rx,
|
rx,
|
||||||
@@ -5212,51 +5053,20 @@ impl SetDisks {
|
|||||||
skip_walkdir_total_timeout: true,
|
skip_walkdir_total_timeout: true,
|
||||||
walkdir_stall_timeout: Some(DECOMMISSION_BACKGROUND_WALKDIR_STALL_TIMEOUT),
|
walkdir_stall_timeout: Some(DECOMMISSION_BACKGROUND_WALKDIR_STALL_TIMEOUT),
|
||||||
agreed: Some(Box::new(move |entry: MetaCacheEntry| Box::pin(cb1(entry)))),
|
agreed: Some(Box::new(move |entry: MetaCacheEntry| Box::pin(cb1(entry)))),
|
||||||
partial: Some(Box::new(move |entries: MetaCacheEntries, errs: &[Option<DiskError>]| {
|
partial: Some(Box::new(move |entries: MetaCacheEntries, _: &[Option<DiskError>]| {
|
||||||
let resolver = resolver.clone();
|
let resolver = resolver.clone();
|
||||||
let cb_func = cb_func.clone();
|
let cb_func = cb_func.clone();
|
||||||
let bucket = unresolved_bucket.clone();
|
match entries.resolve(resolver) {
|
||||||
let prefix = unresolved_prefix.clone();
|
Some(entry) => {
|
||||||
let unresolved_error = unresolved_error.clone();
|
|
||||||
let unresolved_rx = unresolved_rx.clone();
|
|
||||||
let pool_index = unresolved_pool_index;
|
|
||||||
let set_index = unresolved_set_index;
|
|
||||||
let disk_error_count = errs.iter().flatten().count();
|
|
||||||
if unresolved_rx.is_cancelled() {
|
|
||||||
return Box::pin(async {});
|
|
||||||
}
|
|
||||||
|
|
||||||
match resolve_decommission_partial_listing_entry(
|
|
||||||
entries,
|
|
||||||
resolver,
|
|
||||||
&bucket,
|
|
||||||
&prefix,
|
|
||||||
disk_error_count,
|
|
||||||
pool_index,
|
|
||||||
set_index,
|
|
||||||
) {
|
|
||||||
Ok(entry) => {
|
|
||||||
warn!("decommission_pool: list_objects_to_decommission get {}", &entry.name);
|
warn!("decommission_pool: list_objects_to_decommission get {}", &entry.name);
|
||||||
Box::pin(async move {
|
Box::pin(async move {
|
||||||
cb_func(entry).await;
|
cb_func(entry).await;
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
Err(err) => Box::pin(async move {
|
None => {
|
||||||
if unresolved_rx.is_cancelled() {
|
warn!("decommission_pool: list_objects_to_decommission get none");
|
||||||
return;
|
Box::pin(async {})
|
||||||
}
|
}
|
||||||
warn!(
|
|
||||||
event = EVENT_DECOMMISSION_BUCKET,
|
|
||||||
component = LOG_COMPONENT_ECSTORE,
|
|
||||||
subsystem = LOG_SUBSYSTEM_POOLS,
|
|
||||||
bucket = %bucket,
|
|
||||||
prefix = %prefix,
|
|
||||||
state = "unresolved_entry",
|
|
||||||
error = %err,
|
|
||||||
"Decommission listing failed closed on unresolved metadata"
|
|
||||||
);
|
|
||||||
record_decommission_entry_error(&unresolved_error, &unresolved_rx, err).await;
|
|
||||||
}),
|
|
||||||
}
|
}
|
||||||
})),
|
})),
|
||||||
..Default::default()
|
..Default::default()
|
||||||
@@ -5264,10 +5074,6 @@ impl SetDisks {
|
|||||||
)
|
)
|
||||||
.await?;
|
.await?;
|
||||||
|
|
||||||
if let Some(err) = entry_error.lock().await.clone() {
|
|
||||||
return Err(err);
|
|
||||||
}
|
|
||||||
|
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -5458,11 +5264,11 @@ pub(crate) fn fallback_free_capacity_dedup(disks: &[rustfs_madmin::Disk]) -> usi
|
|||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod pools_tests {
|
mod pools_tests {
|
||||||
use super::{
|
use super::{
|
||||||
DECOMMISSION_PROGRESS_SAVE_INTERVAL, DECOMMISSION_PROGRESS_SAVE_ITEM_THRESHOLD, DECOMMISSION_PROGRESS_SAVE_RETRY_BACKOFF,
|
DECOMMISSION_PROGRESS_SAVE_INTERVAL, DECOMMISSION_PROGRESS_SAVE_ITEM_THRESHOLD, DecomBucketInfo,
|
||||||
DecomBucketInfo, DecommissionStartPoolState, DecommissionTerminalState, ListCallback, PoolDecommissionInfo, PoolMeta,
|
DecommissionStartPoolState, DecommissionTerminalState, ListCallback, PoolDecommissionInfo, PoolMeta, PoolSpaceInfo,
|
||||||
PoolSpaceInfo, PoolStatus, apply_decommission_status_space_info, bind_decommission_cancelers,
|
PoolStatus, apply_decommission_status_space_info, bind_decommission_cancelers, bind_missing_decommission_cancelers,
|
||||||
bind_missing_decommission_cancelers, cancel_decommission_canceler, classify_decommission_terminal_state,
|
cancel_decommission_canceler, classify_decommission_terminal_state, count_decommission_item,
|
||||||
count_decommission_item, decommission_cancel_signal_result, decommission_item_size, decommission_meta_bucket_options,
|
decommission_cancel_signal_result, decommission_item_size, decommission_meta_bucket_options,
|
||||||
decommission_start_pool_state, dedup_indices, default_decommission_bucket_concurrency,
|
decommission_start_pool_state, dedup_indices, default_decommission_bucket_concurrency,
|
||||||
ensure_decommission_cancel_allowed, ensure_decommission_clear_allowed, ensure_decommission_listing_disks_available,
|
ensure_decommission_cancel_allowed, ensure_decommission_clear_allowed, ensure_decommission_listing_disks_available,
|
||||||
ensure_decommission_not_rebalancing, ensure_decommission_start_allowed, ensure_decommission_start_keeps_active_pool,
|
ensure_decommission_not_rebalancing, ensure_decommission_start_allowed, ensure_decommission_start_keeps_active_pool,
|
||||||
@@ -5473,12 +5279,11 @@ mod pools_tests {
|
|||||||
has_active_decommission_canceler, is_decommission_active, is_decommission_cancel_requested,
|
has_active_decommission_canceler, is_decommission_active, is_decommission_cancel_requested,
|
||||||
load_decommission_entry_versions, local_decommission_queue_prefix, mark_decommission_bucket_done,
|
load_decommission_entry_versions, local_decommission_queue_prefix, mark_decommission_bucket_done,
|
||||||
merge_pool_status_refresh, missing_decommission_worker_prefix, observe_decommission_terminal_reload_result,
|
merge_pool_status_refresh, missing_decommission_worker_prefix, observe_decommission_terminal_reload_result,
|
||||||
pool_meta_has_active_decommission, record_decommission_entry_error, require_decommission_store,
|
pool_meta_has_active_decommission, require_decommission_store, resolve_decommission_bucket_done_save_result,
|
||||||
resolve_decommission_bucket_done_save_result, resolve_decommission_bucket_state,
|
resolve_decommission_bucket_state, resolve_decommission_check_after_list_result,
|
||||||
resolve_decommission_check_after_list_result, resolve_decommission_entry_cleanup_delete_result,
|
resolve_decommission_entry_cleanup_delete_result, resolve_decommission_entry_exact_versions,
|
||||||
resolve_decommission_entry_exact_versions, resolve_decommission_entry_reload_result, resolve_decommission_listing_error,
|
resolve_decommission_entry_reload_result, resolve_decommission_listing_worker_result,
|
||||||
resolve_decommission_listing_worker_result, resolve_decommission_optional_bucket_config_result,
|
resolve_decommission_optional_bucket_config_result, resolve_decommission_pool_meta_reload_result,
|
||||||
resolve_decommission_partial_listing_entry, resolve_decommission_pool_meta_reload_result,
|
|
||||||
resolve_decommission_preflight_heal_result, resolve_decommission_progress_save_result,
|
resolve_decommission_preflight_heal_result, resolve_decommission_progress_save_result,
|
||||||
resolve_decommission_spawn_failure_result, resolve_decommission_terminal_mark_after_error_result,
|
resolve_decommission_spawn_failure_result, resolve_decommission_terminal_mark_after_error_result,
|
||||||
resolve_decommission_terminal_mark_result, resolve_decommission_update_after_result,
|
resolve_decommission_terminal_mark_result, resolve_decommission_update_after_result,
|
||||||
@@ -5488,17 +5293,16 @@ mod pools_tests {
|
|||||||
should_preserve_decommission_canceled_state, should_reject_decommission_cancel_as_terminal,
|
should_preserve_decommission_canceled_state, should_reject_decommission_cancel_as_terminal,
|
||||||
should_retry_decommission_cancel_reload, should_retry_decommission_listing, should_skip_canceled_decommission_routine,
|
should_retry_decommission_cancel_reload, should_retry_decommission_listing, should_skip_canceled_decommission_routine,
|
||||||
split_decommission_buckets, take_and_cancel_decommission_canceler, take_decommission_canceler,
|
split_decommission_buckets, take_and_cancel_decommission_canceler, take_decommission_canceler,
|
||||||
track_decommission_current_object, track_decommission_current_object_stage, validate_start_decommission_request,
|
touch_decommission_progress, track_decommission_current_object, track_decommission_current_object_stage,
|
||||||
wait_decommission_listing_retry, wait_decommission_worker_drain, with_decommission_entry_context,
|
validate_start_decommission_request, wait_decommission_listing_retry, wait_decommission_worker_drain,
|
||||||
|
with_decommission_entry_context,
|
||||||
};
|
};
|
||||||
use crate::data_movement;
|
use crate::data_movement;
|
||||||
use crate::disk::endpoint::Endpoint;
|
use crate::disk::endpoint::Endpoint;
|
||||||
use crate::error::{Error, StorageError};
|
use crate::error::{Error, StorageError};
|
||||||
use crate::layout::endpoints::{EndpointServerPools, Endpoints, PoolEndpoints};
|
use crate::layout::endpoints::{EndpointServerPools, Endpoints, PoolEndpoints};
|
||||||
use crate::services::rebalance::{RebalStatus, RebalanceInfo, RebalanceMeta, RebalanceStats};
|
use crate::services::rebalance::{RebalStatus, RebalanceInfo, RebalanceMeta, RebalanceStats};
|
||||||
use rustfs_filemeta::{
|
use rustfs_filemeta::{FileInfo, FileInfoVersions, MetaCacheEntry, ObjectPartInfo};
|
||||||
FileInfo, FileInfoVersions, MetaCacheEntries, MetaCacheEntry, MetadataResolutionParams, ObjectPartInfo,
|
|
||||||
};
|
|
||||||
use rustfs_rio::Index;
|
use rustfs_rio::Index;
|
||||||
use std::sync::{
|
use std::sync::{
|
||||||
Arc,
|
Arc,
|
||||||
@@ -6517,65 +6321,6 @@ mod pools_tests {
|
|||||||
assert!(matches!(err, Error::SlowDown));
|
assert!(matches!(err, Error::SlowDown));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_resolve_decommission_partial_listing_entry_rejects_unresolved_metadata() {
|
|
||||||
let err = resolve_decommission_partial_listing_entry(
|
|
||||||
MetaCacheEntries(vec![None]),
|
|
||||||
MetadataResolutionParams {
|
|
||||||
dir_quorum: 2,
|
|
||||||
obj_quorum: 2,
|
|
||||||
bucket: "bucket-a".to_string(),
|
|
||||||
..Default::default()
|
|
||||||
},
|
|
||||||
"bucket-a",
|
|
||||||
"prefix/",
|
|
||||||
1,
|
|
||||||
2,
|
|
||||||
3,
|
|
||||||
)
|
|
||||||
.expect_err("unresolved partial listing must fail closed");
|
|
||||||
|
|
||||||
let message = err.to_string();
|
|
||||||
assert!(message.contains("decommission listing could not resolve metadata"));
|
|
||||||
assert!(message.contains("bucket-a/prefix/"));
|
|
||||||
assert!(message.contains("pool 2 set 3"));
|
|
||||||
assert!(message.contains("1 disk error(s)"));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_record_decommission_entry_error_cancels_listing_and_preserves_first_error() {
|
|
||||||
let entry_error = Arc::new(tokio::sync::Mutex::new(None));
|
|
||||||
let rx = CancellationToken::new();
|
|
||||||
|
|
||||||
record_decommission_entry_error(&entry_error, &rx, Error::SlowDown).await;
|
|
||||||
record_decommission_entry_error(&entry_error, &rx, Error::OperationCanceled).await;
|
|
||||||
|
|
||||||
assert!(rx.is_cancelled());
|
|
||||||
assert!(matches!(*entry_error.lock().await, Some(Error::SlowDown)));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_record_decommission_entry_error_ignores_already_canceled_listing() {
|
|
||||||
let entry_error = Arc::new(tokio::sync::Mutex::new(None));
|
|
||||||
let rx = CancellationToken::new();
|
|
||||||
rx.cancel();
|
|
||||||
|
|
||||||
record_decommission_entry_error(&entry_error, &rx, Error::SlowDown).await;
|
|
||||||
|
|
||||||
assert!(entry_error.lock().await.is_none());
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_resolve_decommission_listing_error_preserves_real_listing_failure() {
|
|
||||||
let err = resolve_decommission_listing_error(Some(Error::SlowDown), Some(Error::OperationCanceled))
|
|
||||||
.expect("listing failure should be returned");
|
|
||||||
assert!(matches!(err, Error::SlowDown));
|
|
||||||
|
|
||||||
let err = resolve_decommission_listing_error(Some(Error::OperationCanceled), Some(Error::SlowDown))
|
|
||||||
.expect("entry failure should be returned");
|
|
||||||
assert!(matches!(err, Error::SlowDown));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_resolve_decommission_check_after_list_result_returns_list_result_without_entry_error() {
|
fn test_resolve_decommission_check_after_list_result_returns_list_result_without_entry_error() {
|
||||||
let err = resolve_decommission_check_after_list_result(Err(Error::OperationCanceled), None)
|
let err = resolve_decommission_check_after_list_result(Err(Error::OperationCanceled), None)
|
||||||
@@ -6793,7 +6538,7 @@ mod pools_tests {
|
|||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_track_decommission_stage_does_not_advance_checkpoint_state() {
|
fn test_touch_decommission_progress_updates_last_update_and_save_baseline() {
|
||||||
let mut meta = PoolMeta {
|
let mut meta = PoolMeta {
|
||||||
pools: vec![PoolStatus {
|
pools: vec![PoolStatus {
|
||||||
id: 0,
|
id: 0,
|
||||||
@@ -6808,13 +6553,11 @@ mod pools_tests {
|
|||||||
..Default::default()
|
..Default::default()
|
||||||
};
|
};
|
||||||
|
|
||||||
track_decommission_current_object_stage(&mut meta, 0, "bucket", "object", "migrate_object")
|
touch_decommission_progress(&mut meta, 0).expect("valid decommission progress should be touched");
|
||||||
.expect("valid decommission progress should be tracked");
|
|
||||||
|
|
||||||
assert_eq!(meta.pools[0].last_update, OffsetDateTime::UNIX_EPOCH);
|
assert!(meta.pools[0].last_update > OffsetDateTime::UNIX_EPOCH);
|
||||||
let info = meta.pools[0].decommission.as_ref().expect("decommission info should exist");
|
let info = meta.pools[0].decommission.as_ref().expect("decommission info should exist");
|
||||||
assert_eq!(info.items_since_last_progress_save(), 5);
|
assert_eq!(info.items_since_last_progress_save(), 0);
|
||||||
assert_eq!(info.stage, "migrate_object");
|
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -6889,134 +6632,6 @@ mod pools_tests {
|
|||||||
assert_eq!(info.items_since_last_progress_save(), 1);
|
assert_eq!(info.items_since_last_progress_save(), 1);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_pool_meta_update_after_does_not_advance_last_update_before_save() {
|
|
||||||
let last_update = OffsetDateTime::UNIX_EPOCH;
|
|
||||||
let mut meta = PoolMeta {
|
|
||||||
pools: vec![PoolStatus {
|
|
||||||
id: 0,
|
|
||||||
cmd_line: "pool-0".to_string(),
|
|
||||||
last_update,
|
|
||||||
decommission: Some(PoolDecommissionInfo {
|
|
||||||
start_time: Some(last_update),
|
|
||||||
items_decommissioned: DECOMMISSION_PROGRESS_SAVE_ITEM_THRESHOLD,
|
|
||||||
..Default::default()
|
|
||||||
}),
|
|
||||||
}],
|
|
||||||
..Default::default()
|
|
||||||
};
|
|
||||||
|
|
||||||
assert!(
|
|
||||||
meta.update_after(0, DECOMMISSION_PROGRESS_SAVE_INTERVAL)
|
|
||||||
.expect("item threshold should request a checkpoint")
|
|
||||||
);
|
|
||||||
assert_eq!(meta.pools[0].last_update, last_update);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_decommission_progress_checkpoint_commits_exact_snapshot_watermark() {
|
|
||||||
let start_time = OffsetDateTime::UNIX_EPOCH;
|
|
||||||
let checkpoint_at = start_time + Duration::seconds(30);
|
|
||||||
let mut meta = PoolMeta {
|
|
||||||
pools: vec![PoolStatus {
|
|
||||||
id: 0,
|
|
||||||
cmd_line: "pool-0".to_string(),
|
|
||||||
last_update: start_time,
|
|
||||||
decommission: Some(PoolDecommissionInfo {
|
|
||||||
start_time: Some(start_time),
|
|
||||||
items_decommissioned: DECOMMISSION_PROGRESS_SAVE_ITEM_THRESHOLD,
|
|
||||||
..Default::default()
|
|
||||||
}),
|
|
||||||
}],
|
|
||||||
..Default::default()
|
|
||||||
};
|
|
||||||
|
|
||||||
let checkpoint = meta
|
|
||||||
.decommission_progress_checkpoint(0, DECOMMISSION_PROGRESS_SAVE_INTERVAL, checkpoint_at)
|
|
||||||
.expect("valid decommission state should produce a checkpoint")
|
|
||||||
.expect("item threshold should produce a checkpoint");
|
|
||||||
meta.count_item(0, 1, false);
|
|
||||||
|
|
||||||
assert!(meta.commit_decommission_progress_checkpoint(0, checkpoint));
|
|
||||||
let info = meta.pools[0].decommission.as_ref().expect("decommission info should exist");
|
|
||||||
assert_eq!(info.progress_save_item_baseline, checkpoint.counted_items);
|
|
||||||
assert_eq!(info.items_since_last_progress_save(), 1);
|
|
||||||
assert_eq!(meta.pools[0].last_update, checkpoint_at);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_decommission_progress_checkpoint_backoff_does_not_advance_baseline() {
|
|
||||||
let start_time = OffsetDateTime::UNIX_EPOCH;
|
|
||||||
let checkpoint_at = start_time + Duration::seconds(30);
|
|
||||||
let retry_after = checkpoint_at + DECOMMISSION_PROGRESS_SAVE_RETRY_BACKOFF;
|
|
||||||
let mut meta = PoolMeta {
|
|
||||||
pools: vec![PoolStatus {
|
|
||||||
id: 0,
|
|
||||||
cmd_line: "pool-0".to_string(),
|
|
||||||
last_update: start_time,
|
|
||||||
decommission: Some(PoolDecommissionInfo {
|
|
||||||
start_time: Some(start_time),
|
|
||||||
items_decommissioned: DECOMMISSION_PROGRESS_SAVE_ITEM_THRESHOLD,
|
|
||||||
..Default::default()
|
|
||||||
}),
|
|
||||||
}],
|
|
||||||
..Default::default()
|
|
||||||
};
|
|
||||||
|
|
||||||
let checkpoint = meta
|
|
||||||
.decommission_progress_checkpoint(0, DECOMMISSION_PROGRESS_SAVE_INTERVAL, checkpoint_at)
|
|
||||||
.expect("valid decommission state should produce a checkpoint")
|
|
||||||
.expect("item threshold should produce a checkpoint");
|
|
||||||
meta.defer_decommission_progress_checkpoint(0, checkpoint, retry_after);
|
|
||||||
|
|
||||||
assert!(
|
|
||||||
meta.decommission_progress_checkpoint(0, DECOMMISSION_PROGRESS_SAVE_INTERVAL, checkpoint_at)
|
|
||||||
.expect("retry backoff check should succeed")
|
|
||||||
.is_none()
|
|
||||||
);
|
|
||||||
assert_eq!(meta.pools[0].last_update, start_time);
|
|
||||||
assert_eq!(
|
|
||||||
meta.pools[0]
|
|
||||||
.decommission
|
|
||||||
.as_ref()
|
|
||||||
.expect("decommission info should exist")
|
|
||||||
.progress_save_item_baseline,
|
|
||||||
0
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_decommission_progress_checkpoint_count_scales_with_threshold() {
|
|
||||||
let start_time = OffsetDateTime::UNIX_EPOCH;
|
|
||||||
let checkpoint_at = start_time;
|
|
||||||
let mut meta = PoolMeta {
|
|
||||||
pools: vec![PoolStatus {
|
|
||||||
id: 0,
|
|
||||||
cmd_line: "pool-0".to_string(),
|
|
||||||
last_update: start_time,
|
|
||||||
decommission: Some(PoolDecommissionInfo {
|
|
||||||
start_time: Some(start_time),
|
|
||||||
..Default::default()
|
|
||||||
}),
|
|
||||||
}],
|
|
||||||
..Default::default()
|
|
||||||
};
|
|
||||||
let mut checkpoint_count = 0;
|
|
||||||
|
|
||||||
for _ in 0..(DECOMMISSION_PROGRESS_SAVE_ITEM_THRESHOLD * 10) {
|
|
||||||
meta.count_item(0, 1, false);
|
|
||||||
if let Some(checkpoint) = meta
|
|
||||||
.decommission_progress_checkpoint(0, DECOMMISSION_PROGRESS_SAVE_INTERVAL, checkpoint_at)
|
|
||||||
.expect("valid decommission state should produce a checkpoint")
|
|
||||||
{
|
|
||||||
checkpoint_count += 1;
|
|
||||||
assert!(meta.commit_decommission_progress_checkpoint(0, checkpoint));
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
assert_eq!(checkpoint_count, 10);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_ensure_decommission_not_rebalancing_rejects_running_rebalance() {
|
fn test_ensure_decommission_not_rebalancing_rejects_running_rebalance() {
|
||||||
let err = ensure_decommission_not_rebalancing(true).expect_err("rebalance running should be rejected");
|
let err = ensure_decommission_not_rebalancing(true).expect_err("rebalance running should be rejected");
|
||||||
|
|||||||
@@ -1640,60 +1640,6 @@ mod tests {
|
|||||||
assert_eq!(payload["items"].as_array().expect("items should be an array").len(), 0);
|
assert_eq!(payload["items"].as_array().expect("items should be an array").len(), 0);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_process_query_request_reports_displaced_terminal_detail() {
|
|
||||||
let heal_manager = Arc::new(HealManager::new(
|
|
||||||
Arc::new(MockStorage),
|
|
||||||
Some(HealConfig {
|
|
||||||
queue_size: 1,
|
|
||||||
..HealConfig::default()
|
|
||||||
}),
|
|
||||||
));
|
|
||||||
let mut displaced = HealRequest::new(
|
|
||||||
HealType::Bucket {
|
|
||||||
bucket: "displaced-channel".to_string(),
|
|
||||||
},
|
|
||||||
HealOptions::default(),
|
|
||||||
HealPriority::Low,
|
|
||||||
);
|
|
||||||
displaced.id = "displaced-channel-task".to_string();
|
|
||||||
let displaced_id = displaced.id.clone();
|
|
||||||
heal_manager
|
|
||||||
.submit_heal_request(displaced)
|
|
||||||
.await
|
|
||||||
.expect("initial channel task should queue");
|
|
||||||
heal_manager
|
|
||||||
.submit_heal_request(HealRequest::new(
|
|
||||||
HealType::Bucket {
|
|
||||||
bucket: "successor-channel".to_string(),
|
|
||||||
},
|
|
||||||
HealOptions::default(),
|
|
||||||
HealPriority::High,
|
|
||||||
))
|
|
||||||
.await
|
|
||||||
.expect("successor channel task should displace the initial task");
|
|
||||||
|
|
||||||
let processor = HealChannelProcessor::new(heal_manager);
|
|
||||||
let (tx, rx) = oneshot::channel();
|
|
||||||
processor
|
|
||||||
.process_query_request("displaced-channel".to_string(), displaced_id, None, tx)
|
|
||||||
.await
|
|
||||||
.expect("displaced query should process");
|
|
||||||
let response = rx
|
|
||||||
.await
|
|
||||||
.expect("query response should be returned")
|
|
||||||
.expect("displaced query should remain successful");
|
|
||||||
let payload: serde_json::Value = serde_json::from_slice(response.data.as_deref().expect("status payload should exist"))
|
|
||||||
.expect("status payload should be json");
|
|
||||||
assert_eq!(payload["summary"], "stopped");
|
|
||||||
assert!(
|
|
||||||
response
|
|
||||||
.error
|
|
||||||
.as_deref()
|
|
||||||
.is_some_and(|detail| detail.contains("reason=displaced"))
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_process_query_request_reports_running_for_queued_task() {
|
async fn test_process_query_request_reports_running_for_queued_task() {
|
||||||
let heal_manager = create_test_heal_manager();
|
let heal_manager = create_test_heal_manager();
|
||||||
|
|||||||
+10
-105
@@ -40,7 +40,6 @@ use tracing::{debug, error, info, warn};
|
|||||||
use super::{DiskError, Endpoint, HealDiskExt as _, local_disk_map_read};
|
use super::{DiskError, Endpoint, HealDiskExt as _, local_disk_map_read};
|
||||||
|
|
||||||
const KEEP_HEAL_TASK_STATUS_DURATION: Duration = Duration::from_secs(10 * 60);
|
const KEEP_HEAL_TASK_STATUS_DURATION: Duration = Duration::from_secs(10 * 60);
|
||||||
const DISPLACED_HEAL_REASON: &str = "reason=displaced; retry_hint=submit_again";
|
|
||||||
const LOG_COMPONENT_HEAL: &str = "heal";
|
const LOG_COMPONENT_HEAL: &str = "heal";
|
||||||
const LOG_SUBSYSTEM_DISK_SCANNER: &str = "disk_scanner";
|
const LOG_SUBSYSTEM_DISK_SCANNER: &str = "disk_scanner";
|
||||||
const LOG_SUBSYSTEM_MANAGER: &str = "manager";
|
const LOG_SUBSYSTEM_MANAGER: &str = "manager";
|
||||||
@@ -121,30 +120,26 @@ struct MrfRepairNoticeTarget {
|
|||||||
version_id: Option<[u8; 16]>,
|
version_id: Option<[u8; 16]>,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone)]
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
struct HealAdmissionDecision {
|
struct HealAdmissionDecision {
|
||||||
result: HealAdmissionResult,
|
result: HealAdmissionResult,
|
||||||
displaced_request: Option<HealRequest>,
|
displaced_task_id: Option<String>,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl HealAdmissionDecision {
|
impl HealAdmissionDecision {
|
||||||
const fn new(result: HealAdmissionResult) -> Self {
|
const fn new(result: HealAdmissionResult) -> Self {
|
||||||
Self {
|
Self {
|
||||||
result,
|
result,
|
||||||
displaced_request: None,
|
displaced_task_id: None,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn accepted_with_displacement(displaced_request: HealRequest) -> Self {
|
fn accepted_with_displacement(displaced_task_id: String) -> Self {
|
||||||
Self {
|
Self {
|
||||||
result: HealAdmissionResult::Accepted,
|
result: HealAdmissionResult::Accepted,
|
||||||
displaced_request: Some(displaced_request),
|
displaced_task_id: Some(displaced_task_id),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn displaced_task_id(&self) -> Option<&str> {
|
|
||||||
self.displaced_request.as_ref().map(|request| request.id.as_str())
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
fn lock_mrf_repair_notice_targets(
|
fn lock_mrf_repair_notice_targets(
|
||||||
@@ -156,55 +151,6 @@ fn lock_mrf_repair_notice_targets(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn lock_displaced_terminals(
|
|
||||||
registry: &StdMutex<HashMap<String, Arc<CompletedHealStatus>>>,
|
|
||||||
) -> StdMutexGuard<'_, HashMap<String, Arc<CompletedHealStatus>>> {
|
|
||||||
match registry.lock() {
|
|
||||||
Ok(guard) => guard,
|
|
||||||
Err(poisoned) => poisoned.into_inner(),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fn record_displaced_terminal(
|
|
||||||
registry: &StdMutex<HashMap<String, Arc<CompletedHealStatus>>>,
|
|
||||||
request: &HealRequest,
|
|
||||||
) -> Arc<CompletedHealStatus> {
|
|
||||||
let terminal = Arc::new(CompletedHealStatus {
|
|
||||||
heal_type: request.heal_type.clone(),
|
|
||||||
status: HealTaskStatus::Failed {
|
|
||||||
error: format!("heal task displaced by a higher-priority request ({DISPLACED_HEAL_REASON})"),
|
|
||||||
},
|
|
||||||
result_items_truncated: false,
|
|
||||||
completed_at: SystemTime::now(),
|
|
||||||
seqed_items: Vec::new(),
|
|
||||||
next_seq: 0,
|
|
||||||
min_seq: 0,
|
|
||||||
});
|
|
||||||
let mut terminals = lock_displaced_terminals(registry);
|
|
||||||
prune_completed_heal_statuses(&mut terminals);
|
|
||||||
terminals.insert(request.id.clone(), Arc::clone(&terminal));
|
|
||||||
terminal
|
|
||||||
}
|
|
||||||
|
|
||||||
async fn remove_displaced_task_aliases(
|
|
||||||
aliases: &Arc<Mutex<HashMap<String, HealTaskAlias>>>,
|
|
||||||
terminals: &StdMutex<HashMap<String, Arc<CompletedHealStatus>>>,
|
|
||||||
task_id: &str,
|
|
||||||
terminal: &Arc<CompletedHealStatus>,
|
|
||||||
) {
|
|
||||||
let mut aliases = aliases.lock().await;
|
|
||||||
let alias_ids = aliases
|
|
||||||
.iter()
|
|
||||||
.filter_map(|(alias_id, alias)| (alias.task_id == task_id).then_some(alias_id.clone()))
|
|
||||||
.collect::<Vec<_>>();
|
|
||||||
let mut displaced_terminals = lock_displaced_terminals(terminals);
|
|
||||||
prune_completed_heal_statuses(&mut displaced_terminals);
|
|
||||||
for alias_id in alias_ids {
|
|
||||||
displaced_terminals.insert(alias_id, Arc::clone(terminal));
|
|
||||||
}
|
|
||||||
aliases.retain(|alias_id, alias| alias_id != task_id && alias.task_id != task_id);
|
|
||||||
}
|
|
||||||
|
|
||||||
async fn remove_task_aliases_for_task(registry: &Arc<Mutex<HashMap<String, HealTaskAlias>>>, task_id: &str) {
|
async fn remove_task_aliases_for_task(registry: &Arc<Mutex<HashMap<String, HealTaskAlias>>>, task_id: &str) {
|
||||||
registry
|
registry
|
||||||
.lock()
|
.lock()
|
||||||
@@ -672,14 +618,6 @@ pub struct HealManager {
|
|||||||
/// are shared so the lookup helper can hand a completed entry to a
|
/// are shared so the lookup helper can hand a completed entry to a
|
||||||
/// caller without cloning the retained result window.
|
/// caller without cloning the retained result window.
|
||||||
completed_heals: Arc<Mutex<HashMap<String, Arc<CompletedHealStatus>>>>,
|
completed_heals: Arc<Mutex<HashMap<String, Arc<CompletedHealStatus>>>>,
|
||||||
/// Terminals for requests removed by priority displacement. An Accepted
|
|
||||||
/// task ID remains queryable for the same process lifetime and the normal
|
|
||||||
/// ten-minute status TTL; clients should treat `reason=displaced` as a
|
|
||||||
/// terminal result and submit a fresh request. This sidecar is synchronous
|
|
||||||
/// so admission can publish the terminal while the queue transition is
|
|
||||||
/// still under its lock, without awaiting another tokio lock. Queue state
|
|
||||||
/// is process-local, so this guarantee does not extend across restart.
|
|
||||||
displaced_terminals: Arc<StdMutex<HashMap<String, Arc<CompletedHealStatus>>>>,
|
|
||||||
/// Client tokens merged into an existing task id.
|
/// Client tokens merged into an existing task id.
|
||||||
task_aliases: Arc<Mutex<HashMap<String, HealTaskAlias>>>,
|
task_aliases: Arc<Mutex<HashMap<String, HealTaskAlias>>>,
|
||||||
/// Heal tasks waiting for a retry backoff to expire.
|
/// Heal tasks waiting for a retry backoff to expire.
|
||||||
@@ -721,7 +659,6 @@ struct HealQueueContext<'a> {
|
|||||||
heal_queue: &'a Arc<Mutex<PriorityHealQueue>>,
|
heal_queue: &'a Arc<Mutex<PriorityHealQueue>>,
|
||||||
active_heals: &'a Arc<Mutex<HashMap<String, Arc<HealTask>>>>,
|
active_heals: &'a Arc<Mutex<HashMap<String, Arc<HealTask>>>>,
|
||||||
completed_heals: &'a Arc<Mutex<HashMap<String, Arc<CompletedHealStatus>>>>,
|
completed_heals: &'a Arc<Mutex<HashMap<String, Arc<CompletedHealStatus>>>>,
|
||||||
displaced_terminals: &'a Arc<StdMutex<HashMap<String, Arc<CompletedHealStatus>>>>,
|
|
||||||
task_aliases: &'a Arc<Mutex<HashMap<String, HealTaskAlias>>>,
|
task_aliases: &'a Arc<Mutex<HashMap<String, HealTaskAlias>>>,
|
||||||
retrying_heals: &'a Arc<Mutex<HashMap<String, RetryingHeal>>>,
|
retrying_heals: &'a Arc<Mutex<HashMap<String, RetryingHeal>>>,
|
||||||
mrf_repair_notice_targets: &'a Arc<StdMutex<HashMap<String, Vec<MrfRepairNoticeTarget>>>>,
|
mrf_repair_notice_targets: &'a Arc<StdMutex<HashMap<String, Vec<MrfRepairNoticeTarget>>>>,
|
||||||
@@ -937,7 +874,7 @@ impl HealManager {
|
|||||||
result = "accepted_by_displacement",
|
result = "accepted_by_displacement",
|
||||||
"Heal queue request accepted by displacement"
|
"Heal queue request accepted by displacement"
|
||||||
});
|
});
|
||||||
return HealAdmissionDecision::accepted_with_displacement(displaced);
|
return HealAdmissionDecision::accepted_with_displacement(displaced.id);
|
||||||
}
|
}
|
||||||
|
|
||||||
demote_to_debug_when!(per_object_request, warn, target: "rustfs::heal::manager", {
|
demote_to_debug_when!(per_object_request, warn, target: "rustfs::heal::manager", {
|
||||||
@@ -1168,7 +1105,6 @@ impl HealManager {
|
|||||||
active_heals: Arc::new(Mutex::new(HashMap::new())),
|
active_heals: Arc::new(Mutex::new(HashMap::new())),
|
||||||
heal_queue: Arc::new(Mutex::new(PriorityHealQueue::new())),
|
heal_queue: Arc::new(Mutex::new(PriorityHealQueue::new())),
|
||||||
completed_heals: Arc::new(Mutex::new(HashMap::new())),
|
completed_heals: Arc::new(Mutex::new(HashMap::new())),
|
||||||
displaced_terminals: Arc::new(StdMutex::new(HashMap::new())),
|
|
||||||
task_aliases: Arc::new(Mutex::new(HashMap::new())),
|
task_aliases: Arc::new(Mutex::new(HashMap::new())),
|
||||||
retrying_heals: Arc::new(Mutex::new(HashMap::new())),
|
retrying_heals: Arc::new(Mutex::new(HashMap::new())),
|
||||||
mrf_repair_notice_targets: Arc::new(StdMutex::new(HashMap::new())),
|
mrf_repair_notice_targets: Arc::new(StdMutex::new(HashMap::new())),
|
||||||
@@ -1273,10 +1209,6 @@ impl HealManager {
|
|||||||
active_heals.clear();
|
active_heals.clear();
|
||||||
publish_active_heal_count(&active_heals);
|
publish_active_heal_count(&active_heals);
|
||||||
self.completed_heals.lock().await.clear();
|
self.completed_heals.lock().await.clear();
|
||||||
// Do not let the synchronous guard live across the following async lock.
|
|
||||||
{
|
|
||||||
lock_displaced_terminals(&self.displaced_terminals).clear();
|
|
||||||
}
|
|
||||||
self.task_aliases.lock().await.clear();
|
self.task_aliases.lock().await.clear();
|
||||||
self.retrying_heals.lock().await.clear();
|
self.retrying_heals.lock().await.clear();
|
||||||
lock_mrf_repair_notice_targets(&self.mrf_repair_notice_targets).clear();
|
lock_mrf_repair_notice_targets(&self.mrf_repair_notice_targets).clear();
|
||||||
@@ -1527,11 +1459,7 @@ impl HealManager {
|
|||||||
task_id = queued_id.to_owned();
|
task_id = queued_id.to_owned();
|
||||||
}
|
}
|
||||||
let should_notify = matches!(admission, HealAdmissionResult::Accepted) && config.event_driven_scheduler_enable;
|
let should_notify = matches!(admission, HealAdmissionResult::Accepted) && config.event_driven_scheduler_enable;
|
||||||
let displaced_task_id = admission_decision.displaced_task_id().map(ToOwned::to_owned);
|
let displaced_task_id = admission_decision.displaced_task_id;
|
||||||
let displaced_terminal = admission_decision
|
|
||||||
.displaced_request
|
|
||||||
.as_ref()
|
|
||||||
.map(|request| record_displaced_terminal(&self.displaced_terminals, request));
|
|
||||||
if matches!(admission, HealAdmissionResult::Accepted | HealAdmissionResult::Merged)
|
if matches!(admission, HealAdmissionResult::Accepted | HealAdmissionResult::Merged)
|
||||||
&& let Some(target) = mrf_notice_target
|
&& let Some(target) = mrf_notice_target
|
||||||
{
|
{
|
||||||
@@ -1545,12 +1473,8 @@ impl HealManager {
|
|||||||
drop(queue);
|
drop(queue);
|
||||||
drop(active_heals);
|
drop(active_heals);
|
||||||
|
|
||||||
if let (Some(displaced_task_id), Some(displaced_terminal)) = (displaced_task_id, displaced_terminal) {
|
if let Some(displaced_task_id) = displaced_task_id {
|
||||||
// The queue has already removed the displaced request, so the
|
self.remove_aliases_for_task(&displaced_task_id).await;
|
||||||
// synchronous terminal sidecar was published before aliases and
|
|
||||||
// MRF ownership are cleaned up.
|
|
||||||
remove_displaced_task_aliases(&self.task_aliases, &self.displaced_terminals, &displaced_task_id, &displaced_terminal)
|
|
||||||
.await;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
if should_notify {
|
if should_notify {
|
||||||
@@ -1625,15 +1549,6 @@ impl HealManager {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if terminal_completed.is_none() {
|
|
||||||
let mut displaced_terminals = lock_displaced_terminals(&self.displaced_terminals);
|
|
||||||
prune_completed_heal_statuses(&mut displaced_terminals);
|
|
||||||
terminal_completed = displaced_terminals
|
|
||||||
.get(canonical_task_id)
|
|
||||||
.filter(|terminal| matches_path(&terminal.heal_type))
|
|
||||||
.cloned();
|
|
||||||
}
|
|
||||||
|
|
||||||
match terminal_completed {
|
match terminal_completed {
|
||||||
Some(completed) => TaskStateLookup::Completed(completed),
|
Some(completed) => TaskStateLookup::Completed(completed),
|
||||||
None => TaskStateLookup::NotFound,
|
None => TaskStateLookup::NotFound,
|
||||||
@@ -1754,19 +1669,9 @@ impl HealManager {
|
|||||||
|
|
||||||
let mut completed_heals = self.completed_heals.lock().await;
|
let mut completed_heals = self.completed_heals.lock().await;
|
||||||
prune_completed_heal_statuses(&mut completed_heals);
|
prune_completed_heal_statuses(&mut completed_heals);
|
||||||
if completed_heals
|
completed_heals
|
||||||
.values()
|
.values()
|
||||||
.any(|completed| heal_type_matches_path(&completed.heal_type, heal_path))
|
.any(|completed| heal_type_matches_path(&completed.heal_type, heal_path))
|
||||||
{
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
drop(completed_heals);
|
|
||||||
|
|
||||||
let mut displaced_terminals = lock_displaced_terminals(&self.displaced_terminals);
|
|
||||||
prune_completed_heal_statuses(&mut displaced_terminals);
|
|
||||||
displaced_terminals
|
|
||||||
.values()
|
|
||||||
.any(|terminal| heal_type_matches_path(&terminal.heal_type, heal_path))
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Get task progress
|
/// Get task progress
|
||||||
|
|||||||
@@ -21,7 +21,6 @@ impl HealManager {
|
|||||||
let heal_queue = self.heal_queue.clone();
|
let heal_queue = self.heal_queue.clone();
|
||||||
let active_heals = self.active_heals.clone();
|
let active_heals = self.active_heals.clone();
|
||||||
let task_aliases = self.task_aliases.clone();
|
let task_aliases = self.task_aliases.clone();
|
||||||
let displaced_terminals = self.displaced_terminals.clone();
|
|
||||||
let mrf_repair_notice_targets = self.mrf_repair_notice_targets.clone();
|
let mrf_repair_notice_targets = self.mrf_repair_notice_targets.clone();
|
||||||
let storage = self.storage.clone();
|
let storage = self.storage.clone();
|
||||||
let replacement_recovery_anchors = self.replacement_recovery_anchors.clone();
|
let replacement_recovery_anchors = self.replacement_recovery_anchors.clone();
|
||||||
@@ -482,10 +481,6 @@ impl HealManager {
|
|||||||
let admission = admission_decision.result;
|
let admission = admission_decision.result;
|
||||||
let should_notify =
|
let should_notify =
|
||||||
matches!(admission, HealAdmissionResult::Accepted) && config.event_driven_scheduler_enable;
|
matches!(admission, HealAdmissionResult::Accepted) && config.event_driven_scheduler_enable;
|
||||||
let displaced_terminal = admission_decision
|
|
||||||
.displaced_request
|
|
||||||
.as_ref()
|
|
||||||
.map(|request| record_displaced_terminal(&displaced_terminals, request));
|
|
||||||
if matches!(admission, HealAdmissionResult::Accepted)
|
if matches!(admission, HealAdmissionResult::Accepted)
|
||||||
&& let Some(anchor) = recovery_anchor
|
&& let Some(anchor) = recovery_anchor
|
||||||
{
|
{
|
||||||
@@ -496,16 +491,8 @@ impl HealManager {
|
|||||||
}
|
}
|
||||||
drop(queue);
|
drop(queue);
|
||||||
drop(config);
|
drop(config);
|
||||||
if let (Some(displaced_task_id), Some(displaced_terminal)) =
|
if let Some(displaced_task_id) = admission_decision.displaced_task_id {
|
||||||
(admission_decision.displaced_task_id().map(ToOwned::to_owned), displaced_terminal)
|
remove_task_aliases_for_task(&task_aliases, &displaced_task_id).await;
|
||||||
{
|
|
||||||
remove_displaced_task_aliases(
|
|
||||||
&task_aliases,
|
|
||||||
&displaced_terminals,
|
|
||||||
&displaced_task_id,
|
|
||||||
&displaced_terminal,
|
|
||||||
)
|
|
||||||
.await;
|
|
||||||
lock_mrf_repair_notice_targets(&mrf_repair_notice_targets).remove(&displaced_task_id);
|
lock_mrf_repair_notice_targets(&mrf_repair_notice_targets).remove(&displaced_task_id);
|
||||||
}
|
}
|
||||||
if matches!(admission, HealAdmissionResult::Accepted) {
|
if matches!(admission, HealAdmissionResult::Accepted) {
|
||||||
|
|||||||
@@ -21,7 +21,6 @@ impl HealManager {
|
|||||||
let heal_queue = self.heal_queue.clone();
|
let heal_queue = self.heal_queue.clone();
|
||||||
let active_heals = self.active_heals.clone();
|
let active_heals = self.active_heals.clone();
|
||||||
let completed_heals = self.completed_heals.clone();
|
let completed_heals = self.completed_heals.clone();
|
||||||
let displaced_terminals = self.displaced_terminals.clone();
|
|
||||||
let task_aliases = self.task_aliases.clone();
|
let task_aliases = self.task_aliases.clone();
|
||||||
let retrying_heals = self.retrying_heals.clone();
|
let retrying_heals = self.retrying_heals.clone();
|
||||||
let mrf_repair_notice_targets = self.mrf_repair_notice_targets.clone();
|
let mrf_repair_notice_targets = self.mrf_repair_notice_targets.clone();
|
||||||
@@ -54,7 +53,6 @@ impl HealManager {
|
|||||||
heal_queue: &heal_queue,
|
heal_queue: &heal_queue,
|
||||||
active_heals: &active_heals,
|
active_heals: &active_heals,
|
||||||
completed_heals: &completed_heals,
|
completed_heals: &completed_heals,
|
||||||
displaced_terminals: &displaced_terminals,
|
|
||||||
task_aliases: &task_aliases,
|
task_aliases: &task_aliases,
|
||||||
retrying_heals: &retrying_heals,
|
retrying_heals: &retrying_heals,
|
||||||
mrf_repair_notice_targets: &mrf_repair_notice_targets,
|
mrf_repair_notice_targets: &mrf_repair_notice_targets,
|
||||||
@@ -73,7 +71,6 @@ impl HealManager {
|
|||||||
heal_queue: &heal_queue,
|
heal_queue: &heal_queue,
|
||||||
active_heals: &active_heals,
|
active_heals: &active_heals,
|
||||||
completed_heals: &completed_heals,
|
completed_heals: &completed_heals,
|
||||||
displaced_terminals: &displaced_terminals,
|
|
||||||
task_aliases: &task_aliases,
|
task_aliases: &task_aliases,
|
||||||
retrying_heals: &retrying_heals,
|
retrying_heals: &retrying_heals,
|
||||||
mrf_repair_notice_targets: &mrf_repair_notice_targets,
|
mrf_repair_notice_targets: &mrf_repair_notice_targets,
|
||||||
@@ -101,7 +98,6 @@ impl HealManager {
|
|||||||
heal_queue,
|
heal_queue,
|
||||||
active_heals,
|
active_heals,
|
||||||
completed_heals,
|
completed_heals,
|
||||||
displaced_terminals,
|
|
||||||
task_aliases,
|
task_aliases,
|
||||||
retrying_heals,
|
retrying_heals,
|
||||||
mrf_repair_notice_targets,
|
mrf_repair_notice_targets,
|
||||||
@@ -187,7 +183,6 @@ impl HealManager {
|
|||||||
let active_heals_clone = active_heals.clone();
|
let active_heals_clone = active_heals.clone();
|
||||||
let heal_queue_clone = heal_queue.clone();
|
let heal_queue_clone = heal_queue.clone();
|
||||||
let completed_heals_clone = completed_heals.clone();
|
let completed_heals_clone = completed_heals.clone();
|
||||||
let displaced_terminals_clone = displaced_terminals.clone();
|
|
||||||
let task_aliases_clone = task_aliases.clone();
|
let task_aliases_clone = task_aliases.clone();
|
||||||
let retrying_heals_clone = retrying_heals.clone();
|
let retrying_heals_clone = retrying_heals.clone();
|
||||||
let mrf_repair_notice_targets_clone = mrf_repair_notice_targets.clone();
|
let mrf_repair_notice_targets_clone = mrf_repair_notice_targets.clone();
|
||||||
@@ -368,7 +363,6 @@ impl HealManager {
|
|||||||
let retry_heal_queue = heal_queue_clone.clone();
|
let retry_heal_queue = heal_queue_clone.clone();
|
||||||
let retrying_heals_for_spawn = retrying_heals_clone.clone();
|
let retrying_heals_for_spawn = retrying_heals_clone.clone();
|
||||||
let retry_task_aliases = task_aliases_clone.clone();
|
let retry_task_aliases = task_aliases_clone.clone();
|
||||||
let retry_displaced_terminals = displaced_terminals_clone.clone();
|
|
||||||
let retry_mrf_repair_notice_targets = mrf_repair_notice_targets_clone.clone();
|
let retry_mrf_repair_notice_targets = mrf_repair_notice_targets_clone.clone();
|
||||||
let retry_completed_heals = completed_heals_clone.clone();
|
let retry_completed_heals = completed_heals_clone.clone();
|
||||||
let retry_notify = notify_clone.clone();
|
let retry_notify = notify_clone.clone();
|
||||||
@@ -436,14 +430,6 @@ impl HealManager {
|
|||||||
let admission = admission_decision.result;
|
let admission = admission_decision.result;
|
||||||
let should_notify = matches!(admission, HealAdmissionResult::Accepted)
|
let should_notify = matches!(admission, HealAdmissionResult::Accepted)
|
||||||
&& retry_config.event_driven_scheduler_enable;
|
&& retry_config.event_driven_scheduler_enable;
|
||||||
// Publish the terminal synchronously while the
|
|
||||||
// queue transition is protected. The subsequent
|
|
||||||
// queue -> retrying handoff retains the lock order
|
|
||||||
// used by operations_snapshot.
|
|
||||||
let displaced_terminal = admission_decision
|
|
||||||
.displaced_request
|
|
||||||
.as_ref()
|
|
||||||
.map(|request| record_displaced_terminal(&retry_displaced_terminals, request));
|
|
||||||
match admission {
|
match admission {
|
||||||
HealAdmissionResult::Accepted => {
|
HealAdmissionResult::Accepted => {
|
||||||
// Transfer ownership while holding queue -> retrying,
|
// Transfer ownership while holding queue -> retrying,
|
||||||
@@ -451,18 +437,10 @@ impl HealManager {
|
|||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
pause_retry_ownership_transition(&retry_request_id, true).await;
|
pause_retry_ownership_transition(&retry_request_id, true).await;
|
||||||
retrying_heals_for_spawn.lock().await.remove(&retry_request_id);
|
retrying_heals_for_spawn.lock().await.remove(&retry_request_id);
|
||||||
let displaced_task_id = admission_decision.displaced_task_id().map(ToOwned::to_owned);
|
let displaced_task_id = admission_decision.displaced_task_id;
|
||||||
drop(queue);
|
drop(queue);
|
||||||
if let (Some(displaced_task_id), Some(displaced_terminal)) =
|
if let Some(displaced_task_id) = displaced_task_id {
|
||||||
(displaced_task_id, displaced_terminal)
|
remove_task_aliases_for_task(&retry_task_aliases, &displaced_task_id).await;
|
||||||
{
|
|
||||||
remove_displaced_task_aliases(
|
|
||||||
&retry_task_aliases,
|
|
||||||
&retry_displaced_terminals,
|
|
||||||
&displaced_task_id,
|
|
||||||
&displaced_terminal,
|
|
||||||
)
|
|
||||||
.await;
|
|
||||||
remove_mrf_repair_notice_targets(
|
remove_mrf_repair_notice_targets(
|
||||||
&retry_mrf_repair_notice_targets,
|
&retry_mrf_repair_notice_targets,
|
||||||
&displaced_task_id,
|
&displaced_task_id,
|
||||||
|
|||||||
@@ -84,7 +84,6 @@ async fn process_manager_queue_once(manager: &HealManager) {
|
|||||||
heal_queue: &manager.heal_queue,
|
heal_queue: &manager.heal_queue,
|
||||||
active_heals: &manager.active_heals,
|
active_heals: &manager.active_heals,
|
||||||
completed_heals: &manager.completed_heals,
|
completed_heals: &manager.completed_heals,
|
||||||
displaced_terminals: &manager.displaced_terminals,
|
|
||||||
task_aliases: &manager.task_aliases,
|
task_aliases: &manager.task_aliases,
|
||||||
retrying_heals: &manager.retrying_heals,
|
retrying_heals: &manager.retrying_heals,
|
||||||
mrf_repair_notice_targets: &manager.mrf_repair_notice_targets,
|
mrf_repair_notice_targets: &manager.mrf_repair_notice_targets,
|
||||||
@@ -2779,10 +2778,7 @@ async fn test_high_priority_request_displaces_lower_priority_when_queue_full() {
|
|||||||
HealAdmissionResult::Accepted
|
HealAdmissionResult::Accepted
|
||||||
);
|
);
|
||||||
assert_eq!(manager.get_queue_length().await, 1);
|
assert_eq!(manager.get_queue_length().await, 1);
|
||||||
assert!(matches!(
|
assert!(matches!(manager.get_task_status(&low_id).await, Err(Error::TaskNotFound { .. })));
|
||||||
manager.get_task_status(&low_id).await,
|
|
||||||
Ok(HealTaskStatus::Failed { error }) if error.contains("reason=displaced")
|
|
||||||
));
|
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
manager
|
manager
|
||||||
.get_task_status(&high_id)
|
.get_task_status(&high_id)
|
||||||
@@ -2792,263 +2788,6 @@ async fn test_high_priority_request_displaces_lower_priority_when_queue_full() {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn displaced_task_remains_queryable() {
|
|
||||||
let manager = HealManager::new(
|
|
||||||
Arc::new(MockStorage),
|
|
||||||
Some(HealConfig {
|
|
||||||
queue_size: 1,
|
|
||||||
..HealConfig::default()
|
|
||||||
}),
|
|
||||||
);
|
|
||||||
let mut displaced = HealRequest::new(
|
|
||||||
HealType::Bucket {
|
|
||||||
bucket: "displaced-bucket".to_string(),
|
|
||||||
},
|
|
||||||
HealOptions::default(),
|
|
||||||
HealPriority::Low,
|
|
||||||
);
|
|
||||||
displaced.id = "displaced-task".to_string();
|
|
||||||
let displaced_id = displaced.id.clone();
|
|
||||||
manager
|
|
||||||
.submit_heal_request(displaced)
|
|
||||||
.await
|
|
||||||
.expect("displaced request should queue");
|
|
||||||
|
|
||||||
let successor = HealRequest::new(
|
|
||||||
HealType::Bucket {
|
|
||||||
bucket: "successor-bucket".to_string(),
|
|
||||||
},
|
|
||||||
HealOptions::default(),
|
|
||||||
HealPriority::High,
|
|
||||||
);
|
|
||||||
manager
|
|
||||||
.submit_heal_request(successor)
|
|
||||||
.await
|
|
||||||
.expect("successor should displace low work");
|
|
||||||
|
|
||||||
let report = manager
|
|
||||||
.get_task_report(&displaced_id)
|
|
||||||
.await
|
|
||||||
.expect("displaced report should remain queryable");
|
|
||||||
assert!(matches!(report.status, HealTaskStatus::Failed { ref error } if error.contains("reason=displaced")));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn displaced_archive_failure_keeps_queryable_terminal() {
|
|
||||||
let manager = HealManager::new(Arc::new(MockStorage), None);
|
|
||||||
let mut request = HealRequest::new(
|
|
||||||
HealType::Bucket {
|
|
||||||
bucket: "archive-failure".to_string(),
|
|
||||||
},
|
|
||||||
HealOptions::default(),
|
|
||||||
HealPriority::Low,
|
|
||||||
);
|
|
||||||
request.id = "archive-failure-task".to_string();
|
|
||||||
let request_id = request.id.clone();
|
|
||||||
// The synchronous sidecar is the authoritative fallback when the normal
|
|
||||||
// completed-task archive has no entry (the failure window that must not
|
|
||||||
// turn an Accepted ID into NotFound).
|
|
||||||
record_displaced_terminal(&manager.displaced_terminals, &request);
|
|
||||||
assert!(manager.completed_heals.lock().await.is_empty());
|
|
||||||
assert!(matches!(
|
|
||||||
manager.get_task_status(&request_id).await,
|
|
||||||
Ok(HealTaskStatus::Failed { error }) if error.contains("reason=displaced")
|
|
||||||
));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn scheduler_retry_displacement_keeps_evicted_task_queryable() {
|
|
||||||
let manager = Arc::new(HealManager::new(
|
|
||||||
Arc::new(MockStorage),
|
|
||||||
Some(HealConfig {
|
|
||||||
queue_size: 1,
|
|
||||||
event_driven_scheduler_enable: false,
|
|
||||||
..HealConfig::default()
|
|
||||||
}),
|
|
||||||
));
|
|
||||||
let mut retry_request = HealRequest::object("retry-transition".to_string(), "object".to_string(), None);
|
|
||||||
retry_request.priority = HealPriority::High;
|
|
||||||
let retry_id = retry_request.id.clone();
|
|
||||||
manager
|
|
||||||
.submit_heal_request(retry_request)
|
|
||||||
.await
|
|
||||||
.expect("retry request should queue");
|
|
||||||
|
|
||||||
// Process exactly one queue cycle so the retry task is spawned without a
|
|
||||||
// background scheduler consuming the filler request before the retry wakes.
|
|
||||||
process_manager_queue_once(&manager).await;
|
|
||||||
tokio::time::timeout(Duration::from_secs(1), async {
|
|
||||||
loop {
|
|
||||||
if manager.retrying_heals.lock().await.contains_key(&retry_id) {
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
tokio::task::yield_now().await;
|
|
||||||
}
|
|
||||||
})
|
|
||||||
.await
|
|
||||||
.expect("retry request should enter backoff");
|
|
||||||
|
|
||||||
let filler = HealRequest::new(
|
|
||||||
HealType::Bucket {
|
|
||||||
bucket: "retry-displaced-filler".to_string(),
|
|
||||||
},
|
|
||||||
HealOptions::default(),
|
|
||||||
HealPriority::Low,
|
|
||||||
);
|
|
||||||
let filler_id = filler.id.clone();
|
|
||||||
manager
|
|
||||||
.submit_heal_request(filler)
|
|
||||||
.await
|
|
||||||
.expect("filler request should occupy the queue");
|
|
||||||
|
|
||||||
tokio::time::timeout(Duration::from_secs(5), async {
|
|
||||||
loop {
|
|
||||||
if matches!(
|
|
||||||
manager.get_task_status(&filler_id).await,
|
|
||||||
Ok(HealTaskStatus::Failed { ref error }) if error.contains("reason=displaced")
|
|
||||||
) {
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
tokio::time::sleep(Duration::from_millis(10)).await;
|
|
||||||
}
|
|
||||||
})
|
|
||||||
.await
|
|
||||||
.expect("retry admission should displace the filler request");
|
|
||||||
assert_eq!(manager.get_queue_length().await, 1);
|
|
||||||
assert_eq!(
|
|
||||||
manager.get_task_status(&retry_id).await.expect("retry should be queued"),
|
|
||||||
HealTaskStatus::Pending
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn concurrent_displacers_produce_one_terminal_generation() {
|
|
||||||
let manager = Arc::new(HealManager::new(
|
|
||||||
Arc::new(MockStorage),
|
|
||||||
Some(HealConfig {
|
|
||||||
queue_size: 1,
|
|
||||||
..HealConfig::default()
|
|
||||||
}),
|
|
||||||
));
|
|
||||||
let mut displaced = HealRequest::new(
|
|
||||||
HealType::Bucket {
|
|
||||||
bucket: "concurrent-displaced".to_string(),
|
|
||||||
},
|
|
||||||
HealOptions::default(),
|
|
||||||
HealPriority::Low,
|
|
||||||
);
|
|
||||||
displaced.id = "concurrent-displaced-task".to_string();
|
|
||||||
let displaced_id = displaced.id.clone();
|
|
||||||
manager
|
|
||||||
.submit_heal_request(displaced)
|
|
||||||
.await
|
|
||||||
.expect("initial request should queue");
|
|
||||||
|
|
||||||
let first = HealRequest::new(
|
|
||||||
HealType::Bucket {
|
|
||||||
bucket: "concurrent-successor-a".to_string(),
|
|
||||||
},
|
|
||||||
HealOptions::default(),
|
|
||||||
HealPriority::High,
|
|
||||||
);
|
|
||||||
let second = HealRequest::new(
|
|
||||||
HealType::Bucket {
|
|
||||||
bucket: "concurrent-successor-b".to_string(),
|
|
||||||
},
|
|
||||||
HealOptions::default(),
|
|
||||||
HealPriority::High,
|
|
||||||
);
|
|
||||||
let (first_result, second_result) = tokio::join!(manager.submit_heal_request(first), manager.submit_heal_request(second));
|
|
||||||
let accepted = [&first_result, &second_result]
|
|
||||||
.into_iter()
|
|
||||||
.filter(|result| matches!(result, Ok(HealAdmissionResult::Accepted)))
|
|
||||||
.count();
|
|
||||||
assert_eq!(accepted, 1, "exactly one concurrent displacer should win the full queue");
|
|
||||||
assert!(
|
|
||||||
first_result.is_ok() && second_result.is_ok(),
|
|
||||||
"the losing request should receive a typed Full result"
|
|
||||||
);
|
|
||||||
let terminals = lock_displaced_terminals(&manager.displaced_terminals);
|
|
||||||
assert_eq!(terminals.len(), 1);
|
|
||||||
assert!(terminals.contains_key(&displaced_id));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn successor_chain_is_bounded_and_authorized() {
|
|
||||||
let manager = HealManager::new(
|
|
||||||
Arc::new(MockStorage),
|
|
||||||
Some(HealConfig {
|
|
||||||
queue_size: 1,
|
|
||||||
..HealConfig::default()
|
|
||||||
}),
|
|
||||||
);
|
|
||||||
let mut original = HealRequest::new(
|
|
||||||
HealType::Bucket {
|
|
||||||
bucket: "authorized-original".to_string(),
|
|
||||||
},
|
|
||||||
HealOptions::default(),
|
|
||||||
HealPriority::Low,
|
|
||||||
);
|
|
||||||
original.id = "authorized-original-task".to_string();
|
|
||||||
let original_id = original.id.clone();
|
|
||||||
manager.submit_heal_request(original).await.expect("original should queue");
|
|
||||||
let mut duplicate = HealRequest::new(
|
|
||||||
HealType::Bucket {
|
|
||||||
bucket: "authorized-original".to_string(),
|
|
||||||
},
|
|
||||||
HealOptions::default(),
|
|
||||||
HealPriority::Low,
|
|
||||||
);
|
|
||||||
duplicate.id = "authorized-duplicate-task".to_string();
|
|
||||||
let duplicate_id = duplicate.id.clone();
|
|
||||||
manager
|
|
||||||
.submit_heal_request(duplicate)
|
|
||||||
.await
|
|
||||||
.expect("same-target duplicate should merge");
|
|
||||||
let successor = HealRequest::new(
|
|
||||||
HealType::Bucket {
|
|
||||||
bucket: "authorized-successor".to_string(),
|
|
||||||
},
|
|
||||||
HealOptions::default(),
|
|
||||||
HealPriority::High,
|
|
||||||
);
|
|
||||||
let successor_id = successor.id.clone();
|
|
||||||
manager.submit_heal_request(successor).await.expect("successor should queue");
|
|
||||||
assert!(manager.task_aliases.lock().await.is_empty());
|
|
||||||
assert!(matches!(manager.get_task_status(&original_id).await, Ok(HealTaskStatus::Failed { .. })));
|
|
||||||
assert!(matches!(manager.get_task_status(&duplicate_id).await, Ok(HealTaskStatus::Failed { .. })));
|
|
||||||
assert_eq!(
|
|
||||||
manager
|
|
||||||
.get_task_status(&successor_id)
|
|
||||||
.await
|
|
||||||
.expect("successor should remain queued"),
|
|
||||||
HealTaskStatus::Pending
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn displaced_terminal_expires_after_bounded_ttl() {
|
|
||||||
let manager = HealManager::new(Arc::new(MockStorage), None);
|
|
||||||
let mut request = HealRequest::new(
|
|
||||||
HealType::Bucket {
|
|
||||||
bucket: "expires".to_string(),
|
|
||||||
},
|
|
||||||
HealOptions::default(),
|
|
||||||
HealPriority::Low,
|
|
||||||
);
|
|
||||||
request.id = "expires-task".to_string();
|
|
||||||
let request_id = request.id.clone();
|
|
||||||
record_displaced_terminal(&manager.displaced_terminals, &request);
|
|
||||||
{
|
|
||||||
let mut terminals = lock_displaced_terminals(&manager.displaced_terminals);
|
|
||||||
let entry =
|
|
||||||
Arc::get_mut(terminals.get_mut(&request_id).expect("terminal should be retained")).expect("test owns terminal entry");
|
|
||||||
entry.completed_at = SystemTime::now() - KEEP_HEAL_TASK_STATUS_DURATION - Duration::from_secs(1);
|
|
||||||
}
|
|
||||||
assert!(matches!(manager.get_task_status(&request_id).await, Err(Error::TaskNotFound { .. })));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_displacing_registered_mrf_task_drops_notice_ownership() {
|
async fn test_displacing_registered_mrf_task_drops_notice_ownership() {
|
||||||
let storage: Arc<dyn HealStorageAPI> = Arc::new(MockStorage);
|
let storage: Arc<dyn HealStorageAPI> = Arc::new(MockStorage);
|
||||||
|
|||||||
@@ -722,10 +722,6 @@ pub struct DeleteVersionsResponse {
|
|||||||
pub errors: ::prost::alloc::vec::Vec<::prost::alloc::string::String>,
|
pub errors: ::prost::alloc::vec::Vec<::prost::alloc::string::String>,
|
||||||
#[prost(message, optional, tag = "3")]
|
#[prost(message, optional, tag = "3")]
|
||||||
pub error: ::core::option::Option<Error>,
|
pub error: ::core::option::Option<Error>,
|
||||||
/// Senders dual-write the legacy strings and typed entries. Receivers prefer typed entries
|
|
||||||
/// when present and fall back to strings for peers that predate this field. Code zero means success.
|
|
||||||
#[prost(message, repeated, tag = "4")]
|
|
||||||
pub item_errors: ::prost::alloc::vec::Vec<Error>,
|
|
||||||
}
|
}
|
||||||
#[derive(Clone, PartialEq, Eq, Hash, ::prost::Message)]
|
#[derive(Clone, PartialEq, Eq, Hash, ::prost::Message)]
|
||||||
pub struct ReadMultipleRequest {
|
pub struct ReadMultipleRequest {
|
||||||
|
|||||||
@@ -2106,9 +2106,6 @@ pub enum ChannelClass {
|
|||||||
Bulk,
|
Bulk,
|
||||||
}
|
}
|
||||||
|
|
||||||
// Keep multiplexed unary RPCs below h2's per-connection small-frame budget.
|
|
||||||
const INTERNODE_RPC_CONCURRENCY_LIMIT: usize = 64;
|
|
||||||
|
|
||||||
/// Whether control/bulk channel isolation is enabled (env-gated, default off for safe rollout).
|
/// Whether control/bulk channel isolation is enabled (env-gated, default off for safe rollout).
|
||||||
fn channel_isolation_enabled() -> bool {
|
fn channel_isolation_enabled() -> bool {
|
||||||
rustfs_utils::get_env_bool(
|
rustfs_utils::get_env_bool(
|
||||||
@@ -2191,7 +2188,6 @@ async fn build_channel(dial_addr: &str, cache_key: &str) -> Result<Channel, Box<
|
|||||||
let mut connector = Endpoint::from_shared(dial_addr.to_string())?
|
let mut connector = Endpoint::from_shared(dial_addr.to_string())?
|
||||||
// Fast connection timeout for dead peer detection
|
// Fast connection timeout for dead peer detection
|
||||||
.connect_timeout(connect_timeout)
|
.connect_timeout(connect_timeout)
|
||||||
.concurrency_limit(INTERNODE_RPC_CONCURRENCY_LIMIT)
|
|
||||||
// TCP-level keepalive - OS will probe connection
|
// TCP-level keepalive - OS will probe connection
|
||||||
.tcp_keepalive(Some(tcp_keepalive))
|
.tcp_keepalive(Some(tcp_keepalive))
|
||||||
// Disable Nagle so latency-sensitive control-plane RPCs (locks/health) are not batched
|
// Disable Nagle so latency-sensitive control-plane RPCs (locks/health) are not batched
|
||||||
|
|||||||
@@ -493,9 +493,6 @@ message DeleteVersionsResponse {
|
|||||||
bool success = 1;
|
bool success = 1;
|
||||||
repeated string errors = 2;
|
repeated string errors = 2;
|
||||||
optional Error error = 3;
|
optional Error error = 3;
|
||||||
// Senders dual-write the legacy strings and typed entries. Receivers prefer typed entries
|
|
||||||
// when present and fall back to strings for peers that predate this field. Code zero means success.
|
|
||||||
repeated Error item_errors = 4;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
message ReadMultipleRequest {
|
message ReadMultipleRequest {
|
||||||
|
|||||||
@@ -16,7 +16,7 @@ use super::persistence::DataUsageCacheLoadAttempt;
|
|||||||
use super::*;
|
use super::*;
|
||||||
use crate::storage_api::scanner_io::{HTTPRangeSpec, ObjectIO};
|
use crate::storage_api::scanner_io::{HTTPRangeSpec, ObjectIO};
|
||||||
use crate::{ScannerGetObjectReader, ScannerPutObjReader};
|
use crate::{ScannerGetObjectReader, ScannerPutObjReader};
|
||||||
use rustfs_data_usage::{ReplicationAllStats, ReplicationTargetUsage};
|
use rustfs_data_usage::{ReplicationAllStats, ReplicationStats};
|
||||||
use serde_json::Value;
|
use serde_json::Value;
|
||||||
use std::io::Cursor;
|
use std::io::Cursor;
|
||||||
use std::pin::Pin;
|
use std::pin::Pin;
|
||||||
@@ -1636,7 +1636,7 @@ fn size_recursive_prunes_empty_and_preserves_threshold_replication_stats() {
|
|||||||
replication_stats: Some(ReplicationAllStats {
|
replication_stats: Some(ReplicationAllStats {
|
||||||
targets: HashMap::from([(
|
targets: HashMap::from([(
|
||||||
"arn:test:threshold".to_string(),
|
"arn:test:threshold".to_string(),
|
||||||
ReplicationTargetUsage {
|
ReplicationStats {
|
||||||
after_threshold_count: 1,
|
after_threshold_count: 1,
|
||||||
..Default::default()
|
..Default::default()
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -13,7 +13,7 @@
|
|||||||
// limitations under the License.
|
// limitations under the License.
|
||||||
|
|
||||||
use super::*;
|
use super::*;
|
||||||
use rustfs_data_usage::{ReplicationAllStats, ReplicationTargetUsage};
|
use rustfs_data_usage::{ReplicationAllStats, ReplicationStats};
|
||||||
|
|
||||||
const TEST_PLAN_DIGEST: DataUsageScanPlanDigest = DataUsageScanPlanDigest([7; 32]);
|
const TEST_PLAN_DIGEST: DataUsageScanPlanDigest = DataUsageScanPlanDigest([7; 32]);
|
||||||
|
|
||||||
@@ -271,7 +271,7 @@ fn completed_data_usage_info_flattens_nested_bucket_entries() {
|
|||||||
replication_stats: Some(ReplicationAllStats {
|
replication_stats: Some(ReplicationAllStats {
|
||||||
targets: HashMap::from([(
|
targets: HashMap::from([(
|
||||||
"arn:target".to_string(),
|
"arn:target".to_string(),
|
||||||
ReplicationTargetUsage {
|
ReplicationStats {
|
||||||
replicated_size: 2048,
|
replicated_size: 2048,
|
||||||
replicated_count: 2,
|
replicated_count: 2,
|
||||||
..Default::default()
|
..Default::default()
|
||||||
|
|||||||
@@ -70,6 +70,12 @@ const SITE_REPLICATION_EDIT_ROUTE: &str = "/rustfs/admin/v3/site-replication/edi
|
|||||||
const SITE_REPLICATION_RESYNC_ROUTE: &str = "/rustfs/admin/v3/site-replication/resync/op";
|
const SITE_REPLICATION_RESYNC_ROUTE: &str = "/rustfs/admin/v3/site-replication/resync/op";
|
||||||
const SITE_REPLICATION_REPAIR_ROUTE: &str = "/rustfs/admin/v3/site-replication/repair";
|
const SITE_REPLICATION_REPAIR_ROUTE: &str = "/rustfs/admin/v3/site-replication/repair";
|
||||||
const SITE_REPLICATION_REPAIR_STATUS_ROUTE: &str = "/rustfs/admin/v3/site-replication/repair/status";
|
const SITE_REPLICATION_REPAIR_STATUS_ROUTE: &str = "/rustfs/admin/v3/site-replication/repair/status";
|
||||||
|
const IAM_POLICY_ATTACH_ROUTE: &str = "/rustfs/admin/v3/idp/builtin/policy/attach";
|
||||||
|
const IAM_POLICY_DETACH_ROUTE: &str = "/rustfs/admin/v3/idp/builtin/policy/detach";
|
||||||
|
const IAM_POLICY_ENTITIES_ROUTE: &str = "/rustfs/admin/v3/idp/builtin/policy-entities";
|
||||||
|
const IAM_ACCESS_KEYS_BULK_ROUTE: &str = "/rustfs/admin/v3/list-access-keys-bulk";
|
||||||
|
const IAM_ACCESS_KEYS_BULK_LDAP_ROUTE: &str = "/rustfs/admin/v3/idp/ldap/list-access-keys-bulk";
|
||||||
|
const IAM_ACCESS_KEYS_BULK_OPENID_ROUTE: &str = "/rustfs/admin/v3/idp/openid/list-access-keys-bulk";
|
||||||
|
|
||||||
macro_rules! log_system_request_rejected {
|
macro_rules! log_system_request_rejected {
|
||||||
($operation:expr, $reason:expr) => {
|
($operation:expr, $reason:expr) => {
|
||||||
@@ -661,9 +667,24 @@ pub struct RuntimeCapabilitiesSummary {
|
|||||||
pub manual_transition_jobs: CapabilityStatus,
|
pub manual_transition_jobs: CapabilityStatus,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// One named admin capability advertised to management clients
|
||||||
|
/// (rustfs/backlog#1900). `name` is a cross-repo wire contract: the rc
|
||||||
|
/// client gates commands on these exact strings (see rustfs/cli
|
||||||
|
/// `IAM_POLICY_DETACH_CAPABILITY` etc.), so entries may be added but
|
||||||
|
/// existing names must never be renamed or removed.
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
|
||||||
|
pub struct AdvertisedAdminCapability {
|
||||||
|
pub name: &'static str,
|
||||||
|
pub status: CapabilityStatus,
|
||||||
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
|
#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
|
||||||
pub struct RuntimeCapabilitiesResponse {
|
pub struct RuntimeCapabilitiesResponse {
|
||||||
pub summary: RuntimeCapabilitiesSummary,
|
pub summary: RuntimeCapabilitiesSummary,
|
||||||
|
/// Additive field: absent in responses from older servers, so clients
|
||||||
|
/// must treat a missing list as "no dynamic advertisement" and fall
|
||||||
|
/// back to their pinned per-version contract.
|
||||||
|
pub advertised: Vec<AdvertisedAdminCapability>,
|
||||||
pub replication: ReplicationCapabilities,
|
pub replication: ReplicationCapabilities,
|
||||||
pub manual_transition_jobs: ManualTransitionJobCapabilities,
|
pub manual_transition_jobs: ManualTransitionJobCapabilities,
|
||||||
pub diagnostic_probes: DiagnosticProbeCapabilities,
|
pub diagnostic_probes: DiagnosticProbeCapabilities,
|
||||||
@@ -986,6 +1007,7 @@ pub(crate) async fn build_runtime_capabilities_response()
|
|||||||
|
|
||||||
Ok(RuntimeCapabilitiesResponse {
|
Ok(RuntimeCapabilitiesResponse {
|
||||||
summary,
|
summary,
|
||||||
|
advertised: advertised_admin_capabilities(),
|
||||||
replication: ReplicationCapabilities::current(),
|
replication: ReplicationCapabilities::current(),
|
||||||
manual_transition_jobs: ManualTransitionJobCapabilities::current(),
|
manual_transition_jobs: ManualTransitionJobCapabilities::current(),
|
||||||
diagnostic_probes: DiagnosticProbeCapabilities::current(),
|
diagnostic_probes: DiagnosticProbeCapabilities::current(),
|
||||||
@@ -1077,6 +1099,23 @@ fn admin_route_capability(method: HttpMethod, path: &str) -> CapabilityStatus {
|
|||||||
admin_route_capability_from_inventory(method, path, ADMIN_ROUTE_POLICY_SPECS, DEFERRED_ADMIN_ROUTE_POLICIES)
|
admin_route_capability_from_inventory(method, path, ADMIN_ROUTE_POLICY_SPECS, DEFERRED_ADMIN_ROUTE_POLICIES)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn advertised_admin_capabilities() -> Vec<AdvertisedAdminCapability> {
|
||||||
|
[
|
||||||
|
("admin.iam.policy-attach", HttpMethod::Post, IAM_POLICY_ATTACH_ROUTE),
|
||||||
|
("admin.iam.policy-detach", HttpMethod::Post, IAM_POLICY_DETACH_ROUTE),
|
||||||
|
("admin.iam.policy-entities", HttpMethod::Get, IAM_POLICY_ENTITIES_ROUTE),
|
||||||
|
("admin.iam.access-keys-bulk", HttpMethod::Get, IAM_ACCESS_KEYS_BULK_ROUTE),
|
||||||
|
("admin.iam.access-keys-bulk.ldap", HttpMethod::Get, IAM_ACCESS_KEYS_BULK_LDAP_ROUTE),
|
||||||
|
("admin.iam.access-keys-bulk.openid", HttpMethod::Get, IAM_ACCESS_KEYS_BULK_OPENID_ROUTE),
|
||||||
|
]
|
||||||
|
.into_iter()
|
||||||
|
.map(|(name, method, route)| AdvertisedAdminCapability {
|
||||||
|
name,
|
||||||
|
status: admin_route_capability(method, route),
|
||||||
|
})
|
||||||
|
.collect()
|
||||||
|
}
|
||||||
|
|
||||||
fn admin_route_capability_from_inventory(
|
fn admin_route_capability_from_inventory(
|
||||||
method: HttpMethod,
|
method: HttpMethod,
|
||||||
path: &str,
|
path: &str,
|
||||||
@@ -1239,6 +1278,48 @@ mod tests {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Wire-contract pin (rustfs/backlog#1900): the rc client keys its
|
||||||
|
/// command gates on these exact capability names, and parses each
|
||||||
|
/// entry as `{name, status: {state, reason?}}`. Renaming or dropping
|
||||||
|
/// a name silently disables the corresponding rc command.
|
||||||
|
#[tokio::test]
|
||||||
|
async fn runtime_capabilities_response_advertises_iam_capabilities() {
|
||||||
|
let response = build_runtime_capabilities_response()
|
||||||
|
.await
|
||||||
|
.expect("runtime capabilities response should build");
|
||||||
|
|
||||||
|
let expected_supported = [
|
||||||
|
"admin.iam.policy-attach",
|
||||||
|
"admin.iam.policy-detach",
|
||||||
|
"admin.iam.policy-entities",
|
||||||
|
"admin.iam.access-keys-bulk",
|
||||||
|
"admin.iam.access-keys-bulk.ldap",
|
||||||
|
"admin.iam.access-keys-bulk.openid",
|
||||||
|
];
|
||||||
|
for name in expected_supported {
|
||||||
|
let entry = response
|
||||||
|
.advertised
|
||||||
|
.iter()
|
||||||
|
.find(|capability| capability.name == name)
|
||||||
|
.unwrap_or_else(|| panic!("{name} must be advertised"));
|
||||||
|
assert_eq!(entry.status.state, CapabilityState::Supported, "{name} must be supported");
|
||||||
|
}
|
||||||
|
|
||||||
|
let mut names: Vec<&str> = response.advertised.iter().map(|capability| capability.name).collect();
|
||||||
|
let total = names.len();
|
||||||
|
names.sort_unstable();
|
||||||
|
names.dedup();
|
||||||
|
assert_eq!(names.len(), total, "advertised capability names must be unique");
|
||||||
|
|
||||||
|
let serialized = serde_json::to_value(&response).expect("response should serialize");
|
||||||
|
let advertised = serialized["advertised"].as_array().expect("advertised must be an array");
|
||||||
|
let detach = advertised
|
||||||
|
.iter()
|
||||||
|
.find(|entry| entry["name"] == "admin.iam.policy-detach")
|
||||||
|
.expect("serialized detach entry must exist");
|
||||||
|
assert_eq!(detach["status"]["state"], "supported");
|
||||||
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn runtime_capabilities_response_reports_missing_topology_before_storage_init() {
|
async fn runtime_capabilities_response_reports_missing_topology_before_storage_init() {
|
||||||
let response = build_runtime_capabilities_response()
|
let response = build_runtime_capabilities_response()
|
||||||
|
|||||||
@@ -146,29 +146,6 @@ fn encode_file_info_msgpack(value: &FileInfo) -> std::result::Result<Vec<u8>, Di
|
|||||||
encode_msgpack_with_capacity(value, "FileInfo", FILE_INFO_MSGPACK_ENCODE_CAPACITY_HINT)
|
encode_msgpack_with_capacity(value, "FileInfo", FILE_INFO_MSGPACK_ENCODE_CAPACITY_HINT)
|
||||||
}
|
}
|
||||||
|
|
||||||
fn encode_delete_versions_errors(disk_errors: Vec<Option<DiskError>>) -> (Vec<String>, Vec<Error>) {
|
|
||||||
let mut errors = Vec::with_capacity(disk_errors.len());
|
|
||||||
let mut item_errors = Vec::with_capacity(disk_errors.len());
|
|
||||||
for error in disk_errors {
|
|
||||||
match error {
|
|
||||||
Some(error) => {
|
|
||||||
let code = match &error {
|
|
||||||
DiskError::Io(source) if source.kind() == std::io::ErrorKind::NotFound => DiskError::FileNotFound.to_u32(),
|
|
||||||
_ => error.to_u32(),
|
|
||||||
};
|
|
||||||
let error_info = error.to_string();
|
|
||||||
errors.push(error_info.clone());
|
|
||||||
item_errors.push(Error { code, error_info });
|
|
||||||
}
|
|
||||||
None => {
|
|
||||||
errors.push(String::new());
|
|
||||||
item_errors.push(Error::default());
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
(errors, item_errors)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn encode_msgpack_named<T: serde::Serialize>(value: &T, value_name: &str) -> std::result::Result<Vec<u8>, DiskError> {
|
fn encode_msgpack_named<T: serde::Serialize>(value: &T, value_name: &str) -> std::result::Result<Vec<u8>, DiskError> {
|
||||||
let mut serializer = rmp_serde::Serializer::new(Vec::with_capacity(MSGPACK_ENCODE_CAPACITY_HINT)).with_struct_map();
|
let mut serializer = rmp_serde::Serializer::new(Vec::with_capacity(MSGPACK_ENCODE_CAPACITY_HINT)).with_struct_map();
|
||||||
value
|
value
|
||||||
@@ -575,7 +552,6 @@ impl NodeService {
|
|||||||
success: false,
|
success: false,
|
||||||
errors: Vec::new(),
|
errors: Vec::new(),
|
||||||
error: Some(DiskError::other(format!("decode FileInfoVersions failed: {err}")).into()),
|
error: Some(DiskError::other(format!("decode FileInfoVersions failed: {err}")).into()),
|
||||||
item_errors: Vec::new(),
|
|
||||||
}));
|
}));
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
@@ -587,26 +563,30 @@ impl NodeService {
|
|||||||
success: false,
|
success: false,
|
||||||
errors: Vec::new(),
|
errors: Vec::new(),
|
||||||
error: Some(DiskError::other(format!("decode DeleteOptions failed: {err}")).into()),
|
error: Some(DiskError::other(format!("decode DeleteOptions failed: {err}")).into()),
|
||||||
item_errors: Vec::new(),
|
|
||||||
}));
|
}));
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
let (errors, item_errors) =
|
let errors = disk
|
||||||
encode_delete_versions_errors(disk.delete_versions(&request.volume, versions, opts).await);
|
.delete_versions(&request.volume, versions, opts)
|
||||||
|
.await
|
||||||
|
.into_iter()
|
||||||
|
.map(|error| match error {
|
||||||
|
Some(e) => e.to_string(),
|
||||||
|
None => "".to_string(),
|
||||||
|
})
|
||||||
|
.collect();
|
||||||
|
|
||||||
Ok(Response::new(DeleteVersionsResponse {
|
Ok(Response::new(DeleteVersionsResponse {
|
||||||
success: true,
|
success: true,
|
||||||
errors,
|
errors,
|
||||||
error: None,
|
error: None,
|
||||||
item_errors,
|
|
||||||
}))
|
}))
|
||||||
} else {
|
} else {
|
||||||
Ok(Response::new(DeleteVersionsResponse {
|
Ok(Response::new(DeleteVersionsResponse {
|
||||||
success: false,
|
success: false,
|
||||||
errors: Vec::new(),
|
errors: Vec::new(),
|
||||||
error: Some(DiskError::other("cannot find disk".to_string()).into()),
|
error: Some(DiskError::other("cannot find disk".to_string()).into()),
|
||||||
item_errors: Vec::new(),
|
|
||||||
}))
|
}))
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1632,8 +1612,8 @@ impl NodeService {
|
|||||||
mod tests {
|
mod tests {
|
||||||
use super::{
|
use super::{
|
||||||
compat_response_json, decode_msgpack_or_json, decode_rename_data_request_file_info,
|
compat_response_json, decode_msgpack_or_json, decode_rename_data_request_file_info,
|
||||||
encode_batch_read_version_response_payloads, encode_delete_versions_errors, encode_file_info_msgpack, encode_msgpack,
|
encode_batch_read_version_response_payloads, encode_file_info_msgpack, encode_msgpack, encode_msgpack_named,
|
||||||
encode_msgpack_named, encode_read_multiple_response_payloads, encode_rename_data_response_payloads,
|
encode_read_multiple_response_payloads, encode_rename_data_response_payloads,
|
||||||
};
|
};
|
||||||
use crate::storage::rpc::node_service::make_server;
|
use crate::storage::rpc::node_service::make_server;
|
||||||
use crate::storage::storage_api::ReadMultipleResp;
|
use crate::storage::storage_api::ReadMultipleResp;
|
||||||
@@ -1652,18 +1632,6 @@ mod tests {
|
|||||||
count: u32,
|
count: u32,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn delete_versions_response_dual_writes_typed_item_errors() {
|
|
||||||
let raw_not_found = super::DiskError::Io(std::io::Error::from(std::io::ErrorKind::NotFound));
|
|
||||||
let (errors, item_errors) = encode_delete_versions_errors(vec![Some(raw_not_found), None]);
|
|
||||||
|
|
||||||
assert!(errors[0].starts_with("io error "));
|
|
||||||
assert!(errors[1].is_empty());
|
|
||||||
assert_eq!(item_errors[0].code, super::DiskError::FileNotFound.to_u32());
|
|
||||||
assert_eq!(item_errors[0].error_info, errors[0]);
|
|
||||||
assert_eq!(item_errors[1].code, 0);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[serial]
|
#[serial]
|
||||||
async fn handle_read_version_records_attribution_for_missing_disk() {
|
async fn handle_read_version_records_attribution_for_missing_disk() {
|
||||||
|
|||||||
Reference in New Issue
Block a user