mirror of
https://github.com/rustfs/rustfs.git
synced 2026-08-23 04:39:04 +00:00
Compare commits
2 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| b3c79cd71a | |||
| c57f22c3a0 |
@@ -325,8 +325,8 @@ slow-timeout = { period = "60s", terminate-after = 2, grace-period = "10s" }
|
|||||||
#
|
#
|
||||||
# Wired by .github/workflows/e2e-replication-nightly.yml (schedule +
|
# Wired by .github/workflows/e2e-replication-nightly.yml (schedule +
|
||||||
# workflow_dispatch), which builds the rustfs binary once, installs awscurl so
|
# workflow_dispatch), which builds the rustfs binary once, installs awscurl so
|
||||||
# the STS dual-node test actually exercises its path (the test fails when
|
# the STS dual-node test actually exercises its path (it skips gracefully with
|
||||||
# awscurl is absent), and routes scheduled failures
|
# a visible log line when awscurl is absent), and routes scheduled failures
|
||||||
# through .github/actions/schedule-failure-issue (ci-8). Explicit division of
|
# through .github/actions/schedule-failure-issue (ci-8). Explicit division of
|
||||||
# labor with e2e-full: these tests run only in the consolidated nightly
|
# labor with e2e-full: these tests run only in the consolidated nightly
|
||||||
# workflow, not in the merge/main lane.
|
# workflow, not in the merge/main lane.
|
||||||
|
|||||||
@@ -681,19 +681,6 @@ jobs:
|
|||||||
cache-save-if: 'false'
|
cache-save-if: 'false'
|
||||||
install-build-packaging-tools: 'false'
|
install-build-packaging-tools: 'false'
|
||||||
|
|
||||||
- name: Set up Python
|
|
||||||
uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
|
|
||||||
with:
|
|
||||||
python-version: "3.12"
|
|
||||||
|
|
||||||
- name: Install awscurl
|
|
||||||
run: |
|
|
||||||
python3 -m pip install --user --upgrade pip "awscurl==0.44"
|
|
||||||
echo "AWSCURL_PATH=$HOME/.local/bin/awscurl" >> "$GITHUB_ENV"
|
|
||||||
|
|
||||||
- name: Verify awscurl
|
|
||||||
run: test -x "$AWSCURL_PATH"
|
|
||||||
|
|
||||||
# Download after the cache restore so the freshly built binary from the
|
# Download after the cache restore so the freshly built binary from the
|
||||||
# build job always wins over anything restored into target/debug.
|
# build job always wins over anything restored into target/debug.
|
||||||
- name: Download debug binary
|
- name: Download debug binary
|
||||||
@@ -816,20 +803,6 @@ jobs:
|
|||||||
- name: Verify awscurl
|
- name: Verify awscurl
|
||||||
run: test -x "$AWSCURL_PATH"
|
run: test -x "$AWSCURL_PATH"
|
||||||
|
|
||||||
- name: Install mc
|
|
||||||
env:
|
|
||||||
MC_VERSION: RELEASE.2025-08-13T08-35-41Z
|
|
||||||
MC_SHA256: 01f866e9c5f9b87c2b09116fa5d7c06695b106242d829a8bb32990c00312e891
|
|
||||||
run: |
|
|
||||||
MC_BINARY="mc.linux-amd64.${MC_VERSION}"
|
|
||||||
curl -fsSLo "$RUNNER_TEMP/mc" "https://github.com/minio/mc/releases/download/${MC_VERSION}/${MC_BINARY}"
|
|
||||||
echo "${MC_SHA256} $RUNNER_TEMP/mc" | sha256sum --check --status
|
|
||||||
chmod +x "$RUNNER_TEMP/mc"
|
|
||||||
echo "$RUNNER_TEMP" >> "$GITHUB_PATH"
|
|
||||||
|
|
||||||
- name: Verify mc
|
|
||||||
run: mc --version
|
|
||||||
|
|
||||||
- name: Install Vault
|
- name: Install Vault
|
||||||
run: |
|
run: |
|
||||||
VAULT_VERSION="1.17.6"
|
VAULT_VERSION="1.17.6"
|
||||||
|
|||||||
@@ -75,7 +75,11 @@ jobs:
|
|||||||
cache-save-if: ${{ github.ref == 'refs/heads/main' }}
|
cache-save-if: ${{ github.ref == 'refs/heads/main' }}
|
||||||
install-build-packaging-tools: 'false'
|
install-build-packaging-tools: 'false'
|
||||||
|
|
||||||
# The STS dual-node test requires awscurl and fails if it is unavailable.
|
# awscurl lets the STS dual-node test actually exercise its path. Without
|
||||||
|
# it the test skips gracefully with a visible log line
|
||||||
|
# (`awscurl_available()` in crates/e2e_test/src/common.rs), so the lane
|
||||||
|
# still passes — installing it just upgrades that one test from skip to
|
||||||
|
# real coverage.
|
||||||
- name: Set up Python
|
- name: Set up Python
|
||||||
uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
|
uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
|
||||||
with:
|
with:
|
||||||
@@ -83,7 +87,7 @@ jobs:
|
|||||||
|
|
||||||
- name: Install awscurl
|
- name: Install awscurl
|
||||||
run: |
|
run: |
|
||||||
python3 -m pip install --user --upgrade pip "awscurl==0.44"
|
python3 -m pip install --user --upgrade pip awscurl
|
||||||
echo "AWSCURL_PATH=$HOME/.local/bin/awscurl" >> "$GITHUB_ENV"
|
echo "AWSCURL_PATH=$HOME/.local/bin/awscurl" >> "$GITHUB_ENV"
|
||||||
|
|
||||||
- name: Verify awscurl
|
- name: Verify awscurl
|
||||||
|
|||||||
@@ -39,10 +39,11 @@ jobs:
|
|||||||
env:
|
env:
|
||||||
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
|
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout main branch
|
||||||
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
||||||
with:
|
with:
|
||||||
persist-credentials: false
|
persist-credentials: false
|
||||||
|
ref: main
|
||||||
|
|
||||||
- name: Setup Rust environment
|
- name: Setup Rust environment
|
||||||
uses: ./.github/actions/setup
|
uses: ./.github/actions/setup
|
||||||
@@ -88,10 +89,11 @@ jobs:
|
|||||||
# either casing.
|
# either casing.
|
||||||
NO_PROXY: 127.0.0.1,localhost
|
NO_PROXY: 127.0.0.1,localhost
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout main branch
|
||||||
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
||||||
with:
|
with:
|
||||||
persist-credentials: false
|
persist-credentials: false
|
||||||
|
ref: main
|
||||||
|
|
||||||
- name: Setup Rust environment
|
- name: Setup Rust environment
|
||||||
uses: ./.github/actions/setup
|
uses: ./.github/actions/setup
|
||||||
@@ -176,10 +178,11 @@ jobs:
|
|||||||
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
|
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
|
||||||
NO_PROXY: 127.0.0.1,localhost
|
NO_PROXY: 127.0.0.1,localhost
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout main branch
|
||||||
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
||||||
with:
|
with:
|
||||||
persist-credentials: false
|
persist-credentials: false
|
||||||
|
ref: main
|
||||||
|
|
||||||
- name: Setup Rust environment
|
- name: Setup Rust environment
|
||||||
uses: ./.github/actions/setup
|
uses: ./.github/actions/setup
|
||||||
|
|||||||
@@ -123,7 +123,7 @@ via `create_s3_client(idx)` / `create_all_clients()`. See
|
|||||||
| `find_available_port` | Random free port (isolation primitive) |
|
| `find_available_port` | Random free port (isolation primitive) |
|
||||||
| `rustfs_binary_path` / `_with_features` | Locate/build the binary; honors `RUSTFS_BUILD_FEATURES` |
|
| `rustfs_binary_path` / `_with_features` | Locate/build the binary; honors `RUSTFS_BUILD_FEATURES` |
|
||||||
| `requested_rustfs_build_features` / `rustfs_build_feature_enabled` | Feature-gate a test to what the binary was built with |
|
| `requested_rustfs_build_features` / `rustfs_build_feature_enabled` | Feature-gate a test to what the binary was built with |
|
||||||
| `execute_awscurl` / `awscurl_post` / `_get` / `_put` / `_delete` / `awscurl_post_sts_form_urlencoded` | Admin/STS API calls via `awscurl`; missing binaries are test failures |
|
| `awscurl_available` + `execute_awscurl` / `awscurl_post` / `_get` / `_put` / `_delete` / `awscurl_post_sts_form_urlencoded` | Admin/STS API calls via `awscurl` (skip gracefully when absent) |
|
||||||
| `replication_fast_env` | Env vars that shrink replication timers (from repl-4); pass to `start_rustfs_server_with_env` |
|
| `replication_fast_env` | Env vars that shrink replication timers (from repl-4); pass to `start_rustfs_server_with_env` |
|
||||||
| `local_http_client` / `init_logging` | Loopback HTTP client; idempotent tracing init |
|
| `local_http_client` / `init_logging` | Loopback HTTP client; idempotent tracing init |
|
||||||
| `RustFSTestClusterEnvironment` (`new`/`start`/`start_node`/`stop_node`/`create_all_clients`) | Multi-node harness |
|
| `RustFSTestClusterEnvironment` (`new`/`start`/`start_node`/`stop_node`/`create_all_clients`) | Multi-node harness |
|
||||||
@@ -189,7 +189,7 @@ cargo nextest run --profile e2e-smoke -p e2e_test
|
|||||||
cargo nextest run --profile e2e-full -p e2e_test
|
cargo nextest run --profile e2e-full -p e2e_test
|
||||||
# Cluster fault nightly lane
|
# Cluster fault nightly lane
|
||||||
cargo nextest run --profile e2e-nightly -p e2e_test
|
cargo nextest run --profile e2e-nightly -p e2e_test
|
||||||
# Replication nightly lane; awscurl is required for STS paths
|
# Replication nightly lane; install awscurl so STS paths do not skip
|
||||||
cargo nextest run --profile e2e-repl-nightly -p e2e_test
|
cargo nextest run --profile e2e-repl-nightly -p e2e_test
|
||||||
# Fixed-port protocol nightly lane
|
# Fixed-port protocol nightly lane
|
||||||
RUSTFS_BUILD_FEATURES=ftps,webdav,sftp \
|
RUSTFS_BUILD_FEATURES=ftps,webdav,sftp \
|
||||||
@@ -221,8 +221,9 @@ The `s3s-e2e` CI job selects a random `RUSTFS_TEST_PORT` (see the `e2e-tests`
|
|||||||
job) to dodge this; local single-node tests already use random ports, so a
|
job) to dodge this; local single-node tests already use random ports, so a
|
||||||
lingering orphan is usually the cause of a spurious bind failure.
|
lingering orphan is usually the cause of a spurious bind failure.
|
||||||
|
|
||||||
**`awscurl` not found.** `awscurl`-dependent tests fail closed with a process
|
**`awscurl` not found.** `awscurl`-dependent tests skip gracefully with a
|
||||||
spawn error. Install the pinned CI version before running their profiles.
|
visible log line (`awscurl_available()`); install `awscurl` to actually run
|
||||||
|
them.
|
||||||
|
|
||||||
## Related
|
## Related
|
||||||
|
|
||||||
@@ -257,9 +258,10 @@ A test module may join the smoke filter only if every test in it is:
|
|||||||
2. **Single-node** — spawns its own server via
|
2. **Single-node** — spawns its own server via
|
||||||
`RustFSTestEnvironment`/`start_rustfs_server` on a random port with an
|
`RustFSTestEnvironment`/`start_rustfs_server` on a random port with an
|
||||||
isolated temp dir. No `RustFSTestClusterEnvironment`, no fixed ports.
|
isolated temp dir. No `RustFSTestClusterEnvironment`, no fixed ports.
|
||||||
3. **Hermetic dependencies** — no pre-started server at `localhost:9000`, no
|
3. **Dependency-free** — no pre-started server at `localhost:9000`, no Vault,
|
||||||
Vault, and no fixed protocol ports. Any required CLI must be pinned and
|
no fixed protocol ports. Tools that may be absent on the runner (e.g.
|
||||||
installed by the workflow; a missing CLI must fail the test.
|
`awscurl`) are acceptable only when the test skips gracefully with a
|
||||||
|
visible log line (see `bucket_policy_check_test.rs`).
|
||||||
4. **Not `#[ignore]`** — ignored tests are activation work (backlog#1149
|
4. **Not `#[ignore]`** — ignored tests are activation work (backlog#1149
|
||||||
ci-13 / backlog#1148 ilm-3), not smoke candidates.
|
ci-13 / backlog#1148 ilm-3), not smoke candidates.
|
||||||
|
|
||||||
|
|||||||
@@ -52,6 +52,10 @@ fn create_user_client(env: &RustFSTestEnvironment, access_key: &str, secret_key:
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_bucket_policy_authenticated_user() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_bucket_policy_authenticated_user() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if !crate::common::awscurl_available() {
|
||||||
|
info!("Skipping test_bucket_policy_authenticated_user because awscurl is not available");
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
info!("Starting test_bucket_policy_authenticated_user...");
|
info!("Starting test_bucket_policy_authenticated_user...");
|
||||||
|
|
||||||
let mut env = RustFSTestEnvironment::new().await?;
|
let mut env = RustFSTestEnvironment::new().await?;
|
||||||
|
|||||||
@@ -15,12 +15,14 @@
|
|||||||
use crate::common::RustFSTestClusterEnvironment;
|
use crate::common::RustFSTestClusterEnvironment;
|
||||||
use aws_sdk_s3::Client;
|
use aws_sdk_s3::Client;
|
||||||
use aws_sdk_s3::error::SdkError;
|
use aws_sdk_s3::error::SdkError;
|
||||||
|
use aws_sdk_s3::types::{CorsConfiguration, CorsRule};
|
||||||
use bytes::Bytes;
|
use bytes::Bytes;
|
||||||
use std::sync::Arc;
|
use std::sync::Arc;
|
||||||
use tokio::sync::Barrier;
|
use tokio::sync::Barrier;
|
||||||
use tracing::{info, warn};
|
use tracing::{info, warn};
|
||||||
|
|
||||||
const BUCKET: &str = "conditional-put-race-bucket";
|
const BUCKET: &str = "conditional-put-race-bucket";
|
||||||
|
const BUCKET_METADATA_RELOAD_BUCKET: &str = "bucket-metadata-reload-barrier";
|
||||||
|
|
||||||
async fn cleanup_object(client: &Client, key: &str) {
|
async fn cleanup_object(client: &Client, key: &str) {
|
||||||
if let Err(e) = client.delete_object().bucket(BUCKET).key(key).send().await {
|
if let Err(e) = client.delete_object().bucket(BUCKET).key(key).send().await {
|
||||||
@@ -28,6 +30,16 @@ async fn cleanup_object(client: &Client, key: &str) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async fn assert_bucket_cors_missing(client: &Client) {
|
||||||
|
let result = client.get_bucket_cors().bucket(BUCKET_METADATA_RELOAD_BUCKET).send().await;
|
||||||
|
match result {
|
||||||
|
Err(SdkError::ServiceError(error)) => {
|
||||||
|
assert_eq!(error.err().meta().code(), Some("NoSuchCORSConfiguration"));
|
||||||
|
}
|
||||||
|
result => panic!("expected the peer to report a missing CORS configuration: {result:?}"),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
async fn conditional_put(
|
async fn conditional_put(
|
||||||
client: &Client,
|
client: &Client,
|
||||||
key: &str,
|
key: &str,
|
||||||
@@ -236,3 +248,48 @@ async fn test_conditional_put_basic_cluster() -> Result<(), Box<dyn std::error::
|
|||||||
cleanup_object(&client, test_key).await;
|
cleanup_object(&client, test_key).await;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn test_bucket_cors_write_is_visible_on_peer_before_response() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
|
crate::common::init_logging();
|
||||||
|
|
||||||
|
let mut cluster = RustFSTestClusterEnvironment::new(2).await?;
|
||||||
|
cluster.start().await?;
|
||||||
|
cluster.create_test_bucket(BUCKET_METADATA_RELOAD_BUCKET).await?;
|
||||||
|
|
||||||
|
let writer = cluster.create_s3_client(0)?;
|
||||||
|
let reader = cluster.create_s3_client(1)?;
|
||||||
|
assert_bucket_cors_missing(&reader).await;
|
||||||
|
|
||||||
|
let rule = CorsRule::builder()
|
||||||
|
.allowed_methods("GET")
|
||||||
|
.allowed_origins("https://example.com")
|
||||||
|
.build()?;
|
||||||
|
let configuration = CorsConfiguration::builder().cors_rules(rule).build()?;
|
||||||
|
|
||||||
|
writer
|
||||||
|
.put_bucket_cors()
|
||||||
|
.bucket(BUCKET_METADATA_RELOAD_BUCKET)
|
||||||
|
.cors_configuration(configuration)
|
||||||
|
.send()
|
||||||
|
.await?;
|
||||||
|
|
||||||
|
let response = reader.get_bucket_cors().bucket(BUCKET_METADATA_RELOAD_BUCKET).send().await?;
|
||||||
|
let rules = response.cors_rules();
|
||||||
|
assert_eq!(
|
||||||
|
rules.len(),
|
||||||
|
1,
|
||||||
|
"peer should observe the committed CORS rule before the write response returns"
|
||||||
|
);
|
||||||
|
assert_eq!(rules[0].allowed_methods(), ["GET"]);
|
||||||
|
assert_eq!(rules[0].allowed_origins(), ["https://example.com"]);
|
||||||
|
|
||||||
|
writer
|
||||||
|
.delete_bucket_cors()
|
||||||
|
.bucket(BUCKET_METADATA_RELOAD_BUCKET)
|
||||||
|
.send()
|
||||||
|
.await?;
|
||||||
|
assert_bucket_cors_missing(&reader).await;
|
||||||
|
writer.delete_bucket().bucket(BUCKET_METADATA_RELOAD_BUCKET).send().await?;
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|||||||
@@ -494,6 +494,17 @@ fn awscurl_binary_path() -> PathBuf {
|
|||||||
.unwrap_or_else(|| PathBuf::from("awscurl"))
|
.unwrap_or_else(|| PathBuf::from("awscurl"))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
pub fn awscurl_available() -> bool {
|
||||||
|
let path = awscurl_binary_path();
|
||||||
|
if path.components().count() > 1 || path.is_absolute() {
|
||||||
|
return path.is_file();
|
||||||
|
}
|
||||||
|
|
||||||
|
std::env::var_os("PATH")
|
||||||
|
.map(|paths| std::env::split_paths(&paths).any(|dir| dir.join(&path).is_file()))
|
||||||
|
.unwrap_or(false)
|
||||||
|
}
|
||||||
|
|
||||||
// Global initialization
|
// Global initialization
|
||||||
static INIT: Once = Once::new();
|
static INIT: Once = Once::new();
|
||||||
|
|
||||||
|
|||||||
@@ -16,7 +16,9 @@
|
|||||||
//! session policy** (`Policy` parameter) via `awscurl --service sts` with explicit
|
//! session policy** (`Policy` parameter) via `awscurl --service sts` with explicit
|
||||||
//! `Content-Type: application/x-www-form-urlencoded` on `POST /`.
|
//! `Content-Type: application/x-www-form-urlencoded` on `POST /`.
|
||||||
|
|
||||||
use crate::common::{RustFSTestEnvironment, awscurl_delete, awscurl_post_sts_form_urlencoded, awscurl_put, init_logging};
|
use crate::common::{
|
||||||
|
RustFSTestEnvironment, awscurl_available, awscurl_delete, awscurl_post_sts_form_urlencoded, awscurl_put, init_logging,
|
||||||
|
};
|
||||||
use aws_sdk_s3::config::{Credentials, Region};
|
use aws_sdk_s3::config::{Credentials, Region};
|
||||||
use aws_sdk_s3::primitives::ByteStream;
|
use aws_sdk_s3::primitives::ByteStream;
|
||||||
use aws_sdk_s3::types::{Delete, ObjectIdentifier, Tag, Tagging};
|
use aws_sdk_s3::types::{Delete, ObjectIdentifier, Tag, Tagging};
|
||||||
@@ -173,6 +175,11 @@ async fn cleanup_bucket_and_object(admin: &Client, bucket: &str, key: &str) {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_e2e_iam_policy_existing_object_tag_get_object() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_e2e_iam_policy_existing_object_tag_get_object() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if !awscurl_available() {
|
||||||
|
info!("Skipping test_e2e_iam_policy_existing_object_tag_get_object: awscurl not available");
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
|
||||||
let suffix = Uuid::new_v4();
|
let suffix = Uuid::new_v4();
|
||||||
let user = format!("e2eiamtag-{suffix}");
|
let user = format!("e2eiamtag-{suffix}");
|
||||||
let user_secret = "longSecretKeyForTest123!";
|
let user_secret = "longSecretKeyForTest123!";
|
||||||
@@ -226,6 +233,11 @@ async fn test_e2e_iam_policy_existing_object_tag_get_object() -> Result<(), Box<
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_e2e_bucket_policy_existing_object_tag_get_object() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_e2e_bucket_policy_existing_object_tag_get_object() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if !awscurl_available() {
|
||||||
|
info!("Skipping test_e2e_bucket_policy_existing_object_tag_get_object: awscurl not available");
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
|
||||||
let suffix = Uuid::new_v4();
|
let suffix = Uuid::new_v4();
|
||||||
let user = format!("e2ebptag-{suffix}");
|
let user = format!("e2ebptag-{suffix}");
|
||||||
let user_secret = "longSecretKeyForTest456!";
|
let user_secret = "longSecretKeyForTest456!";
|
||||||
@@ -282,6 +294,11 @@ async fn test_e2e_bucket_policy_existing_object_tag_get_object() -> Result<(), B
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_e2e_sts_assume_role_session_policy_existing_object_tag() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_e2e_sts_assume_role_session_policy_existing_object_tag() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if !awscurl_available() {
|
||||||
|
info!("Skipping test_e2e_sts_assume_role_session_policy_existing_object_tag: awscurl not available");
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
|
||||||
let suffix = Uuid::new_v4();
|
let suffix = Uuid::new_v4();
|
||||||
let parent = format!("e2e-sts-par-{suffix}");
|
let parent = format!("e2e-sts-par-{suffix}");
|
||||||
let parent_secret = "longSecretKeyForParentSts99!";
|
let parent_secret = "longSecretKeyForParentSts99!";
|
||||||
@@ -353,6 +370,11 @@ async fn test_e2e_sts_assume_role_session_policy_existing_object_tag() -> Result
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_e2e_sts_session_policy_delete_objects_object_prefix_only() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_e2e_sts_session_policy_delete_objects_object_prefix_only() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if !awscurl_available() {
|
||||||
|
info!("Skipping test_e2e_sts_session_policy_delete_objects_object_prefix_only: awscurl not available");
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
|
||||||
let suffix = Uuid::new_v4();
|
let suffix = Uuid::new_v4();
|
||||||
let parent = format!("e2e-sts-del-par-{suffix}");
|
let parent = format!("e2e-sts-del-par-{suffix}");
|
||||||
let parent_secret = "longSecretKeyForParentDelete99!";
|
let parent_secret = "longSecretKeyForParentDelete99!";
|
||||||
|
|||||||
@@ -22,7 +22,9 @@
|
|||||||
//! - KMS backend configuration (Local and Vault)
|
//! - KMS backend configuration (Local and Vault)
|
||||||
//! - SSE encryption testing utilities
|
//! - SSE encryption testing utilities
|
||||||
|
|
||||||
use crate::common::{RustFSTestEnvironment, awscurl_get, awscurl_post, init_logging as common_init_logging, local_http_client};
|
use crate::common::{
|
||||||
|
RustFSTestEnvironment, awscurl_available, awscurl_get, awscurl_post, init_logging as common_init_logging, local_http_client,
|
||||||
|
};
|
||||||
use aws_sdk_s3::Client;
|
use aws_sdk_s3::Client;
|
||||||
use aws_sdk_s3::primitives::ByteStream;
|
use aws_sdk_s3::primitives::ByteStream;
|
||||||
use aws_sdk_s3::types::ServerSideEncryption;
|
use aws_sdk_s3::types::ServerSideEncryption;
|
||||||
@@ -57,6 +59,15 @@ pub fn init_logging() {
|
|||||||
// Additional KMS-specific logging configuration can be added here if needed
|
// Additional KMS-specific logging configuration can be added here if needed
|
||||||
}
|
}
|
||||||
|
|
||||||
|
pub fn skip_if_kms_admin_tool_unavailable(test_name: &str) -> bool {
|
||||||
|
if awscurl_available() {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
info!("Skipping {} because awscurl is not available in PATH", test_name);
|
||||||
|
true
|
||||||
|
}
|
||||||
|
|
||||||
pub fn sse_customer_key_md5_base64(key: &str) -> String {
|
pub fn sse_customer_key_md5_base64(key: &str) -> String {
|
||||||
let mut hasher = Md5::new();
|
let mut hasher = Md5::new();
|
||||||
hasher.update(key.as_bytes());
|
hasher.update(key.as_bytes());
|
||||||
@@ -479,6 +490,10 @@ pub async fn test_kms_key_management(
|
|||||||
access_key: &str,
|
access_key: &str,
|
||||||
secret_key: &str,
|
secret_key: &str,
|
||||||
) -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
) -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
|
if skip_if_kms_admin_tool_unavailable("test_kms_key_management") {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
|
||||||
info!("Testing KMS key management APIs");
|
info!("Testing KMS key management APIs");
|
||||||
|
|
||||||
// Test CreateKey
|
// Test CreateKey
|
||||||
|
|||||||
@@ -20,7 +20,8 @@
|
|||||||
//! - Complete encryption/decryption lifecycle
|
//! - Complete encryption/decryption lifecycle
|
||||||
|
|
||||||
use super::common::{
|
use super::common::{
|
||||||
LocalKMSTestEnvironment, get_kms_status, sse_customer_key_md5_base64, test_kms_key_management, test_sse_c_encryption,
|
LocalKMSTestEnvironment, get_kms_status, skip_if_kms_admin_tool_unavailable, sse_customer_key_md5_base64,
|
||||||
|
test_kms_key_management, test_sse_c_encryption,
|
||||||
};
|
};
|
||||||
use crate::common::{TEST_BUCKET, init_logging};
|
use crate::common::{TEST_BUCKET, init_logging};
|
||||||
use tracing::{error, info};
|
use tracing::{error, info};
|
||||||
@@ -28,6 +29,9 @@ use tracing::{error, info};
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_local_kms_end_to_end() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_local_kms_end_to_end() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_if_kms_admin_tool_unavailable("test_local_kms_end_to_end") {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
info!("Starting Local KMS End-to-End Test");
|
info!("Starting Local KMS End-to-End Test");
|
||||||
|
|
||||||
// Create LocalKMS test environment
|
// Create LocalKMS test environment
|
||||||
|
|||||||
@@ -22,8 +22,8 @@ use crate::common::{TEST_BUCKET, init_logging};
|
|||||||
use tracing::{error, info};
|
use tracing::{error, info};
|
||||||
|
|
||||||
use super::common::{
|
use super::common::{
|
||||||
VAULT_KEY_NAME, VaultTestEnvironment, get_kms_status, sse_customer_key_md5_base64, start_kms,
|
VAULT_KEY_NAME, VaultTestEnvironment, get_kms_status, skip_if_kms_admin_tool_unavailable, sse_customer_key_md5_base64,
|
||||||
test_all_multipart_encryption_types, test_error_scenarios, test_kms_key_management, test_sse_c_encryption,
|
start_kms, test_all_multipart_encryption_types, test_error_scenarios, test_kms_key_management, test_sse_c_encryption,
|
||||||
test_sse_kms_encryption, test_sse_s3_encryption,
|
test_sse_kms_encryption, test_sse_s3_encryption,
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -62,6 +62,9 @@ impl VaultKmsTestContext {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_vault_kms_end_to_end() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_vault_kms_end_to_end() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_if_kms_admin_tool_unavailable("test_vault_kms_end_to_end") {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
info!("Starting Vault KMS End-to-End Test with default key {}", VAULT_KEY_NAME);
|
info!("Starting Vault KMS End-to-End Test with default key {}", VAULT_KEY_NAME);
|
||||||
|
|
||||||
let context = VaultKmsTestContext::new().await?;
|
let context = VaultKmsTestContext::new().await?;
|
||||||
@@ -114,6 +117,9 @@ async fn test_vault_kms_end_to_end() -> Result<(), Box<dyn std::error::Error + S
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_vault_kms_key_isolation() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_vault_kms_key_isolation() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_if_kms_admin_tool_unavailable("test_vault_kms_key_isolation") {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
info!("Starting Vault KMS SSE-C key isolation test");
|
info!("Starting Vault KMS SSE-C key isolation test");
|
||||||
|
|
||||||
let context = VaultKmsTestContext::new().await?;
|
let context = VaultKmsTestContext::new().await?;
|
||||||
@@ -197,6 +203,9 @@ async fn test_vault_kms_key_isolation() -> Result<(), Box<dyn std::error::Error
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_vault_kms_large_file() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_vault_kms_large_file() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_if_kms_admin_tool_unavailable("test_vault_kms_large_file") {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
info!("Starting Vault KMS large file SSE-S3 test");
|
info!("Starting Vault KMS large file SSE-S3 test");
|
||||||
|
|
||||||
let context = VaultKmsTestContext::new().await?;
|
let context = VaultKmsTestContext::new().await?;
|
||||||
@@ -258,6 +267,9 @@ async fn test_vault_kms_large_file() -> Result<(), Box<dyn std::error::Error + S
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_vault_kms_multipart_upload() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_vault_kms_multipart_upload() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_if_kms_admin_tool_unavailable("test_vault_kms_multipart_upload") {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
info!("Starting Vault KMS multipart upload encryption suite");
|
info!("Starting Vault KMS multipart upload encryption suite");
|
||||||
|
|
||||||
let context = VaultKmsTestContext::new().await?;
|
let context = VaultKmsTestContext::new().await?;
|
||||||
@@ -285,6 +297,9 @@ async fn test_vault_kms_multipart_upload() -> Result<(), Box<dyn std::error::Err
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_vault_kms_key_operations() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_vault_kms_key_operations() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_if_kms_admin_tool_unavailable("test_vault_kms_key_operations") {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
info!("Starting Vault KMS key operations test (CRUD)");
|
info!("Starting Vault KMS key operations test (CRUD)");
|
||||||
|
|
||||||
let context = VaultKmsTestContext::new().await?;
|
let context = VaultKmsTestContext::new().await?;
|
||||||
|
|||||||
@@ -41,6 +41,13 @@ async fn create_issue_3107_fixture(root: &Path) -> TestResult {
|
|||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn mc_available() -> bool {
|
||||||
|
Command::new("mc")
|
||||||
|
.arg("--version")
|
||||||
|
.output()
|
||||||
|
.is_ok_and(|output| output.status.success())
|
||||||
|
}
|
||||||
|
|
||||||
fn run_mc(args: &[&str]) -> TestResult {
|
fn run_mc(args: &[&str]) -> TestResult {
|
||||||
let output = Command::new("mc").args(args).output()?;
|
let output = Command::new("mc").args(args).output()?;
|
||||||
if !output.status.success() {
|
if !output.status.success() {
|
||||||
@@ -68,7 +75,10 @@ fn count_files(root: &Path) -> usize {
|
|||||||
async fn test_mc_mirror_small_bucket_completes_without_list_timeout() -> TestResult {
|
async fn test_mc_mirror_small_bucket_completes_without_list_timeout() -> TestResult {
|
||||||
crate::common::init_logging();
|
crate::common::init_logging();
|
||||||
info!("Starting issue #3107 mc mirror regression test");
|
info!("Starting issue #3107 mc mirror regression test");
|
||||||
run_mc(&["--version"])?;
|
if !mc_available() {
|
||||||
|
info!("Skipping issue #3107 mc mirror regression test because mc is not installed");
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
|
||||||
let mut env = RustFSTestEnvironment::new().await?;
|
let mut env = RustFSTestEnvironment::new().await?;
|
||||||
env.start_rustfs_server(vec![]).await?;
|
env.start_rustfs_server(vec![]).await?;
|
||||||
|
|||||||
@@ -4278,6 +4278,10 @@ async fn test_signed_put_object_extract_preserves_pax_metadata_and_version_id()
|
|||||||
async fn test_signed_put_object_extract_authorizes_each_pax_privilege_and_retention_conditions()
|
async fn test_signed_put_object_extract_authorizes_each_pax_privilege_and_retention_conditions()
|
||||||
-> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
-> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if !crate::common::awscurl_available() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
|
||||||
let mut env = RustFSTestEnvironment::new().await?;
|
let mut env = RustFSTestEnvironment::new().await?;
|
||||||
env.start_rustfs_server(vec![]).await?;
|
env.start_rustfs_server(vec![]).await?;
|
||||||
|
|
||||||
|
|||||||
@@ -18,6 +18,15 @@ use http::{Method, StatusCode};
|
|||||||
use tokio::time::{Duration, sleep, timeout};
|
use tokio::time::{Duration, sleep, timeout};
|
||||||
use tracing::{debug, info};
|
use tracing::{debug, info};
|
||||||
|
|
||||||
|
fn skip_without_awscurl() -> bool {
|
||||||
|
if crate::common::awscurl_available() {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
info!("Skipping quota test because awscurl is not available");
|
||||||
|
true
|
||||||
|
}
|
||||||
|
|
||||||
/// Test environment setup for quota tests
|
/// Test environment setup for quota tests
|
||||||
pub struct QuotaTestEnv {
|
pub struct QuotaTestEnv {
|
||||||
pub env: RustFSTestEnvironment,
|
pub env: RustFSTestEnvironment,
|
||||||
@@ -267,6 +276,9 @@ mod integration_tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_quota_basic_operations() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_quota_basic_operations() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_without_awscurl() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
let env = QuotaTestEnv::new().await?;
|
let env = QuotaTestEnv::new().await?;
|
||||||
|
|
||||||
// Create test bucket
|
// Create test bucket
|
||||||
@@ -308,6 +320,9 @@ mod integration_tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_quota_admission_aws_chunked_declared_encoding() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_quota_admission_aws_chunked_declared_encoding() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_without_awscurl() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
let env = QuotaTestEnv::new().await?;
|
let env = QuotaTestEnv::new().await?;
|
||||||
env.create_bucket().await?;
|
env.create_bucket().await?;
|
||||||
|
|
||||||
@@ -356,6 +371,9 @@ mod integration_tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_quota_update_and_clear() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_quota_update_and_clear() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_without_awscurl() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
let env = QuotaTestEnv::new().await?;
|
let env = QuotaTestEnv::new().await?;
|
||||||
|
|
||||||
env.create_bucket().await?;
|
env.create_bucket().await?;
|
||||||
@@ -388,6 +406,9 @@ mod integration_tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_quota_delete_operations() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_quota_delete_operations() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_without_awscurl() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
let env = QuotaTestEnv::new().await?;
|
let env = QuotaTestEnv::new().await?;
|
||||||
|
|
||||||
env.create_bucket().await?;
|
env.create_bucket().await?;
|
||||||
@@ -421,6 +442,9 @@ mod integration_tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_quota_usage_tracking() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_quota_usage_tracking() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_without_awscurl() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
let env = QuotaTestEnv::new().await?;
|
let env = QuotaTestEnv::new().await?;
|
||||||
|
|
||||||
env.create_bucket().await?;
|
env.create_bucket().await?;
|
||||||
@@ -456,6 +480,9 @@ mod integration_tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_quota_statistics() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_quota_statistics() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_without_awscurl() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
let env = QuotaTestEnv::new().await?;
|
let env = QuotaTestEnv::new().await?;
|
||||||
|
|
||||||
env.create_bucket().await?;
|
env.create_bucket().await?;
|
||||||
@@ -486,6 +513,9 @@ mod integration_tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_quota_check_api() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_quota_check_api() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_without_awscurl() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
let env = QuotaTestEnv::new().await?;
|
let env = QuotaTestEnv::new().await?;
|
||||||
|
|
||||||
env.create_bucket().await?;
|
env.create_bucket().await?;
|
||||||
@@ -523,6 +553,9 @@ mod integration_tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_quota_multiple_buckets() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_quota_multiple_buckets() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_without_awscurl() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
let env = QuotaTestEnv::new().await?;
|
let env = QuotaTestEnv::new().await?;
|
||||||
|
|
||||||
// Create two buckets in the same environment
|
// Create two buckets in the same environment
|
||||||
@@ -560,6 +593,9 @@ mod integration_tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_quota_error_handling() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_quota_error_handling() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_without_awscurl() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
let env = QuotaTestEnv::new().await?;
|
let env = QuotaTestEnv::new().await?;
|
||||||
|
|
||||||
env.create_bucket().await?;
|
env.create_bucket().await?;
|
||||||
@@ -592,6 +628,9 @@ mod integration_tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_quota_http_endpoints() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_quota_http_endpoints() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_without_awscurl() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
let env = QuotaTestEnv::new().await?;
|
let env = QuotaTestEnv::new().await?;
|
||||||
|
|
||||||
env.create_bucket().await?;
|
env.create_bucket().await?;
|
||||||
@@ -650,6 +689,9 @@ mod integration_tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_quota_normal_user_permissions() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_quota_normal_user_permissions() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_without_awscurl() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
let env = QuotaTestEnv::new().await?;
|
let env = QuotaTestEnv::new().await?;
|
||||||
env.create_bucket().await?;
|
env.create_bucket().await?;
|
||||||
|
|
||||||
@@ -702,6 +744,9 @@ mod integration_tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_quota_copy_operations() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_quota_copy_operations() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_without_awscurl() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
let env = QuotaTestEnv::new().await?;
|
let env = QuotaTestEnv::new().await?;
|
||||||
|
|
||||||
env.create_bucket().await?;
|
env.create_bucket().await?;
|
||||||
@@ -744,6 +789,9 @@ mod integration_tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_quota_batch_delete() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_quota_batch_delete() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_without_awscurl() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
let env = QuotaTestEnv::new().await?;
|
let env = QuotaTestEnv::new().await?;
|
||||||
|
|
||||||
env.create_bucket().await?;
|
env.create_bucket().await?;
|
||||||
@@ -799,6 +847,9 @@ mod integration_tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_quota_multipart_upload() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
async fn test_quota_multipart_upload() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if skip_without_awscurl() {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
let env = QuotaTestEnv::new().await?;
|
let env = QuotaTestEnv::new().await?;
|
||||||
|
|
||||||
env.create_bucket().await?;
|
env.create_bucket().await?;
|
||||||
|
|||||||
@@ -13,8 +13,9 @@
|
|||||||
// limitations under the License.
|
// limitations under the License.
|
||||||
|
|
||||||
use crate::common::{
|
use crate::common::{
|
||||||
RustFSTestEnvironment, admin_create_user, awscurl_post_sts_form_urlencoded, init_logging, local_http_client,
|
RustFSTestEnvironment, admin_create_user, awscurl_available, awscurl_post_sts_form_urlencoded, init_logging,
|
||||||
replication_fast_env, rustfs_binary_path, signed_request, signed_request_with_client, signed_request_with_session_token,
|
local_http_client, replication_fast_env, rustfs_binary_path, signed_request, signed_request_with_client,
|
||||||
|
signed_request_with_session_token,
|
||||||
};
|
};
|
||||||
use crate::fake_s3_target::{
|
use crate::fake_s3_target::{
|
||||||
FAKE_ACCESS_KEY, FAKE_SECRET_KEY, FakeS3Target, FaultAction as FakeTargetFault, Operation as FakeTargetOperation,
|
FAKE_ACCESS_KEY, FAKE_SECRET_KEY, FakeS3Target, FaultAction as FakeTargetFault, Operation as FakeTargetOperation,
|
||||||
@@ -7280,6 +7281,11 @@ async fn test_site_replication_replicates_multiple_service_accounts_real_dual_no
|
|||||||
async fn test_site_replication_replicates_service_accounts_created_from_sts_session_real_dual_node() -> TestResult {
|
async fn test_site_replication_replicates_service_accounts_created_from_sts_session_real_dual_node() -> TestResult {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
|
||||||
|
if !awscurl_available() {
|
||||||
|
eprintln!("Skipping STS site replication service-account test because awscurl is unavailable");
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
|
||||||
let mut source_env = RustFSTestEnvironment::new().await?;
|
let mut source_env = RustFSTestEnvironment::new().await?;
|
||||||
source_env
|
source_env
|
||||||
.start_rustfs_server_with_env(vec![], LOOPBACK_REPLICATION_TARGET_ENV)
|
.start_rustfs_server_with_env(vec![], LOOPBACK_REPLICATION_TARGET_ENV)
|
||||||
|
|||||||
@@ -21,7 +21,7 @@
|
|||||||
//! - SSRF prevention (internal/private endpoints rejected for tiering)
|
//! - SSRF prevention (internal/private endpoints rejected for tiering)
|
||||||
//! - Race condition handling (concurrent writes converge without corruption)
|
//! - Race condition handling (concurrent writes converge without corruption)
|
||||||
|
|
||||||
use crate::common::{RustFSTestEnvironment, awscurl_put, init_logging};
|
use crate::common::{RustFSTestEnvironment, awscurl_available, awscurl_put, init_logging};
|
||||||
use aws_sdk_s3::error::ProvideErrorMetadata;
|
use aws_sdk_s3::error::ProvideErrorMetadata;
|
||||||
use aws_sdk_s3::primitives::ByteStream;
|
use aws_sdk_s3::primitives::ByteStream;
|
||||||
use aws_sdk_s3::types::{CompletedMultipartUpload, CompletedPart, Tag, Tagging};
|
use aws_sdk_s3::types::{CompletedMultipartUpload, CompletedPart, Tag, Tagging};
|
||||||
@@ -225,11 +225,16 @@ async fn test_concurrent_object_operations() -> Result<(), Box<dyn Error + Send
|
|||||||
/// outcome — the internal endpoint is not accepted — is asserted here.
|
/// outcome — the internal endpoint is not accepted — is asserted here.
|
||||||
///
|
///
|
||||||
/// The admin API is exercised via signed `awscurl` requests, matching the
|
/// The admin API is exercised via signed `awscurl` requests, matching the
|
||||||
/// pattern used by the other admin-API E2E tests in this crate. The full E2E
|
/// pattern used by the other admin-API E2E tests in this crate; the test is
|
||||||
/// lane installs and verifies the pinned `awscurl` prerequisite.
|
/// skipped when `awscurl` is not installed.
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_tiering_url_validation() -> Result<(), Box<dyn Error + Send + Sync>> {
|
async fn test_tiering_url_validation() -> Result<(), Box<dyn Error + Send + Sync>> {
|
||||||
init_logging();
|
init_logging();
|
||||||
|
if !awscurl_available() {
|
||||||
|
info!("Skipping tiering URL validation test because awscurl is not available");
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
|
||||||
let mut env = RustFSTestEnvironment::new().await?;
|
let mut env = RustFSTestEnvironment::new().await?;
|
||||||
env.start_rustfs_server(vec![]).await?;
|
env.start_rustfs_server(vec![]).await?;
|
||||||
|
|
||||||
|
|||||||
@@ -85,6 +85,7 @@ const PEER_REST_RECOVERY_MAX_ATTEMPTS: u32 = 60;
|
|||||||
const PEER_REST_RECOVERY_MAX_BACKOFF: Duration = Duration::from_secs(30);
|
const PEER_REST_RECOVERY_MAX_BACKOFF: Duration = Duration::from_secs(30);
|
||||||
const SCANNER_ACTIVITY_MAX_MESSAGE_SIZE: usize = 1024;
|
const SCANNER_ACTIVITY_MAX_MESSAGE_SIZE: usize = 1024;
|
||||||
const REPLICATION_STATS_MAX_MESSAGE_SIZE: usize = 8 * 1024 * 1024;
|
const REPLICATION_STATS_MAX_MESSAGE_SIZE: usize = 8 * 1024 * 1024;
|
||||||
|
const BUCKET_METADATA_RELOAD_TIMEOUT: Duration = Duration::from_secs(5);
|
||||||
|
|
||||||
/// Error for a peer that reported `success = false` without an `error_info` payload.
|
/// Error for a peer that reported `success = false` without an `error_info` payload.
|
||||||
///
|
///
|
||||||
@@ -1328,27 +1329,38 @@ impl PeerRestClient {
|
|||||||
}
|
}
|
||||||
|
|
||||||
pub async fn load_bucket_metadata(&self, bucket: &str, scanner_maintenance_change: bool) -> Result<()> {
|
pub async fn load_bucket_metadata(&self, bucket: &str, scanner_maintenance_change: bool) -> Result<()> {
|
||||||
self.finalize_result(
|
let result = tokio::time::timeout(BUCKET_METADATA_RELOAD_TIMEOUT, async {
|
||||||
async {
|
let result = self.load_bucket_metadata_once(bucket, scanner_maintenance_change).await;
|
||||||
let mut client = self.get_client().await?;
|
if let Err(err) = &result
|
||||||
let mut request = Request::new(LoadBucketMetadataRequest {
|
&& Self::is_network_like_error(err)
|
||||||
bucket: bucket.to_string(),
|
{
|
||||||
scanner_maintenance_change,
|
self.prepare_retry().await;
|
||||||
});
|
return self.load_bucket_metadata_once(bucket, scanner_maintenance_change).await;
|
||||||
set_tonic_mutation_body_digest(&mut request)?;
|
|
||||||
|
|
||||||
let response = client.load_bucket_metadata(request).await?.into_inner();
|
|
||||||
if !response.success {
|
|
||||||
if let Some(msg) = response.error_info {
|
|
||||||
return Err(Error::other(msg));
|
|
||||||
}
|
|
||||||
return Err(peer_failure_without_details("load_bucket_metadata", Some(bucket)));
|
|
||||||
}
|
|
||||||
Ok(())
|
|
||||||
}
|
}
|
||||||
.await,
|
result
|
||||||
)
|
})
|
||||||
.await
|
.await
|
||||||
|
.unwrap_or_else(|_| Err(Error::other(format!("load_bucket_metadata({bucket}) timed out"))));
|
||||||
|
self.finalize_result(result).await
|
||||||
|
}
|
||||||
|
|
||||||
|
async fn load_bucket_metadata_once(&self, bucket: &str, scanner_maintenance_change: bool) -> Result<()> {
|
||||||
|
let mut client = self.get_client().await?;
|
||||||
|
let mut request = Request::new(LoadBucketMetadataRequest {
|
||||||
|
bucket: bucket.to_string(),
|
||||||
|
scanner_maintenance_change,
|
||||||
|
});
|
||||||
|
set_tonic_mutation_body_digest(&mut request)?;
|
||||||
|
request.set_timeout(BUCKET_METADATA_RELOAD_TIMEOUT);
|
||||||
|
|
||||||
|
let response = client.load_bucket_metadata(request).await?.into_inner();
|
||||||
|
if !response.success {
|
||||||
|
if let Some(msg) = response.error_info {
|
||||||
|
return Err(Error::other(msg));
|
||||||
|
}
|
||||||
|
return Err(peer_failure_without_details("load_bucket_metadata", Some(bucket)));
|
||||||
|
}
|
||||||
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
pub async fn delete_bucket_metadata(&self, bucket: &str) -> Result<()> {
|
pub async fn delete_bucket_metadata(&self, bucket: &str) -> Result<()> {
|
||||||
|
|||||||
@@ -16,14 +16,14 @@
|
|||||||
//!
|
//!
|
||||||
//! `scripts/test/vault_ha_kms_live.sh` owns the official Vault containers and
|
//! `scripts/test/vault_ha_kms_live.sh` owns the official Vault containers and
|
||||||
//! kills the active node while this test continuously decrypts through a
|
//! kills the active node while this test continuously decrypts through a
|
||||||
//! surviving standby. KV2 and Transit must recover after the bounded circuit
|
//! surviving standby. KV2 and Transit requests must remain successful, use a
|
||||||
//! interval, use a bounded number of attempts, and leave the circuit and
|
//! bounded number of attempts, and leave the circuit and in-flight gauges at
|
||||||
//! in-flight gauges at zero after a new leader is elected.
|
//! zero after a new leader is elected.
|
||||||
|
|
||||||
use std::collections::HashMap;
|
use std::collections::HashMap;
|
||||||
use std::path::{Path, PathBuf};
|
use std::path::{Path, PathBuf};
|
||||||
|
use std::sync::Arc;
|
||||||
use std::sync::atomic::{AtomicBool, AtomicU64, Ordering};
|
use std::sync::atomic::{AtomicBool, AtomicU64, Ordering};
|
||||||
use std::sync::{Arc, Mutex};
|
|
||||||
use std::time::Duration;
|
use std::time::Duration;
|
||||||
|
|
||||||
use metrics_util::MetricKind;
|
use metrics_util::MetricKind;
|
||||||
@@ -43,11 +43,6 @@ const OPERATION_ATTEMPTS: &str = "rustfs_kms_backend_operation_attempts";
|
|||||||
const IN_FLIGHT: &str = "rustfs_kms_backend_in_flight";
|
const IN_FLIGHT: &str = "rustfs_kms_backend_in_flight";
|
||||||
const CIRCUIT_OPEN: &str = "rustfs_kms_backend_circuit_open";
|
const CIRCUIT_OPEN: &str = "rustfs_kms_backend_circuit_open";
|
||||||
const MAX_ATTEMPTS: u32 = 10;
|
const MAX_ATTEMPTS: u32 = 10;
|
||||||
const ATTEMPT_TIMEOUT: Duration = Duration::from_secs(2);
|
|
||||||
const HEALTHY_PROGRESS_TIMEOUT: Duration = Duration::from_secs(20);
|
|
||||||
// The circuit remains open for 30s after five failed attempts.
|
|
||||||
const POST_FAILOVER_PROGRESS_TIMEOUT: Duration = Duration::from_secs(35);
|
|
||||||
const FAILOVER_ERROR_POLL_INTERVAL: Duration = Duration::from_millis(100);
|
|
||||||
|
|
||||||
type MetricEntry = (
|
type MetricEntry = (
|
||||||
metrics_util::CompositeKey,
|
metrics_util::CompositeKey,
|
||||||
@@ -69,7 +64,7 @@ fn config(backend: KmsBackend, backend_config: BackendConfig) -> KmsConfig {
|
|||||||
backend,
|
backend,
|
||||||
backend_config,
|
backend_config,
|
||||||
allow_insecure_dev_defaults: true,
|
allow_insecure_dev_defaults: true,
|
||||||
timeout: ATTEMPT_TIMEOUT,
|
timeout: Duration::from_secs(2),
|
||||||
retry_attempts: MAX_ATTEMPTS,
|
retry_attempts: MAX_ATTEMPTS,
|
||||||
enable_cache: false,
|
enable_cache: false,
|
||||||
..KmsConfig::default()
|
..KmsConfig::default()
|
||||||
@@ -169,31 +164,14 @@ fn retryable_failures(snapshot: &[MetricEntry], operation: &str) -> u64 {
|
|||||||
.sum()
|
.sum()
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn wait_for_count(
|
async fn wait_for_count(counter: &AtomicU64, minimum: u64, description: &str) {
|
||||||
counter: &AtomicU64,
|
tokio::time::timeout(Duration::from_secs(20), async {
|
||||||
failure: &Mutex<Option<String>>,
|
|
||||||
minimum: u64,
|
|
||||||
description: &str,
|
|
||||||
timeout: Duration,
|
|
||||||
) {
|
|
||||||
tokio::time::timeout(timeout, async {
|
|
||||||
while counter.load(Ordering::SeqCst) < minimum {
|
while counter.load(Ordering::SeqCst) < minimum {
|
||||||
if let Some(error) = failure.lock().expect("decrypt failure lock poisoned").as_ref() {
|
|
||||||
panic!(
|
|
||||||
"{description} worker failed after {} successful decrypts: {error}",
|
|
||||||
counter.load(Ordering::SeqCst)
|
|
||||||
);
|
|
||||||
}
|
|
||||||
tokio::time::sleep(Duration::from_millis(25)).await;
|
tokio::time::sleep(Duration::from_millis(25)).await;
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
.await
|
.await
|
||||||
.unwrap_or_else(|_| {
|
.unwrap_or_else(|_| panic!("timed out waiting for {description}"));
|
||||||
panic!(
|
|
||||||
"timed out after {timeout:?} waiting for {description}: completed {}, expected {minimum}",
|
|
||||||
counter.load(Ordering::SeqCst)
|
|
||||||
)
|
|
||||||
});
|
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn wait_for_file(path: &Path, description: &str) {
|
async fn wait_for_file(path: &Path, description: &str) {
|
||||||
@@ -211,8 +189,7 @@ async fn decrypt_loop<B: KmsBackendTrait + Send + Sync + 'static>(
|
|||||||
request: DecryptRequest,
|
request: DecryptRequest,
|
||||||
expected: Vec<u8>,
|
expected: Vec<u8>,
|
||||||
completed: Arc<AtomicU64>,
|
completed: Arc<AtomicU64>,
|
||||||
allow_failover_errors: Arc<AtomicBool>,
|
failed: Arc<AtomicBool>,
|
||||||
failure: Arc<Mutex<Option<String>>>,
|
|
||||||
stop: CancellationToken,
|
stop: CancellationToken,
|
||||||
) {
|
) {
|
||||||
while !stop.is_cancelled() {
|
while !stop.is_cancelled() {
|
||||||
@@ -220,18 +197,8 @@ async fn decrypt_loop<B: KmsBackendTrait + Send + Sync + 'static>(
|
|||||||
Ok(response) if response.plaintext == expected => {
|
Ok(response) if response.plaintext == expected => {
|
||||||
completed.fetch_add(1, Ordering::SeqCst);
|
completed.fetch_add(1, Ordering::SeqCst);
|
||||||
}
|
}
|
||||||
Ok(_) => {
|
Ok(_) | Err(_) => {
|
||||||
*failure.lock().expect("decrypt failure lock poisoned") =
|
failed.store(true, Ordering::SeqCst);
|
||||||
Some("decrypt returned unexpected plaintext".to_string());
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
Err(rustfs_kms::KmsError::BackendError { .. } | rustfs_kms::KmsError::OperationTimedOut { .. })
|
|
||||||
if allow_failover_errors.load(Ordering::SeqCst) =>
|
|
||||||
{
|
|
||||||
tokio::time::sleep(FAILOVER_ERROR_POLL_INTERVAL).await;
|
|
||||||
}
|
|
||||||
Err(error) => {
|
|
||||||
*failure.lock().expect("decrypt failure lock poisoned") = Some(error.to_string());
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -329,9 +296,7 @@ async fn exercise_failover(snapshotter: &Snapshotter) {
|
|||||||
);
|
);
|
||||||
|
|
||||||
let stop = CancellationToken::new();
|
let stop = CancellationToken::new();
|
||||||
let allow_failover_errors = Arc::new(AtomicBool::new(false));
|
let failed = Arc::new(AtomicBool::new(false));
|
||||||
let kv2_failure = Arc::new(Mutex::new(None));
|
|
||||||
let transit_failure = Arc::new(Mutex::new(None));
|
|
||||||
let kv2_completed = Arc::new(AtomicU64::new(0));
|
let kv2_completed = Arc::new(AtomicU64::new(0));
|
||||||
let transit_completed = Arc::new(AtomicU64::new(0));
|
let transit_completed = Arc::new(AtomicU64::new(0));
|
||||||
let kv2_worker = tokio::spawn(decrypt_loop(
|
let kv2_worker = tokio::spawn(decrypt_loop(
|
||||||
@@ -339,8 +304,7 @@ async fn exercise_failover(snapshotter: &Snapshotter) {
|
|||||||
kv2_request,
|
kv2_request,
|
||||||
kv2_data_key.plaintext_key,
|
kv2_data_key.plaintext_key,
|
||||||
Arc::clone(&kv2_completed),
|
Arc::clone(&kv2_completed),
|
||||||
Arc::clone(&allow_failover_errors),
|
Arc::clone(&failed),
|
||||||
Arc::clone(&kv2_failure),
|
|
||||||
stop.clone(),
|
stop.clone(),
|
||||||
));
|
));
|
||||||
let transit_worker = tokio::spawn(decrypt_loop(
|
let transit_worker = tokio::spawn(decrypt_loop(
|
||||||
@@ -348,21 +312,12 @@ async fn exercise_failover(snapshotter: &Snapshotter) {
|
|||||||
transit_request,
|
transit_request,
|
||||||
transit_data_key.plaintext_key,
|
transit_data_key.plaintext_key,
|
||||||
Arc::clone(&transit_completed),
|
Arc::clone(&transit_completed),
|
||||||
Arc::clone(&allow_failover_errors),
|
Arc::clone(&failed),
|
||||||
Arc::clone(&transit_failure),
|
|
||||||
stop.clone(),
|
stop.clone(),
|
||||||
));
|
));
|
||||||
|
|
||||||
wait_for_count(&kv2_completed, &kv2_failure, 2, "two healthy KV2 decrypts", HEALTHY_PROGRESS_TIMEOUT).await;
|
wait_for_count(&kv2_completed, 2, "two healthy KV2 decrypts").await;
|
||||||
wait_for_count(
|
wait_for_count(&transit_completed, 2, "two healthy Transit decrypts").await;
|
||||||
&transit_completed,
|
|
||||||
&transit_failure,
|
|
||||||
2,
|
|
||||||
"two healthy Transit decrypts",
|
|
||||||
HEALTHY_PROGRESS_TIMEOUT,
|
|
||||||
)
|
|
||||||
.await;
|
|
||||||
allow_failover_errors.store(true, Ordering::SeqCst);
|
|
||||||
std::fs::write(&marker, b"ready").expect("publish failover readiness marker");
|
std::fs::write(&marker, b"ready").expect("publish failover readiness marker");
|
||||||
|
|
||||||
wait_for_file(&elected, "the replacement Vault leader").await;
|
wait_for_file(&elected, "the replacement Vault leader").await;
|
||||||
@@ -371,39 +326,18 @@ async fn exercise_failover(snapshotter: &Snapshotter) {
|
|||||||
|
|
||||||
let kv2_after_election = kv2_completed.load(Ordering::SeqCst) + 2;
|
let kv2_after_election = kv2_completed.load(Ordering::SeqCst) + 2;
|
||||||
let transit_after_election = transit_completed.load(Ordering::SeqCst) + 2;
|
let transit_after_election = transit_completed.load(Ordering::SeqCst) + 2;
|
||||||
wait_for_count(
|
wait_for_count(&kv2_completed, kv2_after_election, "post-failover KV2 decrypts").await;
|
||||||
&kv2_completed,
|
wait_for_count(&transit_completed, transit_after_election, "post-failover Transit decrypts").await;
|
||||||
&kv2_failure,
|
|
||||||
kv2_after_election,
|
|
||||||
"post-failover KV2 decrypts",
|
|
||||||
POST_FAILOVER_PROGRESS_TIMEOUT,
|
|
||||||
)
|
|
||||||
.await;
|
|
||||||
wait_for_count(
|
|
||||||
&transit_completed,
|
|
||||||
&transit_failure,
|
|
||||||
transit_after_election,
|
|
||||||
"post-failover Transit decrypts",
|
|
||||||
POST_FAILOVER_PROGRESS_TIMEOUT,
|
|
||||||
)
|
|
||||||
.await;
|
|
||||||
|
|
||||||
stop.cancel();
|
stop.cancel();
|
||||||
kv2_worker.await.expect("KV2 decrypt worker must join");
|
kv2_worker.await.expect("KV2 decrypt worker must join");
|
||||||
transit_worker.await.expect("Transit decrypt worker must join");
|
transit_worker.await.expect("Transit decrypt worker must join");
|
||||||
assert!(
|
assert!(!failed.load(Ordering::SeqCst), "no decrypt may fail or return different plaintext");
|
||||||
kv2_failure.lock().expect("KV2 failure lock poisoned").is_none(),
|
|
||||||
"no KV2 decrypt may fail or return different plaintext"
|
|
||||||
);
|
|
||||||
assert!(
|
|
||||||
transit_failure.lock().expect("Transit failure lock poisoned").is_none(),
|
|
||||||
"no Transit decrypt may fail or return different plaintext"
|
|
||||||
);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
#[ignore = "requires a real three-node Vault Raft cluster; run scripts/test/vault_ha_kms_live.sh"]
|
#[ignore = "requires a real three-node Vault Raft cluster; run scripts/test/vault_ha_kms_live.sh"]
|
||||||
fn vault_raft_leader_failure_recovers_kv2_and_transit_decrypts() {
|
fn vault_raft_leader_failure_preserves_kv2_and_transit_decrypts() {
|
||||||
let recorder = DebuggingRecorder::new();
|
let recorder = DebuggingRecorder::new();
|
||||||
let snapshotter = recorder.snapshotter();
|
let snapshotter = recorder.snapshotter();
|
||||||
metrics::with_local_recorder(&recorder, || {
|
metrics::with_local_recorder(&recorder, || {
|
||||||
@@ -415,6 +349,11 @@ fn vault_raft_leader_failure_recovers_kv2_and_transit_decrypts() {
|
|||||||
});
|
});
|
||||||
let snapshot = snapshotter.snapshot().into_vec();
|
let snapshot = snapshotter.snapshot().into_vec();
|
||||||
|
|
||||||
|
assert_eq!(
|
||||||
|
counter_value(&snapshot, OPERATIONS_TOTAL, &[("outcome", "circuit_open")]),
|
||||||
|
0,
|
||||||
|
"a bounded leader election must not open the circuit"
|
||||||
|
);
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
counter_value(&snapshot, OPERATIONS_TOTAL, &[("outcome", "budget_exhausted")]),
|
counter_value(&snapshot, OPERATIONS_TOTAL, &[("outcome", "budget_exhausted")]),
|
||||||
0,
|
0,
|
||||||
|
|||||||
@@ -513,13 +513,15 @@ fn sr_bucket_meta_item(bucket: String, item_type: &str) -> SRBucketMeta {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn notify_bucket_metadata_reload(
|
async fn notify_bucket_metadata_reload(
|
||||||
bucket: String,
|
bucket: String,
|
||||||
operation: &'static str,
|
operation: &'static str,
|
||||||
request_context: Option<request_context::RequestContext>,
|
request_context: Option<request_context::RequestContext>,
|
||||||
scanner_maintenance_change: bool,
|
scanner_maintenance_change: bool,
|
||||||
) {
|
) {
|
||||||
record_local_scanner_maintenance_reload(&bucket, scanner_maintenance_change);
|
record_local_scanner_maintenance_reload(&bucket, scanner_maintenance_change);
|
||||||
|
// Keep reload detached across request cancellation, but wait before a healthy peer can serve the previous config.
|
||||||
|
let (completed_tx, completed_rx) = tokio::sync::oneshot::channel();
|
||||||
spawn_background_with_context(request_context, async move {
|
spawn_background_with_context(request_context, async move {
|
||||||
if let Some(notification_sys) = current_notification_system() {
|
if let Some(notification_sys) = current_notification_system() {
|
||||||
let result = if scanner_maintenance_change {
|
let result = if scanner_maintenance_change {
|
||||||
@@ -531,7 +533,9 @@ fn notify_bucket_metadata_reload(
|
|||||||
warn!(bucket = %bucket, error = %err, "failed to notify peers after {operation}");
|
warn!(bucket = %bucket, error = %err, "failed to notify peers after {operation}");
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
let _ = completed_tx.send(());
|
||||||
});
|
});
|
||||||
|
let _ = completed_rx.await;
|
||||||
}
|
}
|
||||||
|
|
||||||
fn record_local_scanner_maintenance_reload(bucket: &str, scanner_maintenance_change: bool) {
|
fn record_local_scanner_maintenance_reload(bucket: &str, scanner_maintenance_change: bool) {
|
||||||
@@ -1476,7 +1480,7 @@ impl DefaultBucketUsecase {
|
|||||||
.await
|
.await
|
||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "delete bucket encryption", request_context, false);
|
notify_bucket_metadata_reload(bucket.clone(), "delete bucket encryption", request_context, false).await;
|
||||||
|
|
||||||
let item = sr_bucket_meta_item(bucket.clone(), "sse-config");
|
let item = sr_bucket_meta_item(bucket.clone(), "sse-config");
|
||||||
if let Err(err) = site_replication_bucket_meta_hook(item).await {
|
if let Err(err) = site_replication_bucket_meta_hook(item).await {
|
||||||
@@ -1508,7 +1512,7 @@ impl DefaultBucketUsecase {
|
|||||||
.await
|
.await
|
||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "delete bucket cors", request_context, false);
|
notify_bucket_metadata_reload(bucket.clone(), "delete bucket cors", request_context, false).await;
|
||||||
|
|
||||||
let item = sr_bucket_meta_item(bucket.clone(), "cors-config");
|
let item = sr_bucket_meta_item(bucket.clone(), "cors-config");
|
||||||
if let Err(err) = site_replication_bucket_meta_hook(item).await {
|
if let Err(err) = site_replication_bucket_meta_hook(item).await {
|
||||||
@@ -1540,7 +1544,7 @@ impl DefaultBucketUsecase {
|
|||||||
.await
|
.await
|
||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "delete bucket lifecycle", request_context, true);
|
notify_bucket_metadata_reload(bucket.clone(), "delete bucket lifecycle", request_context, true).await;
|
||||||
|
|
||||||
let item = sr_bucket_meta_item(bucket.clone(), "lc-config");
|
let item = sr_bucket_meta_item(bucket.clone(), "lc-config");
|
||||||
if let Err(err) = site_replication_bucket_meta_hook(item).await {
|
if let Err(err) = site_replication_bucket_meta_hook(item).await {
|
||||||
@@ -1572,7 +1576,7 @@ impl DefaultBucketUsecase {
|
|||||||
.await
|
.await
|
||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "delete bucket policy", request_context, false);
|
notify_bucket_metadata_reload(bucket.clone(), "delete bucket policy", request_context, false).await;
|
||||||
|
|
||||||
let item = sr_bucket_meta_item(bucket.clone(), "policy");
|
let item = sr_bucket_meta_item(bucket.clone(), "policy");
|
||||||
if let Err(err) = site_replication_bucket_meta_hook(item).await {
|
if let Err(err) = site_replication_bucket_meta_hook(item).await {
|
||||||
@@ -1630,7 +1634,7 @@ impl DefaultBucketUsecase {
|
|||||||
}
|
}
|
||||||
drop(targets_guard);
|
drop(targets_guard);
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "delete bucket replication", request_context, true);
|
notify_bucket_metadata_reload(bucket.clone(), "delete bucket replication", request_context, true).await;
|
||||||
|
|
||||||
let item = sr_bucket_meta_item(bucket.clone(), "replication-config");
|
let item = sr_bucket_meta_item(bucket.clone(), "replication-config");
|
||||||
if let Err(err) = site_replication_bucket_meta_hook(item).await {
|
if let Err(err) = site_replication_bucket_meta_hook(item).await {
|
||||||
@@ -1655,7 +1659,7 @@ impl DefaultBucketUsecase {
|
|||||||
.await
|
.await
|
||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "delete bucket tagging", request_context, false);
|
notify_bucket_metadata_reload(bucket.clone(), "delete bucket tagging", request_context, false).await;
|
||||||
|
|
||||||
let item = sr_bucket_meta_item(bucket.clone(), "tags");
|
let item = sr_bucket_meta_item(bucket.clone(), "tags");
|
||||||
if let Err(err) = site_replication_bucket_meta_hook(item).await {
|
if let Err(err) = site_replication_bucket_meta_hook(item).await {
|
||||||
@@ -1688,7 +1692,7 @@ impl DefaultBucketUsecase {
|
|||||||
.await
|
.await
|
||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "delete public access block", request_context, false);
|
notify_bucket_metadata_reload(bucket.clone(), "delete public access block", request_context, false).await;
|
||||||
|
|
||||||
Ok(S3Response::with_status(DeletePublicAccessBlockOutput::default(), StatusCode::NO_CONTENT))
|
Ok(S3Response::with_status(DeletePublicAccessBlockOutput::default(), StatusCode::NO_CONTENT))
|
||||||
}
|
}
|
||||||
@@ -2143,7 +2147,7 @@ impl DefaultBucketUsecase {
|
|||||||
.await
|
.await
|
||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "put bucket encryption", request_context, false);
|
notify_bucket_metadata_reload(bucket.clone(), "put bucket encryption", request_context, false).await;
|
||||||
|
|
||||||
let mut item = sr_bucket_meta_item(bucket.clone(), "sse-config");
|
let mut item = sr_bucket_meta_item(bucket.clone(), "sse-config");
|
||||||
item.sse_config = Some(
|
item.sse_config = Some(
|
||||||
@@ -2222,7 +2226,7 @@ impl DefaultBucketUsecase {
|
|||||||
.await
|
.await
|
||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "put bucket lifecycle", request_context, true);
|
notify_bucket_metadata_reload(bucket.clone(), "put bucket lifecycle", request_context, true).await;
|
||||||
|
|
||||||
let mut item = sr_bucket_meta_item(bucket.clone(), "lc-config");
|
let mut item = sr_bucket_meta_item(bucket.clone(), "lc-config");
|
||||||
item.expiry_lc_config =
|
item.expiry_lc_config =
|
||||||
@@ -2307,7 +2311,7 @@ impl DefaultBucketUsecase {
|
|||||||
.await
|
.await
|
||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "put bucket notification", request_context, false);
|
notify_bucket_metadata_reload(bucket.clone(), "put bucket notification", request_context, false).await;
|
||||||
|
|
||||||
let region = resolve_notification_region(self.global_region(), request_region);
|
let region = resolve_notification_region(self.global_region(), request_region);
|
||||||
let notify = current_notify_interface_for_context(self.context.as_deref());
|
let notify = current_notify_interface_for_context(self.context.as_deref());
|
||||||
@@ -2412,7 +2416,7 @@ impl DefaultBucketUsecase {
|
|||||||
.await
|
.await
|
||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "put bucket policy", request_context, false);
|
notify_bucket_metadata_reload(bucket.clone(), "put bucket policy", request_context, false).await;
|
||||||
|
|
||||||
let mut item = sr_bucket_meta_item(bucket.clone(), "policy");
|
let mut item = sr_bucket_meta_item(bucket.clone(), "policy");
|
||||||
item.policy = Some(serde_json::from_str(&policy).map_err(|e| s3_error!(InvalidArgument, "parse policy failed {:?}", e))?);
|
item.policy = Some(serde_json::from_str(&policy).map_err(|e| s3_error!(InvalidArgument, "parse policy failed {:?}", e))?);
|
||||||
@@ -2447,7 +2451,7 @@ impl DefaultBucketUsecase {
|
|||||||
.await
|
.await
|
||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "put bucket cors", request_context, false);
|
notify_bucket_metadata_reload(bucket.clone(), "put bucket cors", request_context, false).await;
|
||||||
|
|
||||||
let mut item = sr_bucket_meta_item(bucket.clone(), "cors-config");
|
let mut item = sr_bucket_meta_item(bucket.clone(), "cors-config");
|
||||||
item.cors =
|
item.cors =
|
||||||
@@ -2491,7 +2495,7 @@ impl DefaultBucketUsecase {
|
|||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
drop(targets_guard);
|
drop(targets_guard);
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "put bucket replication", request_context, true);
|
notify_bucket_metadata_reload(bucket.clone(), "put bucket replication", request_context, true).await;
|
||||||
|
|
||||||
let mut item = sr_bucket_meta_item(bucket.clone(), "replication-config");
|
let mut item = sr_bucket_meta_item(bucket.clone(), "replication-config");
|
||||||
item.replication_config = Some(
|
item.replication_config = Some(
|
||||||
@@ -2531,7 +2535,7 @@ impl DefaultBucketUsecase {
|
|||||||
.await
|
.await
|
||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "put public access block", request_context, false);
|
notify_bucket_metadata_reload(bucket.clone(), "put public access block", request_context, false).await;
|
||||||
|
|
||||||
Ok(S3Response::new(PutPublicAccessBlockOutput::default()))
|
Ok(S3Response::new(PutPublicAccessBlockOutput::default()))
|
||||||
}
|
}
|
||||||
@@ -2560,7 +2564,7 @@ impl DefaultBucketUsecase {
|
|||||||
.await
|
.await
|
||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "put bucket tagging", request_context, false);
|
notify_bucket_metadata_reload(bucket.clone(), "put bucket tagging", request_context, false).await;
|
||||||
|
|
||||||
let mut item = sr_bucket_meta_item(bucket.clone(), "tags");
|
let mut item = sr_bucket_meta_item(bucket.clone(), "tags");
|
||||||
item.tags = Some(serialize_config(&tagging).and_then(|bytes| String::from_utf8(bytes).map_err(to_internal_error))?);
|
item.tags = Some(serialize_config(&tagging).and_then(|bytes| String::from_utf8(bytes).map_err(to_internal_error))?);
|
||||||
@@ -2593,7 +2597,7 @@ impl DefaultBucketUsecase {
|
|||||||
.await
|
.await
|
||||||
.map_err(ApiError::from)?;
|
.map_err(ApiError::from)?;
|
||||||
|
|
||||||
notify_bucket_metadata_reload(bucket.clone(), "put bucket versioning", request_context, false);
|
notify_bucket_metadata_reload(bucket.clone(), "put bucket versioning", request_context, false).await;
|
||||||
|
|
||||||
let mut item = sr_bucket_meta_item(bucket.clone(), "version-config");
|
let mut item = sr_bucket_meta_item(bucket.clone(), "version-config");
|
||||||
item.versioning = Some(
|
item.versioning = Some(
|
||||||
@@ -3044,7 +3048,7 @@ mod tests {
|
|||||||
"{method} should identify the bucket metadata operation in reload logs"
|
"{method} should identify the bucket metadata operation in reload logs"
|
||||||
);
|
);
|
||||||
let expected_reload = format!(
|
let expected_reload = format!(
|
||||||
"notify_bucket_metadata_reload(bucket.clone(), \"{operation}\", request_context, {scanner_maintenance_change});"
|
"notify_bucket_metadata_reload(bucket.clone(), \"{operation}\", request_context, {scanner_maintenance_change}).await;"
|
||||||
);
|
);
|
||||||
assert!(
|
assert!(
|
||||||
body.contains(&expected_reload),
|
body.contains(&expected_reload),
|
||||||
|
|||||||
@@ -241,7 +241,7 @@ env \
|
|||||||
RUSTFS_TEST_VAULT_FAILOVER_MARKER="$MARKER" \
|
RUSTFS_TEST_VAULT_FAILOVER_MARKER="$MARKER" \
|
||||||
RUSTFS_TEST_VAULT_OLD_LEADER="$OLD_LEADER" \
|
RUSTFS_TEST_VAULT_OLD_LEADER="$OLD_LEADER" \
|
||||||
cargo test -p rustfs-kms --test vault_ha_failover_live \
|
cargo test -p rustfs-kms --test vault_ha_failover_live \
|
||||||
vault_raft_leader_failure_recovers_kv2_and_transit_decrypts -- \
|
vault_raft_leader_failure_preserves_kv2_and_transit_decrypts -- \
|
||||||
--ignored --nocapture --test-threads=1 &
|
--ignored --nocapture --test-threads=1 &
|
||||||
TEST_PID=$!
|
TEST_PID=$!
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user