mirror of
https://github.com/rustfs/rustfs.git
synced 2026-08-22 12:26:37 +00:00
Compare commits
5 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 637d4f5e45 | |||
| a39ce768cf | |||
| d3515f5109 | |||
| 8c0eaf225d | |||
| 1a3be70d98 |
@@ -14,9 +14,10 @@
|
|||||||
|
|
||||||
name: "Schedule Failure Issue"
|
name: "Schedule Failure Issue"
|
||||||
description: >-
|
description: >-
|
||||||
Open (or update) a tracking issue when a scheduled workflow run fails.
|
Open (or update) a tracking issue when a scheduled workflow run fails or
|
||||||
|
does not complete normally.
|
||||||
Dedupes by workflow name: if an open issue titled
|
Dedupes by workflow name: if an open issue titled
|
||||||
"[scheduled-failure] <workflow name>" already exists, the failure is
|
"[scheduled-failure] <workflow name>" already exists, the result is
|
||||||
appended as a comment; otherwise a new issue is created. This is the
|
appended as a comment; otherwise a new issue is created. This is the
|
||||||
single alerting mechanism for all scheduled pipelines (backlog#1149 ci-8).
|
single alerting mechanism for all scheduled pipelines (backlog#1149 ci-8).
|
||||||
|
|
||||||
@@ -38,6 +39,26 @@ inputs:
|
|||||||
Set to an empty string to skip labeling.
|
Set to an empty string to skip labeling.
|
||||||
required: false
|
required: false
|
||||||
default: "infrastructure"
|
default: "infrastructure"
|
||||||
|
source-run-id:
|
||||||
|
description: "Run ID to report. Defaults to the current workflow run."
|
||||||
|
required: false
|
||||||
|
default: ${{ github.run_id }}
|
||||||
|
source-run-attempt:
|
||||||
|
description: "Run attempt to report. Defaults to the current attempt."
|
||||||
|
required: false
|
||||||
|
default: ${{ github.run_attempt }}
|
||||||
|
source-event:
|
||||||
|
description: "Trigger event of the run being reported."
|
||||||
|
required: false
|
||||||
|
default: ${{ github.event_name }}
|
||||||
|
source-ref-name:
|
||||||
|
description: "Ref name of the run being reported."
|
||||||
|
required: false
|
||||||
|
default: ${{ github.ref_name }}
|
||||||
|
source-sha:
|
||||||
|
description: "Commit SHA of the run being reported."
|
||||||
|
required: false
|
||||||
|
default: ${{ github.sha }}
|
||||||
|
|
||||||
runs:
|
runs:
|
||||||
using: "composite"
|
using: "composite"
|
||||||
@@ -48,17 +69,21 @@ runs:
|
|||||||
GH_TOKEN: ${{ inputs.github-token }}
|
GH_TOKEN: ${{ inputs.github-token }}
|
||||||
WORKFLOW_NAME: ${{ inputs.workflow-name }}
|
WORKFLOW_NAME: ${{ inputs.workflow-name }}
|
||||||
ISSUE_LABEL: ${{ inputs.label }}
|
ISSUE_LABEL: ${{ inputs.label }}
|
||||||
|
SOURCE_RUN_ID: ${{ inputs.source-run-id }}
|
||||||
|
SOURCE_RUN_ATTEMPT: ${{ inputs.source-run-attempt }}
|
||||||
|
SOURCE_EVENT: ${{ inputs.source-event }}
|
||||||
|
SOURCE_REF_NAME: ${{ inputs.source-ref-name }}
|
||||||
|
SOURCE_SHA: ${{ inputs.source-sha }}
|
||||||
run: |
|
run: |
|
||||||
set -euo pipefail
|
set -euo pipefail
|
||||||
|
|
||||||
title="[scheduled-failure] ${WORKFLOW_NAME}"
|
title="[scheduled-failure] ${WORKFLOW_NAME}"
|
||||||
run_url="${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}"
|
run_url="${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${SOURCE_RUN_ID}"
|
||||||
|
|
||||||
# Failed job names for this run attempt. The alert job runs while the
|
# Inspect the reported run attempt. It can be the current in-workflow
|
||||||
# run as a whole is still in progress, so inspect the jobs that have
|
# failure or a completed run observed by the external watchdog.
|
||||||
# already completed with a non-success conclusion.
|
|
||||||
failed_jobs="$(gh api \
|
failed_jobs="$(gh api \
|
||||||
"repos/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}/attempts/${GITHUB_RUN_ATTEMPT}/jobs" \
|
"repos/${GITHUB_REPOSITORY}/actions/runs/${SOURCE_RUN_ID}/attempts/${SOURCE_RUN_ATTEMPT}/jobs" \
|
||||||
--paginate \
|
--paginate \
|
||||||
--jq '.jobs[]
|
--jq '.jobs[]
|
||||||
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled")
|
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled")
|
||||||
@@ -68,13 +93,13 @@ runs:
|
|||||||
fi
|
fi
|
||||||
|
|
||||||
body="$(cat <<EOF
|
body="$(cat <<EOF
|
||||||
Scheduled run of **${WORKFLOW_NAME}** failed.
|
Scheduled run of **${WORKFLOW_NAME}** did not complete successfully.
|
||||||
|
|
||||||
- Run: ${run_url} (attempt ${GITHUB_RUN_ATTEMPT})
|
- Run: ${run_url} (attempt ${SOURCE_RUN_ATTEMPT})
|
||||||
- Event: \`${GITHUB_EVENT_NAME}\`
|
- Event: \`${SOURCE_EVENT}\`
|
||||||
- Ref: \`${GITHUB_REF_NAME}\` @ \`${GITHUB_SHA}\`
|
- Ref: \`${SOURCE_REF_NAME}\` @ \`${SOURCE_SHA}\`
|
||||||
|
|
||||||
Failed jobs:
|
Non-success jobs:
|
||||||
${failed_jobs}
|
${failed_jobs}
|
||||||
EOF
|
EOF
|
||||||
)"
|
)"
|
||||||
|
|||||||
@@ -1032,3 +1032,23 @@ jobs:
|
|||||||
|
|
||||||
echo "🎉 Released $TAG successfully!"
|
echo "🎉 Released $TAG successfully!"
|
||||||
echo "📄 Release URL: ${{ needs.create-release.outputs.release_url }}"
|
echo "📄 Release URL: ${{ needs.create-release.outputs.release_url }}"
|
||||||
|
|
||||||
|
alert-on-failure:
|
||||||
|
name: Alert on scheduled failure
|
||||||
|
needs: [build-check, prepare-platform-matrix, build-rustfs, build-summary]
|
||||||
|
if: >-
|
||||||
|
always() && github.event_name == 'schedule' &&
|
||||||
|
(contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled'))
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
timeout-minutes: 10
|
||||||
|
permissions:
|
||||||
|
contents: read
|
||||||
|
issues: write
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
||||||
|
with:
|
||||||
|
persist-credentials: false
|
||||||
|
- name: Open or update failure-tracking issue
|
||||||
|
uses: ./.github/actions/schedule-failure-issue
|
||||||
|
with:
|
||||||
|
github-token: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
|||||||
@@ -1032,3 +1032,37 @@ jobs:
|
|||||||
path: artifacts/s3tests-single/**
|
path: artifacts/s3tests-single/**
|
||||||
if-no-files-found: ignore
|
if-no-files-found: ignore
|
||||||
retention-days: 3
|
retention-days: 3
|
||||||
|
|
||||||
|
alert-on-failure:
|
||||||
|
name: Alert on scheduled failure
|
||||||
|
needs:
|
||||||
|
- typos
|
||||||
|
- quick-checks
|
||||||
|
- test-and-lint
|
||||||
|
- test-ilm-integration-serial
|
||||||
|
- test-and-lint-rio-v2
|
||||||
|
- test-and-lint-protocols
|
||||||
|
- build-rustfs-debug-binary
|
||||||
|
- build-rustfs-debug-binary-rio-v2
|
||||||
|
- uring-integration
|
||||||
|
- e2e-tests
|
||||||
|
- e2e-full
|
||||||
|
- e2e-tests-rio-v2
|
||||||
|
- s3-implemented-tests
|
||||||
|
- s3-lifecycle-behavior-tests
|
||||||
|
if: >-
|
||||||
|
always() && github.event_name == 'schedule' &&
|
||||||
|
(contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled'))
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
timeout-minutes: 10
|
||||||
|
permissions:
|
||||||
|
contents: read
|
||||||
|
issues: write
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
||||||
|
with:
|
||||||
|
persist-credentials: false
|
||||||
|
- name: Open or update failure-tracking issue
|
||||||
|
uses: ./.github/actions/schedule-failure-issue
|
||||||
|
with:
|
||||||
|
github-token: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
|||||||
@@ -121,3 +121,21 @@ jobs:
|
|||||||
cargo nextest run --run-ignored ignored-only --no-tests=fail \
|
cargo nextest run --run-ignored ignored-only --no-tests=fail \
|
||||||
-p "$INTEROP_PACKAGE" --features "$INTEROP_FEATURES" \
|
-p "$INTEROP_PACKAGE" --features "$INTEROP_FEATURES" \
|
||||||
-E "$INTEROP_FILTER"
|
-E "$INTEROP_FILTER"
|
||||||
|
|
||||||
|
alert-on-failure:
|
||||||
|
name: Alert on scheduled failure
|
||||||
|
needs: [minio-interop]
|
||||||
|
if: always() && github.event_name == 'schedule' && contains(needs.*.result, 'failure')
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
timeout-minutes: 10
|
||||||
|
permissions:
|
||||||
|
contents: read
|
||||||
|
issues: write
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
||||||
|
with:
|
||||||
|
persist-credentials: false
|
||||||
|
- name: Open or update failure-tracking issue
|
||||||
|
uses: ./.github/actions/schedule-failure-issue
|
||||||
|
with:
|
||||||
|
github-token: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
|||||||
@@ -194,3 +194,23 @@ jobs:
|
|||||||
|
|
||||||
- name: Run HA leader failover live checks (three-node Raft cluster in Docker)
|
- name: Run HA leader failover live checks (three-node Raft cluster in Docker)
|
||||||
run: bash scripts/test/vault_ha_kms_live.sh
|
run: bash scripts/test/vault_ha_kms_live.sh
|
||||||
|
|
||||||
|
alert-on-failure:
|
||||||
|
name: Alert on scheduled failure
|
||||||
|
needs: [build, kms-vault-lane, kms-vault-ha-failover]
|
||||||
|
if: >-
|
||||||
|
always() && github.event_name == 'schedule' &&
|
||||||
|
(contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled'))
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
timeout-minutes: 10
|
||||||
|
permissions:
|
||||||
|
contents: read
|
||||||
|
issues: write
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
||||||
|
with:
|
||||||
|
persist-credentials: false
|
||||||
|
- name: Open or update failure-tracking issue
|
||||||
|
uses: ./.github/actions/schedule-failure-issue
|
||||||
|
with:
|
||||||
|
github-token: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
|||||||
@@ -0,0 +1,63 @@
|
|||||||
|
# Copyright 2024 RustFS Team
|
||||||
|
#
|
||||||
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
# you may not use this file except in compliance with the License.
|
||||||
|
# You may obtain a copy of the License at
|
||||||
|
#
|
||||||
|
# http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
#
|
||||||
|
# Unless required by applicable law or agreed to in writing, software
|
||||||
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
# See the License for the specific language governing permissions and
|
||||||
|
# limitations under the License.
|
||||||
|
|
||||||
|
name: Scheduled Validation Watchdog
|
||||||
|
|
||||||
|
on:
|
||||||
|
workflow_run:
|
||||||
|
workflows:
|
||||||
|
- "Security Audit"
|
||||||
|
- "Build and Release"
|
||||||
|
- "Continuous Integration"
|
||||||
|
- "coverage"
|
||||||
|
- "e2e-nightly"
|
||||||
|
- "e2e-s3tests"
|
||||||
|
- "Fuzz"
|
||||||
|
- "mint"
|
||||||
|
- "minio-interop"
|
||||||
|
- "Nightly GNU Build"
|
||||||
|
- "Performance A/B"
|
||||||
|
- "Runner Hygiene"
|
||||||
|
types: [completed]
|
||||||
|
|
||||||
|
permissions:
|
||||||
|
contents: read
|
||||||
|
|
||||||
|
jobs:
|
||||||
|
alert-on-incomplete-run:
|
||||||
|
name: Alert on incomplete scheduled run
|
||||||
|
if: >-
|
||||||
|
github.event.workflow_run.event == 'schedule' &&
|
||||||
|
github.event.workflow_run.conclusion != 'success' &&
|
||||||
|
github.event.workflow_run.conclusion != 'failure'
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
timeout-minutes: 10
|
||||||
|
permissions:
|
||||||
|
actions: read
|
||||||
|
contents: read
|
||||||
|
issues: write
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
||||||
|
with:
|
||||||
|
persist-credentials: false
|
||||||
|
- name: Open or update incomplete-run issue
|
||||||
|
uses: ./.github/actions/schedule-failure-issue
|
||||||
|
with:
|
||||||
|
github-token: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
workflow-name: ${{ github.event.workflow_run.name }}
|
||||||
|
source-run-id: ${{ github.event.workflow_run.id }}
|
||||||
|
source-run-attempt: ${{ github.event.workflow_run.run_attempt }}
|
||||||
|
source-event: ${{ github.event.workflow_run.event }}
|
||||||
|
source-ref-name: ${{ github.event.workflow_run.head_branch }}
|
||||||
|
source-sha: ${{ github.event.workflow_run.head_sha }}
|
||||||
@@ -50,10 +50,10 @@ use rustfs_protos::evict_failed_connection;
|
|||||||
use rustfs_protos::proto_gen::node_service::RenamePartRequest;
|
use rustfs_protos::proto_gen::node_service::RenamePartRequest;
|
||||||
use rustfs_protos::proto_gen::node_service::{
|
use rustfs_protos::proto_gen::node_service::{
|
||||||
BatchReadVersionRequest, BatchReadVersionResponse, CheckPartsRequest, DeletePathsRequest, DeleteRequest,
|
BatchReadVersionRequest, BatchReadVersionResponse, CheckPartsRequest, DeletePathsRequest, DeleteRequest,
|
||||||
DeleteVersionRequest, DeleteVersionsRequest, DeleteVolumeRequest, DiskInfoRequest, ListDirRequest, ListVolumesRequest,
|
DeleteVersionRequest, DeleteVersionsRequest, DeleteVersionsResponse, DeleteVolumeRequest, DiskInfoRequest, ListDirRequest,
|
||||||
MakeVolumeRequest, MakeVolumesRequest, PreparePartTransactionRequest, ReadAllRequest, ReadMetadataRequest,
|
ListVolumesRequest, MakeVolumeRequest, MakeVolumesRequest, PreparePartTransactionRequest, ReadAllRequest,
|
||||||
ReadMultipleRequest, ReadMultipleResponse, ReadPartsRequest, ReadVersionRequest, ReadXlRequest, RenameDataRequest,
|
ReadMetadataRequest, ReadMultipleRequest, ReadMultipleResponse, ReadPartsRequest, ReadVersionRequest, ReadXlRequest,
|
||||||
RenameFileRequest, SettlePartTransactionRequest, SnapshotLeaseReleaseRequest, SnapshotLeaseRenewRequest,
|
RenameDataRequest, RenameFileRequest, SettlePartTransactionRequest, SnapshotLeaseReleaseRequest, SnapshotLeaseRenewRequest,
|
||||||
SnapshotLeaseRequest, SnapshotLeaseResponse, StatVolumeRequest, UpdateMetadataRequest, VerifyFileRequest, WriteAllRequest,
|
SnapshotLeaseRequest, SnapshotLeaseResponse, StatVolumeRequest, UpdateMetadataRequest, VerifyFileRequest, WriteAllRequest,
|
||||||
WriteMetadataRequest, node_service_client::NodeServiceClient,
|
WriteMetadataRequest, node_service_client::NodeServiceClient,
|
||||||
};
|
};
|
||||||
@@ -112,6 +112,28 @@ const EVENT_REMOTE_DISK_RPC: &str = "remote_disk_rpc";
|
|||||||
const SNAPSHOT_LEASE_PROTOCOL_VERSION: u32 = 1;
|
const SNAPSHOT_LEASE_PROTOCOL_VERSION: u32 = 1;
|
||||||
pub const REMOTE_SNAPSHOT_LEASE_TTL: Duration = Duration::from_secs(60);
|
pub const REMOTE_SNAPSHOT_LEASE_TTL: Duration = Duration::from_secs(60);
|
||||||
|
|
||||||
|
fn decode_delete_versions_errors(response: DeleteVersionsResponse, expected_len: usize) -> Vec<Option<Error>> {
|
||||||
|
if !response.item_errors.is_empty() {
|
||||||
|
if response.item_errors.len() != expected_len {
|
||||||
|
return vec![Some(Error::other("malformed delete_versions item errors")); expected_len];
|
||||||
|
}
|
||||||
|
return response
|
||||||
|
.item_errors
|
||||||
|
.into_iter()
|
||||||
|
.map(|error| (error.code != 0).then(|| error.into()))
|
||||||
|
.collect();
|
||||||
|
}
|
||||||
|
|
||||||
|
if response.errors.len() != expected_len {
|
||||||
|
return vec![Some(Error::other("malformed delete_versions errors")); expected_len];
|
||||||
|
}
|
||||||
|
response
|
||||||
|
.errors
|
||||||
|
.into_iter()
|
||||||
|
.map(|error| (!error.is_empty()).then(|| Error::other(error)))
|
||||||
|
.collect()
|
||||||
|
}
|
||||||
|
|
||||||
fn snapshot_lease_token_from_response(response: SnapshotLeaseResponse) -> Result<SnapshotLeaseToken> {
|
fn snapshot_lease_token_from_response(response: SnapshotLeaseResponse) -> Result<SnapshotLeaseToken> {
|
||||||
if !response.success {
|
if !response.success {
|
||||||
return Err(response.error.unwrap_or_default().into());
|
return Err(response.error.unwrap_or_default().into());
|
||||||
@@ -2406,8 +2428,6 @@ impl DiskAPI for RemoteDisk {
|
|||||||
return errors;
|
return errors;
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO(backlog): replace string errors with typed `StorageError` variants
|
|
||||||
|
|
||||||
let result = self
|
let result = self
|
||||||
.execute_with_timeout(
|
.execute_with_timeout(
|
||||||
|| async {
|
|| async {
|
||||||
@@ -2439,17 +2459,7 @@ impl DiskAPI for RemoteDisk {
|
|||||||
}
|
}
|
||||||
return errors;
|
return errors;
|
||||||
}
|
}
|
||||||
response
|
decode_delete_versions_errors(response, versions.len())
|
||||||
.errors
|
|
||||||
.iter()
|
|
||||||
.map(|error| {
|
|
||||||
if error.is_empty() {
|
|
||||||
None
|
|
||||||
} else {
|
|
||||||
Some(Error::other(error.to_string()))
|
|
||||||
}
|
|
||||||
})
|
|
||||||
.collect()
|
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tracing::instrument(level = "trace", skip_all)]
|
#[tracing::instrument(level = "trace", skip_all)]
|
||||||
@@ -3760,6 +3770,63 @@ mod tests {
|
|||||||
|
|
||||||
static INIT: Once = Once::new();
|
static INIT: Once = Once::new();
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn delete_versions_response_preserves_typed_item_errors() {
|
||||||
|
let errors = decode_delete_versions_errors(
|
||||||
|
DeleteVersionsResponse {
|
||||||
|
success: true,
|
||||||
|
errors: vec!["file not found".to_string(), String::new()],
|
||||||
|
error: None,
|
||||||
|
item_errors: vec![
|
||||||
|
rustfs_protos::proto_gen::node_service::Error {
|
||||||
|
code: DiskError::FileNotFound.to_u32(),
|
||||||
|
error_info: "file not found".to_string(),
|
||||||
|
},
|
||||||
|
rustfs_protos::proto_gen::node_service::Error::default(),
|
||||||
|
],
|
||||||
|
},
|
||||||
|
2,
|
||||||
|
);
|
||||||
|
|
||||||
|
assert!(matches!(errors.as_slice(), [Some(DiskError::FileNotFound), None]));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn delete_versions_response_accepts_legacy_string_errors() {
|
||||||
|
let errors = decode_delete_versions_errors(
|
||||||
|
DeleteVersionsResponse {
|
||||||
|
success: true,
|
||||||
|
errors: vec!["legacy error".to_string(), String::new()],
|
||||||
|
error: None,
|
||||||
|
item_errors: Vec::new(),
|
||||||
|
},
|
||||||
|
2,
|
||||||
|
);
|
||||||
|
|
||||||
|
assert_eq!(errors.len(), 2);
|
||||||
|
assert_eq!(errors[0].as_ref().map(ToString::to_string).as_deref(), Some("io error legacy error"));
|
||||||
|
assert!(errors[1].is_none());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn delete_versions_response_rejects_misaligned_item_errors() {
|
||||||
|
let errors = decode_delete_versions_errors(
|
||||||
|
DeleteVersionsResponse {
|
||||||
|
success: true,
|
||||||
|
errors: vec!["file not found".to_string()],
|
||||||
|
error: None,
|
||||||
|
item_errors: vec![rustfs_protos::proto_gen::node_service::Error {
|
||||||
|
code: DiskError::FileNotFound.to_u32(),
|
||||||
|
error_info: "file not found".to_string(),
|
||||||
|
}],
|
||||||
|
},
|
||||||
|
2,
|
||||||
|
);
|
||||||
|
|
||||||
|
assert_eq!(errors.len(), 2);
|
||||||
|
assert!(errors.iter().all(Option::is_some));
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn disk_mutation_digest_marks_rolling_compatibility() {
|
fn disk_mutation_digest_marks_rolling_compatibility() {
|
||||||
let mut request = Request::new(());
|
let mut request = Request::new(());
|
||||||
|
|||||||
@@ -722,6 +722,10 @@ pub struct DeleteVersionsResponse {
|
|||||||
pub errors: ::prost::alloc::vec::Vec<::prost::alloc::string::String>,
|
pub errors: ::prost::alloc::vec::Vec<::prost::alloc::string::String>,
|
||||||
#[prost(message, optional, tag = "3")]
|
#[prost(message, optional, tag = "3")]
|
||||||
pub error: ::core::option::Option<Error>,
|
pub error: ::core::option::Option<Error>,
|
||||||
|
/// Senders dual-write the legacy strings and typed entries. Receivers prefer typed entries
|
||||||
|
/// when present and fall back to strings for peers that predate this field. Code zero means success.
|
||||||
|
#[prost(message, repeated, tag = "4")]
|
||||||
|
pub item_errors: ::prost::alloc::vec::Vec<Error>,
|
||||||
}
|
}
|
||||||
#[derive(Clone, PartialEq, Eq, Hash, ::prost::Message)]
|
#[derive(Clone, PartialEq, Eq, Hash, ::prost::Message)]
|
||||||
pub struct ReadMultipleRequest {
|
pub struct ReadMultipleRequest {
|
||||||
|
|||||||
@@ -493,6 +493,9 @@ message DeleteVersionsResponse {
|
|||||||
bool success = 1;
|
bool success = 1;
|
||||||
repeated string errors = 2;
|
repeated string errors = 2;
|
||||||
optional Error error = 3;
|
optional Error error = 3;
|
||||||
|
// Senders dual-write the legacy strings and typed entries. Receivers prefer typed entries
|
||||||
|
// when present and fall back to strings for peers that predate this field. Code zero means success.
|
||||||
|
repeated Error item_errors = 4;
|
||||||
}
|
}
|
||||||
|
|
||||||
message ReadMultipleRequest {
|
message ReadMultipleRequest {
|
||||||
|
|||||||
@@ -146,6 +146,29 @@ fn encode_file_info_msgpack(value: &FileInfo) -> std::result::Result<Vec<u8>, Di
|
|||||||
encode_msgpack_with_capacity(value, "FileInfo", FILE_INFO_MSGPACK_ENCODE_CAPACITY_HINT)
|
encode_msgpack_with_capacity(value, "FileInfo", FILE_INFO_MSGPACK_ENCODE_CAPACITY_HINT)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn encode_delete_versions_errors(disk_errors: Vec<Option<DiskError>>) -> (Vec<String>, Vec<Error>) {
|
||||||
|
let mut errors = Vec::with_capacity(disk_errors.len());
|
||||||
|
let mut item_errors = Vec::with_capacity(disk_errors.len());
|
||||||
|
for error in disk_errors {
|
||||||
|
match error {
|
||||||
|
Some(error) => {
|
||||||
|
let code = match &error {
|
||||||
|
DiskError::Io(source) if source.kind() == std::io::ErrorKind::NotFound => DiskError::FileNotFound.to_u32(),
|
||||||
|
_ => error.to_u32(),
|
||||||
|
};
|
||||||
|
let error_info = error.to_string();
|
||||||
|
errors.push(error_info.clone());
|
||||||
|
item_errors.push(Error { code, error_info });
|
||||||
|
}
|
||||||
|
None => {
|
||||||
|
errors.push(String::new());
|
||||||
|
item_errors.push(Error::default());
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
(errors, item_errors)
|
||||||
|
}
|
||||||
|
|
||||||
fn encode_msgpack_named<T: serde::Serialize>(value: &T, value_name: &str) -> std::result::Result<Vec<u8>, DiskError> {
|
fn encode_msgpack_named<T: serde::Serialize>(value: &T, value_name: &str) -> std::result::Result<Vec<u8>, DiskError> {
|
||||||
let mut serializer = rmp_serde::Serializer::new(Vec::with_capacity(MSGPACK_ENCODE_CAPACITY_HINT)).with_struct_map();
|
let mut serializer = rmp_serde::Serializer::new(Vec::with_capacity(MSGPACK_ENCODE_CAPACITY_HINT)).with_struct_map();
|
||||||
value
|
value
|
||||||
@@ -552,6 +575,7 @@ impl NodeService {
|
|||||||
success: false,
|
success: false,
|
||||||
errors: Vec::new(),
|
errors: Vec::new(),
|
||||||
error: Some(DiskError::other(format!("decode FileInfoVersions failed: {err}")).into()),
|
error: Some(DiskError::other(format!("decode FileInfoVersions failed: {err}")).into()),
|
||||||
|
item_errors: Vec::new(),
|
||||||
}));
|
}));
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
@@ -563,30 +587,26 @@ impl NodeService {
|
|||||||
success: false,
|
success: false,
|
||||||
errors: Vec::new(),
|
errors: Vec::new(),
|
||||||
error: Some(DiskError::other(format!("decode DeleteOptions failed: {err}")).into()),
|
error: Some(DiskError::other(format!("decode DeleteOptions failed: {err}")).into()),
|
||||||
|
item_errors: Vec::new(),
|
||||||
}));
|
}));
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
let errors = disk
|
let (errors, item_errors) =
|
||||||
.delete_versions(&request.volume, versions, opts)
|
encode_delete_versions_errors(disk.delete_versions(&request.volume, versions, opts).await);
|
||||||
.await
|
|
||||||
.into_iter()
|
|
||||||
.map(|error| match error {
|
|
||||||
Some(e) => e.to_string(),
|
|
||||||
None => "".to_string(),
|
|
||||||
})
|
|
||||||
.collect();
|
|
||||||
|
|
||||||
Ok(Response::new(DeleteVersionsResponse {
|
Ok(Response::new(DeleteVersionsResponse {
|
||||||
success: true,
|
success: true,
|
||||||
errors,
|
errors,
|
||||||
error: None,
|
error: None,
|
||||||
|
item_errors,
|
||||||
}))
|
}))
|
||||||
} else {
|
} else {
|
||||||
Ok(Response::new(DeleteVersionsResponse {
|
Ok(Response::new(DeleteVersionsResponse {
|
||||||
success: false,
|
success: false,
|
||||||
errors: Vec::new(),
|
errors: Vec::new(),
|
||||||
error: Some(DiskError::other("cannot find disk".to_string()).into()),
|
error: Some(DiskError::other("cannot find disk".to_string()).into()),
|
||||||
|
item_errors: Vec::new(),
|
||||||
}))
|
}))
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1612,8 +1632,8 @@ impl NodeService {
|
|||||||
mod tests {
|
mod tests {
|
||||||
use super::{
|
use super::{
|
||||||
compat_response_json, decode_msgpack_or_json, decode_rename_data_request_file_info,
|
compat_response_json, decode_msgpack_or_json, decode_rename_data_request_file_info,
|
||||||
encode_batch_read_version_response_payloads, encode_file_info_msgpack, encode_msgpack, encode_msgpack_named,
|
encode_batch_read_version_response_payloads, encode_delete_versions_errors, encode_file_info_msgpack, encode_msgpack,
|
||||||
encode_read_multiple_response_payloads, encode_rename_data_response_payloads,
|
encode_msgpack_named, encode_read_multiple_response_payloads, encode_rename_data_response_payloads,
|
||||||
};
|
};
|
||||||
use crate::storage::rpc::node_service::make_server;
|
use crate::storage::rpc::node_service::make_server;
|
||||||
use crate::storage::storage_api::ReadMultipleResp;
|
use crate::storage::storage_api::ReadMultipleResp;
|
||||||
@@ -1632,6 +1652,18 @@ mod tests {
|
|||||||
count: u32,
|
count: u32,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn delete_versions_response_dual_writes_typed_item_errors() {
|
||||||
|
let raw_not_found = super::DiskError::Io(std::io::Error::from(std::io::ErrorKind::NotFound));
|
||||||
|
let (errors, item_errors) = encode_delete_versions_errors(vec![Some(raw_not_found), None]);
|
||||||
|
|
||||||
|
assert!(errors[0].starts_with("io error "));
|
||||||
|
assert!(errors[1].is_empty());
|
||||||
|
assert_eq!(item_errors[0].code, super::DiskError::FileNotFound.to_u32());
|
||||||
|
assert_eq!(item_errors[0].error_info, errors[0]);
|
||||||
|
assert_eq!(item_errors[1].code, 0);
|
||||||
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[serial]
|
#[serial]
|
||||||
async fn handle_read_version_records_attribution_for_missing_disk() {
|
async fn handle_read_version_records_attribution_for_missing_disk() {
|
||||||
|
|||||||
@@ -15,6 +15,20 @@ from pathlib import Path
|
|||||||
|
|
||||||
|
|
||||||
ROOT = Path(__file__).resolve().parents[1]
|
ROOT = Path(__file__).resolve().parents[1]
|
||||||
|
SCHEDULED_ALERT_WORKFLOWS = (
|
||||||
|
".github/workflows/audit.yml",
|
||||||
|
".github/workflows/build.yml",
|
||||||
|
".github/workflows/ci.yml",
|
||||||
|
".github/workflows/coverage.yml",
|
||||||
|
".github/workflows/e2e-replication-nightly.yml",
|
||||||
|
".github/workflows/e2e-s3tests.yml",
|
||||||
|
".github/workflows/fuzz.yml",
|
||||||
|
".github/workflows/mint.yml",
|
||||||
|
".github/workflows/minio-interop.yml",
|
||||||
|
".github/workflows/nightly-gnu.yml",
|
||||||
|
".github/workflows/performance-ab.yml",
|
||||||
|
".github/workflows/runner-hygiene.yml",
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
def words(value: str) -> set[str]:
|
def words(value: str) -> set[str]:
|
||||||
@@ -252,6 +266,72 @@ def check_profile_definitions(root: Path) -> list[str]:
|
|||||||
return errors
|
return errors
|
||||||
|
|
||||||
|
|
||||||
|
def check_scheduled_alerts(root: Path) -> list[str]:
|
||||||
|
errors: list[str] = []
|
||||||
|
for relative in SCHEDULED_ALERT_WORKFLOWS:
|
||||||
|
path = root / relative
|
||||||
|
try:
|
||||||
|
lines = path.read_text().splitlines()
|
||||||
|
except FileNotFoundError:
|
||||||
|
errors.append(f"{relative}: missing scheduled validation workflow")
|
||||||
|
continue
|
||||||
|
|
||||||
|
try:
|
||||||
|
start = lines.index(" alert-on-failure:") + 1
|
||||||
|
except ValueError:
|
||||||
|
errors.append(f"{relative}: missing alert-on-failure job")
|
||||||
|
continue
|
||||||
|
end = next(
|
||||||
|
(index for index in range(start, len(lines)) if re.fullmatch(r" [A-Za-z0-9_-]+:", lines[index])),
|
||||||
|
len(lines),
|
||||||
|
)
|
||||||
|
job = "\n".join(line.split("#", 1)[0] for line in lines[start:end])
|
||||||
|
required = (
|
||||||
|
"always()",
|
||||||
|
"github.event_name == 'schedule'",
|
||||||
|
"contains(needs.*.result, 'failure')",
|
||||||
|
"issues: write",
|
||||||
|
"uses: ./.github/actions/schedule-failure-issue",
|
||||||
|
"github-token: ${{ secrets.GITHUB_TOKEN }}",
|
||||||
|
)
|
||||||
|
missing = [token for token in required if token not in job]
|
||||||
|
if missing:
|
||||||
|
errors.append(f"{relative}: alert-on-failure missing {', '.join(missing)}")
|
||||||
|
|
||||||
|
watchdog_path = root / ".github/workflows/scheduled-validation-watchdog.yml"
|
||||||
|
try:
|
||||||
|
watchdog = "\n".join(
|
||||||
|
line.split("#", 1)[0] for line in watchdog_path.read_text().splitlines()
|
||||||
|
)
|
||||||
|
except FileNotFoundError:
|
||||||
|
errors.append(".github/workflows/scheduled-validation-watchdog.yml: missing completion watchdog")
|
||||||
|
return errors
|
||||||
|
for relative in SCHEDULED_ALERT_WORKFLOWS:
|
||||||
|
path = root / relative
|
||||||
|
if not path.is_file():
|
||||||
|
continue
|
||||||
|
source = path.read_text()
|
||||||
|
match = re.search(r"^name:\s*[\"']?([^\"'\n]+)", source, re.MULTILINE)
|
||||||
|
if not match:
|
||||||
|
errors.append(f"{relative}: missing workflow name")
|
||||||
|
elif f'- "{match.group(1).strip()}"' not in watchdog:
|
||||||
|
errors.append(f"{relative}: missing from scheduled completion watchdog")
|
||||||
|
required = (
|
||||||
|
"github.event.workflow_run.event == 'schedule'",
|
||||||
|
"github.event.workflow_run.conclusion != 'success'",
|
||||||
|
"github.event.workflow_run.conclusion != 'failure'",
|
||||||
|
"workflow-name: ${{ github.event.workflow_run.name }}",
|
||||||
|
"source-run-id: ${{ github.event.workflow_run.id }}",
|
||||||
|
"source-run-attempt: ${{ github.event.workflow_run.run_attempt }}",
|
||||||
|
)
|
||||||
|
missing = [token for token in required if token not in watchdog]
|
||||||
|
if missing:
|
||||||
|
errors.append(
|
||||||
|
".github/workflows/scheduled-validation-watchdog.yml: missing " + ", ".join(missing)
|
||||||
|
)
|
||||||
|
return errors
|
||||||
|
|
||||||
|
|
||||||
def check_profile_listing(root: Path, profile: str, listing: Path) -> list[str]:
|
def check_profile_listing(root: Path, profile: str, listing: Path) -> list[str]:
|
||||||
try:
|
try:
|
||||||
expected_digest = profile_selection(root, profile)
|
expected_digest = profile_selection(root, profile)
|
||||||
@@ -281,6 +361,7 @@ def validate(root: Path) -> list[str]:
|
|||||||
errors.extend(check_runner_selection(root))
|
errors.extend(check_runner_selection(root))
|
||||||
errors.extend(check_s3_tests_runner(root))
|
errors.extend(check_s3_tests_runner(root))
|
||||||
errors.extend(check_profile_definitions(root))
|
errors.extend(check_profile_definitions(root))
|
||||||
|
errors.extend(check_scheduled_alerts(root))
|
||||||
return errors
|
return errors
|
||||||
|
|
||||||
|
|
||||||
@@ -363,6 +444,7 @@ class SelfTests(unittest.TestCase):
|
|||||||
mock.patch(__name__ + ".check_fuzz_targets", return_value=[]),
|
mock.patch(__name__ + ".check_fuzz_targets", return_value=[]),
|
||||||
mock.patch(__name__ + ".check_runner_selection", return_value=[]),
|
mock.patch(__name__ + ".check_runner_selection", return_value=[]),
|
||||||
mock.patch(__name__ + ".check_profile_definitions", return_value=[]),
|
mock.patch(__name__ + ".check_profile_definitions", return_value=[]),
|
||||||
|
mock.patch(__name__ + ".check_scheduled_alerts", return_value=[]),
|
||||||
):
|
):
|
||||||
self.assertEqual(len(validate(root)), 1)
|
self.assertEqual(len(validate(root)), 1)
|
||||||
|
|
||||||
@@ -413,6 +495,54 @@ class SelfTests(unittest.TestCase):
|
|||||||
with mock.patch.object(sys, "platform", "linux"):
|
with mock.patch.object(sys, "platform", "linux"):
|
||||||
self.assertEqual(len(check_profile_listing(root, "e2e-full", listing)), 1)
|
self.assertEqual(len(check_profile_listing(root, "e2e-full", listing)), 1)
|
||||||
|
|
||||||
|
def test_scheduled_alerts_require_completion_watchdog(self) -> None:
|
||||||
|
with tempfile.TemporaryDirectory() as tmp:
|
||||||
|
root = Path(tmp)
|
||||||
|
alert = (
|
||||||
|
" alert-on-failure:\n"
|
||||||
|
" if: always() && github.event_name == 'schedule' && "
|
||||||
|
"contains(needs.*.result, 'failure')\n"
|
||||||
|
" permissions:\n"
|
||||||
|
" issues: write\n"
|
||||||
|
" steps:\n"
|
||||||
|
" - uses: ./.github/actions/schedule-failure-issue\n"
|
||||||
|
" with:\n"
|
||||||
|
" github-token: ${{ secrets.GITHUB_TOKEN }}\n"
|
||||||
|
)
|
||||||
|
names: list[str] = []
|
||||||
|
for relative in SCHEDULED_ALERT_WORKFLOWS:
|
||||||
|
path = root / relative
|
||||||
|
path.parent.mkdir(parents=True, exist_ok=True)
|
||||||
|
names.append(path.stem)
|
||||||
|
path.write_text(f'name: "{path.stem}"\n{alert}')
|
||||||
|
watchdog = root / ".github/workflows/scheduled-validation-watchdog.yml"
|
||||||
|
watchdog.write_text(
|
||||||
|
"\n".join(f'- "{name}"' for name in names)
|
||||||
|
+ "\ngithub.event.workflow_run.event == 'schedule'\n"
|
||||||
|
+ "github.event.workflow_run.conclusion != 'success'\n"
|
||||||
|
+ "github.event.workflow_run.conclusion != 'failure'\n"
|
||||||
|
+ "workflow-name: ${{ github.event.workflow_run.name }}\n"
|
||||||
|
+ "source-run-id: ${{ github.event.workflow_run.id }}\n"
|
||||||
|
+ "source-run-attempt: ${{ github.event.workflow_run.run_attempt }}\n"
|
||||||
|
)
|
||||||
|
self.assertEqual(check_scheduled_alerts(root), [])
|
||||||
|
|
||||||
|
first = root / SCHEDULED_ALERT_WORKFLOWS[0]
|
||||||
|
mutations = (
|
||||||
|
("contains(needs.*.result, 'failure')", "false"),
|
||||||
|
("issues: write", "issues: read"),
|
||||||
|
("uses: ./.github/actions/schedule-failure-issue", "uses: actions/checkout@v7"),
|
||||||
|
("github-token: ${{ secrets.GITHUB_TOKEN }}", "github-token: missing"),
|
||||||
|
)
|
||||||
|
for required, replacement in mutations:
|
||||||
|
original = first.read_text()
|
||||||
|
first.write_text(original.replace(required, replacement))
|
||||||
|
self.assertEqual(len(check_scheduled_alerts(root)), 1)
|
||||||
|
first.write_text(original)
|
||||||
|
|
||||||
|
watchdog.write_text(watchdog.read_text().replace(f'- "{names[0]}"\n', ""))
|
||||||
|
self.assertEqual(len(check_scheduled_alerts(root)), 1)
|
||||||
|
|
||||||
def main() -> int:
|
def main() -> int:
|
||||||
if sys.argv[1:] == ["--self-test"]:
|
if sys.argv[1:] == ["--self-test"]:
|
||||||
suite = unittest.defaultTestLoader.loadTestsFromTestCase(SelfTests)
|
suite = unittest.defaultTestLoader.loadTestsFromTestCase(SelfTests)
|
||||||
@@ -436,7 +566,7 @@ def main() -> int:
|
|||||||
for error in errors:
|
for error in errors:
|
||||||
print(f"ERROR: {error}", file=sys.stderr)
|
print(f"ERROR: {error}", file=sys.stderr)
|
||||||
return 1
|
return 1
|
||||||
print("OK: e2e modules, runner selection, fuzz matrices, profiles, and bounded diagnostics are wired")
|
print("OK: e2e modules, runner selection, fuzz matrices, profiles, and scheduled alerts are wired")
|
||||||
return 0
|
return 0
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user