From ff008729226c3117c6514473ed261089ad65e4cc Mon Sep 17 00:00:00 2001 From: Zhengchao An Date: Mon, 7 Sep 2026 08:59:20 +0800 Subject: [PATCH] docs(ilm): restore transition gate doc comment after handler reorder (#7325) Commit 086ee8e48 moved authorize_recovery_admin_request above authorize_transition_admin_request and left the transition gate's doc comment attached to the recovery gate, which returns a hashed actor rather than the masked access key the comment describes. Move the comment back onto the transition gate and give the recovery gate its own accurate description. No behavior change. --- rustfs/src/admin/handlers/ilm_transition.rs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/rustfs/src/admin/handlers/ilm_transition.rs b/rustfs/src/admin/handlers/ilm_transition.rs index e628b5290..23c545a3c 100644 --- a/rustfs/src/admin/handlers/ilm_transition.rs +++ b/rustfs/src/admin/handlers/ilm_transition.rs @@ -467,9 +467,9 @@ async fn authorize_manual_transition_request(req: &S3Request) -> S3Result< authorize_transition_admin_request(req, AdminAction::SetTierAction).await } -/// The credential pre-check keeps this endpoint family's historical -/// missing-credentials message (the shared gate reports "get cred failed") and -/// still yields the masked actor every transition audit log records. +/// Recovery endpoints bind their audit actor to the authenticated access key +/// (hashed, never the presented key itself); the credential pre-check keeps +/// this endpoint family's historical missing-credentials message. async fn authorize_recovery_admin_request(req: &S3Request, action: AdminAction) -> S3Result { if req.credentials.is_none() { return Err(admin_s3_error(AdminS3ErrorCode::InvalidRequest, "authentication required")); @@ -478,6 +478,9 @@ async fn authorize_recovery_admin_request(req: &S3Request, action: AdminAc Ok(recovery_actor_sha256(&credentials)) } +/// The credential pre-check keeps this endpoint family's historical +/// missing-credentials message (the shared gate reports "get cred failed") and +/// still yields the masked actor every transition audit log records. async fn authorize_transition_admin_request(req: &S3Request, action: AdminAction) -> S3Result { let Some(input_cred) = req.credentials.as_ref() else { return Err(s3_error!(InvalidRequest, "authentication required"));