diff --git a/crates/ecstore/src/diagnostics/admin_server_info.rs b/crates/ecstore/src/diagnostics/admin_server_info.rs index b03b576ea..1ffbac27a 100644 --- a/crates/ecstore/src/diagnostics/admin_server_info.rs +++ b/crates/ecstore/src/diagnostics/admin_server_info.rs @@ -653,6 +653,7 @@ fn reconcile_servers_with_endpoint_topology( (added, report) } +#[allow(dead_code, reason = "exercised by this file's topology tests (backlog#1823)")] fn server_topology_completeness_report( servers: &[ServerProperties], endpoints: &EndpointServerPools, diff --git a/crates/ecstore/src/diagnostics/get.rs b/crates/ecstore/src/diagnostics/get.rs index e05f213b0..c02e41161 100644 --- a/crates/ecstore/src/diagnostics/get.rs +++ b/crates/ecstore/src/diagnostics/get.rs @@ -46,21 +46,49 @@ pub(crate) const GET_CODEC_STREAMING_OBJECT_CLASS_MULTIPART: &str = "multipart"; pub(crate) const GET_STAGE_DECODE: &str = "decode"; pub(crate) const GET_STAGE_EMIT: &str = "emit"; pub(crate) const GET_STAGE_FILL: &str = "fill"; +#[allow( + dead_code, + reason = "GET stage vocabulary; value pinned by this file's tests, no writer yet (backlog#1823)" +)] pub(crate) const GET_STAGE_FIRST_BYTE: &str = "first_byte"; +#[allow( + dead_code, + reason = "GET stage vocabulary; value pinned by this file's tests, no writer yet (backlog#1823)" +)] pub(crate) const GET_STAGE_FIRST_METADATA_RESPONSE: &str = "first_metadata_response"; +#[allow( + dead_code, + reason = "GET stage vocabulary; value pinned by this file's tests, no writer yet (backlog#1823)" +)] pub(crate) const GET_STAGE_FIRST_VALID_METADATA_RESPONSE: &str = "first_valid_metadata_response"; +#[allow( + dead_code, + reason = "GET stage vocabulary; value pinned by this file's tests, no writer yet (backlog#1823)" +)] pub(crate) const GET_STAGE_FIRST_SHARD_READ: &str = "first_shard_read"; +#[allow( + dead_code, + reason = "GET stage vocabulary; value pinned by this file's tests, no writer yet (backlog#1823)" +)] pub(crate) const GET_STAGE_FULL_BODY: &str = "full_body"; pub(crate) const GET_STAGE_INLINE_PREPARE: &str = "inline_prepare"; pub(crate) const GET_STAGE_LOCK_ACQUIRE: &str = "lock_acquire"; pub(crate) const GET_STAGE_METADATA: &str = "metadata"; pub(crate) const GET_STAGE_METADATA_CACHE_LOOKUP: &str = "metadata_cache_lookup"; +#[allow( + dead_code, + reason = "GET stage vocabulary; value pinned by this file's tests, no writer yet (backlog#1823)" +)] pub(crate) const GET_STAGE_METADATA_FANOUT: &str = "metadata_fanout"; pub(crate) const GET_STAGE_METADATA_RESOLVE: &str = "metadata_resolve"; pub(crate) const GET_STAGE_OBJECT_INFO: &str = "object_info"; pub(crate) const GET_STAGE_OUTPUT_LOCK_WAIT: &str = "output_lock_wait"; pub(crate) const GET_STAGE_OUTPUT_POLL: &str = "output_poll"; pub(crate) const GET_STAGE_PATH_DECISION: &str = "path_decision"; +#[allow( + dead_code, + reason = "GET stage vocabulary; value pinned by this file's tests, no writer yet (backlog#1823)" +)] pub(crate) const GET_STAGE_QUORUM_REACHED: &str = "quorum_reached"; pub(crate) const GET_STAGE_RANGE: &str = "range"; pub(crate) const GET_STAGE_READER_SETUP: &str = "reader_setup"; @@ -89,11 +117,23 @@ pub(crate) const GET_STAGE_READ_VERSION_PATH_CHECK: &str = "read_version_path_ch pub(crate) const GET_STAGE_READ_VERSION_PATH_RESOLVE: &str = "read_version_path_resolve"; pub(crate) const GET_STAGE_READ_VERSION_XLMETA_READ: &str = "read_version_xlmeta_read"; pub(crate) const GET_STAGE_RECONSTRUCT: &str = "reconstruct"; +#[allow( + dead_code, + reason = "GET stage vocabulary; value pinned by this file's tests, no writer yet (backlog#1823)" +)] pub(crate) const GET_STAGE_RESPONSE_HANDOFF: &str = "response_handoff"; +#[allow( + dead_code, + reason = "GET stage vocabulary; value pinned by this file's tests, no writer yet (backlog#1823)" +)] pub(crate) const GET_STAGE_SLOWEST_METADATA_RESPONSE: &str = "slowest_metadata_response"; pub(crate) const GET_STAGE_STRIPE_READ: &str = "stripe_read"; pub(crate) const GET_STAGE_STRIPE_READ_FIRST_SHARD: &str = "stripe_read_first_shard"; pub(crate) const GET_STAGE_STRIPE_READ_QUORUM: &str = "stripe_read_quorum"; +#[allow( + dead_code, + reason = "GET stage vocabulary; value pinned by this file's tests, no writer yet (backlog#1823)" +)] pub(crate) const GET_STAGE_BITROT_VERIFY: &str = "bitrot_verify"; pub(crate) const GET_READER_BUFFER_OUTPUT: &str = "output"; @@ -159,8 +199,20 @@ pub(crate) const GET_METADATA_EARLY_STOP_REASON_VERSION_NOT_FOUND: &str = "versi pub(crate) const GET_METADATA_EARLY_STOP_REASON_VERSION_MATCH_QUORUM: &str = "version_match_quorum"; /// Early-stop active state labels +#[allow( + dead_code, + reason = "GET stage vocabulary; value pinned by this file's tests, no writer yet (backlog#1823)" +)] pub(crate) const EARLY_STOP_ACTIVE_HIT: &str = "hit"; +#[allow( + dead_code, + reason = "GET stage vocabulary; value pinned by this file's tests, no writer yet (backlog#1823)" +)] pub(crate) const EARLY_STOP_ACTIVE_MISS: &str = "miss"; +#[allow( + dead_code, + reason = "GET stage vocabulary; value pinned by this file's tests, no writer yet (backlog#1823)" +)] pub(crate) const EARLY_STOP_ACTIVE_DISABLED: &str = "disabled"; #[derive(Clone, Copy, Debug, Eq, PartialEq)] diff --git a/crates/ecstore/src/diagnostics/mod.rs b/crates/ecstore/src/diagnostics/mod.rs index c0f7673a5..45c50e928 100644 --- a/crates/ecstore/src/diagnostics/mod.rs +++ b/crates/ecstore/src/diagnostics/mod.rs @@ -13,8 +13,6 @@ // limitations under the License. // #730: diagnostics constants are staged for request-path telemetry migration. -#![allow(dead_code)] pub(crate) mod admin_server_info; pub(crate) mod get; -pub(crate) mod pool; diff --git a/crates/ecstore/src/diagnostics/pool.rs b/crates/ecstore/src/diagnostics/pool.rs deleted file mode 100644 index 2a4d7d88d..000000000 --- a/crates/ecstore/src/diagnostics/pool.rs +++ /dev/null @@ -1,30 +0,0 @@ -// Copyright 2024 RustFS Team -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -//! BytesPool metric label constants. -//! -//! These constants are used when recording pool acquisition and return -//! metrics to avoid string allocations and ensure label consistency. - -/// BytesPool tier labels -pub const POOL_TIER_SMALL: &str = "small"; -pub const POOL_TIER_MEDIUM: &str = "medium"; -pub const POOL_TIER_LARGE: &str = "large"; -pub const POOL_TIER_XLARGE: &str = "xlarge"; - -/// BytesPool outcome labels -pub const POOL_OUTCOME_HIT: &str = "hit"; -pub const POOL_OUTCOME_MISS: &str = "miss"; -pub const POOL_OUTCOME_RECYCLED: &str = "recycled"; -pub const POOL_OUTCOME_DROPPED: &str = "dropped";