mirror of
https://github.com/rustfs/rustfs.git
synced 2026-08-05 04:47:43 +00:00
refactor: prune root runtime compat aliases (#3687)
This commit is contained in:
@@ -146,6 +146,9 @@ RustFS root `storage_compat.rs` must expose bucket metadata and quota contracts
|
||||
as explicit aliases only. Broad `metadata`, `metadata_sys`, and `quota` module
|
||||
passthroughs are reserved to narrower app/admin/storage compatibility
|
||||
boundaries that still need module-local owner cleanup.
|
||||
Root runtime storage config initialization and disk endpoint contracts must also
|
||||
stay explicit aliases. The root compatibility boundary must not restore `com`,
|
||||
bare `init`, or grouped `endpoint::Endpoint` passthroughs.
|
||||
|
||||
ECStore ClusterControlPlane read models must stay owned by the crate-private
|
||||
`cluster` module. Public access goes through `rustfs_ecstore::api::cluster` so
|
||||
|
||||
@@ -5,16 +5,17 @@ Status values: `[ ]` not started, `[~]` in progress, `[x]` complete, `[!]` block
|
||||
## Current Context
|
||||
|
||||
- Issue: [`rustfs/backlog#660`](https://github.com/rustfs/backlog/issues/660)
|
||||
- Branch: `overtrue/arch-root-runtime-compat-boundaries`
|
||||
- Baseline: completed `C-011/C-012/C-013/API-055/API-059`.
|
||||
- Stacked on: main after workload admission provider composition.
|
||||
- Branch: `overtrue/arch-root-runtime-compat-aliases`
|
||||
- Baseline: completed `C-011/C-012/C-013/API-055/API-059/API-079`.
|
||||
- Stacked on: API-079 root runtime bucket compatibility pruning.
|
||||
- PR type for this branch: `pure-move`
|
||||
- Runtime behavior changes: none.
|
||||
- Rust code changes: prune broad root bucket metadata/quota compatibility module
|
||||
passthroughs into explicit aliases for the current RustFS root consumers.
|
||||
- CI/script changes: guard against restoring broad root bucket compatibility
|
||||
- Rust code changes: prune root config read/write, config initialization, and
|
||||
disk endpoint compatibility passthroughs into explicit aliases for startup
|
||||
and runtime consumers.
|
||||
- CI/script changes: guard against restoring broad root config and disk endpoint
|
||||
module passthroughs.
|
||||
- Docs changes: record the API-079 root runtime bucket compatibility boundary.
|
||||
- Docs changes: record the API-080 root runtime compatibility alias boundary.
|
||||
|
||||
## Phase 0 Tasks
|
||||
|
||||
@@ -124,6 +125,23 @@ Status values: `[ ]` not started, `[~]` in progress, `[x]` complete, `[!]` block
|
||||
bucket metadata ownership, and all app/admin/storage compatibility paths.
|
||||
- Verification: RustFS compile coverage, formatting, diff hygiene, risk
|
||||
scan, architecture guard, pre-commit quality gate, and three-expert review.
|
||||
- [x] `API-080` Prune root runtime config and disk compatibility aliases.
|
||||
- Completed slice: replace root config `com` passthroughs with explicit
|
||||
config read/write aliases for module switches, expose ECStore config
|
||||
initialization as `init_ecstore_config`, split disk endpoint access into an
|
||||
explicit `Endpoint` alias, and guard these root aliases against broad
|
||||
module restores.
|
||||
- Acceptance: startup storage initializes ECStore config through a direct
|
||||
compatibility alias, module switch persistence uses direct config IO
|
||||
aliases, root runtime disk endpoint consumers keep the same endpoint type,
|
||||
and app/admin/storage local compatibility modules remain unchanged for
|
||||
their own cleanup slices.
|
||||
- Must preserve: startup storage initialization order, global config
|
||||
migration/retry behavior, module switch persistence semantics, endpoint
|
||||
parsing/layout behavior, local disk and lock-client initialization,
|
||||
readiness marking, and all app/admin/storage compatibility paths.
|
||||
- Verification: RustFS compile coverage, formatting, diff hygiene, risk
|
||||
scan, architecture guard, pre-commit quality gate, and three-expert review.
|
||||
- [x] `G-012` Inventory placement and repair invariants.
|
||||
- Acceptance:
|
||||
[`placement-repair-invariants.md`](placement-repair-invariants.md) records
|
||||
@@ -3157,14 +3175,23 @@ Status values: `[ ]` not started, `[~]` in progress, `[x]` complete, `[!]` block
|
||||
|
||||
| Expert | Status | Notes |
|
||||
|---|---|---|
|
||||
| Quality/architecture | passed | API-079 narrows the root RustFS bucket compatibility boundary to explicit aliases without adding new ECStore ownership cycles. |
|
||||
| Migration preservation | passed | Bucket notification loading, table-catalog metadata checks, quota error mapping, and app/admin/storage compatibility paths remain preserved. |
|
||||
| Quality/architecture | passed | API-080 narrows root runtime config and disk endpoint compatibility to explicit aliases without adding new ECStore ownership cycles. |
|
||||
| Migration preservation | passed | Startup config initialization, module switch persistence, endpoint handling, local disk/lock setup, readiness, and app/admin/storage compatibility paths remain preserved. |
|
||||
| Testing/verification | passed | RustFS compile coverage, migration guard, formatting, diff hygiene, added-line risk scan, full pre-commit, and three-expert review passed. |
|
||||
|
||||
## Verification Notes
|
||||
|
||||
Passed before push:
|
||||
|
||||
- Issue #660 API-080 current slice:
|
||||
- `cargo check -p rustfs --lib`: passed.
|
||||
- `cargo fmt --all --check`: passed.
|
||||
- `git diff --check`: passed.
|
||||
- `bash -n scripts/check_architecture_migration_rules.sh`: passed.
|
||||
- `./scripts/check_architecture_migration_rules.sh`: passed.
|
||||
- Rust added-line risk scan on changed Rust files and guard script: passed.
|
||||
- `make pre-commit`: passed.
|
||||
|
||||
- Issue #660 C-013 current slice:
|
||||
- `cargo test -p rustfs-concurrency workload::tests:: -- --nocapture`:
|
||||
passed.
|
||||
|
||||
Reference in New Issue
Block a user