feat: preserve request ids across async recovery logs (#3451)

* feat(obs): promote request ids in structured logs

* refactor(tracing): propagate spans into request tasks

* test(ecstore): baseline recovery monitor log chains

* fix(replication): reduce startup resync log noise

* chore(docs): stop tracking local recovery baseline

* chore(obs): polish request id logging cleanup
This commit is contained in:
houseme
2026-06-14 23:16:04 +08:00
committed by GitHub
parent 9499391370
commit efaf07d323
21 changed files with 1194 additions and 360 deletions
+1 -1
View File
@@ -137,7 +137,7 @@ metrics = { workspace = true }
tokio = { workspace = true, features = ["rt-multi-thread", "macros", "test-util"] } tokio = { workspace = true, features = ["rt-multi-thread", "macros", "test-util"] }
criterion = { workspace = true, features = ["html_reports"] } criterion = { workspace = true, features = ["html_reports"] }
temp-env = { workspace = true, features = ["async_closure"] } temp-env = { workspace = true, features = ["async_closure"] }
tracing-subscriber = { workspace = true } tracing-subscriber = { workspace = true, features = ["json"] }
serial_test = { workspace = true } serial_test = { workspace = true }
opentelemetry_sdk = { workspace = true } opentelemetry_sdk = { workspace = true }
@@ -64,9 +64,14 @@ const EVENT_REPLICATION_WORKER_RESIZE_SKIPPED: &str = "replication_worker_resize
const EVENT_REPLICATION_WORKER_RESIZED: &str = "replication_worker_resized"; const EVENT_REPLICATION_WORKER_RESIZED: &str = "replication_worker_resized";
const EVENT_REPLICATION_BACKPRESSURE: &str = "replication_backpressure"; const EVENT_REPLICATION_BACKPRESSURE: &str = "replication_backpressure";
const EVENT_REPLICATION_RESYNC_LOAD_SKIPPED: &str = "replication_resync_load_skipped"; const EVENT_REPLICATION_RESYNC_LOAD_SKIPPED: &str = "replication_resync_load_skipped";
const EVENT_REPLICATION_RESYNC_RECOVERED: &str = "replication_resync_recovered";
const EVENT_REPLICATION_CONFIG_LOOKUP_SKIPPED: &str = "replication_config_lookup_skipped"; const EVENT_REPLICATION_CONFIG_LOOKUP_SKIPPED: &str = "replication_config_lookup_skipped";
const EVENT_REPLICATION_MRF_QUEUE_OVERFLOW: &str = "replication_mrf_queue_overflow"; const EVENT_REPLICATION_MRF_QUEUE_OVERFLOW: &str = "replication_mrf_queue_overflow";
fn should_auto_resume_resync(status: ResyncStatusType) -> bool {
matches!(status, ResyncStatusType::ResyncPending | ResyncStatusType::ResyncStarted)
}
// Worker limits // Worker limits
pub const WORKER_MAX_LIMIT: usize = 500; pub const WORKER_MAX_LIMIT: usize = 500;
pub const WORKER_MIN_LIMIT: usize = 50; pub const WORKER_MIN_LIMIT: usize = 50;
@@ -1017,6 +1022,11 @@ impl<S: StorageAPI + NamespaceLocking> ReplicationPool<S> {
// Note: Leader lock implementation would be needed here // Note: Leader lock implementation would be needed here
// let _lock_guard = global_leader_lock.get_lock().await?; // let _lock_guard = global_leader_lock.get_lock().await?;
let mut recovered_statuses = Vec::new();
let mut restart_opts = Vec::new();
let mut recovered_bucket_count = 0usize;
let mut skipped_failed_target_count = 0usize;
for bucket in buckets { for bucket in buckets {
let meta = match load_bucket_resync_metadata(bucket, self.storage.clone()).await { let meta = match load_bucket_resync_metadata(bucket, self.storage.clone()).await {
Ok(meta) => meta, Ok(meta) => meta,
@@ -1036,40 +1046,54 @@ impl<S: StorageAPI + NamespaceLocking> ReplicationPool<S> {
} }
}; };
// Store metadata in resyncer if meta.targets_map.is_empty() {
{ continue;
let mut status_map = self.resyncer.status_map.write().await;
status_map.insert(bucket.clone(), meta.clone());
} }
// Process target statistics recovered_bucket_count += 1;
let target_stats = meta.clone_tgt_stats(); for (arn, stats) in &meta.targets_map {
for (arn, stats) in target_stats { if should_auto_resume_resync(stats.resync_status) {
match stats.resync_status { restart_opts.push(ResyncOpts {
ResyncStatusType::ResyncFailed | ResyncStatusType::ResyncStarted | ResyncStatusType::ResyncPending => { bucket: bucket.clone(),
// Note: This would spawn a resync task in a real implementation arn: arn.clone(),
// For now, we just log the resync request resync_id: stats.resync_id.clone(),
resync_before: stats.resync_before_date,
});
} else if stats.resync_status == ResyncStatusType::ResyncFailed {
skipped_failed_target_count += 1;
}
}
recovered_statuses.push((bucket.clone(), meta));
}
if !recovered_statuses.is_empty() {
let mut status_map = self.resyncer.status_map.write().await;
status_map.extend(recovered_statuses);
}
if !restart_opts.is_empty() || skipped_failed_target_count > 0 {
info!(
event = EVENT_REPLICATION_RESYNC_RECOVERED,
component = LOG_COMPONENT_ECSTORE,
subsystem = LOG_SUBSYSTEM_REPLICATION,
recovered_buckets = recovered_bucket_count,
resumed_targets = restart_opts.len(),
skipped_failed_targets = skipped_failed_target_count,
"Recovered replication resync state from persisted metadata; failed targets require manual resync restart"
);
}
for opts in restart_opts {
let ctx = CancellationToken::new(); let ctx = CancellationToken::new();
let bucket_clone = bucket.clone();
let resync = self.resyncer.clone(); let resync = self.resyncer.clone();
let storage = self.storage.clone(); let storage = self.storage.clone();
let opts = ResyncOpts {
bucket: bucket_clone,
arn,
resync_id: stats.resync_id,
resync_before: stats.resync_before_date,
};
tokio::spawn(async move { tokio::spawn(async move {
resync.register_cancel_token(&opts, ctx.clone()).await; resync.register_cancel_token(&opts, ctx.clone()).await;
Box::pin(resync.clone().resync_bucket(ctx, storage, true, opts.clone())).await; Box::pin(resync.clone().resync_bucket(ctx, storage, true, opts.clone())).await;
resync.clear_cancel_token(&opts).await; resync.clear_cancel_token(&opts).await;
}); });
} }
_ => {}
}
}
}
Ok(()) Ok(())
} }
@@ -1498,4 +1522,14 @@ mod tests {
admission.merge(ReplicationQueueAdmission::Missed); admission.merge(ReplicationQueueAdmission::Missed);
assert_eq!(admission, ReplicationQueueAdmission::Missed); assert_eq!(admission, ReplicationQueueAdmission::Missed);
} }
#[test]
fn auto_resume_resync_only_for_inflight_states() {
assert!(should_auto_resume_resync(ResyncStatusType::ResyncPending));
assert!(should_auto_resume_resync(ResyncStatusType::ResyncStarted));
assert!(!should_auto_resume_resync(ResyncStatusType::NoResync));
assert!(!should_auto_resume_resync(ResyncStatusType::ResyncCanceled));
assert!(!should_auto_resume_resync(ResyncStatusType::ResyncCompleted));
assert!(!should_auto_resume_resync(ResyncStatusType::ResyncFailed));
}
} }
@@ -87,7 +87,7 @@ use tokio::task::JoinSet;
use tokio::time::Duration as TokioDuration; use tokio::time::Duration as TokioDuration;
use tokio_util::io::ReaderStream; use tokio_util::io::ReaderStream;
use tokio_util::sync::CancellationToken; use tokio_util::sync::CancellationToken;
use tracing::{debug, error, instrument, warn}; use tracing::{debug, error, instrument, trace, warn};
use uuid::Uuid; use uuid::Uuid;
const LOG_COMPONENT_ECSTORE: &str = "ecstore"; const LOG_COMPONENT_ECSTORE: &str = "ecstore";
@@ -920,6 +920,7 @@ impl ReplicationResyncer {
(roi.size, None) (roi.size, None)
}; };
if err.is_some() {
debug!( debug!(
event = EVENT_RESYNC_OBJECT_PROCESSED, event = EVENT_RESYNC_OBJECT_PROCESSED,
component = LOG_COMPONENT_ECSTORE, component = LOG_COMPONENT_ECSTORE,
@@ -930,8 +931,21 @@ impl ReplicationResyncer {
version_id = %roi.version_id.unwrap_or_default(), version_id = %roi.version_id.unwrap_or_default(),
size, size,
error = ?err, error = ?err,
"Processed resync object with verification error"
);
} else {
trace!(
event = EVENT_RESYNC_OBJECT_PROCESSED,
component = LOG_COMPONENT_ECSTORE,
subsystem = LOG_SUBSYSTEM_REPLICATION_RESYNC,
reset_id = %reset_id,
bucket = %bucket_name,
object = %roi.name,
version_id = %roi.version_id.unwrap_or_default(),
size,
"Processed resync object" "Processed resync object"
); );
}
if cancel_token.is_cancelled() { if cancel_token.is_cancelled() {
return; return;
+16 -6
View File
@@ -34,6 +34,7 @@ use std::{
}; };
use time::OffsetDateTime; use time::OffsetDateTime;
use tokio::sync::mpsc::{self, Receiver, Sender}; use tokio::sync::mpsc::{self, Receiver, Sender};
use tracing::Instrument;
use crate::client::utils::base64_encode; use crate::client::utils::base64_encode;
use crate::client::{ use crate::client::{
@@ -221,11 +222,14 @@ impl TransitionClient {
let self_clone = Arc::clone(&self); let self_clone = Arc::clone(&self);
let bucket_name_owned = bucket_name.to_string(); let bucket_name_owned = bucket_name.to_string();
tokio::spawn(async move { tokio::spawn(
async move {
self_clone self_clone
.remove_objects_inner(&bucket_name_owned, objects_rx, &result_tx, opts) .remove_objects_inner(&bucket_name_owned, objects_rx, &result_tx, opts)
.await; .await;
}); }
.instrument(tracing::Span::current()),
);
result_rx result_rx
} }
@@ -241,12 +245,16 @@ impl TransitionClient {
let bucket_name_owned = bucket_name.to_string(); let bucket_name_owned = bucket_name.to_string();
let (result_tx, mut result_rx) = mpsc::channel(1); let (result_tx, mut result_rx) = mpsc::channel(1);
tokio::spawn(async move { tokio::spawn(
async move {
self_clone self_clone
.remove_objects_inner(&bucket_name_owned, objects_rx, &result_tx, opts) .remove_objects_inner(&bucket_name_owned, objects_rx, &result_tx, opts)
.await; .await;
}); }
tokio::spawn(async move { .instrument(tracing::Span::current()),
);
tokio::spawn(
async move {
while let Some(res) = result_rx.recv().await { while let Some(res) = result_rx.recv().await {
if res.err.is_none() { if res.err.is_none() {
continue; continue;
@@ -260,7 +268,9 @@ impl TransitionClient {
}) })
.await; .await;
} }
}); }
.instrument(tracing::Span::current()),
);
error_rx error_rx
} }
+120 -3
View File
@@ -52,7 +52,7 @@ use tokio::{net::TcpStream, time::Duration};
use tonic::Request; use tonic::Request;
use tonic::service::interceptor::InterceptedService; use tonic::service::interceptor::InterceptedService;
use tonic::transport::Channel; use tonic::transport::Channel;
use tracing::warn; use tracing::{Instrument, warn};
pub const PEER_RESTSIGNAL: &str = "signal"; pub const PEER_RESTSIGNAL: &str = "signal";
pub const PEER_RESTSUB_SYS: &str = "sub-sys"; pub const PEER_RESTSUB_SYS: &str = "sub-sys";
@@ -78,6 +78,16 @@ pub struct PeerRestClient {
} }
impl PeerRestClient { impl PeerRestClient {
fn recovery_monitor_span(grid_host: &str) -> tracing::Span {
tracing::info_span!(
"recovery-monitor",
component = "ecstore",
subsystem = "peer_rest_client",
kind = "peer_rest",
grid_host = %grid_host
)
}
pub fn new(host: XHost, grid_host: String) -> Self { pub fn new(host: XHost, grid_host: String) -> Self {
Self { Self {
host, host,
@@ -172,7 +182,9 @@ impl PeerRestClient {
let grid_host = self.grid_host.clone(); let grid_host = self.grid_host.clone();
let offline = Arc::clone(&self.offline); let offline = Arc::clone(&self.offline);
let recovery_running = Arc::clone(&self.recovery_running); let recovery_running = Arc::clone(&self.recovery_running);
tokio::spawn(async move { let span = Self::recovery_monitor_span(&grid_host);
tokio::spawn(
async move {
let mut delay = get_drive_active_check_interval(); let mut delay = get_drive_active_check_interval();
let connect_timeout = get_drive_active_check_timeout(); let connect_timeout = get_drive_active_check_timeout();
@@ -193,7 +205,24 @@ impl PeerRestClient {
"peer recovery monitor reached max attempts; will retry on next request" "peer recovery monitor reached max attempts; will retry on next request"
); );
recovery_running.store(false, Ordering::Release); recovery_running.store(false, Ordering::Release);
}); }
.instrument(span),
);
}
#[cfg(test)]
fn spawn_recovery_monitor_log_probe_for_test(&self) -> tokio::sync::oneshot::Receiver<()> {
let (tx, rx) = tokio::sync::oneshot::channel();
let grid_host = self.grid_host.clone();
let span = Self::recovery_monitor_span(&grid_host);
tokio::spawn(
async move {
warn!(grid_host = %grid_host, "peer recovery monitor log probe");
let _ = tx.send(());
}
.instrument(span),
);
rx
} }
async fn perform_connectivity_check(addr: &str, timeout_duration: Duration) -> Result<()> { async fn perform_connectivity_check(addr: &str, timeout_duration: Duration) -> Result<()> {
@@ -956,6 +985,58 @@ impl PeerRestClient {
#[cfg(test)] #[cfg(test)]
mod tests { mod tests {
use super::*; use super::*;
use serde_json::Value;
use std::io::{self, Write};
use std::sync::{Arc, Mutex};
use tracing_subscriber::{Registry, fmt::MakeWriter, layer::SubscriberExt};
#[derive(Clone, Default)]
struct CapturedLogs {
buffer: Arc<Mutex<Vec<u8>>>,
}
struct CapturedLogWriter {
buffer: Arc<Mutex<Vec<u8>>>,
}
impl CapturedLogs {
fn lines(&self) -> Vec<Value> {
let buffer = self
.buffer
.lock()
.expect("captured logs mutex should not be poisoned")
.clone();
String::from_utf8(buffer)
.expect("captured logs should be valid UTF-8")
.lines()
.map(|line| serde_json::from_str::<Value>(line).expect("captured log line should be valid JSON"))
.collect()
}
}
impl Write for CapturedLogWriter {
fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
self.buffer
.lock()
.expect("captured logs mutex should not be poisoned")
.extend_from_slice(buf);
Ok(buf.len())
}
fn flush(&mut self) -> io::Result<()> {
Ok(())
}
}
impl<'a> MakeWriter<'a> for CapturedLogs {
type Writer = CapturedLogWriter;
fn make_writer(&'a self) -> Self::Writer {
CapturedLogWriter {
buffer: Arc::clone(&self.buffer),
}
}
}
fn test_peer_client() -> PeerRestClient { fn test_peer_client() -> PeerRestClient {
PeerRestClient::new( PeerRestClient::new(
@@ -1011,4 +1092,40 @@ mod tests {
assert!(matches!(err, Error::VolumeNotFound)); assert!(matches!(err, Error::VolumeNotFound));
assert!(!client.offline.load(Ordering::Acquire)); assert!(!client.offline.load(Ordering::Acquire));
} }
#[tokio::test(flavor = "current_thread")]
async fn peer_rest_recovery_probe_logs_keep_request_id_span_context() {
let logs = CapturedLogs::default();
let subscriber = Registry::default().with(
tracing_subscriber::fmt::layer()
.with_writer(logs.clone())
.with_ansi(false)
.without_time()
.json()
.flatten_event(true)
.with_current_span(true)
.with_span_list(true),
);
let _guard = tracing::subscriber::set_default(subscriber);
let client = test_peer_client();
let span = tracing::info_span!("request-span", request_id = "req-peer-rest");
let _entered = span.enter();
let done = client.spawn_recovery_monitor_log_probe_for_test();
done.await.expect("recovery monitor probe should signal completion");
let log = logs
.lines()
.into_iter()
.find(|value| value.get("message").and_then(Value::as_str) == Some("peer recovery monitor log probe"))
.expect("expected peer recovery monitor probe log");
assert_eq!(log["span"]["name"], Value::String("recovery-monitor".to_string()));
assert_eq!(log["span"]["kind"], Value::String("peer_rest".to_string()));
let spans = log["spans"].as_array().expect("spans should be present");
assert!(spans.iter().any(|span| {
span.get("name").and_then(Value::as_str) == Some("request-span")
&& span.get("request_id").and_then(Value::as_str) == Some("req-peer-rest")
}));
}
} }
+23 -5
View File
@@ -45,7 +45,7 @@ use tokio_util::sync::CancellationToken;
use tonic::Request; use tonic::Request;
use tonic::service::interceptor::InterceptedService; use tonic::service::interceptor::InterceptedService;
use tonic::transport::Channel; use tonic::transport::Channel;
use tracing::{debug, info, warn}; use tracing::{Instrument, debug, info, warn};
type Client = Arc<Box<dyn PeerS3Client>>; type Client = Arc<Box<dyn PeerS3Client>>;
@@ -596,6 +596,16 @@ pub struct RemotePeerS3Client {
} }
impl RemotePeerS3Client { impl RemotePeerS3Client {
fn recovery_monitor_span(addr: &str) -> tracing::Span {
tracing::info_span!(
"recovery-monitor",
component = "ecstore",
subsystem = "peer_s3_client",
kind = "peer_s3",
addr = %addr
)
}
pub fn new(node: Option<Node>, pools: Option<Vec<usize>>) -> Self { pub fn new(node: Option<Node>, pools: Option<Vec<usize>>) -> Self {
let addr = node.as_ref().map(|v| v.url.to_string()).unwrap_or_default(); let addr = node.as_ref().map(|v| v.url.to_string()).unwrap_or_default();
let client = Self { let client = Self {
@@ -661,10 +671,14 @@ impl RemotePeerS3Client {
let health_clone = Arc::clone(&health); let health_clone = Arc::clone(&health);
let addr_clone = addr.clone(); let addr_clone = addr.clone();
let cancel_clone = cancel_token.clone(); let cancel_clone = cancel_token.clone();
let span = Self::recovery_monitor_span(&addr_clone);
tokio::spawn(async move { tokio::spawn(
async move {
Self::monitor_remote_peer_recovery(addr_clone, health_clone, cancel_clone).await; Self::monitor_remote_peer_recovery(addr_clone, health_clone, cancel_clone).await;
}); }
.instrument(span),
);
} }
} }
} }
@@ -767,9 +781,13 @@ impl RemotePeerS3Client {
let health = Arc::clone(&self.health); let health = Arc::clone(&self.health);
let cancel_token = self.cancel_token.clone(); let cancel_token = self.cancel_token.clone();
let addr = self.addr.clone(); let addr = self.addr.clone();
tokio::spawn(async move { let span = Self::recovery_monitor_span(&addr);
tokio::spawn(
async move {
Self::monitor_remote_peer_recovery(addr, health, cancel_token).await; Self::monitor_remote_peer_recovery(addr, health, cancel_token).await;
}); }
.instrument(span),
);
} }
} }
} }
+275 -8
View File
@@ -65,7 +65,7 @@ use tokio::{
}; };
use tokio_util::sync::CancellationToken; use tokio_util::sync::CancellationToken;
use tonic::{Request, service::interceptor::InterceptedService, transport::Channel}; use tonic::{Request, service::interceptor::InterceptedService, transport::Channel};
use tracing::{debug, warn}; use tracing::{Instrument, debug, warn};
use uuid::Uuid; use uuid::Uuid;
#[derive(Clone, Copy, Debug, Eq, PartialEq)] #[derive(Clone, Copy, Debug, Eq, PartialEq)]
@@ -117,6 +117,17 @@ pub struct RemoteDisk {
} }
impl RemoteDisk { impl RemoteDisk {
fn recovery_monitor_span(addr: &str, endpoint: &Endpoint) -> tracing::Span {
tracing::info_span!(
"recovery-monitor",
component = LOG_COMPONENT_ECSTORE,
subsystem = LOG_SUBSYSTEM_REMOTE_DISK,
kind = "remote_disk",
endpoint = %endpoint,
addr = %addr
)
}
fn is_retryable_walk_dir_error(err: &DiskError) -> bool { fn is_retryable_walk_dir_error(err: &DiskError) -> bool {
if is_network_like_disk_error(err) { if is_network_like_disk_error(err) {
return true; return true;
@@ -239,9 +250,37 @@ impl RemoteDisk {
let endpoint = self.endpoint.clone(); let endpoint = self.endpoint.clone();
let health = Arc::clone(&self.health); let health = Arc::clone(&self.health);
let cancel_token = self.cancel_token.clone(); let cancel_token = self.cancel_token.clone();
tokio::spawn(async move { let span = Self::recovery_monitor_span(&addr, &endpoint);
tokio::spawn(
async move {
Self::monitor_remote_disk_recovery(addr, endpoint, health, cancel_token).await; Self::monitor_remote_disk_recovery(addr, endpoint, health, cancel_token).await;
}); }
.instrument(span),
);
}
#[cfg(test)]
fn spawn_recovery_monitor_log_probe_for_test(&self) -> tokio::sync::oneshot::Receiver<()> {
let (tx, rx) = tokio::sync::oneshot::channel();
let endpoint = self.endpoint.clone();
let addr = self.addr.clone();
let span = Self::recovery_monitor_span(&addr, &endpoint);
tokio::spawn(
async move {
warn!(
event = EVENT_REMOTE_DISK_HEALTH,
component = LOG_COMPONENT_ECSTORE,
subsystem = LOG_SUBSYSTEM_REMOTE_DISK,
endpoint = %endpoint,
addr,
state = "probe",
"remote disk recovery monitor log probe"
);
let _ = tx.send(());
}
.instrument(span),
);
rx
} }
fn mark_suspect_or_offline(&self, reason: &'static str) -> bool { fn mark_suspect_or_offline(&self, reason: &'static str) -> bool {
@@ -295,10 +334,14 @@ impl RemoteDisk {
let addr_clone = addr.clone(); let addr_clone = addr.clone();
let endpoint_clone = endpoint.clone(); let endpoint_clone = endpoint.clone();
let cancel_clone = cancel_token.clone(); let cancel_clone = cancel_token.clone();
let span = Self::recovery_monitor_span(&addr_clone, &endpoint_clone);
tokio::spawn(async move { tokio::spawn(
async move {
Self::monitor_remote_disk_recovery(addr_clone, endpoint_clone, health_clone, cancel_clone).await; Self::monitor_remote_disk_recovery(addr_clone, endpoint_clone, health_clone, cancel_clone).await;
}); }
.instrument(span),
);
} }
loop { loop {
@@ -357,10 +400,14 @@ impl RemoteDisk {
let addr_clone = addr.clone(); let addr_clone = addr.clone();
let endpoint_clone = endpoint.clone(); let endpoint_clone = endpoint.clone();
let cancel_clone = cancel_token.clone(); let cancel_clone = cancel_token.clone();
let span = Self::recovery_monitor_span(&addr_clone, &endpoint_clone);
tokio::spawn(async move { tokio::spawn(
async move {
Self::monitor_remote_disk_recovery(addr_clone, endpoint_clone, health_clone, cancel_clone).await; Self::monitor_remote_disk_recovery(addr_clone, endpoint_clone, health_clone, cancel_clone).await;
}); }
.instrument(span),
);
} }
} }
} }
@@ -375,10 +422,28 @@ impl RemoteDisk {
cancel_token: CancellationToken, cancel_token: CancellationToken,
) { ) {
let mut interval = time::interval(get_drive_returning_probe_interval()); let mut interval = time::interval(get_drive_returning_probe_interval());
debug!(
event = EVENT_REMOTE_DISK_HEALTH,
component = LOG_COMPONENT_ECSTORE,
subsystem = LOG_SUBSYSTEM_REMOTE_DISK,
endpoint = %endpoint,
addr,
state = "recovery_monitor_started",
"Remote disk recovery monitor started"
);
loop { loop {
tokio::select! { tokio::select! {
_ = cancel_token.cancelled() => { _ = cancel_token.cancelled() => {
debug!(
event = EVENT_REMOTE_DISK_HEALTH,
component = LOG_COMPONENT_ECSTORE,
subsystem = LOG_SUBSYSTEM_REMOTE_DISK,
endpoint = %endpoint,
addr,
state = "recovery_monitor_cancelled",
"Remote disk recovery monitor cancelled"
);
return; return;
} }
_ = interval.tick() => { _ = interval.tick() => {
@@ -2200,17 +2265,68 @@ mod tests {
use super::*; use super::*;
use crate::rpc::{InternodeDataTransportCapabilities, TcpHttpInternodeDataTransport}; use crate::rpc::{InternodeDataTransportCapabilities, TcpHttpInternodeDataTransport};
use rustfs_common::GLOBAL_CONN_MAP; use rustfs_common::GLOBAL_CONN_MAP;
use serde_json::Value;
use std::io::{self as std_io, Write};
use std::pin::Pin; use std::pin::Pin;
use std::sync::{Mutex as StdMutex, Once}; use std::sync::{Arc, Mutex, Mutex as StdMutex, Once};
use std::task::{Context, Poll}; use std::task::{Context, Poll};
use tokio::io::{ReadBuf, duplex}; use tokio::io::{ReadBuf, duplex};
use tokio::net::TcpListener; use tokio::net::TcpListener;
use tonic::transport::Endpoint as TonicEndpoint; use tonic::transport::Endpoint as TonicEndpoint;
use tracing::Level; use tracing::Level;
use tracing_subscriber::{Registry, fmt::MakeWriter, layer::SubscriberExt};
use uuid::Uuid; use uuid::Uuid;
static INIT: Once = Once::new(); static INIT: Once = Once::new();
#[derive(Clone, Default)]
struct CapturedLogs {
buffer: Arc<Mutex<Vec<u8>>>,
}
struct CapturedLogWriter {
buffer: Arc<Mutex<Vec<u8>>>,
}
impl CapturedLogs {
fn lines(&self) -> Vec<Value> {
let buffer = self
.buffer
.lock()
.expect("captured logs mutex should not be poisoned")
.clone();
String::from_utf8(buffer)
.expect("captured logs should be valid UTF-8")
.lines()
.map(|line| serde_json::from_str::<Value>(line).expect("captured log line should be valid JSON"))
.collect()
}
}
impl Write for CapturedLogWriter {
fn write(&mut self, buf: &[u8]) -> std_io::Result<usize> {
self.buffer
.lock()
.expect("captured logs mutex should not be poisoned")
.extend_from_slice(buf);
Ok(buf.len())
}
fn flush(&mut self) -> std_io::Result<()> {
Ok(())
}
}
impl<'a> MakeWriter<'a> for CapturedLogs {
type Writer = CapturedLogWriter;
fn make_writer(&'a self) -> Self::Writer {
CapturedLogWriter {
buffer: Arc::clone(&self.buffer),
}
}
}
#[derive(Debug, Clone)] #[derive(Debug, Clone)]
enum RecordedTransportCall { enum RecordedTransportCall {
Read(ReadStreamRequest), Read(ReadStreamRequest),
@@ -3500,4 +3616,155 @@ mod tests {
assert_eq!(endpoint.set_idx, 2); assert_eq!(endpoint.set_idx, 2);
assert_eq!(endpoint.disk_idx, 3); assert_eq!(endpoint.disk_idx, 3);
} }
#[tokio::test(flavor = "current_thread")]
async fn remote_disk_recovery_probe_logs_keep_request_id_span_context() {
let logs = CapturedLogs::default();
let subscriber = Registry::default().with(
tracing_subscriber::fmt::layer()
.with_writer(logs.clone())
.with_ansi(false)
.without_time()
.json()
.flatten_event(true)
.with_current_span(true)
.with_span_list(true),
);
let _guard = tracing::subscriber::set_default(subscriber);
let endpoint = Endpoint {
url: url::Url::parse("http://127.0.0.1:59996/data").expect("endpoint URL should parse"),
is_local: false,
pool_idx: 0,
set_idx: 0,
disk_idx: 0,
};
let remote_disk = RemoteDisk::new(
&endpoint,
&DiskOption {
cleanup: false,
health_check: true,
},
Arc::new(TcpHttpInternodeDataTransport),
)
.await
.expect("remote disk should construct");
let span = tracing::info_span!("request-span", request_id = "req-remote-disk");
let _entered = span.enter();
let done = remote_disk.spawn_recovery_monitor_log_probe_for_test();
done.await
.expect("remote disk recovery monitor probe should signal completion");
let log = logs
.lines()
.into_iter()
.find(|value| value.get("message").and_then(Value::as_str) == Some("remote disk recovery monitor log probe"))
.expect("expected remote disk recovery monitor probe log");
assert_eq!(log["span"]["name"], Value::String("recovery-monitor".to_string()));
assert_eq!(log["span"]["kind"], Value::String("remote_disk".to_string()));
let spans = log["spans"].as_array().expect("spans should be present");
assert!(spans.iter().any(|span| {
span.get("name").and_then(Value::as_str) == Some("request-span")
&& span.get("request_id").and_then(Value::as_str) == Some("req-remote-disk")
}));
}
#[tokio::test(flavor = "current_thread")]
async fn remote_disk_network_error_starts_recovery_monitor_with_request_context() {
let logs = CapturedLogs::default();
let subscriber = Registry::default().with(
tracing_subscriber::fmt::layer()
.with_writer(logs.clone())
.with_ansi(false)
.without_time()
.json()
.flatten_event(true)
.with_current_span(true)
.with_span_list(true),
);
let _guard = tracing::subscriber::set_default(subscriber);
let addr = "http://127.0.0.1:59997".to_string();
let endpoint = Endpoint {
url: url::Url::parse(&format!("{addr}/data")).expect("endpoint URL should parse"),
is_local: false,
pool_idx: 0,
set_idx: 0,
disk_idx: 0,
};
let remote_disk = RemoteDisk::new(
&endpoint,
&DiskOption {
cleanup: false,
health_check: true,
},
Arc::new(TcpHttpInternodeDataTransport),
)
.await
.expect("remote disk should construct");
let span = tracing::info_span!("request-span", request_id = "req-remote-disk-e2e");
let _entered = span.enter();
let err = remote_disk
.execute_with_timeout(
|| async {
Err::<(), Error>(DiskError::Io(std::io::Error::new(
std::io::ErrorKind::ConnectionRefused,
"connection refused",
)))
},
Duration::from_secs(1),
)
.await
.expect_err("network-like operation error should fail");
assert_eq!(
match &err {
DiskError::Io(io_err) => io_err.kind(),
other => panic!("expected io network error, got {other:?}"),
},
std::io::ErrorKind::ConnectionRefused
);
tokio::task::yield_now().await;
tokio::time::sleep(Duration::from_millis(20)).await;
remote_disk.cancel_token.cancel();
tokio::task::yield_now().await;
let lines = logs.lines();
let marked_suspect = lines
.iter()
.find(|value| value.get("state").and_then(Value::as_str) == Some("marked_suspect"))
.expect("expected marked_suspect log");
assert!(
marked_suspect["spans"]
.as_array()
.expect("spans should be present")
.iter()
.any(|span| {
span.get("name").and_then(Value::as_str) == Some("request-span")
&& span.get("request_id").and_then(Value::as_str) == Some("req-remote-disk-e2e")
})
);
let recovery_started = lines
.iter()
.find(|value| value.get("state").and_then(Value::as_str) == Some("recovery_monitor_started"))
.expect("expected recovery_monitor_started log");
assert_eq!(recovery_started["span"]["name"], Value::String("recovery-monitor".to_string()));
assert_eq!(recovery_started["span"]["kind"], Value::String("remote_disk".to_string()));
assert!(
recovery_started["spans"]
.as_array()
.expect("spans should be present")
.iter()
.any(|span| {
span.get("name").and_then(Value::as_str) == Some("request-span")
&& span.get("request_id").and_then(Value::as_str) == Some("req-remote-disk-e2e")
})
);
}
} }
+6 -3
View File
@@ -127,7 +127,7 @@ use tokio::{
}; };
use tokio_util::sync::CancellationToken; use tokio_util::sync::CancellationToken;
use tracing::error; use tracing::error;
use tracing::{debug, info, warn}; use tracing::{Instrument, debug, info, warn};
use uuid::Uuid; use uuid::Uuid;
const LOG_COMPONENT_ECSTORE: &str = "ecstore"; const LOG_COMPONENT_ECSTORE: &str = "ecstore";
@@ -1491,7 +1491,8 @@ impl SetDisks {
if !pending.is_empty() { if !pending.is_empty() {
let cleanup_requests = requests.clone(); let cleanup_requests = requests.clone();
let lockers = self.lockers.clone(); let lockers = self.lockers.clone();
let handle = tokio::spawn(async move { let handle = tokio::spawn(
async move {
let mut late_lock_ids_by_client = vec![Vec::new(); lockers.len()]; let mut late_lock_ids_by_client = vec![Vec::new(); lockers.len()];
let mut pending = pending; let mut pending = pending;
while let Some(join_result) = pending.join_next().await { while let Some(join_result) = pending.join_next().await {
@@ -1539,7 +1540,9 @@ impl SetDisks {
} }
})) }))
.await; .await;
}); }
.instrument(tracing::Span::current()),
);
drop(handle); drop(handle);
} }
+22 -10
View File
@@ -40,7 +40,7 @@ use std::sync::Arc;
use tokio::sync::broadcast::{self}; use tokio::sync::broadcast::{self};
use tokio::sync::mpsc::{self, Receiver, Sender}; use tokio::sync::mpsc::{self, Receiver, Sender};
use tokio_util::sync::CancellationToken; use tokio_util::sync::CancellationToken;
use tracing::{error, info, warn}; use tracing::{Instrument, error, info, warn};
use uuid::Uuid; use uuid::Uuid;
const MAX_OBJECT_LIST: i32 = 1000; const MAX_OBJECT_LIST: i32 = 1000;
@@ -710,7 +710,8 @@ impl ECStore {
let cancel_rx1 = cancel.clone(); let cancel_rx1 = cancel.clone();
let cancel_rx1_for_err = cancel_rx1.clone(); let cancel_rx1_for_err = cancel_rx1.clone();
let err_tx1 = err_tx.clone(); let err_tx1 = err_tx.clone();
let job1 = tokio::spawn(async move { let job1 = tokio::spawn(
async move {
let mut opts = opts; let mut opts = opts;
opts.stop_disk_at_limit = true; opts.stop_disk_at_limit = true;
if let Err(err) = store.list_merged(cancel_rx1, opts, sender).await if let Err(err) = store.list_merged(cancel_rx1, opts, sender).await
@@ -719,14 +720,17 @@ impl ECStore {
error!("list_merged err {:?}", err); error!("list_merged err {:?}", err);
let _ = err_tx1.send(Arc::new(err)); let _ = err_tx1.send(Arc::new(err));
} }
}); }
.instrument(tracing::Span::current()),
);
let cancel_rx2 = cancel.clone(); let cancel_rx2 = cancel.clone();
let (result_tx, mut result_rx) = mpsc::channel(1); let (result_tx, mut result_rx) = mpsc::channel(1);
let err_tx2 = err_tx.clone(); let err_tx2 = err_tx.clone();
let opts = o.clone(); let opts = o.clone();
let job2 = tokio::spawn(async move { let job2 = tokio::spawn(
async move {
if let Err(err) = gather_results(cancel_rx2, opts, recv, result_tx).await { if let Err(err) = gather_results(cancel_rx2, opts, recv, result_tx).await {
error!("gather_results err {:?}", err); error!("gather_results err {:?}", err);
let _ = err_tx2.send(Arc::new(err)); let _ = err_tx2.send(Arc::new(err));
@@ -734,7 +738,9 @@ impl ECStore {
// cancel call exit spawns // cancel call exit spawns
cancel.cancel(); cancel.cancel();
}); }
.instrument(tracing::Span::current()),
);
let mut result = { let mut result = {
// receiver result // receiver result
@@ -815,11 +821,14 @@ impl ECStore {
} }
} }
tokio::spawn(async move { tokio::spawn(
async move {
if let Err(err) = merge_entry_channels(rx, inputs, sender.clone(), 1).await { if let Err(err) = merge_entry_channels(rx, inputs, sender.clone(), 1).await {
error!("merge_entry_channels err {:?}", err) error!("merge_entry_channels err {:?}", err)
} }
}); }
.instrument(tracing::Span::current()),
);
// let merge_res = merge_entry_channels(rx, inputs, sender.clone(), 1).await; // let merge_res = merge_entry_channels(rx, inputs, sender.clone(), 1).await;
@@ -1007,7 +1016,8 @@ impl ECStore {
Err(_) => None, Err(_) => None,
}; };
tokio::spawn(async move { tokio::spawn(
async move {
let mut sent_err = false; let mut sent_err = false;
while let Some(entry) = merge_rx.recv().await { while let Some(entry) = merge_rx.recv().await {
if opts.latest_only { if opts.latest_only {
@@ -1108,9 +1118,11 @@ impl ECStore {
} }
} }
} }
}); }
.instrument(tracing::Span::current()),
);
tokio::spawn(async move { merge_entry_channels(rx, inputs, merge_tx, 1).await }); tokio::spawn(async move { merge_entry_channels(rx, inputs, merge_tx, 1).await }.instrument(tracing::Span::current()));
let walk_results = join_all(futures).await; let walk_results = join_all(futures).await;
let mut errs = Vec::new(); let mut errs = Vec::new();
+1 -1
View File
@@ -61,6 +61,7 @@ opentelemetry-otlp = { workspace = true }
opentelemetry-semantic-conventions = { workspace = true } opentelemetry-semantic-conventions = { workspace = true }
percent-encoding = { workspace = true } percent-encoding = { workspace = true }
serde = { workspace = true } serde = { workspace = true }
serde_json = { workspace = true }
tracing = { workspace = true, features = ["std", "attributes"] } tracing = { workspace = true, features = ["std", "attributes"] }
tracing-appender = { workspace = true } tracing-appender = { workspace = true }
tracing-error = { workspace = true } tracing-error = { workspace = true }
@@ -83,4 +84,3 @@ jemalloc_pprof = { workspace = true, optional = true }
tokio = { workspace = true, features = ["full"] } tokio = { workspace = true, features = ["full"] }
tempfile = { workspace = true } tempfile = { workspace = true }
temp-env = { workspace = true } temp-env = { workspace = true }
serde_json = { workspace = true }
+171 -11
View File
@@ -48,13 +48,19 @@ use rustfs_config::observability::{
DEFAULT_OBS_LOG_ZSTD_WORKERS, DEFAULT_OBS_LOG_ZSTD_WORKERS,
}; };
use rustfs_config::{APP_NAME, DEFAULT_LOG_KEEP_FILES, DEFAULT_LOG_ROTATION_TIME, DEFAULT_OBS_LOG_STDOUT_ENABLED}; use rustfs_config::{APP_NAME, DEFAULT_LOG_KEEP_FILES, DEFAULT_LOG_ROTATION_TIME, DEFAULT_OBS_LOG_STDOUT_ENABLED};
use serde_json::Value as JsonValue;
use std::sync::Arc; use std::sync::Arc;
use std::{collections::BTreeMap, fmt};
use std::{fs, io::IsTerminal, time::Duration}; use std::{fs, io::IsTerminal, time::Duration};
use tracing::Subscriber; use tracing::Subscriber;
use tracing::{info, warn}; use tracing::{info, warn};
use tracing_error::ErrorLayer; use tracing_error::ErrorLayer;
use tracing_subscriber::{ use tracing_subscriber::{
fmt::{format::FmtSpan, time::LocalTime}, fmt::{
FormatEvent,
format::{FmtSpan, Format, Json, JsonFields, Writer},
time::LocalTime,
},
layer::SubscriberExt, layer::SubscriberExt,
registry::LookupSpan, registry::LookupSpan,
util::SubscriberInitExt, util::SubscriberInitExt,
@@ -65,6 +71,73 @@ const LOG_SUBSYSTEM_LOCAL_LOGGING: &str = "local_logging";
const EVENT_LOCAL_LOGGING_STATE: &str = "local_logging_state"; const EVENT_LOCAL_LOGGING_STATE: &str = "local_logging_state";
const EVENT_LOG_CLEANER_STATE: &str = "log_cleaner_state"; const EVENT_LOG_CLEANER_STATE: &str = "log_cleaner_state";
const STDERR_WARNING_PREFIX: &str = "[WARN]"; const STDERR_WARNING_PREFIX: &str = "[WARN]";
const REQUEST_ID: &str = "request-id";
#[derive(Clone, Debug)]
struct RequestIdJsonFormat<T> {
inner: Format<Json, T>,
}
impl<T> RequestIdJsonFormat<T> {
fn new(inner: Format<Json, T>) -> Self {
Self { inner }
}
}
impl<S, T> FormatEvent<S, JsonFields> for RequestIdJsonFormat<T>
where
S: Subscriber + for<'lookup> LookupSpan<'lookup>,
T: tracing_subscriber::fmt::time::FormatTime,
{
fn format_event(
&self,
ctx: &tracing_subscriber::fmt::FmtContext<'_, S, JsonFields>,
mut writer: Writer<'_>,
event: &tracing::Event<'_>,
) -> fmt::Result {
let mut buffer = String::new();
self.inner.format_event(ctx, Writer::new(&mut buffer), event)?;
let request_id = span_scope_request_id(ctx, event);
if request_id.is_none() {
return writer.write_str(&buffer);
}
let trimmed = buffer.trim_end();
let mut payload: JsonValue = serde_json::from_str(trimmed).map_err(|_| fmt::Error)?;
if let Some(object) = payload.as_object_mut() {
object
.entry(REQUEST_ID.to_string())
.or_insert_with(|| JsonValue::String(request_id.expect("checked is_some")));
}
let serialized = serde_json::to_string(&payload).map_err(|_| fmt::Error)?;
writer.write_str(&serialized)?;
writer.write_char('\n')
}
}
fn span_scope_request_id<S>(
ctx: &tracing_subscriber::fmt::FmtContext<'_, S, JsonFields>,
event: &tracing::Event<'_>,
) -> Option<String>
where
S: Subscriber + for<'lookup> LookupSpan<'lookup>,
{
let current_span = event.parent().and_then(|id| ctx.span(id)).or_else(|| ctx.lookup_current())?;
let mut request_id = None;
for span in current_span.scope().from_root() {
let extensions = span.extensions();
let formatted_fields = extensions.get::<tracing_subscriber::fmt::FormattedFields<JsonFields>>()?;
let fields: BTreeMap<String, JsonValue> = serde_json::from_str(&formatted_fields.fields).ok()?;
if let Some(value) = fields.get(REQUEST_ID).and_then(JsonValue::as_str) {
request_id = Some(value.to_string());
}
}
request_id
}
pub(super) fn build_json_log_layer<S, W>(writer: W, enable_ansi: bool, span_events: FmtSpan) -> impl tracing_subscriber::Layer<S> pub(super) fn build_json_log_layer<S, W>(writer: W, enable_ansi: bool, span_events: FmtSpan) -> impl tracing_subscriber::Layer<S>
where where
@@ -81,9 +154,11 @@ where
.with_line_number(true) .with_line_number(true)
.with_writer(writer) .with_writer(writer)
.json() .json()
.flatten_event(true)
.with_current_span(true) .with_current_span(true)
.with_span_list(true) .with_span_list(true)
.with_span_events(span_events) .with_span_events(span_events)
.map_event_format(RequestIdJsonFormat::new)
} }
/// Initialize local logging (stdout-only or file-rolling). /// Initialize local logging (stdout-only or file-rolling).
@@ -520,7 +595,7 @@ pub fn spawn_cleanup_task(
} }
Ok(Err(e)) => { Ok(Err(e)) => {
counter!(METRIC_LOG_CLEANER_RUN_FAILURES_TOTAL).increment(1); counter!(METRIC_LOG_CLEANER_RUN_FAILURES_TOTAL).increment(1);
tracing::warn!( warn!(
event = EVENT_LOG_CLEANER_STATE, event = EVENT_LOG_CLEANER_STATE,
component = LOG_COMPONENT_OBS, component = LOG_COMPONENT_OBS,
subsystem = LOG_SUBSYSTEM_LOCAL_LOGGING, subsystem = LOG_SUBSYSTEM_LOCAL_LOGGING,
@@ -531,7 +606,7 @@ pub fn spawn_cleanup_task(
} }
Err(e) => { Err(e) => {
counter!(METRIC_LOG_CLEANER_RUN_FAILURES_TOTAL).increment(1); counter!(METRIC_LOG_CLEANER_RUN_FAILURES_TOTAL).increment(1);
tracing::warn!( warn!(
event = EVENT_LOG_CLEANER_STATE, event = EVENT_LOG_CLEANER_STATE,
component = LOG_COMPONENT_OBS, component = LOG_COMPONENT_OBS,
subsystem = LOG_SUBSYSTEM_LOCAL_LOGGING, subsystem = LOG_SUBSYSTEM_LOCAL_LOGGING,
@@ -593,7 +668,7 @@ mod tests {
let subscriber = Registry::default().with(layer); let subscriber = Registry::default().with(layer);
tracing::subscriber::with_default(subscriber, || { tracing::subscriber::with_default(subscriber, || {
tracing::info!(component = "obs_contract_test", sink = "stdout", "hello world"); info!(component = "obs_contract_test", sink = "stdout", "hello world");
}); });
let raw = String::from_utf8( let raw = String::from_utf8(
@@ -609,6 +684,55 @@ mod tests {
(raw, parsed) (raw, parsed)
} }
fn render_json_log_with_request_span() -> Value {
let writer = SharedWriter::default();
let layer = build_json_log_layer(writer.clone(), false, FmtSpan::NONE);
let subscriber = Registry::default().with(layer);
tracing::subscriber::with_default(subscriber, || {
let span = tracing::info_span!("http-request", request_id = "req-123", method = "GET");
let _guard = span.enter();
info!(component = "obs_contract_test", message = "inside request span");
});
let raw = String::from_utf8(
writer
.inner
.lock()
.expect("shared writer lock should not be poisoned")
.clone(),
)
.expect("log output should be valid UTF-8");
let first_line = raw.lines().next().expect("expected one JSON log line");
serde_json::from_str(first_line).expect("log line should be valid JSON")
}
fn render_json_log_with_recovery_monitor_child_span() -> Value {
let writer = SharedWriter::default();
let layer = build_json_log_layer(writer.clone(), false, FmtSpan::NONE);
let subscriber = Registry::default().with(layer);
tracing::subscriber::with_default(subscriber, || {
let request_span = tracing::info_span!("request-span", request_id = "req-parent", method = "GET");
let _request_guard = request_span.enter();
let recovery_span =
tracing::info_span!("recovery-monitor", kind = "remote_disk", endpoint = "http://127.0.0.1:9000/data");
let _recovery_guard = recovery_span.enter();
warn!(component = "obs_contract_test", message = "inside recovery monitor");
});
let raw = String::from_utf8(
writer
.inner
.lock()
.expect("shared writer lock should not be poisoned")
.clone(),
)
.expect("log output should be valid UTF-8");
let first_line = raw.lines().next().expect("expected one JSON log line");
serde_json::from_str(first_line).expect("log line should be valid JSON")
}
#[test] #[test]
/// Invalid file names should be reported as errors instead of panicking. /// Invalid file names should be reported as errors instead of panicking.
fn test_init_file_logging_invalid_filename_does_not_panic() { fn test_init_file_logging_invalid_filename_does_not_panic() {
@@ -661,9 +785,9 @@ mod tests {
assert!(!raw.contains('\u{1b}'), "JSON log output must not contain ANSI escape sequences: {raw}"); assert!(!raw.contains('\u{1b}'), "JSON log output must not contain ANSI escape sequences: {raw}");
assert_eq!(parsed.get("level").and_then(Value::as_str), Some("INFO")); assert_eq!(parsed.get("level").and_then(Value::as_str), Some("INFO"));
assert_eq!(parsed["fields"]["message"], Value::String("hello world".to_string())); assert_eq!(parsed["message"], Value::String("hello world".to_string()));
assert_eq!(parsed["fields"]["component"], Value::String("obs_contract_test".to_string())); assert_eq!(parsed["component"], Value::String("obs_contract_test".to_string()));
assert_eq!(parsed["fields"]["sink"], Value::String("stdout".to_string())); assert_eq!(parsed["sink"], Value::String("stdout".to_string()));
assert!(parsed.get("target").is_some(), "expected target field in JSON log output"); assert!(parsed.get("target").is_some(), "expected target field in JSON log output");
} }
@@ -686,18 +810,54 @@ mod tests {
.collect::<BTreeSet<_>>(); .collect::<BTreeSet<_>>();
assert_eq!(plain_keys, color_keys, "top-level JSON log keys must stay stable across sinks"); assert_eq!(plain_keys, color_keys, "top-level JSON log keys must stay stable across sinks");
let plain_field_keys = plain["fields"] let plain_field_keys = plain
.as_object() .as_object()
.expect("plain JSON log fields should be an object") .expect("plain JSON log should be an object")
.keys() .keys()
.filter(|key| {
!matches!(
key.as_str(),
"timestamp" | "level" | "target" | "filename" | "line_number" | "threadName" | "threadId"
)
})
.cloned() .cloned()
.collect::<BTreeSet<_>>(); .collect::<BTreeSet<_>>();
let color_field_keys = color["fields"] let color_field_keys = color
.as_object() .as_object()
.expect("color JSON log fields should be an object") .expect("color JSON log should be an object")
.keys() .keys()
.filter(|key| {
!matches!(
key.as_str(),
"timestamp" | "level" | "target" | "filename" | "line_number" | "threadName" | "threadId"
)
})
.cloned() .cloned()
.collect::<BTreeSet<_>>(); .collect::<BTreeSet<_>>();
assert_eq!(plain_field_keys, color_field_keys, "structured field keys must stay stable across sinks"); assert_eq!(plain_field_keys, color_field_keys, "structured field keys must stay stable across sinks");
} }
#[test]
fn test_json_log_layer_promotes_request_id_from_current_span() {
let parsed = render_json_log_with_request_span();
assert_eq!(parsed["request_id"], Value::String("req-123".to_string()));
assert_eq!(parsed["message"], Value::String("inside request span".to_string()));
assert_eq!(parsed["span"]["request_id"], Value::String("req-123".to_string()));
}
#[test]
fn test_json_log_layer_promotes_parent_request_id_for_recovery_monitor_child_span() {
let parsed = render_json_log_with_recovery_monitor_child_span();
assert_eq!(parsed["request_id"], Value::String("req-parent".to_string()));
assert_eq!(parsed["message"], Value::String("inside recovery monitor".to_string()));
assert_eq!(parsed["span"]["name"], Value::String("recovery-monitor".to_string()));
assert_eq!(parsed["span"]["kind"], Value::String("remote_disk".to_string()));
let spans = parsed["spans"].as_array().expect("spans should be present");
assert!(spans.iter().any(|span| {
span.get("name").and_then(Value::as_str) == Some("request-span")
&& span.get("request_id").and_then(Value::as_str) == Some("req-parent")
}));
}
} }
+6 -2
View File
@@ -40,6 +40,7 @@ use std::collections::HashMap;
use std::sync::atomic::AtomicU64; use std::sync::atomic::AtomicU64;
use std::sync::{Arc, LazyLock}; use std::sync::{Arc, LazyLock};
use tokio::sync::Semaphore; use tokio::sync::Semaphore;
use tracing::Instrument;
use uuid::Uuid; use uuid::Uuid;
/// Permits available to the fire-and-forget AbortMultipartUpload tasks /// Permits available to the fire-and-forget AbortMultipartUpload tasks
@@ -1086,7 +1087,8 @@ impl<S: StorageBackend + Send + Sync + 'static> Drop for SftpDriver<S> {
} }
}; };
tokio::spawn(async move { tokio::spawn(
async move {
let _permit = permit; let _permit = permit;
tracing::warn!( tracing::warn!(
bucket = %bucket, bucket = %bucket,
@@ -1167,7 +1169,9 @@ impl<S: StorageBackend + Send + Sync + 'static> Drop for SftpDriver<S> {
); );
} }
} }
}); }
.instrument(tracing::Span::current()),
);
} }
} }
} }
+11 -4
View File
@@ -35,7 +35,7 @@ use std::time::Duration;
use tokio::net::TcpListener; use tokio::net::TcpListener;
use tokio::sync::{broadcast, watch}; use tokio::sync::{broadcast, watch};
use tokio_rustls::TlsAcceptor; use tokio_rustls::TlsAcceptor;
use tracing::{debug, error, info, warn}; use tracing::{Instrument, debug, error, info, info_span, warn};
const LOG_COMPONENT_PROTOCOLS: &str = "protocols"; const LOG_COMPONENT_PROTOCOLS: &str = "protocols";
const LOG_SUBSYSTEM_WEBDAV_SERVER: &str = "webdav_server"; const LOG_SUBSYSTEM_WEBDAV_SERVER: &str = "webdav_server";
@@ -144,9 +144,14 @@ where
let tls_acceptor = tls_acceptor.clone(); let tls_acceptor = tls_acceptor.clone();
let max_body_size = self.config.max_body_size; let max_body_size = self.config.max_body_size;
tokio::spawn(async move {
let source_ip: IpAddr = addr.ip(); let source_ip: IpAddr = addr.ip();
let span = info_span!(
"webdav-connection",
peer = %source_ip,
transport = if tls_acceptor.is_some() { "tls" } else { "tcp" },
);
tokio::spawn(
async move {
if let Some(acceptor) = tls_acceptor { if let Some(acceptor) = tls_acceptor {
match acceptor.accept(stream).await { match acceptor.accept(stream).await {
Ok(tls_stream) => { Ok(tls_stream) => {
@@ -191,7 +196,9 @@ where
); );
} }
} }
}); }
.instrument(span),
);
} }
Err(e) => { Err(e) => {
error!( error!(
+186 -3
View File
@@ -15,7 +15,11 @@
use crate::admin::handlers::health::{HealthProbe, build_health_response_parts, collect_dependency_readiness}; use crate::admin::handlers::health::{HealthProbe, build_health_response_parts, collect_dependency_readiness};
use crate::license::has_valid_license; use crate::license::has_valid_license;
use crate::server::has_path_prefix; use crate::server::has_path_prefix;
use crate::server::{CONSOLE_PREFIX, FAVICON_PATH, HEALTH_PREFIX, HEALTH_READY_PATH, LICENSE, RUSTFS_ADMIN_PREFIX, VERSION}; use crate::server::{
CONSOLE_PREFIX, FAVICON_PATH, HEALTH_PREFIX, HEALTH_READY_PATH, HeaderMapCarrier, LICENSE, RUSTFS_ADMIN_PREFIX,
RequestContextLayer, VERSION,
};
use crate::storage::request_context::RequestContext;
use crate::version::build; use crate::version::build;
use axum::{ use axum::{
Json, Router, Json, Router,
@@ -27,6 +31,7 @@ use axum::{
}; };
use http::{HeaderMap, HeaderName, HeaderValue, Method, StatusCode, Uri}; use http::{HeaderMap, HeaderName, HeaderValue, Method, StatusCode, Uri};
use mime_guess::from_path; use mime_guess::from_path;
use opentelemetry::global;
use rust_embed::RustEmbed; use rust_embed::RustEmbed;
use serde::Serialize; use serde::Serialize;
use std::{ use std::{
@@ -41,7 +46,8 @@ use tower_http::limit::RequestBodyLimitLayer;
use tower_http::request_id::{MakeRequestUuid, PropagateRequestIdLayer, SetRequestIdLayer}; use tower_http::request_id::{MakeRequestUuid, PropagateRequestIdLayer, SetRequestIdLayer};
use tower_http::timeout::TimeoutLayer; use tower_http::timeout::TimeoutLayer;
use tower_http::trace::TraceLayer; use tower_http::trace::TraceLayer;
use tracing::{debug, error, info, instrument, warn}; use tracing::{Span, debug, error, info, instrument, warn};
use tracing_opentelemetry::OpenTelemetrySpanExt;
#[derive(RustEmbed)] #[derive(RustEmbed)]
#[folder = "$CARGO_MANIFEST_DIR/static"] #[folder = "$CARGO_MANIFEST_DIR/static"]
@@ -491,9 +497,45 @@ fn setup_console_middleware_stack(
// Add comprehensive middleware layers using tower-http features // Add comprehensive middleware layers using tower-http features
app = app app = app
.layer(CatchPanicLayer::new()) .layer(CatchPanicLayer::new())
.layer(
TraceLayer::new_for_http()
.make_span_with(|request: &Request| {
let request_context = request.extensions().get::<RequestContext>();
let request_id = request_context.map(|ctx| ctx.request_id.as_str()).unwrap_or("unknown");
let trace_id = request_context.and_then(|ctx| ctx.trace_id.as_deref()).unwrap_or("unknown");
let span_id = request_context.and_then(|ctx| ctx.span_id.as_deref()).unwrap_or("unknown");
let parent_context = global::get_text_map_propagator(|propagator| {
propagator.extract(&HeaderMapCarrier::new(request.headers()))
});
let span = tracing::info_span!(
"console-request",
request_id = %request_id,
trace_id = %trace_id,
span_id = %span_id,
method = %request.method(),
uri = %request.uri(),
status_code = tracing::field::Empty,
);
if span.is_disabled() {
return span;
}
if let Err(err) = span.set_parent(parent_context) {
debug!(error = ?err, "Failed to propagate tracing context for console request");
}
span
})
.on_response(|response: &Response, _latency: Duration, span: &Span| {
span.record("status_code", tracing::field::display(response.status()));
}),
)
.layer(PropagateRequestIdLayer::x_request_id()) .layer(PropagateRequestIdLayer::x_request_id())
.layer(RequestContextLayer)
.layer(SetRequestIdLayer::x_request_id(MakeRequestUuid)) .layer(SetRequestIdLayer::x_request_id(MakeRequestUuid))
.layer(TraceLayer::new_for_http())
// Compress responses // Compress responses
.layer(CompressionLayer::new()) .layer(CompressionLayer::new())
.layer(middleware::from_fn(console_logging_middleware)) .layer(middleware::from_fn(console_logging_middleware))
@@ -684,12 +726,47 @@ pub(crate) fn make_console_server() -> Router {
mod tests { mod tests {
use super::*; use super::*;
use axum::body::Body; use axum::body::Body;
use axum::routing::get;
use http::{Request, StatusCode}; use http::{Request, StatusCode};
use http_body_util::BodyExt; use http_body_util::BodyExt;
use serial_test::serial; use serial_test::serial;
use std::io;
use std::net::{IpAddr, Ipv4Addr}; use std::net::{IpAddr, Ipv4Addr};
use std::sync::{Arc, Mutex};
use temp_env::async_with_vars; use temp_env::async_with_vars;
use tower::ServiceExt; use tower::ServiceExt;
use tracing_subscriber::{Registry, layer::SubscriberExt};
#[derive(Clone, Default)]
struct SharedWriter {
inner: Arc<Mutex<Vec<u8>>>,
}
struct SharedWriterGuard {
inner: Arc<Mutex<Vec<u8>>>,
}
impl<'writer> tracing_subscriber::fmt::MakeWriter<'writer> for SharedWriter {
type Writer = SharedWriterGuard;
fn make_writer(&'writer self) -> Self::Writer {
SharedWriterGuard {
inner: Arc::clone(&self.inner),
}
}
}
impl io::Write for SharedWriterGuard {
fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
let mut inner = self.inner.lock().expect("shared writer lock should not be poisoned");
inner.extend_from_slice(buf);
Ok(buf.len())
}
fn flush(&mut self) -> io::Result<()> {
Ok(())
}
}
#[test] #[test]
fn console_api_base_url_keeps_rustfs_admin_prefix() { fn console_api_base_url_keeps_rustfs_admin_prefix() {
@@ -739,6 +816,112 @@ mod tests {
); );
} }
#[tokio::test(flavor = "current_thread")]
async fn console_trace_layer_records_request_id_on_current_span() {
let writer = SharedWriter::default();
let subscriber = Registry::default().with(
tracing_subscriber::fmt::layer()
.without_time()
.with_target(false)
.with_level(false)
.with_ansi(false)
.json()
.flatten_event(true)
.with_current_span(true)
.with_span_list(true)
.with_writer(writer.clone()),
);
let _guard = tracing::subscriber::set_default(subscriber);
let app = Router::new()
.route(
"/trace-test",
get(|| async {
tracing::info!("console handler log");
StatusCode::OK
}),
)
.layer(
TraceLayer::new_for_http()
.make_span_with(|request: &http::Request<_>| {
let request_context = request.extensions().get::<RequestContext>();
let request_id = request_context.map(|ctx| ctx.request_id.as_str()).unwrap_or("unknown");
let trace_id = request_context.and_then(|ctx| ctx.trace_id.as_deref()).unwrap_or("unknown");
let span_id = request_context.and_then(|ctx| ctx.span_id.as_deref()).unwrap_or("unknown");
let parent_context = global::get_text_map_propagator(|propagator| {
propagator.extract(&HeaderMapCarrier::new(request.headers()))
});
let span = tracing::info_span!(
"console-request",
request_id = %request_id,
trace_id = %trace_id,
span_id = %span_id,
method = %request.method(),
uri = %request.uri(),
status_code = tracing::field::Empty,
);
if span.is_disabled() {
return span;
}
if let Err(err) = span.set_parent(parent_context) {
debug!(error = ?err, "Failed to propagate tracing context for console request");
}
span
})
.on_response(|response: &Response, _latency: Duration, span: &Span| {
span.record("status_code", tracing::field::display(response.status()));
}),
)
.layer(RequestContextLayer)
.layer(SetRequestIdLayer::x_request_id(MakeRequestUuid));
app.oneshot(
Request::builder()
.uri("/trace-test")
.body(Body::empty())
.expect("failed to build trace test request"),
)
.await
.expect("trace test request should complete");
let output = String::from_utf8(
writer
.inner
.lock()
.expect("shared writer lock should not be poisoned")
.clone(),
)
.expect("console trace log output should be valid UTF-8");
let log = output
.lines()
.map(|line| serde_json::from_str::<serde_json::Value>(line).expect("console log line should be valid JSON"))
.find(|value| value.get("message").and_then(serde_json::Value::as_str) == Some("console handler log"))
.expect("expected console handler log entry");
assert_eq!(log["span"]["method"], serde_json::Value::String("GET".to_string()));
assert_eq!(log["span"]["name"], serde_json::Value::String("console-request".to_string()));
assert!(
log.get("span")
.and_then(|span| span.get("request_id"))
.and_then(serde_json::Value::as_str)
.is_some(),
"{output}"
);
assert_ne!(
log.get("span")
.and_then(|span| span.get("request_id"))
.and_then(serde_json::Value::as_str),
Some("unknown"),
"{output}"
);
}
/// Regression: when no console CORS origins are configured (the new /// Regression: when no console CORS origins are configured (the new
/// default), the layer must NOT emit `Access-Control-Allow-Origin`, so /// default), the layer must NOT emit `Access-Control-Allow-Origin`, so
/// browsers treat responses as same-origin only. /// browsers treat responses as same-origin only.
+4 -4
View File
@@ -17,6 +17,7 @@ use crate::admin::router::{AdminOperation, Operation, S3Router};
use crate::app::context::resolve_object_store_handle; use crate::app::context::resolve_object_store_handle;
use crate::server::ADMIN_PREFIX; use crate::server::ADMIN_PREFIX;
use crate::server::RemoteAddr; use crate::server::RemoteAddr;
use crate::storage::request_context::spawn_traced;
use bytes::Bytes; use bytes::Bytes;
use http::{HeaderMap, HeaderValue, Uri}; use http::{HeaderMap, HeaderValue, Uri};
use hyper::{Method, StatusCode}; use hyper::{Method, StatusCode};
@@ -34,7 +35,6 @@ use s3s::{Body, S3Request, S3Response, S3Result, s3_error};
use serde::{Deserialize, Serialize}; use serde::{Deserialize, Serialize};
use std::path::PathBuf; use std::path::PathBuf;
use time::{OffsetDateTime, format_description::well_known::Rfc3339}; use time::{OffsetDateTime, format_description::well_known::Rfc3339};
use tokio::spawn;
use tokio::sync::mpsc; use tokio::sync::mpsc;
use tracing::{info, warn}; use tracing::{info, warn};
@@ -395,7 +395,7 @@ impl Operation for HealHandler {
let tx_clone = tx.clone(); let tx_clone = tx.clone();
let heal_path_str = heal_path.to_str().unwrap_or_default().to_string(); let heal_path_str = heal_path.to_str().unwrap_or_default().to_string();
let client_token = hip.client_token.clone(); let client_token = hip.client_token.clone();
spawn(async move { spawn_traced(async move {
match rustfs_common::heal_channel::query_heal_status(heal_path_str, client_token).await { match rustfs_common::heal_channel::query_heal_status(heal_path_str, client_token).await {
Ok(response) if response.success => { Ok(response) if response.success => {
let (summary, items) = heal_channel_response_status(&response); let (summary, items) = heal_channel_response_status(&response);
@@ -445,7 +445,7 @@ impl Operation for HealHandler {
let client_token = hip.client_token.clone(); let client_token = hip.client_token.clone();
let client_address = client_address.clone(); let client_address = client_address.clone();
let heal_settings = hip.hs; let heal_settings = hip.hs;
spawn(async move { spawn_traced(async move {
match rustfs_common::heal_channel::cancel_heal_task(heal_path_str, client_token.clone()).await { match rustfs_common::heal_channel::cancel_heal_task(heal_path_str, client_token.clone()).await {
Ok(response) if response.success => { Ok(response) if response.success => {
let resp_bytes = if client_token.is_empty() { let resp_bytes = if client_token.is_empty() {
@@ -495,7 +495,7 @@ impl Operation for HealHandler {
// Use new heal channel mechanism // Use new heal channel mechanism
let tx_clone = tx.clone(); let tx_clone = tx.clone();
let client_address = client_address.clone(); let client_address = client_address.clone();
spawn(async move { spawn_traced(async move {
// Create heal request through channel // Create heal request through channel
let heal_request = build_heal_channel_request(&hip); let heal_request = build_heal_channel_request(&hip);
let client_token = heal_request.id.clone(); let client_token = heal_request.id.clone();
+3 -2
View File
@@ -19,6 +19,7 @@
//! exposition endpoint. //! exposition endpoint.
use crate::admin::router::Operation; use crate::admin::router::Operation;
use crate::storage::request_context::spawn_traced;
use bytes::Bytes; use bytes::Bytes;
use futures::{Stream, StreamExt}; use futures::{Stream, StreamExt};
use http::{HeaderMap, HeaderValue, Uri}; use http::{HeaderMap, HeaderValue, Uri};
@@ -35,9 +36,9 @@ use std::collections::{HashMap, HashSet};
use std::pin::Pin; use std::pin::Pin;
use std::task::{Context, Poll}; use std::task::{Context, Poll};
use std::time::Duration as StdDuration; use std::time::Duration as StdDuration;
use tokio::select;
use tokio::sync::mpsc; use tokio::sync::mpsc;
use tokio::time::interval; use tokio::time::interval;
use tokio::{select, spawn};
use tokio_stream::wrappers::ReceiverStream; use tokio_stream::wrappers::ReceiverStream;
use tracing::{debug, error, warn}; use tracing::{debug, error, warn};
@@ -217,7 +218,7 @@ impl Operation for MetricsHandler {
}); });
let body = Body::from(in_stream); let body = Body::from(in_stream);
spawn(async move { spawn_traced(async move {
while n > 0 { while n > 0 {
let mut metrics = RealtimeMetrics::default(); let mut metrics = RealtimeMetrics::default();
let local_metrics = collect_local_metrics(types, &opts).await; let local_metrics = collect_local_metrics(types, &opts).await;
+2 -2
View File
@@ -21,6 +21,7 @@ use crate::{
app::context::{resolve_object_store_handle, resolve_tier_config_handle}, app::context::{resolve_object_store_handle, resolve_tier_config_handle},
auth::{check_key_valid, get_session_token}, auth::{check_key_valid, get_session_token},
server::{ADMIN_PREFIX, RemoteAddr}, server::{ADMIN_PREFIX, RemoteAddr},
storage::request_context::spawn_traced,
}; };
use http::Uri; use http::Uri;
use http::{HeaderMap, StatusCode}; use http::{HeaderMap, StatusCode};
@@ -54,7 +55,6 @@ use s3s::{
use serde_urlencoded::from_bytes; use serde_urlencoded::from_bytes;
use std::collections::HashMap; use std::collections::HashMap;
use time::OffsetDateTime; use time::OffsetDateTime;
use tokio::spawn;
use tracing::{debug, warn}; use tracing::{debug, warn};
const LOG_COMPONENT_ADMIN: &str = "admin"; const LOG_COMPONENT_ADMIN: &str = "admin";
@@ -91,7 +91,7 @@ pub struct AddTier {}
fn spawn_transition_tier_config_propagation(action: &'static str) { fn spawn_transition_tier_config_propagation(action: &'static str) {
if let Some(notification_sys) = get_global_notification_sys() { if let Some(notification_sys) = get_global_notification_sys() {
spawn(async move { spawn_traced(async move {
for peer_result in notification_sys.load_transition_tier_config().await { for peer_result in notification_sys.load_transition_tier_config().await {
if let Some(err) = peer_result.err { if let Some(err) = peer_result.err {
warn!( warn!(
+2 -1
View File
@@ -23,6 +23,7 @@ use crate::server::{
ADMIN_PREFIX, HEALTH_PREFIX, HEALTH_READY_PATH, MINIO_ADMIN_PREFIX, PROFILE_CPU_PATH, PROFILE_MEMORY_PATH, is_admin_path, ADMIN_PREFIX, HEALTH_PREFIX, HEALTH_READY_PATH, MINIO_ADMIN_PREFIX, PROFILE_CPU_PATH, PROFILE_MEMORY_PATH, is_admin_path,
}; };
use crate::storage::access::{ReqInfo, authorize_request}; use crate::storage::access::{ReqInfo, authorize_request};
use crate::storage::request_context::spawn_traced;
use aws_sdk_s3::primitives::ByteStream as AwsByteStream; use aws_sdk_s3::primitives::ByteStream as AwsByteStream;
use bytes::Bytes; use bytes::Bytes;
use futures::{Stream, StreamExt}; use futures::{Stream, StreamExt};
@@ -1310,7 +1311,7 @@ fn build_listen_notification_response(uri: &Uri, bucket: Option<&str>) -> S3Resu
inner: ReceiverStream::new(rx), inner: ReceiverStream::new(rx),
}); });
tokio::spawn(async move { spawn_traced(async move {
let mut ticker = tokio::time::interval(interval_duration); let mut ticker = tokio::time::interval(interval_duration);
let mut peer_ticker = tokio::time::interval(LISTEN_NOTIFICATION_PEER_POLL_INTERVAL); let mut peer_ticker = tokio::time::interval(LISTEN_NOTIFICATION_PEER_POLL_INTERVAL);
// Skip the immediate first tick so behavior starts after interval duration. // Skip the immediate first tick so behavior starts after interval duration.
+2
View File
@@ -41,7 +41,9 @@ pub use service_state::ShutdownSignal;
pub use service_state::wait_for_shutdown; pub use service_state::wait_for_shutdown;
// Items only used within the library crate (admin handlers, server/http.rs, etc.). // Items only used within the library crate (admin handlers, server/http.rs, etc.).
pub(crate) use http::HeaderMapCarrier;
pub(crate) use http::active_http_requests; pub(crate) use http::active_http_requests;
pub(crate) use layer::RequestContextLayer;
pub(crate) use module_switch::{ pub(crate) use module_switch::{
ModuleSwitchSnapshot, ModuleSwitchSource, PersistedModuleSwitches, current_module_switch_snapshot, ModuleSwitchSnapshot, ModuleSwitchSource, PersistedModuleSwitches, current_module_switch_snapshot,
refresh_persisted_module_switches_from_store, save_persisted_module_switches_to_store, validate_module_switch_update, refresh_persisted_module_switches_from_store, save_persisted_module_switches_to_store, validate_module_switch_update,
+2 -1
View File
@@ -13,6 +13,7 @@
// limitations under the License. // limitations under the License.
use crate::server::RPC_PREFIX; use crate::server::RPC_PREFIX;
use crate::storage::request_context::spawn_traced;
use bytes::{Bytes, BytesMut}; use bytes::{Bytes, BytesMut};
use futures_util::TryStreamExt; use futures_util::TryStreamExt;
use http::{HeaderMap, Method, Request, Response, StatusCode, Uri}; use http::{HeaderMap, Method, Request, Response, StatusCode, Uri};
@@ -243,7 +244,7 @@ async fn handle_walk_dir(req: Request<Incoming>) -> Response<Body> {
}; };
let (rd, mut wd) = tokio::io::duplex(DEFAULT_READ_BUFFER_SIZE); let (rd, mut wd) = tokio::io::duplex(DEFAULT_READ_BUFFER_SIZE);
tokio::spawn(async move { spawn_traced(async move {
if let Err(e) = disk.walk_dir(args, &mut wd).await { if let Err(e) = disk.walk_dir(args, &mut wd).await {
warn!(error = %e, "walk_dir failed"); warn!(error = %e, "walk_dir failed");
} }
+1 -1
View File
@@ -77,7 +77,7 @@ fi
# export RUSTFS_TLS_PATH="./deploy/certs" # export RUSTFS_TLS_PATH="./deploy/certs"
# Observability related configuration # Observability related configuration
export RUSTFS_OBS_ENDPOINT=http://localhost:4318 # OpenTelemetry Collector address #export RUSTFS_OBS_ENDPOINT=http://localhost:4318 # OpenTelemetry Collector address
# RustFS OR OTEL exporter configuration # RustFS OR OTEL exporter configuration
#export RUSTFS_OBS_TRACE_ENDPOINT=http://localhost:4318/v1/traces # OpenTelemetry Collector trace address http://localhost:4318/v1/traces #export RUSTFS_OBS_TRACE_ENDPOINT=http://localhost:4318/v1/traces # OpenTelemetry Collector trace address http://localhost:4318/v1/traces
#export OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://localhost:14318/v1/traces #export OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://localhost:14318/v1/traces