gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-08-27 15:37:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak in Cache update method (#1143)

Browse Source
This commit is contained in:
sunfkny
2025-12-15 10:04:14 +08:00
committed by GitHub
parent 3ba415740e
commit e8fe9731fd
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/filemeta/src/metacache.rs
+7 -1
View File
@@ -831,10 +831,16 @@ impl<T: Clone + Debug + Send + 'static> Cache<T> {
} }
} }
#[allow(unsafe_code)]
async fn update(&self) -> std::io::Result<()> { async fn update(&self) -> std::io::Result<()> {
match (self.update_fn)().await { match (self.update_fn)().await {
Ok(val) => { Ok(val) => {
self.val.store(Box::into_raw(Box::new(val)), AtomicOrdering::SeqCst); let old = self.val.swap(Box::into_raw(Box::new(val)), AtomicOrdering::SeqCst);
if !old.is_null() {
unsafe {
drop(Box::from_raw(old));
}
}
let now = SystemTime::now() let now = SystemTime::now()
.duration_since(UNIX_EPOCH) .duration_since(UNIX_EPOCH)
.expect("Time went backwards") .expect("Time went backwards")