From dd35538e90c27653a02188685edf3e648eb08573 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=AE=89=E6=AD=A3=E8=B6=85?= Date: Wed, 20 May 2026 11:59:34 +0800 Subject: [PATCH] fix(ecstore): remove stale disk TODOs (#3022) --- crates/ecstore/src/disk/disk_store.rs | 2 -- crates/ecstore/src/disk/local.rs | 3 ++- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/crates/ecstore/src/disk/disk_store.rs b/crates/ecstore/src/disk/disk_store.rs index c4650eb04..ed664e394 100644 --- a/crates/ecstore/src/disk/disk_store.rs +++ b/crates/ecstore/src/disk/disk_store.rs @@ -557,8 +557,6 @@ impl LocalDiskWrapper { /// Monitor disk writability periodically async fn monitor_disk_writable(disk: Arc, health: Arc, cancel_token: CancellationToken) { - // TODO: config interval - let mut interval = time::interval(get_drive_active_check_interval()); loop { diff --git a/crates/ecstore/src/disk/local.rs b/crates/ecstore/src/disk/local.rs index f3c474129..fd3261002 100644 --- a/crates/ecstore/src/disk/local.rs +++ b/crates/ecstore/src/disk/local.rs @@ -3051,7 +3051,6 @@ impl DiskAPI for LocalDisk { #[tracing::instrument(skip(self))] async fn disk_info(&self, _: &DiskInfoOptions) -> Result { let mut info = Cache::get(self.disk_info_cache.clone()).await?; - // TODO: nr_requests, rotational info.nr_requests = self.nrrequests; info.rotational = self.rotational; info.mount_path = self.path().to_str().unwrap().to_string(); @@ -3719,6 +3718,8 @@ mod test { assert!(!disk_info.fs_type.is_empty(), "fs_type should not be empty on this platform"); assert!(disk_info.total > 0); assert!(disk_info.free <= disk_info.total); + assert_eq!(disk_info.nr_requests, disk.nrrequests); + assert_eq!(disk_info.rotational, disk.rotational); assert!(!disk_info.mount_path.is_empty()); assert!(!disk_info.endpoint.is_empty());