mirror of
https://github.com/rustfs/rustfs.git
synced 2026-08-20 19:42:17 +00:00
test(admin-auth): add unit and e2e coverage for the admin authorization gate (#4717)
test(admin-auth): unit + e2e coverage for the admin authorization gate Adds the first tests for the central admin authorization gate `rustfs/src/admin/auth.rs`, which previously had zero coverage (backlog#1151 sec-4, master plan #1155). Unit tests (rustfs/src/admin/auth.rs): - Refactor the two `validate_admin_request*` entry points to share a single generic decision core `evaluate_admin_actions<S: Store>` / `check_admin_request_auth<S: Store>` (removes the duplicated action-loop and makes the gate testable without a running cluster). - Cover: owner/root credential allowed; authenticated non-admin credential denied with AccessDenied; missing credential denied; and the multi-action loop grants on any permitted action, denies when none pass. Backed by an in-memory empty IamSys so the owner path short-circuits to allow and every other principal resolves to deny. E2E (crates/e2e_test/src/admin_auth_test.rs, raw SigV4 over HTTP, no awscurl dependency): - non_admin_credential_denied_on_admin_api: a limited IAM user gets 403 AccessDenied on GET /rustfs/admin/v3/info while root succeeds. - root_credential_rotation_takes_effect: restart with rotated --access-key/--secret-key; new credential works and the stale one is rejected, on both the admin plane and the S3 data plane. - default_credentials_emit_startup_warning: booting with the default rustfsadmin credentials emits the default-credentials warning. Refs rustfs/backlog#1151 (sec-4), #1155.
This commit is contained in:
@@ -0,0 +1,319 @@
|
|||||||
|
// Copyright 2024 RustFS Team
|
||||||
|
//
|
||||||
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
// you may not use this file except in compliance with the License.
|
||||||
|
// You may obtain a copy of the License at
|
||||||
|
//
|
||||||
|
// http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
//
|
||||||
|
// Unless required by applicable law or agreed to in writing, software
|
||||||
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
// See the License for the specific language governing permissions and
|
||||||
|
// limitations under the License.
|
||||||
|
|
||||||
|
//! Negative / lifecycle e2e coverage for the central admin authorization gate
|
||||||
|
//! (`rustfs/src/admin/auth.rs`), tracking rustfs/backlog#1151 sec-4.
|
||||||
|
//!
|
||||||
|
//! These tests exercise the gate end-to-end against a real server, using raw
|
||||||
|
//! SigV4-signed HTTP (no `awscurl` dependency) so the exact HTTP status and S3
|
||||||
|
//! error code are asserted:
|
||||||
|
//!
|
||||||
|
//! 1. A fully authenticated but non-admin credential is rejected with
|
||||||
|
//! `403 AccessDenied` on an admin API (`GET /rustfs/admin/v3/info`), while
|
||||||
|
//! the root credential is accepted — proving the rejection is authorization,
|
||||||
|
//! not a broken endpoint.
|
||||||
|
//! 2. Root-credential rotation takes effect across a restart: the new
|
||||||
|
//! credential is accepted and the old credential is rejected, on both the
|
||||||
|
//! S3 data plane and the admin plane.
|
||||||
|
//! 3. Starting with the default `rustfsadmin` credentials emits the
|
||||||
|
//! default-credentials startup warning (observable operator signal).
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use crate::common::{RustFSTestEnvironment, init_logging, local_http_client, rustfs_binary_path};
|
||||||
|
use aws_sdk_s3::config::{Credentials, Region};
|
||||||
|
use aws_sdk_s3::{Client, Config};
|
||||||
|
use http::header::HOST;
|
||||||
|
use rustfs_signer::constants::UNSIGNED_PAYLOAD;
|
||||||
|
use rustfs_signer::sign_v4;
|
||||||
|
use s3s::Body;
|
||||||
|
use serial_test::serial;
|
||||||
|
use std::error::Error;
|
||||||
|
use std::io::Read;
|
||||||
|
use std::process::{Command, Stdio};
|
||||||
|
use std::sync::{Arc, Mutex};
|
||||||
|
use std::time::{Duration, Instant};
|
||||||
|
|
||||||
|
const ADMIN_INFO_PATH: &str = "/rustfs/admin/v3/info";
|
||||||
|
|
||||||
|
/// Send a SigV4-signed request to `path` (optionally with a JSON `body`) and
|
||||||
|
/// return `(status, body)`. Uses the `UNSIGNED_PAYLOAD` content hash so a
|
||||||
|
/// request body can be attached without the caller pre-hashing it — the
|
||||||
|
/// server verifies the signature against the same sentinel, exactly as the
|
||||||
|
/// AWS SDKs / MinIO client do for streaming/unsigned payloads.
|
||||||
|
async fn signed_request(
|
||||||
|
base_url: &str,
|
||||||
|
method: http::Method,
|
||||||
|
path: &str,
|
||||||
|
body: Option<&str>,
|
||||||
|
access_key: &str,
|
||||||
|
secret_key: &str,
|
||||||
|
) -> Result<(reqwest::StatusCode, String), Box<dyn Error + Send + Sync>> {
|
||||||
|
let url = format!("{base_url}{path}");
|
||||||
|
let uri = url.parse::<http::Uri>()?;
|
||||||
|
let authority = uri.authority().ok_or("missing authority")?.to_string();
|
||||||
|
let body_bytes = body.map(|b| b.as_bytes().to_vec()).unwrap_or_default();
|
||||||
|
|
||||||
|
// The signature is computed over `UNSIGNED_PAYLOAD`, so the body bytes do
|
||||||
|
// not participate in the SigV4 hash — sign over an empty body and attach
|
||||||
|
// the real payload to the wire request below.
|
||||||
|
let request = http::Request::builder()
|
||||||
|
.method(method.clone())
|
||||||
|
.uri(uri)
|
||||||
|
.header(HOST, authority)
|
||||||
|
.header("x-amz-content-sha256", UNSIGNED_PAYLOAD);
|
||||||
|
let signed = sign_v4(request.body(Body::empty())?, 0, access_key, secret_key, "", "us-east-1");
|
||||||
|
|
||||||
|
let client = local_http_client();
|
||||||
|
let mut rb = client.request(method, url.as_str());
|
||||||
|
for (name, value) in signed.headers() {
|
||||||
|
rb = rb.header(name, value);
|
||||||
|
}
|
||||||
|
if !body_bytes.is_empty() {
|
||||||
|
rb = rb.body(body_bytes);
|
||||||
|
}
|
||||||
|
let resp = rb.send().await?;
|
||||||
|
let status = resp.status();
|
||||||
|
let text = resp.text().await?;
|
||||||
|
Ok((status, text))
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Build an S3 client bound to explicit credentials (used to exercise the S3
|
||||||
|
/// data plane with rotated / stale root credentials).
|
||||||
|
fn s3_client_with(env: &RustFSTestEnvironment, access_key: &str, secret_key: &str) -> Client {
|
||||||
|
let credentials = Credentials::new(access_key, secret_key, None, None, "sec4-admin-auth");
|
||||||
|
let config = Config::builder()
|
||||||
|
.credentials_provider(credentials)
|
||||||
|
.region(Region::new("us-east-1"))
|
||||||
|
.endpoint_url(&env.url)
|
||||||
|
.force_path_style(true)
|
||||||
|
.behavior_version_latest()
|
||||||
|
.build();
|
||||||
|
Client::from_conf(config)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Create a non-admin IAM user via the admin `add-user` API using the root
|
||||||
|
/// credentials. The user is created with no policy attached, so it is a
|
||||||
|
/// valid (authenticatable) principal that is nonetheless unauthorized for
|
||||||
|
/// admin actions.
|
||||||
|
async fn create_limited_user(
|
||||||
|
env: &RustFSTestEnvironment,
|
||||||
|
access_key: &str,
|
||||||
|
secret_key: &str,
|
||||||
|
) -> Result<(), Box<dyn Error + Send + Sync>> {
|
||||||
|
let path = format!("/rustfs/admin/v3/add-user?accessKey={access_key}");
|
||||||
|
let body = serde_json::json!({ "secretKey": secret_key, "status": "enabled" }).to_string();
|
||||||
|
let (status, resp) =
|
||||||
|
signed_request(&env.url, http::Method::PUT, &path, Some(&body), &env.access_key, &env.secret_key).await?;
|
||||||
|
assert!(status.is_success(), "add-user should succeed (status={status}, body={resp})");
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A fully authenticated but non-admin credential must be rejected with
|
||||||
|
/// `403 AccessDenied` on an admin API, while the root credential succeeds.
|
||||||
|
#[tokio::test(flavor = "multi_thread")]
|
||||||
|
#[serial]
|
||||||
|
async fn non_admin_credential_denied_on_admin_api() -> Result<(), Box<dyn Error + Send + Sync>> {
|
||||||
|
init_logging();
|
||||||
|
let mut env = RustFSTestEnvironment::new().await?;
|
||||||
|
env.start_rustfs_server(vec![]).await?;
|
||||||
|
|
||||||
|
let user_ak = "sec4limited";
|
||||||
|
let user_sk = "sec4limitedsecret";
|
||||||
|
create_limited_user(&env, user_ak, user_sk).await?;
|
||||||
|
|
||||||
|
// Root credential is authorized: proves the endpoint works.
|
||||||
|
let (root_status, root_body) =
|
||||||
|
signed_request(&env.url, http::Method::GET, ADMIN_INFO_PATH, None, &env.access_key, &env.secret_key).await?;
|
||||||
|
assert_eq!(
|
||||||
|
root_status,
|
||||||
|
reqwest::StatusCode::OK,
|
||||||
|
"root credential must be authorized on the admin API, body: {root_body}"
|
||||||
|
);
|
||||||
|
|
||||||
|
// Non-admin credential is rejected by the admin authorization gate.
|
||||||
|
let (status, body) = signed_request(&env.url, http::Method::GET, ADMIN_INFO_PATH, None, user_ak, user_sk).await?;
|
||||||
|
assert_eq!(
|
||||||
|
status,
|
||||||
|
reqwest::StatusCode::FORBIDDEN,
|
||||||
|
"non-admin credential must get 403 on the admin API, body: {body}"
|
||||||
|
);
|
||||||
|
assert!(
|
||||||
|
body.contains("AccessDenied"),
|
||||||
|
"admin gate rejection must carry the AccessDenied S3 error code, body: {body}"
|
||||||
|
);
|
||||||
|
|
||||||
|
env.stop_server();
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Rotating the root credentials (restart with new `--access-key` /
|
||||||
|
/// `--secret-key` on the same data directory) takes effect: the new
|
||||||
|
/// credential is accepted and the old one is rejected, on both the S3 data
|
||||||
|
/// plane and the admin plane.
|
||||||
|
#[tokio::test(flavor = "multi_thread")]
|
||||||
|
#[serial]
|
||||||
|
async fn root_credential_rotation_takes_effect() -> Result<(), Box<dyn Error + Send + Sync>> {
|
||||||
|
init_logging();
|
||||||
|
let mut env = RustFSTestEnvironment::new().await?;
|
||||||
|
|
||||||
|
let old_ak = env.access_key.clone();
|
||||||
|
let old_sk = env.secret_key.clone();
|
||||||
|
|
||||||
|
// --- Boot with the original root credential. ---
|
||||||
|
env.start_rustfs_server(vec![]).await?;
|
||||||
|
|
||||||
|
// Admin plane accepts the original root credential.
|
||||||
|
let (status, body) = signed_request(&env.url, http::Method::GET, ADMIN_INFO_PATH, None, &old_ak, &old_sk).await?;
|
||||||
|
assert_eq!(status, reqwest::StatusCode::OK, "original root must reach admin API, body: {body}");
|
||||||
|
// S3 plane accepts the original root credential.
|
||||||
|
s3_client_with(&env, &old_ak, &old_sk)
|
||||||
|
.list_buckets()
|
||||||
|
.send()
|
||||||
|
.await
|
||||||
|
.expect("original root must be able to list buckets on the S3 plane");
|
||||||
|
|
||||||
|
env.stop_server();
|
||||||
|
|
||||||
|
// --- Rotate: restart on the same data dir with a new root credential. ---
|
||||||
|
let new_ak = "rotatedroot";
|
||||||
|
let new_sk = "rotatedrootsecret";
|
||||||
|
env.access_key = new_ak.to_string();
|
||||||
|
env.secret_key = new_sk.to_string();
|
||||||
|
env.start_rustfs_server(vec![]).await?;
|
||||||
|
|
||||||
|
// New root credential works on both planes.
|
||||||
|
let (status, body) = signed_request(&env.url, http::Method::GET, ADMIN_INFO_PATH, None, new_ak, new_sk).await?;
|
||||||
|
assert_eq!(status, reqwest::StatusCode::OK, "rotated root must reach admin API, body: {body}");
|
||||||
|
s3_client_with(&env, new_ak, new_sk)
|
||||||
|
.list_buckets()
|
||||||
|
.send()
|
||||||
|
.await
|
||||||
|
.expect("rotated root must be able to list buckets on the S3 plane");
|
||||||
|
|
||||||
|
// Old root credential is now rejected on both planes.
|
||||||
|
let (status, body) = signed_request(&env.url, http::Method::GET, ADMIN_INFO_PATH, None, &old_ak, &old_sk).await?;
|
||||||
|
assert_eq!(
|
||||||
|
status,
|
||||||
|
reqwest::StatusCode::FORBIDDEN,
|
||||||
|
"stale root must be rejected on the admin API after rotation, body: {body}"
|
||||||
|
);
|
||||||
|
let s3_old = s3_client_with(&env, &old_ak, &old_sk).list_buckets().send().await;
|
||||||
|
assert!(
|
||||||
|
s3_old.is_err(),
|
||||||
|
"stale root must be rejected on the S3 plane after rotation, got: {s3_old:?}"
|
||||||
|
);
|
||||||
|
|
||||||
|
env.stop_server();
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Booting with the default `rustfsadmin` credentials must emit the
|
||||||
|
/// default-credentials startup warning so operators get an observable
|
||||||
|
/// signal. The predicate + message text are unit-tested in
|
||||||
|
/// `rustfs::startup_server`; this pins that the warning actually fires at
|
||||||
|
/// runtime. We capture the child's stdout/stderr directly (the shared
|
||||||
|
/// harness inherits stdio) and poll for the warning until it appears.
|
||||||
|
#[tokio::test(flavor = "multi_thread")]
|
||||||
|
#[serial]
|
||||||
|
async fn default_credentials_emit_startup_warning() -> Result<(), Box<dyn Error + Send + Sync>> {
|
||||||
|
init_logging();
|
||||||
|
|
||||||
|
let port = RustFSTestEnvironment::find_available_port().await?;
|
||||||
|
let address = format!("127.0.0.1:{port}");
|
||||||
|
let temp_dir = std::env::temp_dir().join(format!("rustfs_sec4_defcred_{}_{}", std::process::id(), port));
|
||||||
|
std::fs::create_dir_all(&temp_dir)?;
|
||||||
|
let temp_dir_str = temp_dir.display().to_string();
|
||||||
|
|
||||||
|
let mut child = Command::new(rustfs_binary_path())
|
||||||
|
.env("RUST_LOG", "rustfs=info")
|
||||||
|
.env("RUSTFS_CONSOLE_ENABLE", "false")
|
||||||
|
.args([
|
||||||
|
"--address",
|
||||||
|
&address,
|
||||||
|
// Explicitly the compiled-in defaults, so the warning must fire.
|
||||||
|
"--access-key",
|
||||||
|
"rustfsadmin",
|
||||||
|
"--secret-key",
|
||||||
|
"rustfsadmin",
|
||||||
|
&temp_dir_str,
|
||||||
|
])
|
||||||
|
.stdout(Stdio::piped())
|
||||||
|
.stderr(Stdio::piped())
|
||||||
|
.spawn()?;
|
||||||
|
|
||||||
|
// Drain stdout + stderr concurrently into a shared buffer so a full
|
||||||
|
// pipe never blocks the child.
|
||||||
|
let captured = Arc::new(Mutex::new(String::new()));
|
||||||
|
let mut readers = Vec::new();
|
||||||
|
for stream in [
|
||||||
|
child.stdout.take().map(|s| Box::new(s) as Box<dyn Read + Send>),
|
||||||
|
child.stderr.take().map(|s| Box::new(s) as Box<dyn Read + Send>),
|
||||||
|
]
|
||||||
|
.into_iter()
|
||||||
|
.flatten()
|
||||||
|
{
|
||||||
|
let sink = Arc::clone(&captured);
|
||||||
|
readers.push(std::thread::spawn(move || {
|
||||||
|
let mut stream = stream;
|
||||||
|
let mut buf = [0u8; 4096];
|
||||||
|
loop {
|
||||||
|
match stream.read(&mut buf) {
|
||||||
|
Ok(0) | Err(_) => break,
|
||||||
|
Ok(n) => {
|
||||||
|
if let Ok(mut guard) = sink.lock() {
|
||||||
|
guard.push_str(&String::from_utf8_lossy(&buf[..n]));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}));
|
||||||
|
}
|
||||||
|
|
||||||
|
const WARNING_NEEDLE: &str = "Detected default root credentials";
|
||||||
|
let deadline = Instant::now() + Duration::from_secs(30);
|
||||||
|
let mut seen = false;
|
||||||
|
while Instant::now() < deadline {
|
||||||
|
if let Ok(Some(status)) = child.try_wait() {
|
||||||
|
// Process exited; make a final check of what we captured.
|
||||||
|
seen = captured.lock().map(|g| g.contains(WARNING_NEEDLE)).unwrap_or(false);
|
||||||
|
assert!(
|
||||||
|
seen,
|
||||||
|
"server exited ({status}) before emitting the default-credentials warning; captured: {}",
|
||||||
|
captured.lock().map(|g| g.clone()).unwrap_or_default()
|
||||||
|
);
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
if captured.lock().map(|g| g.contains(WARNING_NEEDLE)).unwrap_or(false) {
|
||||||
|
seen = true;
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
tokio::time::sleep(Duration::from_millis(200)).await;
|
||||||
|
}
|
||||||
|
|
||||||
|
let _ = child.kill();
|
||||||
|
let _ = child.wait();
|
||||||
|
for r in readers {
|
||||||
|
let _ = r.join();
|
||||||
|
}
|
||||||
|
let _ = std::fs::remove_dir_all(&temp_dir);
|
||||||
|
|
||||||
|
assert!(
|
||||||
|
seen,
|
||||||
|
"starting with default credentials must emit the default-credentials warning; captured: {}",
|
||||||
|
captured.lock().map(|g| g.clone()).unwrap_or_default()
|
||||||
|
);
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -62,6 +62,10 @@ mod bucket_policy_check_test;
|
|||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod security_boundary_test;
|
mod security_boundary_test;
|
||||||
|
|
||||||
|
// Admin authorization gate: non-admin denial + root-credential lifecycle (backlog#1151 sec-4)
|
||||||
|
#[cfg(test)]
|
||||||
|
mod admin_auth_test;
|
||||||
|
|
||||||
/// IAM / bucket / STS session policy with `s3:ExistingObjectTag` conditions (E2E).
|
/// IAM / bucket / STS session policy with `s3:ExistingObjectTag` conditions (E2E).
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod existing_object_tag_policy_test;
|
mod existing_object_tag_policy_test;
|
||||||
|
|||||||
+292
-14
@@ -16,7 +16,7 @@ use crate::auth::get_condition_values;
|
|||||||
use http::HeaderMap;
|
use http::HeaderMap;
|
||||||
use http::Uri;
|
use http::Uri;
|
||||||
use rustfs_credentials::Credentials;
|
use rustfs_credentials::Credentials;
|
||||||
use rustfs_iam::store::object::ObjectStore;
|
use rustfs_iam::store::Store;
|
||||||
use rustfs_iam::sys::IamSys;
|
use rustfs_iam::sys::IamSys;
|
||||||
use rustfs_policy::policy::{Args, action::Action};
|
use rustfs_policy::policy::{Args, action::Action};
|
||||||
use s3s::{S3Result, s3_error};
|
use s3s::{S3Result, s3_error};
|
||||||
@@ -67,8 +67,22 @@ pub async fn validate_admin_request(
|
|||||||
remote_addr,
|
remote_addr,
|
||||||
};
|
};
|
||||||
|
|
||||||
for action in &actions {
|
evaluate_admin_actions(iam_store, &ctx, &actions, "", "").await
|
||||||
if check_admin_request_auth(iam_store.clone(), &ctx, *action, "", "")
|
}
|
||||||
|
|
||||||
|
/// Return `Ok(())` as soon as any of the candidate `actions` is allowed for the
|
||||||
|
/// request context, otherwise `AccessDenied`. This is the single decision core
|
||||||
|
/// shared by every admin-gate entry point; unit tests exercise it directly so
|
||||||
|
/// the allow/deny contract does not silently drift.
|
||||||
|
async fn evaluate_admin_actions<S: Store>(
|
||||||
|
iam_store: Arc<IamSys<S>>,
|
||||||
|
ctx: &AuthContext<'_>,
|
||||||
|
actions: &[Action],
|
||||||
|
bucket: &str,
|
||||||
|
object: &str,
|
||||||
|
) -> S3Result<()> {
|
||||||
|
for action in actions {
|
||||||
|
if check_admin_request_auth(iam_store.clone(), ctx, *action, bucket, object)
|
||||||
.await
|
.await
|
||||||
.is_ok()
|
.is_ok()
|
||||||
{
|
{
|
||||||
@@ -78,8 +92,8 @@ pub async fn validate_admin_request(
|
|||||||
Err(s3_error!(AccessDenied, "Access Denied"))
|
Err(s3_error!(AccessDenied, "Access Denied"))
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn check_admin_request_auth(
|
async fn check_admin_request_auth<S: Store>(
|
||||||
iam_store: Arc<IamSys<ObjectStore>>,
|
iam_store: Arc<IamSys<S>>,
|
||||||
ctx: &AuthContext<'_>,
|
ctx: &AuthContext<'_>,
|
||||||
action: Action,
|
action: Action,
|
||||||
bucket: &str,
|
bucket: &str,
|
||||||
@@ -157,15 +171,7 @@ pub async fn validate_admin_request_with_bucket_object(
|
|||||||
remote_addr,
|
remote_addr,
|
||||||
};
|
};
|
||||||
|
|
||||||
for action in &actions {
|
evaluate_admin_actions(iam_store, &ctx, &actions, resource.bucket, resource.object).await
|
||||||
if check_admin_request_auth(iam_store.clone(), &ctx, *action, resource.bucket, resource.object)
|
|
||||||
.await
|
|
||||||
.is_ok()
|
|
||||||
{
|
|
||||||
return Ok(());
|
|
||||||
}
|
|
||||||
}
|
|
||||||
Err(s3_error!(AccessDenied, "Access Denied"))
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Unified authentication request handler for both UI and CLI
|
/// Unified authentication request handler for both UI and CLI
|
||||||
@@ -224,3 +230,275 @@ pub async fn authenticate_request(
|
|||||||
|
|
||||||
result
|
result
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
//! Unit coverage for the central admin authorization gate (rustfs/backlog#1151 sec-4).
|
||||||
|
//!
|
||||||
|
//! These tests pin the allow/deny contract of the gate decision core without a
|
||||||
|
//! running cluster. The gate delegates the actual policy evaluation to
|
||||||
|
//! `IamSys::is_allowed`; the behavior owned *here* is: owner/root short-circuits
|
||||||
|
//! to allow, any other principal with no matching policy is denied with
|
||||||
|
//! `AccessDenied`, and `evaluate_admin_actions` grants access as soon as any one
|
||||||
|
//! candidate action is permitted. We drive that with an `IamSys` backed by an
|
||||||
|
//! empty in-memory cache so `is_owner=true` returns allow (owner short-circuit)
|
||||||
|
//! and every non-owner principal resolves to deny.
|
||||||
|
use super::*;
|
||||||
|
use rustfs_iam::cache::Cache;
|
||||||
|
use rustfs_iam::manager::IamCache;
|
||||||
|
use rustfs_iam::store::{GroupInfo, MappedPolicy, UserType};
|
||||||
|
use rustfs_policy::auth::UserIdentity;
|
||||||
|
use rustfs_policy::policy::PolicyDoc;
|
||||||
|
use rustfs_policy::policy::action::AdminAction;
|
||||||
|
use serde::Serialize;
|
||||||
|
use serde::de::DeserializeOwned;
|
||||||
|
use std::collections::HashMap;
|
||||||
|
use std::sync::atomic::{AtomicBool, AtomicI64, AtomicU8, AtomicU64};
|
||||||
|
|
||||||
|
/// A `Store` whose methods are never invoked by these tests: the gate only
|
||||||
|
/// reaches the persistence layer for non-owner principals, and the
|
||||||
|
/// `IamCache` we build starts with an empty in-memory snapshot, so
|
||||||
|
/// `get_user` resolves to `None` (unknown user) before any `api` call.
|
||||||
|
#[derive(Clone)]
|
||||||
|
struct EmptyStore;
|
||||||
|
|
||||||
|
#[async_trait::async_trait]
|
||||||
|
impl Store for EmptyStore {
|
||||||
|
fn has_watcher(&self) -> bool {
|
||||||
|
false
|
||||||
|
}
|
||||||
|
async fn save_iam_config<Item: Serialize + Send>(
|
||||||
|
&self,
|
||||||
|
_item: Item,
|
||||||
|
_path: impl AsRef<str> + Send,
|
||||||
|
) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn load_iam_config<Item: DeserializeOwned>(
|
||||||
|
&self,
|
||||||
|
_path: impl AsRef<str> + Send,
|
||||||
|
) -> rustfs_iam::error::Result<Item> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn delete_iam_config(&self, _path: impl AsRef<str> + Send) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn save_user_identity(
|
||||||
|
&self,
|
||||||
|
_name: &str,
|
||||||
|
_user_type: UserType,
|
||||||
|
_item: UserIdentity,
|
||||||
|
_ttl: Option<usize>,
|
||||||
|
) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn delete_user_identity(&self, _name: &str, _user_type: UserType) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn load_user_identity(&self, _name: &str, _user_type: UserType) -> rustfs_iam::error::Result<UserIdentity> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn load_user(
|
||||||
|
&self,
|
||||||
|
_name: &str,
|
||||||
|
_user_type: UserType,
|
||||||
|
_m: &mut HashMap<String, UserIdentity>,
|
||||||
|
) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn load_users(
|
||||||
|
&self,
|
||||||
|
_user_type: UserType,
|
||||||
|
_m: &mut HashMap<String, UserIdentity>,
|
||||||
|
) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn load_secret_key(&self, _name: &str, _user_type: UserType) -> rustfs_iam::error::Result<String> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn save_group_info(&self, _name: &str, _item: GroupInfo) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn delete_group_info(&self, _name: &str) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn load_group(&self, _name: &str, _m: &mut HashMap<String, GroupInfo>) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn load_groups(&self, _m: &mut HashMap<String, GroupInfo>) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn save_policy_doc(&self, _name: &str, _item: PolicyDoc) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn delete_policy_doc(&self, _name: &str) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn load_policy(&self, _name: &str) -> rustfs_iam::error::Result<PolicyDoc> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn load_policy_doc(&self, _name: &str, _m: &mut HashMap<String, PolicyDoc>) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn load_policy_docs(&self, _m: &mut HashMap<String, PolicyDoc>) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn save_mapped_policy(
|
||||||
|
&self,
|
||||||
|
_name: &str,
|
||||||
|
_user_type: UserType,
|
||||||
|
_is_group: bool,
|
||||||
|
_item: MappedPolicy,
|
||||||
|
_ttl: Option<usize>,
|
||||||
|
) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn delete_mapped_policy(
|
||||||
|
&self,
|
||||||
|
_name: &str,
|
||||||
|
_user_type: UserType,
|
||||||
|
_is_group: bool,
|
||||||
|
) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn load_mapped_policy(
|
||||||
|
&self,
|
||||||
|
_name: &str,
|
||||||
|
_user_type: UserType,
|
||||||
|
_is_group: bool,
|
||||||
|
_m: &mut HashMap<String, MappedPolicy>,
|
||||||
|
) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn load_mapped_policies(
|
||||||
|
&self,
|
||||||
|
_user_type: UserType,
|
||||||
|
_is_group: bool,
|
||||||
|
_m: &mut HashMap<String, MappedPolicy>,
|
||||||
|
) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
async fn load_all(&self, _cache: &Cache) -> rustfs_iam::error::Result<()> {
|
||||||
|
unimplemented!("EmptyStore is not exercised by the admin-auth gate tests")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Build an `IamSys` backed by an empty in-memory cache. The cache is
|
||||||
|
/// constructed directly (all fields are public, mirroring the iam crate's
|
||||||
|
/// own `build_test_iam_cache`) so no cluster-backed `ObjectStore` or disk
|
||||||
|
/// load is required. Readiness state is irrelevant: the gate calls
|
||||||
|
/// `is_allowed` directly, which does not gate on `is_ready`.
|
||||||
|
fn iam_sys_with_empty_store() -> Arc<IamSys<EmptyStore>> {
|
||||||
|
let (send_chan, _rx) = tokio::sync::mpsc::channel::<i64>(1);
|
||||||
|
let cache = IamCache {
|
||||||
|
cache: Cache::default(),
|
||||||
|
api: EmptyStore,
|
||||||
|
state: Arc::new(AtomicU8::new(0)),
|
||||||
|
loading: Arc::new(AtomicBool::new(false)),
|
||||||
|
roles: HashMap::new(),
|
||||||
|
send_chan,
|
||||||
|
last_timestamp: AtomicI64::new(0),
|
||||||
|
sync_failures: AtomicU64::new(0),
|
||||||
|
sync_successes: AtomicU64::new(0),
|
||||||
|
last_sync_duration_millis: AtomicU64::new(0),
|
||||||
|
};
|
||||||
|
Arc::new(IamSys::new(Arc::new(cache)))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn ctx_for<'a>(headers: &'a HeaderMap, cred: &'a Credentials, is_owner: bool) -> AuthContext<'a> {
|
||||||
|
AuthContext {
|
||||||
|
headers,
|
||||||
|
cred,
|
||||||
|
is_owner,
|
||||||
|
deny_only: false,
|
||||||
|
remote_addr: None,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn admin_action() -> Action {
|
||||||
|
Action::AdminAction(AdminAction::ServerInfoAdminAction)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn assert_access_denied(res: S3Result<()>) {
|
||||||
|
let err = res.expect_err("gate should reject the request");
|
||||||
|
assert_eq!(
|
||||||
|
err.code(),
|
||||||
|
&s3s::S3ErrorCode::AccessDenied,
|
||||||
|
"admin gate rejection must map to the AccessDenied S3 error code"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Owner (root/admin) credential is authorized for an admin action.
|
||||||
|
#[tokio::test]
|
||||||
|
async fn admin_owner_credential_is_allowed() {
|
||||||
|
let iam = iam_sys_with_empty_store();
|
||||||
|
let headers = HeaderMap::new();
|
||||||
|
let cred = Credentials {
|
||||||
|
access_key: "rustfsadmin".to_string(),
|
||||||
|
..Default::default()
|
||||||
|
};
|
||||||
|
let ctx = ctx_for(&headers, &cred, true);
|
||||||
|
|
||||||
|
let res = check_admin_request_auth(iam, &ctx, admin_action(), "", "").await;
|
||||||
|
assert!(res.is_ok(), "owner credential must pass the admin auth gate");
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A known-shaped but non-owner principal with no matching policy is denied.
|
||||||
|
#[tokio::test]
|
||||||
|
async fn non_admin_credential_is_denied() {
|
||||||
|
let iam = iam_sys_with_empty_store();
|
||||||
|
let headers = HeaderMap::new();
|
||||||
|
let cred = Credentials {
|
||||||
|
access_key: "limiteduser".to_string(),
|
||||||
|
secret_key: "limitedsecret".to_string(),
|
||||||
|
..Default::default()
|
||||||
|
};
|
||||||
|
let ctx = ctx_for(&headers, &cred, false);
|
||||||
|
|
||||||
|
let res = check_admin_request_auth(iam, &ctx, admin_action(), "", "").await;
|
||||||
|
assert_access_denied(res);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A request carrying an empty (missing) access key is denied.
|
||||||
|
#[tokio::test]
|
||||||
|
async fn missing_credential_is_denied() {
|
||||||
|
let iam = iam_sys_with_empty_store();
|
||||||
|
let headers = HeaderMap::new();
|
||||||
|
let cred = Credentials::default();
|
||||||
|
let ctx = ctx_for(&headers, &cred, false);
|
||||||
|
|
||||||
|
let res = check_admin_request_auth(iam, &ctx, admin_action(), "", "").await;
|
||||||
|
assert_access_denied(res);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// The multi-action loop authorizes as soon as one candidate action passes
|
||||||
|
/// (owner short-circuits every action), and denies when none pass.
|
||||||
|
#[tokio::test]
|
||||||
|
async fn evaluate_admin_actions_grants_when_any_action_allowed() {
|
||||||
|
let headers = HeaderMap::new();
|
||||||
|
let actions = vec![
|
||||||
|
Action::AdminAction(AdminAction::ServerInfoAdminAction),
|
||||||
|
Action::AdminAction(AdminAction::ConfigUpdateAdminAction),
|
||||||
|
];
|
||||||
|
|
||||||
|
// Owner: allowed on the first candidate action.
|
||||||
|
let owner_cred = Credentials {
|
||||||
|
access_key: "rustfsadmin".to_string(),
|
||||||
|
..Default::default()
|
||||||
|
};
|
||||||
|
let owner_ctx = ctx_for(&headers, &owner_cred, true);
|
||||||
|
let iam = iam_sys_with_empty_store();
|
||||||
|
let res = evaluate_admin_actions(iam, &owner_ctx, &actions, "", "").await;
|
||||||
|
assert!(res.is_ok(), "owner must be granted when at least one action is permitted");
|
||||||
|
|
||||||
|
// Non-owner with no policy: none of the candidate actions pass.
|
||||||
|
let user_cred = Credentials {
|
||||||
|
access_key: "limiteduser".to_string(),
|
||||||
|
..Default::default()
|
||||||
|
};
|
||||||
|
let user_ctx = ctx_for(&headers, &user_cred, false);
|
||||||
|
let iam = iam_sys_with_empty_store();
|
||||||
|
let res = evaluate_admin_actions(iam, &user_ctx, &actions, "", "").await;
|
||||||
|
assert_access_denied(res);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user