refactor: prune consumer storage compat paths (#3704)

docs/architecture/crate-boundaries.md

@@ -190,6 +190,10 @@ paths centralized behind local `ecstore_*` module aliases rather than scattering
 The RustFS app/admin storage compatibility boundaries must likewise route raw
 ECStore facade access through their local `ecstore_*` module aliases instead of
 scattering `rustfs_ecstore::api::...` paths through compatibility wrappers.
+Peripheral consumer storage compatibility boundaries must follow the same
+pattern. IAM, heal, scanner, notify, observability, Swift, S3 Select, test, and
+fuzz storage compatibility modules keep raw ECStore facade access centralized
+behind local `ecstore_*` module aliases.
 Scanner, notify, observability, and e2e `storage_compat.rs` boundaries must
 also stay narrow. Scanner must not restore grouped bucket compatibility exports
 for target, lifecycle, metadata, replication, or versioning modules. Notify

docs/architecture/migration-progress.md

@@ -5,16 +5,16 @@ Status values: `[ ]` not started, `[~]` in progress, `[x]` complete, `[!]` block
 ## Current Context
 
 - Issue: [`rustfs/backlog#660`](https://github.com/rustfs/backlog/issues/660)
-- Branch: `overtrue/arch-outer-compat-raw-facade-prune`
-- Baseline: completed `C-011/C-012/C-013/API-055/API-059/API-079/API-080/API-081/API-082/API-083/API-084/API-085/API-086/API-087/API-088/API-089/API-090/API-091/API-092`.
-- Stacked on: `overtrue/arch-outer-compat-call-facade-prune` pending API-092 merge.
+- Branch: `overtrue/arch-outer-consumer-compat-raw-facade-prune`
+- Baseline: completed `C-011/C-012/C-013/API-055/API-059/API-079/API-080/API-081/API-082/API-083/API-084/API-085/API-086/API-087/API-088/API-089/API-090/API-091/API-092/API-093`.
+- Stacked on: `overtrue/arch-outer-compat-raw-facade-prune` pending API-093 merge.
 - PR type for this branch: `pure-move`
 - Runtime behavior changes: none.
-- Rust code changes: centralize RustFS app/admin raw ECStore facade paths behind
-  local `ecstore_*` module aliases.
-- CI/script changes: guard the RustFS app/admin storage compatibility
-  boundaries against restoring scattered raw ECStore facade paths.
-- Docs changes: record the API-093 app/admin facade path cleanup.
+- Rust code changes: centralize peripheral consumer storage compatibility raw
+  ECStore facade paths behind local `ecstore_*` module aliases.
+- CI/script changes: guard peripheral consumer storage compatibility boundaries
+  against restoring scattered raw ECStore facade paths.
+- Docs changes: record the API-094 consumer facade path cleanup.
 
 ## Phase 0 Tasks
 
@@ -333,6 +333,21 @@ Status values: `[ ]` not started, `[~]` in progress, `[x]` complete, `[!]` block
   - Verification: RustFS compile coverage, app/admin raw facade path residual
     scan, migration guard, formatting, diff hygiene, Rust risk scan,
     pre-commit quality gate, and three-expert review.
+- [x] `API-094` Prune consumer raw facade paths.
+  - Completed slice: replace scattered raw `rustfs_ecstore::api::...` paths in
+    peripheral consumer storage compatibility boundaries with local
+    `ecstore_*` module aliases.
+  - Acceptance: IAM, heal, scanner, notify, observability, Swift, S3 Select,
+    test, and fuzz storage compatibility modules no longer contain raw
+    `rustfs_ecstore::api::...` facade paths outside centralized local alias
+    imports.
+  - Must preserve: IAM config and notifications, heal disk lookup, scanner
+    lifecycle and tier helpers, notify server config IO, observability runtime
+    metrics, Swift metadata wrappers, S3 Select error checks, and test/fuzz
+    harness wrappers.
+  - Verification: RustFS compile coverage, consumer raw facade path residual
+    scan, migration guard, formatting, diff hygiene, Rust risk scan,
+    pre-commit quality gate, and three-expert review.
 - [x] `G-012` Inventory placement and repair invariants.
   - Acceptance:
     [`placement-repair-invariants.md`](placement-repair-invariants.md) records
@@ -3366,14 +3381,25 @@ Status values: `[ ]` not started, `[~]` in progress, `[x]` complete, `[!]` block
 
 | Expert | Status | Notes |
 |---|---|---|
-| Quality/architecture | passed | API-093 centralizes RustFS app/admin ECStore facade paths behind local `ecstore_*` module aliases without adding nested compatibility modules. |
-| Migration preservation | passed | App lifecycle, metadata, object-lock, replication, data usage, notification, tier, layout, compression, admin rebalance, metrics, bucket target, quota, storage class, and server configuration compatibility keep the same ECStore contracts. |
-| Testing/verification | passed | RustFS compile coverage, app/admin raw facade path residual scan, migration and layer guards, formatting, diff hygiene, Rust risk scan, full pre-commit, and three-expert review passed. |
+| Quality/architecture | passed | API-094 centralizes peripheral consumer ECStore facade paths behind local `ecstore_*` module aliases without adding nested compatibility modules. |
+| Migration preservation | passed | IAM config and notifications, heal disk lookup, scanner lifecycle and tier helpers, notify server config IO, observability runtime metrics, Swift metadata wrappers, S3 Select error checks, and test/fuzz harness wrappers keep the same ECStore contracts. |
+| Testing/verification | passed | RustFS compile coverage, consumer raw facade path residual scan, migration and layer guards, formatting, diff hygiene, Rust risk scan, full pre-commit, and three-expert review passed. |
 
 ## Verification Notes
 
 Passed before push:
 
+- Issue #660 API-094 current slice:
+  - `cargo check -p rustfs`: passed.
+  - `cargo fmt --all --check`: passed.
+  - `git diff --check`: passed.
+  - `bash -n scripts/check_architecture_migration_rules.sh`: passed.
+  - `./scripts/check_architecture_migration_rules.sh`: passed.
+  - `./scripts/check_layer_dependencies.sh`: passed.
+  - Consumer raw facade path residual scan: passed.
+  - Rust risk scan on changed Rust files: passed.
+  - `make pre-commit`: passed.
+
 - Issue #660 API-093 current slice:
   - `cargo check -p rustfs`: passed.
   - `cargo fmt --all --check`: passed.