gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-08-28 16:07:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(lock): Add support for disabling lock manager (#511)

Browse Source 
* feat(lock): Add support for disabling lock manager
Implement control of lock system activation and deactivation via environment variables
Add DisabledLockManager for lock-free operation scenarios
Introduce LockManager trait to uniformly manage different lock managers

Signed-off-by: junxiang Mu <1948535941@qq.com>

* refactor(lock): Optimize implementation of global lock manager and parsing of boolean environment variables
Refactor the implementation of the global lock manager: wrap FastObjectLockManager with Arc and add the as_fast_lock_manager method
Extract the boolean environment variable parsing logic into an independent function parse_bool_env_var

Signed-off-by: junxiang Mu <1948535941@qq.com>

---------

Signed-off-by: junxiang Mu <1948535941@qq.com>
This commit is contained in:
guojidan
2025-09-11 13:46:06 +08:00
committed by GitHub
parent d4beb1cc0b
commit cf863ba059
11 changed files with 1052 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/lock/src/fast_lock/guard.rs
+52 -16
View File
@@ -26,8 +26,9 @@ pub struct FastLockGuard {
key: ObjectKey,
mode: LockMode,
owner: Arc<str>,
shard: Arc<LockShard>,
shard: Option<Arc<LockShard>>, // None when locks are disabled
released: bool,
disabled: bool, // True when locks are disabled globally
}
impl FastLockGuard {
@@ -36,8 +37,21 @@ impl FastLockGuard {
key,
mode,
owner,
shard,
shard: Some(shard),
released: false,
disabled: false,
}
}
/// Create a disabled guard (when locks are globally disabled)
pub(crate) fn new_disabled(key: ObjectKey, mode: LockMode, owner: Arc<str>) -> Self {
Self {
key,
mode,
owner,
shard: None,
released: false,
disabled: true,
}
}
@@ -65,11 +79,23 @@ impl FastLockGuard {
return false;
}
let success = self.shard.release_lock(&self.key, &self.owner, self.mode);
if success {
if self.disabled {
// For disabled locks, always succeed
self.released = true;
return true;
}
if let Some(shard) = &self.shard {
let success = shard.release_lock(&self.key, &self.owner, self.mode);
if success {
self.released = true;
}
success
} else {
// Should not happen, but handle gracefully
self.released = true;
false
}
success
}
/// Check if the lock has been released
@@ -77,27 +103,36 @@ impl FastLockGuard {
self.released
}
/// Check if this guard represents a disabled lock
pub fn is_disabled(&self) -> bool {
self.disabled
}
/// Get lock information for monitoring
pub fn lock_info(&self) -> Option<crate::fast_lock::types::ObjectLockInfo> {
if self.released {
if self.released || self.disabled {
None
} else if let Some(shard) = &self.shard {
shard.get_lock_info(&self.key)
} else {
self.shard.get_lock_info(&self.key)
None
}
}
}
impl Drop for FastLockGuard {
fn drop(&mut self) {
if !self.released {
let success = self.shard.release_lock(&self.key, &self.owner, self.mode);
if !success {
tracing::warn!(
"Failed to release lock during drop: key={}, owner={}, mode={:?}",
self.key,
self.owner,
self.mode
);
if !self.released && !self.disabled {
if let Some(shard) = &self.shard {
let success = shard.release_lock(&self.key, &self.owner, self.mode);
if !success {
tracing::warn!(
"Failed to release lock during drop: key={}, owner={}, mode={:?}",
self.key,
self.owner,
self.mode
);
}
}
}
}
@@ -110,6 +145,7 @@ impl std::fmt::Debug for FastLockGuard {
.field("mode", &self.mode)
.field("owner", &self.owner)
.field("released", &self.released)
.field("disabled", &self.disabled)
.finish()
}
}