From cd165ab1817b4c8d468904c4ef8673e56867eb4e Mon Sep 17 00:00:00 2001 From: Zhengchao An Date: Sun, 28 Jun 2026 20:28:04 +0800 Subject: [PATCH] docs: document obs reverse dependency on ecstore (#735) (#4010) docs: document obs reverse dependency on ecstore Add comment explaining why obs depends on ecstore and the scope of work required to break this dependency. Refs #735 Co-authored-by: houseme --- crates/obs/Cargo.toml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/crates/obs/Cargo.toml b/crates/obs/Cargo.toml index 33d3eb8b6..64b23dfbd 100644 --- a/crates/obs/Cargo.toml +++ b/crates/obs/Cargo.toml @@ -37,6 +37,11 @@ workspace = true rustfs-audit = { workspace = true } rustfs-common = { workspace = true } rustfs-config = { workspace = true, features = ["constants", "observability"] } +# NOTE: This dependency on rustfs-ecstore is a known architectural limitation. +# The obs crate imports types from ecstore for metrics collection. +# Breaking this dependency would require defining traits in obs and +# implementing them in ecstore, which is a significant refactoring. +# See https://github.com/rustfs/backlog/issues/735 for discussion. rustfs-ecstore = { workspace = true } rustfs-iam = { workspace = true } rustfs-io-metrics = { workspace = true }