gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-08-02 19:39:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: move runtime fallback defaults to owners (#3961)

Browse Source
This commit is contained in:
Zhengchao An
2026-06-27 22:21:09 +08:00
committed by GitHub
parent 20f56af09c
commit c7dc3d7974
12 changed files with 217 additions and 164 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/architecture/migration-progress.md
+45 -14
View File
@@ -5,7 +5,7 @@ Status values: `[ ]` not started, `[~]` in progress, `[x]` complete, `[!]` block
## Current Context
- Issue: [`rustfs/backlog#660`](https://github.com/rustfs/backlog/issues/660)
- Branch: `overtrue/arch-runtime-specialized-fallback-boundary`
- Branch: `overtrue/arch-runtime-root-fallback-facade-cleanup`
- Baseline: completed `C-011/C-012/C-013/API-055/API-059/API-079/API-080/API-081/API-082/API-083/API-084/API-085/API-086/API-087/API-088/API-089/API-090/API-091/API-092/API-093/API-094/API-095/API-096/API-097/API-098/API-099/API-100/API-101/API-102/API-103/API-104/API-105/API-106/API-107/API-108/API-109/API-110/API-111/API-112/API-113/API-114/API-115/API-116/API-117/API-118/API-119/API-120/API-121/API-122/API-123/API-124/API-125/API-126/API-127/API-128/API-129/API-130/API-131/API-132/API-133/API-134/API-135/API-136/API-137/API-138/API-139/API-140/API-141/API-142/API-143/API-144/API-145/API-146/API-147/API-148/API-149/API-150/API-151/API-152/API-153/API-154/API-155/API-156/API-157/API-158/API-159/API-160/API-161/API-162/API-163/API-164/API-165/API-166/API-167/API-168/API-169/API-170/API-171/API-172/API-173/API-174/API-175/API-176/API-177/API-178/API-179/API-180/API-181/API-182/API-183/API-184/API-185/API-186/API-187/API-188/API-189/API-190/API-191/API-192/API-193/API-194/API-195/API-196/API-197/API-198/API-199/API-200/API-201/API-202/API-203/API-204/API-205/API-206/API-207/API-208/API-209/API-210/API-211/API-212/API-213/API-214/API-215/API-216/API-217/API-218/API-219/API-220/API-221/API-222/API-223/API-224/API-225/API-226/API-227/API-228/API-229/API-230/API-231/API-232/API-233/API-234/API-235/API-236/API-237/API-238/API-239/API-240/API-241/API-242/API-243/API-244/API-245/API-246/API-247/API-248/API-249/API-250/API-251/API-252/API-253/API-254/CTX-002`.
- Current baseline also includes API-255 from PR #3923, API-256 from PR
#3925, CFG-009 from PR #3927, C-007/C-009 from PR #3935, C-008/C-010
@@ -24,21 +24,20 @@ Status values: `[ ]` not started, `[~]` in progress, `[x]` complete, `[!]` block
PR #3952, the GLOB-007 AppContext-only fallback signature cleanup from
PR #3953, the GLOB-007 runtime resolver fallback boundary cleanup from
PR #3954, the GLOB-007 service/credential resolver fallback removal from
PR #3955, and the GLOB-007 scalar/handle resolver fallback removal from
PR #3957.
- Current phase PR: GLOB-007 specialized resolver fallback boundary.
- Based on: `origin/main` after PR #3957 merged.
PR #3955, the GLOB-007 scalar/handle resolver fallback removal from PR #3957,
and the GLOB-007 specialized resolver fallback boundary from PR #3958.
- Current phase PR: GLOB-007 root runtime fallback facade cleanup.
- Based on: `origin/main` after PR #3958 merged.
- PR type for this branch: `ci-gate`.
- Runtime behavior changes: AppContext specialized resolver helpers for KMS
initialization, notify interface, outbound TLS state, scanner metrics, S3
Select DB, server-config publish, and storage-class publish now stop at the
AppContext boundary, while root runtime facades preserve the existing
no-AppContext fallback contracts for callers.
- Rust code changes: move those specialized no-AppContext fallbacks out of
`app::context` public resolvers and into the root `runtime_sources` facade.
- Runtime behavior changes: no intended behavior change; admin, app, storage,
server, startup, and config owner facades preserve their existing
no-AppContext defaults.
- Rust code changes: remove concrete default fallback wrappers from the root
`runtime_sources` facade and move those defaults to the owner facades that
consume them.
- CI/script changes: none intended.
- Docs changes: update this progress ledger for the specialized fallback
boundary.
- Docs changes: update this progress ledger for the root fallback facade
cleanup.
## Phase 0 Tasks
@@ -6107,6 +6106,9 @@ Status values: `[ ]` not started, `[~]` in progress, `[x]` complete, `[!]` block
| Expert | Status | Notes |
|---|---|---|
| Quality/architecture | pass | GLOB-007 removes concrete fallback composition from the root runtime facade; owner facades now decide when to apply fallback factories. |
| Migration preservation | pass | Existing admin, app, storage, server, startup, and config no-AppContext defaults are preserved at their consuming owner boundaries. |
| Testing/verification | pass | Focused resolver, TLS, S3 Select, config, and config-info tests passed; compile, formatting, architecture guard, residual scans, diff hygiene, Rust risk scan, and full `make pre-pr` passed before PR. |
| Quality/architecture | pass | GLOB-007 moves specialized no-AppContext fallback behavior from AppContext public resolvers to root runtime facade wrappers, keeping resolver helpers context-only. |
| Migration preservation | pass | Existing callers keep concrete root facade return contracts for KMS initialization, notify interface, outbound TLS state, scanner metrics, S3 Select DB, server-config publish, and storage-class publish. |
| Testing/verification | pass | Focused resolver, site-replication TLS, S3 Select, and config tests passed; compile, formatting, architecture guard, specialized fallback residual scan, diff hygiene, Rust risk scan, Rust quality scan, and full `make pre-pr` passed before PR. |
@@ -9848,6 +9850,35 @@ Notes:
- `make pre-pr`: passed, including 6917 nextest tests passed, 112 skipped,
and doctests passed.
- Issue #660 GLOB-007 root runtime fallback facade cleanup:
- `cargo check -p rustfs --lib`: passed.
- `cargo test -p rustfs --lib app::context::tests::resolver_helpers_are_context_first_and_empty_when_context_is_absent`:
passed.
- `cargo test -p rustfs --lib admin::handlers::site_replication::tests::test_site_replication_peer_client_rebuilds_when_generation_changes`:
passed.
- `cargo test -p rustfs --lib admin::handlers::site_replication::tests::test_site_replication_local_endpoint`:
passed, 4 passed.
- `cargo test -p rustfs --lib app::select_object::tests`: passed, 19
passed.
- `cargo test -p rustfs --lib admin::handlers::config_admin::tests`: passed,
29 passed.
- `cargo test -p rustfs --lib admin::service::config::tests`: passed, 7
passed.
- `cargo test -p rustfs --lib config::info::tests`: passed, 5 passed.
- `cargo fmt --all --check`: passed.
- `./scripts/check_architecture_migration_rules.sh`: passed.
- `git diff --check`: passed.
- Root runtime fallback composition residual scan: passed; the root runtime
facade no longer owns concrete no-AppContext default composition.
- Owner AppContext bypass scan: passed; owner runtime facades use root
runtime entrypoints instead of direct AppContext access.
- Rust risk scan: passed; no new production unwrap/expect, numeric casts,
boxed public errors, or production println/eprintln introduced in changed
Rust files. Relaxed atomics are limited to the test-only TLS generation
override.
- `make pre-pr`: passed, including 6918 nextest tests passed, 112 skipped,
and doctests passed.
## Handoff Notes
- Continue with larger consumer-migration batches outside the cleaned