From c498fbcb27036127476081b42d65d9f7b08b3b7b Mon Sep 17 00:00:00 2001
From: lihaixing <lihaixing@tal.com>
Date: Wed, 9 Jul 2025 11:09:22 +0800
Subject: [PATCH] fix: drop writers to close all files, this is to prevent
 FileAccessDenied errors when renaming data

---
 crates/ecstore/src/set_disk.rs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/crates/ecstore/src/set_disk.rs b/crates/ecstore/src/set_disk.rs
index a0b619074..60a022a1c 100644
--- a/crates/ecstore/src/set_disk.rs
+++ b/crates/ecstore/src/set_disk.rs
@@ -4099,6 +4099,8 @@ impl ObjectIO for SetDisks {
             }
         }
 
+        drop(writers); // drop writers to close all files, this is to prevent FileAccessDenied errors when renaming data
+
         let (online_disks, _, op_old_dir) = Self::rename_data(
             &shuffle_disks,
             RUSTFS_META_TMP_BUCKET,
@@ -5039,6 +5041,8 @@ impl StorageAPI for SetDisks {
 
         let fi_buff = fi.marshal_msg()?;
 
+        drop(writers); // drop writers to close all files
+
         let part_path = format!("{}/{}/{}", upload_id_path, fi.data_dir.unwrap_or_default(), part_suffix);
         let _ = Self::rename_part(
             &disks,