gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-07-26 08:18:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: fix migration-gate count guard failing on every PR (nextest JSON counting) (#4686)

Browse Source 
ci: count migration-gate tests via nextest JSON, not human-format indentation

The count-floor guard (#4673) parsed nextest's human list format with
grep -c '^    '. CI's newer nextest emits a different indentation, so the
count collapsed to 0 and the gate failed on every PR based on current
main (first observed on #4683, then #4674/#4677/#4680). Count via
--message-format json + jq instead, which is stable across versions, and
fail loudly if the JSON shape ever changes.
This commit is contained in:
Zhengchao An
2026-07-10 22:19:17 +08:00
committed by GitHub
parent f13e98eb81
commit b9e5e818a9
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/check_migration_gate_count.sh
+12 -6
View File
@@ -54,12 +54,18 @@ if [[ "$mode" == "all" || "$mode" == "check" ]]; then
exit 1
fi
# Human-format list: binary headers start at column 0, one test per
# 4-space-indented line. A nextest failure aborts via set -e with its
# stderr visible; an output-format change collapses the count to 0 and
# fails loudly rather than silently passing.
list_output="$(cargo nextest list -p rustfs-ecstore --lib -E "$MIGRATION_GATE_FILTER")"
count="$(printf '%s\n' "$list_output" | grep -c '^ ' || true)"
# Count via the structured JSON listing, not the human format: the
# human format's indentation varies across nextest versions (CI's newer
# nextest emitted a layout where no line matched '^ ', collapsing the
# count to 0 and failing every PR). A nextest failure aborts via set -e
# with its stderr visible; a JSON schema change makes jq fail loudly
# rather than silently passing.
count="$(cargo nextest list -p rustfs-ecstore --lib -E "$MIGRATION_GATE_FILTER" --message-format json \
| jq '[."rust-suites"[].testcases[] | select(."filter-match".status == "matches")] | length')"
if ! [[ "$count" =~ ^[0-9]+$ ]]; then
echo "error: could not parse nextest JSON listing (got count: '$count')" >&2
exit 1
fi
if ((count < floor)); then
echo "error: migration gate selects $count tests, below the committed floor of $floor." >&2