gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-08-27 15:37:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ilm): retry transient scope admission races (#5280)

Browse Source 
Co-authored-by: heihutu <heihutu@gmail.com>
This commit is contained in:
houseme
2026-07-26 17:13:53 +08:00
committed by GitHub
parent 4e353fb3c8
commit a609b92b3c
1 changed files with 31 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ecstore/src/bucket/lifecycle/manual_transition_job.rs
+31 -25
View File
@@ -1015,34 +1015,40 @@ pub async fn claim_manual_transition_scope_admission(
api: Arc<ECStore>, api: Arc<ECStore>,
admission: &ManualTransitionScopeAdmission, admission: &ManualTransitionScopeAdmission,
) -> EcstoreResult<ManualTransitionScopeAdmissionClaim> { ) -> EcstoreResult<ManualTransitionScopeAdmissionClaim> {
match save_manual_transition_scope_admission_if_absent(api.clone(), admission).await { loop {
Ok(()) => return finish_manual_transition_scope_admission_claim(api, admission).await, match save_manual_transition_scope_admission_if_absent(api.clone(), admission).await {
Err(Error::PreconditionFailed) => {} Ok(()) => return finish_manual_transition_scope_admission_claim(api, admission).await,
Err(err) => return Err(err), Err(Error::PreconditionFailed) => {}
}
let (active, etag) = load_manual_transition_scope_admission_with_etag(api.clone(), &admission.scope_key).await?;
let scope_lease_expired = manual_transition_scope_admission_lease_expired(&active);
let active_job_reclaimable = if active.job_id == admission.job_id {
scope_lease_expired
} else {
match load_manual_transition_job_record(api.clone(), active.job_id).await {
Ok(active_job) => {
active_job.is_terminal() || (scope_lease_expired && manual_transition_job_lease_expired(&active_job))
}
Err(Error::ConfigNotFound) => true,
Err(err) => return Err(err), Err(err) => return Err(err),
} }
};
if active_job_reclaimable {
return match save_manual_transition_scope_admission_if_current(api.clone(), admission, &etag).await {
Ok(()) => finish_manual_transition_scope_admission_claim(api, admission).await,
Err(Error::PreconditionFailed) => Ok(ManualTransitionScopeAdmissionClaim::Conflict(Box::new(active))),
Err(err) => Err(err),
};
}
Ok(ManualTransitionScopeAdmissionClaim::Conflict(Box::new(active))) let (active, etag) = match load_manual_transition_scope_admission_with_etag(api.clone(), &admission.scope_key).await {
Ok(active) => active,
Err(Error::ConfigNotFound) => continue,
Err(err) => return Err(err),
};
let scope_lease_expired = manual_transition_scope_admission_lease_expired(&active);
let active_job_reclaimable = if active.job_id == admission.job_id {
scope_lease_expired
} else {
match load_manual_transition_job_record(api.clone(), active.job_id).await {
Ok(active_job) => {
active_job.is_terminal() || (scope_lease_expired && manual_transition_job_lease_expired(&active_job))
}
Err(Error::ConfigNotFound) => true,
Err(err) => return Err(err),
}
};
if active_job_reclaimable {
match save_manual_transition_scope_admission_if_current(api.clone(), admission, &etag).await {
Ok(()) => return finish_manual_transition_scope_admission_claim(api, admission).await,
Err(Error::PreconditionFailed) => continue,
Err(err) => return Err(err),
}
}
return Ok(ManualTransitionScopeAdmissionClaim::Conflict(Box::new(active)));
}
} }
async fn finish_manual_transition_scope_admission_claim( async fn finish_manual_transition_scope_admission_claim(