gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-08-31 09:18:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ecstore): reject symlink path escapes (#3742)

Browse Source 
Co-authored-by: Zhengchao An <anzhengchao@gmail.com>
This commit is contained in:
houseme
2026-06-22 19:28:40 +08:00
committed by GitHub
parent 2f85ef4455
commit a53ccb2407
2 changed files with 95 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ecstore/src/disk/fs.rs
+34 -2
View File
@@ -150,11 +150,11 @@ pub fn access_std(path: impl AsRef<Path>) -> io::Result<()> {
}
pub async fn lstat(path: impl AsRef<Path>) -> io::Result<Metadata> {
fs::metadata(path).await
fs::symlink_metadata(path).await
}
pub fn lstat_std(path: impl AsRef<Path>) -> io::Result<Metadata> {
std::fs::metadata(path)
std::fs::symlink_metadata(path)
}
pub async fn make_dir_all(path: impl AsRef<Path>) -> io::Result<()> {
@@ -355,6 +355,22 @@ mod tests {
assert_eq!(metadata.len(), 12); // "test content" is 12 bytes
}
#[cfg(unix)]
#[tokio::test]
async fn test_lstat_preserves_symlink_metadata() {
use std::os::unix::fs::symlink;
let temp_dir = TempDir::new().unwrap();
let target_path = temp_dir.path().join("target.txt");
let link_path = temp_dir.path().join("link.txt");
tokio::fs::write(&target_path, b"test content").await.unwrap();
symlink(&target_path, &link_path).unwrap();
let metadata = lstat(&link_path).await.unwrap();
assert!(metadata.file_type().is_symlink());
}
#[test]
fn test_lstat_std() {
let temp_dir = TempDir::new().unwrap();
@@ -369,6 +385,22 @@ mod tests {
assert_eq!(metadata.len(), 12); // "test content" is 12 bytes
}
#[cfg(unix)]
#[test]
fn test_lstat_std_preserves_symlink_metadata() {
use std::os::unix::fs::symlink;
let temp_dir = TempDir::new().unwrap();
let target_path = temp_dir.path().join("target-std.txt");
let link_path = temp_dir.path().join("link-std.txt");
std::fs::write(&target_path, b"test content").unwrap();
symlink(&target_path, &link_path).unwrap();
let metadata = lstat_std(&link_path).unwrap();
assert!(metadata.file_type().is_symlink());
}
#[tokio::test]
async fn test_make_dir_all() {
let temp_dir = TempDir::new().unwrap();