gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-08-31 09:18:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(e2e): require exact checksum errors (#6548)

Browse Source
This commit is contained in:
Zhengchao An
2026-08-25 04:32:53 +08:00
committed by GitHub
parent 82df9ec4fa
commit 9f12f344c9
1 changed files with 20 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/e2e_test/src/checksum_upload_test.rs
+20 -14
View File
@@ -20,6 +20,7 @@ mod tests {
use crate::common::{RustFSTestEnvironment, init_logging}; use crate::common::{RustFSTestEnvironment, init_logging};
use aws_sdk_s3::Client; use aws_sdk_s3::Client;
use aws_sdk_s3::config::{Credentials, Region, RequestChecksumCalculation}; use aws_sdk_s3::config::{Credentials, Region, RequestChecksumCalculation};
use aws_sdk_s3::error::ProvideErrorMetadata;
use aws_sdk_s3::primitives::ByteStream; use aws_sdk_s3::primitives::ByteStream;
use aws_sdk_s3::types::{ChecksumAlgorithm, ChecksumMode, CompletedMultipartUpload, CompletedPart}; use aws_sdk_s3::types::{ChecksumAlgorithm, ChecksumMode, CompletedMultipartUpload, CompletedPart};
use aws_smithy_http_client::Builder as SmithyHttpClientBuilder; use aws_smithy_http_client::Builder as SmithyHttpClientBuilder;
@@ -186,16 +187,16 @@ mod tests {
.send() .send()
.await; .await;
assert!( let error = result.expect_err("PutObject with a mismatched SHA256 must be rejected (issue #4341)");
result.is_err(), assert_eq!(
"PutObject with a mismatched SHA256 must be rejected, but it succeeded (issue #4341)" error.raw_response().map(|response| response.status().as_u16()),
Some(400),
"Mismatched SHA256 must return HTTP 400, got {error:?}"
); );
let err = result.err().unwrap(); assert_eq!(
let msg = format!("{err:?}"); error.as_service_error().and_then(ProvideErrorMetadata::code),
info!("PutObject correctly rejected mismatched checksum: {msg}"); Some("BadDigest"),
assert!( "Mismatched SHA256 must return BadDigest, got {error:?}"
msg.contains("BadDigest") || msg.to_lowercase().contains("digest") || msg.to_lowercase().contains("checksum"),
"Expected a BadDigest/checksum error, got: {msg}"
); );
// And the object must not have been stored. // And the object must not have been stored.
@@ -556,11 +557,16 @@ mod tests {
}) })
.send() .send()
.await; .await;
assert!(put_bad.is_err(), "{header}: a mismatched checksum must be rejected"); let error = put_bad.expect_err("a mismatched checksum must be rejected");
let msg = format!("{:?}", put_bad.err().unwrap()); assert_eq!(
assert!( error.raw_response().map(|response| response.status().as_u16()),
msg.contains("BadDigest") || msg.to_lowercase().contains("digest") || msg.to_lowercase().contains("checksum"), Some(400),
"{header}: expected a BadDigest/checksum error, got: {msg}" "{header}: mismatched checksum must return HTTP 400, got {error:?}"
);
assert_eq!(
error.as_service_error().and_then(ProvideErrorMetadata::code),
Some("BadDigest"),
"{header}: mismatched checksum must return BadDigest, got {error:?}"
); );
let error = client let error = client
.head_object() .head_object()