feat(storage): refactor audit and notification with OperationHelper (#825)

gsadmin/rustfs

Fork 0

mirror of https://github.com/rustfs/rustfs.git synced 2026-08-08 14:23:13 +00:00

Browse Source

* improve code for audit

* improve code ecfs.rs

* improve code

* improve code for ecfs.rs

* feat(storage): refactor audit and notification with OperationHelper

This commit introduces a significant refactoring of the audit logging and event notification mechanisms within `ecfs.rs`.

The core of this change is the new `OperationHelper` struct, which encapsulates and simplifies the logic for both concerns. It replaces the previous `AuditHelper` and manual event dispatching.

Key improvements include:

- **Unified Handling**: `OperationHelper` manages both audit and notification builders, providing a single, consistent entry point for S3 operations.
- **RAII for Automation**: By leveraging the `Drop` trait, the helper automatically dispatches logs and notifications when it goes out of scope. This simplifies S3 method implementations and ensures cleanup even on early returns.
- **Fluent API**: A builder-like pattern with methods such as `.object()`, `.version_id()`, and `.suppress_event()` makes the code more readable and expressive.
- **Context-Aware Logic**: The helper's `.complete()` method intelligently populates log details based on the operation's `S3Result` and only triggers notifications on success.
- **Modular Design**: All helper logic is now isolated in `rustfs/src/storage/helper.rs`, improving separation of concerns and making `ecfs.rs` cleaner.

This refactoring significantly enhances code clarity, reduces boilerplate, and improves the robustness of logging and notification handling across the storage layer.

* fix

* improve code for audit and notify

* fix

This commit is contained in:

houseme

2025-11-10 17:30:50 +08:00

committed by

GitHub

parent b26aad4129

commit 98be7df0f5

25 changed files with 905 additions and 835 deletions

									
										rustfs/Cargo.toml
									
		-1
	
												View File
												
				@@ -112,7 +112,6 @@ mime_guess = { workspace = true }

				pin-project-lite.workspace = true

				rust-embed = { workspace = true, features = ["interpolate-folder-path"] }

				s3s.workspace = true

				scopeguard.workspace = true

				shadow-rs = { workspace = true, features = ["build", "metadata"] }

				sysinfo = { workspace = true, features = ["multithread"] }

				thiserror = { workspace = true }