refactor(ecstore): use local replication paths (#4130)

crates/ecstore/src/bucket/replication/README.md

@@ -46,7 +46,9 @@ and lifecycle/heal scheduling paths.
    only after call sites prove a narrower object read/write/delete/walk shape.
 4. Preserve `rustfs_ecstore::api::bucket::replication` compatibility until
    lifecycle, scanner, OBS, heal, and tests compile through replacement paths.
-5. Move at most one contract boundary per code-bearing PR and verify it with
+5. Keep imports between modules in this directory relative to the local
+   replication module, not `crate::bucket::replication::*` self paths.
+6. Move at most one contract boundary per code-bearing PR and verify it with
    focused replication tests before broad gates.
 
 ## First Code-Bearing Step

crates/ecstore/src/bucket/replication/config.rs

@@ -14,7 +14,7 @@
 
 use super::replication_filemeta_boundary::ReplicationType;
 use super::replication_tagging_boundary as tagging_boundary;
-use crate::bucket::replication::ReplicationRuleExt as _;
+use super::rule::ReplicationRuleExt as _;
 use s3s::dto::DeleteMarkerReplicationStatus;
 use s3s::dto::DeleteReplicationStatus;
 use s3s::dto::Destination;

crates/ecstore/src/bucket/replication/replication_pool.rs

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+use super::datatypes::ResyncStatusType;
 use super::replication_config_store as config_store;
 use super::replication_error_boundary::Error as EcstoreError;
 use super::replication_filemeta_boundary::{
@@ -20,19 +21,15 @@ use super::replication_filemeta_boundary::{
     ResyncDecision, VersionPurgeStatusType, replication_statuses_map, version_purge_statuses_map,
 };
 use super::replication_metadata_boundary as metadata_boundary;
+use super::replication_resyncer::{
+    BucketReplicationResyncStatus, DeletedObjectReplicationInfo, ReplicationConfig, ReplicationResyncer, ResyncOpts,
+    TargetReplicationResyncStatus, decode_mrf_file, decode_resync_file, encode_mrf_file, get_heal_replicate_object_info,
+    replicate_delete, replicate_object, save_resync_status,
+};
+use super::replication_state::ReplicationStats;
 use super::replication_storage_boundary::{DeletedObject, ObjectInfo, ObjectOptions, ReplicationObjectIO, ReplicationStorage};
 use super::replication_target_boundary as target_boundary;
 use super::runtime_boundary as runtime_sources;
-use crate::bucket::replication::ResyncOpts;
-use crate::bucket::replication::ResyncStatusType;
-use crate::bucket::replication::replicate_delete;
-use crate::bucket::replication::replicate_object;
-use crate::bucket::replication::replication_resyncer::{
-    BucketReplicationResyncStatus, DeletedObjectReplicationInfo, ReplicationConfig, ReplicationResyncer,
-    TargetReplicationResyncStatus, decode_mrf_file, decode_resync_file, encode_mrf_file, get_heal_replicate_object_info,
-    save_resync_status,
-};
-use crate::bucket::replication::replication_state::ReplicationStats;
 use lazy_static::lazy_static;
 use rustfs_utils::http::{SUFFIX_REPLICATION_TIMESTAMP, get_str};
 use std::any::Any;
@@ -1692,8 +1689,8 @@ async fn queue_replicate_deletes_wrapper(
 
 #[cfg(test)]
 mod tests {
+    use super::super::replication_resyncer::{decode_mrf_file, encode_mrf_file};
     use super::*;
-    use crate::bucket::replication::replication_resyncer::{decode_mrf_file, encode_mrf_file};
     use uuid::Uuid;
 
     #[test]

crates/ecstore/src/bucket/replication/replication_resyncer.rs

@@ -12,6 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+use super::config::{ObjectOpts, ReplicationConfigurationExt as _};
+use super::datatypes::ResyncStatusType;
 use super::replication_bandwidth_boundary;
 use super::replication_config_store as config_store;
 use super::replication_error_boundary::{Error, Result, is_err_object_not_found, is_err_version_not_found};
@@ -36,8 +38,6 @@ use super::replication_target_boundary::{
 };
 use super::replication_versioning_boundary as versioning_boundary;
 use super::runtime_boundary as runtime_sources;
-use crate::bucket::replication::ResyncStatusType;
-use crate::bucket::replication::{ObjectOpts, ReplicationConfigurationExt as _};
 use aws_sdk_s3::error::{ProvideErrorMetadata, SdkError};
 use aws_sdk_s3::operation::head_object::{HeadObjectError, HeadObjectOutput};
 use aws_sdk_s3::primitives::ByteStream;

crates/ecstore/src/bucket/replication/rule.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use crate::bucket::replication::ObjectOpts;
+use super::config::ObjectOpts;
 use s3s::dto::ReplicaModificationsStatus;
 use s3s::dto::ReplicationRule;
 

crates/ecstore/src/bucket/replication/runtime_boundary.rs

@@ -14,9 +14,9 @@
 
 use std::sync::Arc;
 
+use super::replication_pool::DynReplicationPool;
+use super::replication_state::ReplicationStats;
 use crate::bucket::bandwidth::monitor::Monitor;
-use crate::bucket::replication::replication_pool::DynReplicationPool;
-use crate::bucket::replication::replication_state::ReplicationStats;
 use crate::runtime::sources;
 use crate::store::ECStore;