From 8893de1cad4465f8f4a28ee8c97bf17066ba2932 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=AE=89=E6=AD=A3=E8=B6=85?= Date: Tue, 31 Mar 2026 22:08:21 +0800 Subject: [PATCH] test(admin): cover empty kms key aliases (#2331) Co-authored-by: cxymds --- rustfs/src/admin/handlers/kms_keys.rs | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/rustfs/src/admin/handlers/kms_keys.rs b/rustfs/src/admin/handlers/kms_keys.rs index aa154ee6b..25bb7b1dc 100644 --- a/rustfs/src/admin/handlers/kms_keys.rs +++ b/rustfs/src/admin/handlers/kms_keys.rs @@ -320,6 +320,17 @@ mod tests { assert_eq!(extract_key_id(&uri).as_deref(), Some("legacy-key")); } + #[test] + fn test_extract_key_id_skips_empty_aliases() { + for (uri, expected) in [ + ("/rustfs/admin/v3/kms/key/status?keyId=&key-id=minio-key", Some("minio-key")), + ("/rustfs/admin/v3/kms/key/status?keyId=&key-id=&key=fallback-key", Some("fallback-key")), + ("/rustfs/admin/v3/kms/key/status?keyId=&key-id=&key=", None), + ] { + let uri: Uri = uri.parse().expect("uri should parse"); + assert_eq!(extract_key_id(&uri).as_deref(), expected); + } + } } /// List KMS keys (legacy endpoint)