gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-09-04 11:15:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(obs): tighten low-risk telemetry correctness (#4483)

Browse Source 
Refs rustfs/backlog#1007
Refs rustfs/backlog#986

- respect explicit log-target directives when injecting noisy-crate suppressions
- fix daily rotation day-boundary checks and add a short retry cooldown after failed rotations
- preserve recorder metadata across label variants and serialize gauge updates before export
- correct profiling target_env reporting, trace all=true parsing, cleaner accounting/docs, and legacy system interval rounding

Co-authored-by: heihutu <heihutu@gmail.com>
This commit is contained in:
houseme
2026-07-08 22:06:19 +08:00
committed by GitHub
parent dee8e4e639
commit 87044b2378
12 changed files with 217 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/obs/src/cleaner/mod.rs
+14 -3
View File
@@ -127,8 +127,6 @@ mod tests {
fn assert_parallel_cleanup_completes(file_count: usize, workers: usize) -> std::io::Result<()> {
let tmp = TempDir::new()?;
let dir = tmp.path().to_path_buf();
let expected_freed = (file_count * 256) as u64;
for i in 0..file_count {
create_log_file(&dir, &format!("app.log.2024-01-{i:03}"), 256)?;
}
@@ -160,9 +158,22 @@ mod tests {
name.starts_with("app.log.") && !compressed_suffixes.iter().any(|suffix| name.ends_with(suffix))
})
.count();
let archive_bytes: u64 = std::fs::read_dir(&dir)?
.filter_map(Result::ok)
.filter(|entry| {
let name = entry.file_name();
let name = name.to_string_lossy();
compressed_suffixes.iter().any(|suffix| name.ends_with(suffix))
})
.map(|entry| entry.metadata().map(|metadata| metadata.len()).unwrap_or(0))
.sum();
assert_eq!(result.0, file_count, "all rotated logs should be deleted after compression");
assert_eq!(result.1, expected_freed, "freed bytes should match the removed source files");
assert_eq!(
result.1,
(file_count * 256) as u64 - archive_bytes,
"freed bytes should exclude archive bytes that still remain on disk"
);
assert_eq!(archive_count, file_count, "each rotated log should leave behind one archive");
assert_eq!(original_count, 0, "compressed source logs should be removed");
Ok(())