refactor: centralize startup runtime sources (#3838)

This commit is contained in:
Zhengchao An
2026-06-25 11:31:38 +08:00
committed by GitHub
parent fe5961cc16
commit 839cab47ce
13 changed files with 208 additions and 57 deletions
+30 -6
View File
@@ -5,8 +5,8 @@ Status values: `[ ]` not started, `[~]` in progress, `[x]` complete, `[!]` block
## Current Context
- Issue: [`rustfs/backlog#660`](https://github.com/rustfs/backlog/issues/660)
- Branch: `overtrue/arch-app-context-runtime-source-fallbacks`
- Baseline: completed `C-011/C-012/C-013/API-055/API-059/API-079/API-080/API-081/API-082/API-083/API-084/API-085/API-086/API-087/API-088/API-089/API-090/API-091/API-092/API-093/API-094/API-095/API-096/API-097/API-098/API-099/API-100/API-101/API-102/API-103/API-104/API-105/API-106/API-107/API-108/API-109/API-110/API-111/API-112/API-113/API-114/API-115/API-116/API-117/API-118/API-119/API-120/API-121/API-122/API-123/API-124/API-125/API-126/API-127/API-128/API-129/API-130/API-131/API-132/API-133/API-134/API-135/API-136/API-137/API-138/API-139/API-140/API-141/API-142/API-143/API-144/API-145/API-146/API-147/API-148/API-149/API-150/API-151/API-152/API-153/API-154/API-155/API-156/API-157/API-158/API-159/API-160/API-161/API-162/API-163/API-164/API-165/API-166/API-167/API-168/API-169/API-170/API-171/API-172/API-173/API-174/API-175/API-176/API-177/API-178/API-179/API-180/API-181/API-182/API-183/API-184/API-185/API-186/API-187/API-188/API-189/API-190/API-191/API-192/API-193/API-194/API-195/API-196/API-197/API-198/API-199/API-200/API-201/API-202`.
- Branch: `overtrue/arch-startup-runtime-sources`
- Baseline: completed `C-011/C-012/C-013/API-055/API-059/API-079/API-080/API-081/API-082/API-083/API-084/API-085/API-086/API-087/API-088/API-089/API-090/API-091/API-092/API-093/API-094/API-095/API-096/API-097/API-098/API-099/API-100/API-101/API-102/API-103/API-104/API-105/API-106/API-107/API-108/API-109/API-110/API-111/API-112/API-113/API-114/API-115/API-116/API-117/API-118/API-119/API-120/API-121/API-122/API-123/API-124/API-125/API-126/API-127/API-128/API-129/API-130/API-131/API-132/API-133/API-134/API-135/API-136/API-137/API-138/API-139/API-140/API-141/API-142/API-143/API-144/API-145/API-146/API-147/API-148/API-149/API-150/API-151/API-152/API-153/API-154/API-155/API-156/API-157/API-158/API-159/API-160/API-161/API-162/API-163/API-164/API-165/API-166/API-167/API-168/API-169/API-170/API-171/API-172/API-173/API-174/API-175/API-176/API-177/API-178/API-179/API-180/API-181/API-182/API-183/API-184/API-185/API-186/API-187/API-188/API-189/API-190/API-191/API-192/API-193/API-194/API-195/API-196/API-197/API-198/API-199/API-200/API-201/API-202/API-203`.
- Based on: stacked on PR #3828 head after PR #3827.
- PR type for this branch: `consumer-migration`
- Runtime behavior changes: none.
@@ -41,7 +41,9 @@ Status values: `[ ]` not started, `[~]` in progress, `[x]` complete, `[!]` block
runtime config, erasure-mode, lifecycle queue, and tier runtime source helper
names, plus IAM root-credential, server-config, and notification runtime
source helpers, plus AppContext fallback KMS/IAM/ECStore/config/metrics/TLS
runtime source helpers,
runtime source helpers, plus startup/root KMS, credentials, region,
readiness-time, observability, metrics, buffer, and TLS runtime source
helpers,
through AppContext-first or owner-crate resolver boundaries.
- CI/script changes: lock completed owner and test/fuzz boundaries against
bare/glob imports, scattered raw ECStore facade subpaths, and startup
@@ -52,7 +54,7 @@ Status values: `[ ]` not started, `[~]` in progress, `[x]` complete, `[!]` block
event-bridge thin module regressions, plus IAM runtime-source bypasses;
accept the reviewed AppContext resolver reverse dependencies in the layer
baseline.
- Docs changes: record the API-136 through API-202 owner facade and lifecycle
- Docs changes: record the API-136 through API-203 owner facade and lifecycle
runtime-source cleanup.
## Phase 0 Tasks
@@ -5178,7 +5180,29 @@ Passed before push:
merged API-184.
- `make pre-commit`: passed.
- Issue #660 API-202 current slice:
- Issue #660 API-203 current slice:
- Do: centralize startup/root runtime global publication and initialization
behind `rustfs/src/startup_runtime_sources.rs`, including action
credentials, runtime region/port/address, init time, KMS manager,
observability guard, metrics runtime, buffer profile, and outbound TLS
generation/state metrics.
- Must preserve: startup ordering, embedded startup semantics, KMS
configuration behavior, observability guard error classification, buffer
profile fallback behavior, TLS startup publish behavior, and TLS reload
loop behavior.
- `cargo fmt --all`: passed.
- `cargo fmt --all --check`: passed.
- `./scripts/check_architecture_migration_rules.sh`: passed.
- `./scripts/check_layer_dependencies.sh`: passed.
- `cargo check --tests -p rustfs`: passed.
- `cargo test -p rustfs startup --lib -- --nocapture`: passed.
- `git diff --check`: passed.
- Rust risk scan: passed; no new production unwrap/expect, unchecked narrow
casts, stringly errors, or ad-hoc stdout/stderr.
- `make pre-pr`: passed after rebasing onto current `origin/main`.
- Verification: focused checks and full `make pre-pr` passed before PR.
- Issue #660 API-202 prior slice:
- `cargo test -p rustfs app::context --lib -- --nocapture`: passed.
- `cargo fmt --all`: passed.
- `cargo fmt --all --check`: passed.
@@ -5186,7 +5210,7 @@ Passed before push:
- `./scripts/check_layer_dependencies.sh`: passed.
- AppContext fallback runtime source scan: passed; direct fallback global
reads should be isolated to `rustfs/src/app/context/runtime_sources.rs`.
- Verification: focused checks passed; full `make pre-pr` pending before PR.
- Verification: focused checks and full `make pre-pr` passed before PR.
- Issue #660 API-184 current slice:
- `cargo check -p rustfs-rio --tests`: passed.