refactor: improve object listing and version handling

- Refactor find_version_index to accept Uuid directly instead of string
- Split from_meta_cache_entries_sorted into separate methods for versions and infos
- Add support for after_version_id filtering in version listing
- Fix S3 error code for replication configuration not found
- Improve error handling and logging levels
- Clean up import statements and remove debug code

crates/filemeta/src/fileinfo.rs

@@ -461,13 +461,7 @@ pub struct FileInfoVersions {
 }
 
 impl FileInfoVersions {
-    pub fn find_version_index(&self, v: &str) -> Option<usize> {
-        if v.is_empty() {
-            return None;
-        }
-
-        let vid = Uuid::parse_str(v).unwrap_or_default();
-
+    pub fn find_version_index(&self, vid: Uuid) -> Option<usize> {
         self.versions.iter().position(|v| v.version_id == Some(vid))
     }
 

crates/filemeta/src/filemeta.rs

@@ -2006,11 +2006,7 @@ impl MetaObject {
             if *status == TRANSITION_COMPLETE.as_bytes().to_vec() {
                 let vid = Uuid::parse_str(&fi.tier_free_version_id());
                 if let Err(err) = vid {
-                    panic!(
-                        "Invalid Tier Object delete marker versionId {} {}",
-                        fi.tier_free_version_id(),
-                        err
-                    );
+                    panic!("Invalid Tier Object delete marker versionId {} {}", fi.tier_free_version_id(), err);
                 }
                 let vid = vid.unwrap();
                 let mut free_entry = FileMetaVersion {

crates/obs/src/telemetry.rs

@@ -1,19 +1,19 @@
 use crate::OtelConfig;
-use flexi_logger::{style, Age, Cleanup, Criterion, DeferredNow, FileSpec, LogSpecification, Naming, Record, WriteMode};
+use flexi_logger::{Age, Cleanup, Criterion, DeferredNow, FileSpec, LogSpecification, Naming, Record, WriteMode, style};
 use nu_ansi_term::Color;
 use opentelemetry::trace::TracerProvider;
-use opentelemetry::{global, KeyValue};
+use opentelemetry::{KeyValue, global};
 use opentelemetry_appender_tracing::layer::OpenTelemetryTracingBridge;
 use opentelemetry_otlp::WithExportConfig;
 use opentelemetry_sdk::logs::SdkLoggerProvider;
 use opentelemetry_sdk::{
+    Resource,
     metrics::{MeterProviderBuilder, PeriodicReader, SdkMeterProvider},
     trace::{RandomIdGenerator, Sampler, SdkTracerProvider},
-    Resource,
 };
 use opentelemetry_semantic_conventions::{
-    attribute::{DEPLOYMENT_ENVIRONMENT_NAME, NETWORK_LOCAL_ADDRESS, SERVICE_VERSION as OTEL_SERVICE_VERSION},
     SCHEMA_URL,
+    attribute::{DEPLOYMENT_ENVIRONMENT_NAME, NETWORK_LOCAL_ADDRESS, SERVICE_VERSION as OTEL_SERVICE_VERSION},
 };
 use rustfs_config::{
     APP_NAME, DEFAULT_LOG_DIR, DEFAULT_LOG_KEEP_FILES, DEFAULT_LOG_LEVEL, ENVIRONMENT, METER_INTERVAL, SAMPLE_RATIO,
@@ -28,7 +28,7 @@ use tracing_error::ErrorLayer;
 use tracing_opentelemetry::{MetricsLayer, OpenTelemetryLayer};
 use tracing_subscriber::fmt::format::FmtSpan;
 use tracing_subscriber::fmt::time::LocalTime;
-use tracing_subscriber::{layer::SubscriberExt, util::SubscriberInitExt, EnvFilter, Layer};
+use tracing_subscriber::{EnvFilter, Layer, layer::SubscriberExt, util::SubscriberInitExt};
 
 /// A guard object that manages the lifecycle of OpenTelemetry components.
 ///

crates/utils/src/os/windows.rs

@@ -40,14 +40,12 @@ pub fn get_info(p: impl AsRef<Path>) -> std::io::Result<DiskInfo> {
     let free = unsafe { *lp_total_number_of_free_bytes.QuadPart() };
 
     if free > total {
-        return Err(Error::other(
-            format!(
-                "detected free space ({}) > total drive space ({}), fs corruption at ({}). please run 'fsck'",
-                free,
-                total,
-                p.as_ref().display()
-            ),
-        ));
+        return Err(Error::other(format!(
+            "detected free space ({}) > total drive space ({}), fs corruption at ({}). please run 'fsck'",
+            free,
+            total,
+            p.as_ref().display()
+        )));
     }
 
     let mut lp_sectors_per_cluster: DWORD = 0;

crates/utils/src/retry.rs

@@ -65,4 +65,4 @@ impl Stream for RetryTimer {
 
 pub fn new_retry_timer(_max_retry: i32, _base_sleep: Duration, _max_sleep: Duration, _jitter: f64) -> Vec<i32> {
     todo!();
-}
+}