chore(ecstore): adjudicate 32 bare dead_code allows (#6173)

mirror of https://github.com/rustfs/rustfs.git synced 2026-08-18 18:46:17 +00:00

Replace every bare `#[allow(dead_code)]` in ecstore with either a deletion or a per-item allow carrying a `reason`. Blanket allows at module, struct, and impl level silence the lint for future members too, so each is narrowed to the members that are actually dead.

Delete the dead cluster in `config/heal.rs` (`Config`, its three methods, `RUSTFS_BITROT_CYCLE_IN_MONTHS`, `parse_bitrot_config`) rather than annotate it: it has no callers and is unreachable outside the crate, and `parse_bitrot_config` would panic on its disabled path via `Duration::from_secs_f64(-1.0)`. `DEFAULT_KVS` stays, since the config registry uses it.

Correct two `reason` strings on `Checksum::new` and `PutObjReader::md5_current_hex_string`, which are methods but carried a field-only rationale.

Refs backlog#1823

Co-authored-by: houseme <housemecn@gmail.com>

This commit is contained in:

Zhengchao An

2026-08-18 07:51:56 +08:00

committed by

GitHub

parent beb6e1383e

commit 7cb91a0190

20 changed files with 59 additions and 91 deletions

									
										crates/ecstore/src/client/api_get_options.rs
									
		-1
	
												View File
												
				@@ -27,7 +27,6 @@ use tracing::warn;

				use crate::client::api_error_response::err_invalid_argument;

				#[derive(Default)]

				#[allow(dead_code)]

				pub struct AdvancedGetOptions {

				    pub replication_delete_marker: bool,

				    pub is_replication_ready_for_delete_marker: bool,