From 7c2b513613626b09a55101308079b9d33bb0e3ce Mon Sep 17 00:00:00 2001 From: Zhengchao An Date: Fri, 14 Aug 2026 08:10:49 +0800 Subject: [PATCH] chore(obs): drop 44 dead_code blankets from the metrics tree (#6086) --- crates/obs/src/metrics/collectors/audit.rs | 2 -- .../obs/src/metrics/collectors/cluster_config.rs | 2 -- .../src/metrics/collectors/cluster_erasure_set.rs | 2 -- .../obs/src/metrics/collectors/cluster_health.rs | 2 -- crates/obs/src/metrics/collectors/cluster_iam.rs | 2 -- crates/obs/src/metrics/collectors/cluster_usage.rs | 2 -- crates/obs/src/metrics/collectors/ilm.rs | 2 -- crates/obs/src/metrics/collectors/notification.rs | 2 -- .../src/metrics/collectors/notification_target.rs | 2 -- crates/obs/src/metrics/collectors/replication.rs | 2 -- crates/obs/src/metrics/collectors/request.rs | 2 -- crates/obs/src/metrics/collectors/scanner.rs | 2 -- crates/obs/src/metrics/collectors/system_cpu.rs | 2 -- crates/obs/src/metrics/collectors/system_drive.rs | 2 -- crates/obs/src/metrics/collectors/system_gpu.rs | 2 -- crates/obs/src/metrics/collectors/system_memory.rs | 2 -- .../obs/src/metrics/collectors/system_network.rs | 2 -- .../obs/src/metrics/collectors/system_process.rs | 2 -- crates/obs/src/metrics/schema/audit.rs | 2 -- crates/obs/src/metrics/schema/bucket.rs | 2 -- .../obs/src/metrics/schema/bucket_replication.rs | 2 -- crates/obs/src/metrics/schema/cluster.rs | 2 -- crates/obs/src/metrics/schema/cluster_config.rs | 2 -- .../obs/src/metrics/schema/cluster_erasure_set.rs | 2 -- crates/obs/src/metrics/schema/cluster_health.rs | 2 -- crates/obs/src/metrics/schema/cluster_iam.rs | 2 -- .../obs/src/metrics/schema/cluster_notification.rs | 2 -- crates/obs/src/metrics/schema/cluster_usage.rs | 2 -- crates/obs/src/metrics/schema/ilm.rs | 2 -- crates/obs/src/metrics/schema/node_bucket.rs | 2 -- crates/obs/src/metrics/schema/node_disk.rs | 2 -- .../obs/src/metrics/schema/notification_target.rs | 2 -- crates/obs/src/metrics/schema/process_resource.rs | 2 -- crates/obs/src/metrics/schema/replication.rs | 2 -- crates/obs/src/metrics/schema/request.rs | 14 ++++++++++++-- crates/obs/src/metrics/schema/scanner.rs | 2 -- crates/obs/src/metrics/schema/system_cpu.rs | 2 -- crates/obs/src/metrics/schema/system_drive.rs | 2 -- crates/obs/src/metrics/schema/system_gpu.rs | 2 -- crates/obs/src/metrics/schema/system_memory.rs | 2 -- crates/obs/src/metrics/schema/system_network.rs | 2 -- .../obs/src/metrics/schema/system_network_host.rs | 2 -- crates/obs/src/metrics/schema/system_process.rs | 2 -- crates/obs/src/metrics/stats_collector.rs | 2 -- 44 files changed, 12 insertions(+), 88 deletions(-) diff --git a/crates/obs/src/metrics/collectors/audit.rs b/crates/obs/src/metrics/collectors/audit.rs index eb6d75f30..506c2390d 100644 --- a/crates/obs/src/metrics/collectors/audit.rs +++ b/crates/obs/src/metrics/collectors/audit.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! Audit metrics collector. //! //! Collects audit log metrics including failed messages, queue length, diff --git a/crates/obs/src/metrics/collectors/cluster_config.rs b/crates/obs/src/metrics/collectors/cluster_config.rs index e079be17e..5985b6017 100644 --- a/crates/obs/src/metrics/collectors/cluster_config.rs +++ b/crates/obs/src/metrics/collectors/cluster_config.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! Cluster config metrics collector. //! //! Collects cluster configuration metrics including storage class diff --git a/crates/obs/src/metrics/collectors/cluster_erasure_set.rs b/crates/obs/src/metrics/collectors/cluster_erasure_set.rs index 0a94b10a3..b919b17e0 100644 --- a/crates/obs/src/metrics/collectors/cluster_erasure_set.rs +++ b/crates/obs/src/metrics/collectors/cluster_erasure_set.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! Cluster erasure set metrics collector. //! //! Collects erasure coding set metrics including parity, quorum, diff --git a/crates/obs/src/metrics/collectors/cluster_health.rs b/crates/obs/src/metrics/collectors/cluster_health.rs index 2f579c163..d84c428d4 100644 --- a/crates/obs/src/metrics/collectors/cluster_health.rs +++ b/crates/obs/src/metrics/collectors/cluster_health.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! Cluster health metrics collector. //! //! Collects cluster-wide health metrics including drive counts diff --git a/crates/obs/src/metrics/collectors/cluster_iam.rs b/crates/obs/src/metrics/collectors/cluster_iam.rs index 39a5e187f..435c5b39d 100644 --- a/crates/obs/src/metrics/collectors/cluster_iam.rs +++ b/crates/obs/src/metrics/collectors/cluster_iam.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! Cluster IAM metrics collector. //! //! Collects IAM (Identity and Access Management) metrics including diff --git a/crates/obs/src/metrics/collectors/cluster_usage.rs b/crates/obs/src/metrics/collectors/cluster_usage.rs index c493145ec..76ccd6cf5 100644 --- a/crates/obs/src/metrics/collectors/cluster_usage.rs +++ b/crates/obs/src/metrics/collectors/cluster_usage.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! Cluster usage metrics collector. //! //! Collects cluster-wide and per-bucket usage metrics including diff --git a/crates/obs/src/metrics/collectors/ilm.rs b/crates/obs/src/metrics/collectors/ilm.rs index 664f3a36b..d9a3d55a3 100644 --- a/crates/obs/src/metrics/collectors/ilm.rs +++ b/crates/obs/src/metrics/collectors/ilm.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! ILM (Information Lifecycle Management) metrics collector. //! //! Collects ILM metrics including pending tasks, active tasks, diff --git a/crates/obs/src/metrics/collectors/notification.rs b/crates/obs/src/metrics/collectors/notification.rs index 2c7d97f61..7a10e0efd 100644 --- a/crates/obs/src/metrics/collectors/notification.rs +++ b/crates/obs/src/metrics/collectors/notification.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! Notification metrics collector. //! //! Collects notification system metrics including events sent, diff --git a/crates/obs/src/metrics/collectors/notification_target.rs b/crates/obs/src/metrics/collectors/notification_target.rs index 797f00ff4..7f6095285 100644 --- a/crates/obs/src/metrics/collectors/notification_target.rs +++ b/crates/obs/src/metrics/collectors/notification_target.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::metrics::report::PrometheusMetric; use crate::metrics::schema::notification_target::{ NOTIFICATION_TARGET_FAILED_MESSAGES_BY_SERVER_MD, NOTIFICATION_TARGET_FAILED_MESSAGES_MD, diff --git a/crates/obs/src/metrics/collectors/replication.rs b/crates/obs/src/metrics/collectors/replication.rs index c1311696b..4dc347058 100644 --- a/crates/obs/src/metrics/collectors/replication.rs +++ b/crates/obs/src/metrics/collectors/replication.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! Replication metrics collector. //! //! Collects cluster-wide replication metrics including queue stats, diff --git a/crates/obs/src/metrics/collectors/request.rs b/crates/obs/src/metrics/collectors/request.rs index 2aae53666..fe5037102 100644 --- a/crates/obs/src/metrics/collectors/request.rs +++ b/crates/obs/src/metrics/collectors/request.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! API request metrics collector. //! //! Collects API request metrics including request counts, errors, diff --git a/crates/obs/src/metrics/collectors/scanner.rs b/crates/obs/src/metrics/collectors/scanner.rs index 7ce05c23d..db220ca96 100644 --- a/crates/obs/src/metrics/collectors/scanner.rs +++ b/crates/obs/src/metrics/collectors/scanner.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! Scanner metrics collector. //! //! Collects background scanner metrics including bucket-drive scans, diff --git a/crates/obs/src/metrics/collectors/system_cpu.rs b/crates/obs/src/metrics/collectors/system_cpu.rs index 5e829a8b4..88fde08ef 100644 --- a/crates/obs/src/metrics/collectors/system_cpu.rs +++ b/crates/obs/src/metrics/collectors/system_cpu.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! System CPU metrics collector. //! //! Collects CPU metrics including load average, CPU time distribution, diff --git a/crates/obs/src/metrics/collectors/system_drive.rs b/crates/obs/src/metrics/collectors/system_drive.rs index 936a88c4e..8306ef175 100644 --- a/crates/obs/src/metrics/collectors/system_drive.rs +++ b/crates/obs/src/metrics/collectors/system_drive.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! System drive metrics collector. //! //! Collects detailed drive/disk metrics including capacity, I/O statistics, diff --git a/crates/obs/src/metrics/collectors/system_gpu.rs b/crates/obs/src/metrics/collectors/system_gpu.rs index beb0aca3c..72719c0ad 100644 --- a/crates/obs/src/metrics/collectors/system_gpu.rs +++ b/crates/obs/src/metrics/collectors/system_gpu.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! System GPU metrics collector. //! //! Collects GPU memory usage metrics using NVML library. diff --git a/crates/obs/src/metrics/collectors/system_memory.rs b/crates/obs/src/metrics/collectors/system_memory.rs index c9e319365..acd4ad4e9 100644 --- a/crates/obs/src/metrics/collectors/system_memory.rs +++ b/crates/obs/src/metrics/collectors/system_memory.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! System memory metrics collector. //! //! Collects memory-related metrics including total, used, free, diff --git a/crates/obs/src/metrics/collectors/system_network.rs b/crates/obs/src/metrics/collectors/system_network.rs index 8bb660de0..4bd4949c0 100644 --- a/crates/obs/src/metrics/collectors/system_network.rs +++ b/crates/obs/src/metrics/collectors/system_network.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! System network metrics collector. //! //! Collects internode network metrics including errors, dial times, diff --git a/crates/obs/src/metrics/collectors/system_process.rs b/crates/obs/src/metrics/collectors/system_process.rs index 708c1e975..99dfd83b9 100644 --- a/crates/obs/src/metrics/collectors/system_process.rs +++ b/crates/obs/src/metrics/collectors/system_process.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! System process metrics collector. //! //! Collects process-level metrics including file descriptors, memory, diff --git a/crates/obs/src/metrics/schema/audit.rs b/crates/obs/src/metrics/schema/audit.rs index b08e95269..a4021c323 100644 --- a/crates/obs/src/metrics/schema/audit.rs +++ b/crates/obs/src/metrics/schema/audit.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/bucket.rs b/crates/obs/src/metrics/schema/bucket.rs index e4af34615..d5d8d802d 100644 --- a/crates/obs/src/metrics/schema/bucket.rs +++ b/crates/obs/src/metrics/schema/bucket.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/bucket_replication.rs b/crates/obs/src/metrics/schema/bucket_replication.rs index 1d7b1c924..2131c7412 100644 --- a/crates/obs/src/metrics/schema/bucket_replication.rs +++ b/crates/obs/src/metrics/schema/bucket_replication.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/cluster.rs b/crates/obs/src/metrics/schema/cluster.rs index 58637fc0f..ee4793ced 100644 --- a/crates/obs/src/metrics/schema/cluster.rs +++ b/crates/obs/src/metrics/schema/cluster.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/cluster_config.rs b/crates/obs/src/metrics/schema/cluster_config.rs index 2b10d3fb2..eb35a9036 100644 --- a/crates/obs/src/metrics/schema/cluster_config.rs +++ b/crates/obs/src/metrics/schema/cluster_config.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/cluster_erasure_set.rs b/crates/obs/src/metrics/schema/cluster_erasure_set.rs index 3c496f92f..23f852d28 100644 --- a/crates/obs/src/metrics/schema/cluster_erasure_set.rs +++ b/crates/obs/src/metrics/schema/cluster_erasure_set.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/cluster_health.rs b/crates/obs/src/metrics/schema/cluster_health.rs index 444bfa927..1c8b05614 100644 --- a/crates/obs/src/metrics/schema/cluster_health.rs +++ b/crates/obs/src/metrics/schema/cluster_health.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/cluster_iam.rs b/crates/obs/src/metrics/schema/cluster_iam.rs index 7c0ff00a3..4c0bae72c 100644 --- a/crates/obs/src/metrics/schema/cluster_iam.rs +++ b/crates/obs/src/metrics/schema/cluster_iam.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/cluster_notification.rs b/crates/obs/src/metrics/schema/cluster_notification.rs index 5fbedc67c..8be9a9807 100644 --- a/crates/obs/src/metrics/schema/cluster_notification.rs +++ b/crates/obs/src/metrics/schema/cluster_notification.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/cluster_usage.rs b/crates/obs/src/metrics/schema/cluster_usage.rs index 24dab6187..4b44104ed 100644 --- a/crates/obs/src/metrics/schema/cluster_usage.rs +++ b/crates/obs/src/metrics/schema/cluster_usage.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/ilm.rs b/crates/obs/src/metrics/schema/ilm.rs index 01316de37..ac0538654 100644 --- a/crates/obs/src/metrics/schema/ilm.rs +++ b/crates/obs/src/metrics/schema/ilm.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/node_bucket.rs b/crates/obs/src/metrics/schema/node_bucket.rs index c8e2393da..77561ee92 100644 --- a/crates/obs/src/metrics/schema/node_bucket.rs +++ b/crates/obs/src/metrics/schema/node_bucket.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, MetricSubsystem, new_gauge_md}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/node_disk.rs b/crates/obs/src/metrics/schema/node_disk.rs index fad52b6c7..3a521e3fd 100644 --- a/crates/obs/src/metrics/schema/node_disk.rs +++ b/crates/obs/src/metrics/schema/node_disk.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, MetricSubsystem, new_gauge_md}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/notification_target.rs b/crates/obs/src/metrics/schema/notification_target.rs index 32c4c4502..cec0ca9cf 100644 --- a/crates/obs/src/metrics/schema/notification_target.rs +++ b/crates/obs/src/metrics/schema/notification_target.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/process_resource.rs b/crates/obs/src/metrics/schema/process_resource.rs index 5bac84f5a..d0a243a3a 100644 --- a/crates/obs/src/metrics/schema/process_resource.rs +++ b/crates/obs/src/metrics/schema/process_resource.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::node_identity::SERVER_LABEL; use crate::{MetricDescriptor, MetricName, MetricSubsystem, new_gauge_md}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/replication.rs b/crates/obs/src/metrics/schema/replication.rs index 93cd0cbd7..1290a770e 100644 --- a/crates/obs/src/metrics/schema/replication.rs +++ b/crates/obs/src/metrics/schema/replication.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/request.rs b/crates/obs/src/metrics/schema/request.rs index 9f90a64c9..8009742ab 100644 --- a/crates/obs/src/metrics/schema/request.rs +++ b/crates/obs/src/metrics/schema/request.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, MetricSubsystem, new_counter_md, new_gauge_md, subsystems}; use std::sync::LazyLock; /// name label @@ -32,6 +30,13 @@ const API_SERVER_NAME_TYPE_LE_LABELS: [&str; 4] = [SERVER_LABEL, NAME_LABEL, TYP const API_TYPE_LABELS: [&str; 1] = [TYPE_LABEL]; const API_SERVER_TYPE_LABELS: [&str; 2] = [SERVER_LABEL, TYPE_LABEL]; +// Declared for MinIO metric parity but never emitted: no collector passes these +// descriptors to `PrometheusMetric::from_descriptor`, so the wire names +// (`rejected_auth_total`, `rejected_header_total`, `rejected_timestamp_total`, +// `rejected_invalid_total`, `waiting_total`, `incoming_total`) never appear in a +// scrape. Kept so the gap stays greppable rather than silently disappearing with +// their `MetricName` variants; wiring an emitter is what retires these allows. +#[allow(dead_code, reason = "declared metric with no emitter; see note above (backlog#1823)")] pub static API_REJECTED_AUTH_TOTAL_MD: LazyLock = LazyLock::new(|| { new_counter_md( MetricName::ApiRejectedAuthTotal, @@ -41,6 +46,7 @@ pub static API_REJECTED_AUTH_TOTAL_MD: LazyLock = LazyLock::ne ) }); +#[allow(dead_code, reason = "declared metric with no emitter; see note above (backlog#1823)")] pub static API_REJECTED_HEADER_TOTAL_MD: LazyLock = LazyLock::new(|| { new_counter_md( MetricName::ApiRejectedHeaderTotal, @@ -50,6 +56,7 @@ pub static API_REJECTED_HEADER_TOTAL_MD: LazyLock = LazyLock:: ) }); +#[allow(dead_code, reason = "declared metric with no emitter; see note above (backlog#1823)")] pub static API_REJECTED_TIMESTAMP_TOTAL_MD: LazyLock = LazyLock::new(|| { new_counter_md( MetricName::ApiRejectedTimestampTotal, @@ -59,6 +66,7 @@ pub static API_REJECTED_TIMESTAMP_TOTAL_MD: LazyLock = LazyLoc ) }); +#[allow(dead_code, reason = "declared metric with no emitter; see note above (backlog#1823)")] pub static API_REJECTED_INVALID_TOTAL_MD: LazyLock = LazyLock::new(|| { new_counter_md( MetricName::ApiRejectedInvalidTotal, @@ -68,6 +76,7 @@ pub static API_REJECTED_INVALID_TOTAL_MD: LazyLock = LazyLock: ) }); +#[allow(dead_code, reason = "declared metric with no emitter; see note above (backlog#1823)")] pub static API_REQUESTS_WAITING_TOTAL_MD: LazyLock = LazyLock::new(|| { new_gauge_md( MetricName::ApiRequestsWaitingTotal, @@ -77,6 +86,7 @@ pub static API_REQUESTS_WAITING_TOTAL_MD: LazyLock = LazyLock: ) }); +#[allow(dead_code, reason = "declared metric with no emitter; see note above (backlog#1823)")] pub static API_REQUESTS_INCOMING_TOTAL_MD: LazyLock = LazyLock::new(|| { new_gauge_md( MetricName::ApiRequestsIncomingTotal, diff --git a/crates/obs/src/metrics/schema/scanner.rs b/crates/obs/src/metrics/schema/scanner.rs index a9027bf07..53cb9548b 100644 --- a/crates/obs/src/metrics/schema/scanner.rs +++ b/crates/obs/src/metrics/schema/scanner.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/system_cpu.rs b/crates/obs/src/metrics/schema/system_cpu.rs index f0a3ea784..8ef132128 100644 --- a/crates/obs/src/metrics/schema/system_cpu.rs +++ b/crates/obs/src/metrics/schema/system_cpu.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::node_identity::SERVER_LABEL; use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems}; /// CPU system-related metric descriptors diff --git a/crates/obs/src/metrics/schema/system_drive.rs b/crates/obs/src/metrics/schema/system_drive.rs index e32fab738..e64ee0b9d 100644 --- a/crates/obs/src/metrics/schema/system_drive.rs +++ b/crates/obs/src/metrics/schema/system_drive.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/system_gpu.rs b/crates/obs/src/metrics/schema/system_gpu.rs index 958e6cace..02c0db587 100644 --- a/crates/obs/src/metrics/schema/system_gpu.rs +++ b/crates/obs/src/metrics/schema/system_gpu.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! GPU-related metric descriptors. //! //! This module defines metric descriptors for GPU monitoring, diff --git a/crates/obs/src/metrics/schema/system_memory.rs b/crates/obs/src/metrics/schema/system_memory.rs index 0ffa9f193..7204bd984 100644 --- a/crates/obs/src/metrics/schema/system_memory.rs +++ b/crates/obs/src/metrics/schema/system_memory.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::node_identity::SERVER_LABEL; use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/system_network.rs b/crates/obs/src/metrics/schema/system_network.rs index 5571951fd..425fc1655 100644 --- a/crates/obs/src/metrics/schema/system_network.rs +++ b/crates/obs/src/metrics/schema/system_network.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::node_identity::SERVER_LABEL; use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/system_network_host.rs b/crates/obs/src/metrics/schema/system_network_host.rs index 45cc89ffe..26d4cc98f 100644 --- a/crates/obs/src/metrics/schema/system_network_host.rs +++ b/crates/obs/src/metrics/schema/system_network_host.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::node_identity::SERVER_LABEL; use crate::{MetricDescriptor, MetricName, new_counter_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/schema/system_process.rs b/crates/obs/src/metrics/schema/system_process.rs index ecddbc9c3..c6b45453b 100644 --- a/crates/obs/src/metrics/schema/system_process.rs +++ b/crates/obs/src/metrics/schema/system_process.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - use crate::node_identity::SERVER_LABEL; use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems}; use std::sync::LazyLock; diff --git a/crates/obs/src/metrics/stats_collector.rs b/crates/obs/src/metrics/stats_collector.rs index c312f7eff..cf5e77025 100644 --- a/crates/obs/src/metrics/stats_collector.rs +++ b/crates/obs/src/metrics/stats_collector.rs @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#![allow(dead_code)] - //! Statistics collection functions for metrics. //! //! This module contains functions that collect statistics from various