gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-08-27 15:37:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(quota): keep the degraded-baseline fallback off the write path's stack (#5728)

Browse Source 
The fallback future embeds the whole snapshot loader, and every object write nests a quota check several futures deep, so inlining it grew each write's state machine by the loader's full size — the debug-build 2MiB worker-stack overflow class fixed for bucket-config writes in #5648. Box the fallback at its call site; the allocation only happens on the degraded path.
This commit is contained in:
Zhengchao An
2026-08-05 11:02:33 +08:00
committed by GitHub
parent d2e5346044
commit 75d0c8d6b9
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ecstore/src/bucket/quota/checker.rs
+7 -1
View File
@@ -214,7 +214,13 @@ impl QuotaChecker {
// the writes issued before the next complete scanner cycle. Buckets // the writes issued before the next complete scanner cycle. Buckets
// with no persisted baseline anywhere keep failing closed. // with no persisted baseline anywhere keep failing closed.
let store = self.metadata_sys.read().await.object_store(); let store = self.metadata_sys.read().await.object_store();
if let Some(baseline) = crate::data_usage::lookup_degraded_bucket_usage_baseline(store, bucket).await { // Box the fallback: it embeds the whole snapshot-load future, and every
// object write nests a quota check several futures deep, so keeping it
// inline would grow each write's state machine by the loader's full
// size — the debug-build 2MiB worker-stack overflow class fixed for
// bucket-config writes in #5648. The allocation only happens on the
// degraded path; the authoritative fast path returns above.
if let Some(baseline) = Box::pin(crate::data_usage::lookup_degraded_bucket_usage_baseline(store, bucket)).await {
debug!(bucket, baseline, "Bucket quota admission using degraded persisted usage baseline"); debug!(bucket, baseline, "Bucket quota admission using degraded persisted usage baseline");
return Ok(baseline); return Ok(baseline);
} }