refactor(replication): isolate storage api contracts (#4240)

* refactor(replication): isolate storage api contracts

* docs(replication): record storage api contract boundary

crates/storage-api/Cargo.toml

@@ -29,9 +29,8 @@ doctest = false
 
 [dependencies]
 async-trait.workspace = true
-# NOTE: This dependency on rustfs-filemeta is a known architectural limitation.
-# The replication types (ReplicationStatusType, VersionPurgeStatusType, ReplicationState)
-# are shared between storage-api and filemeta. Moving them would require changes in 300+ files.
+# Storage-facing replication contracts are isolated in src/replication.rs until
+# the underlying wire types can move without creating a replication/storage-api cycle.
 rustfs-filemeta.workspace = true
 serde.workspace = true
 time.workspace = true

crates/storage-api/src/lib.rs

@@ -23,6 +23,8 @@ pub mod object;
 pub mod observability;
 pub mod topology;
 
+mod replication;
+
 pub use admin::{DiskSetSelector, StorageAdminApi};
 pub use bucket::{BucketInfo, BucketOperations, BucketOptions, DeleteBucketOptions, MakeBucketOptions, SRBucketDeleteOp};
 pub use capability::{CapabilitySnapshotError, CapabilityState, CapabilityStatus};

crates/storage-api/src/object.rs

@@ -15,7 +15,7 @@
 use std::fmt;
 use std::sync::Arc;
 
-use rustfs_filemeta::{
+use crate::replication::{
     ReplicationState, ReplicationStatusType, VersionPurgeStatusType, replication_statuses_map, version_purge_statuses_map,
 };
 use time::OffsetDateTime;

crates/storage-api/src/replication.rs

@@ -0,0 +1,17 @@
+// Copyright 2024 RustFS Team
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+pub(crate) use rustfs_filemeta::{
+    ReplicationState, ReplicationStatusType, VersionPurgeStatusType, replication_statuses_map, version_purge_statuses_map,
+};