Merge branch 'main' of github.com:rustfs/rustfs into houseme/get-small-file-optimization

* 'main' of github.com:rustfs/rustfs:
  fix(data-usage): refresh versioned usage state (#3969)
  ci: add protocol feature test matrix (swift, sftp, no-default) (#736) (#3975)
  chore: replace blanket #![allow(dead_code)] with #![warn(dead_code)] (#742) (#3974)

.github/workflows/ci.yml

@@ -178,6 +178,44 @@ jobs:
       - name: Run rio-v2 clippy lints
         run: cargo clippy -p rustfs -p rustfs-ecstore --all-targets --features rio-v2 -- -D warnings
 
+  test-and-lint-protocols:
+    name: "Test and Lint (${{ matrix.features.name }})"
+    needs: skip-check
+    if: needs.skip-check.outputs.should_skip != 'true'
+    runs-on: ubicloud-standard-4
+    timeout-minutes: 60
+    strategy:
+      fail-fast: false
+      matrix:
+        features:
+          - name: swift
+            flags: "--features swift"
+          - name: sftp
+            flags: "--features sftp"
+          - name: no-default
+            flags: "--no-default-features"
+    env:
+      FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v7
+
+      - name: Setup Rust environment
+        uses: ./.github/actions/setup
+        with:
+          rust-version: stable
+          cache-shared-key: ci-test-${{ matrix.features.name }}-${{ hashFiles('**/Cargo.lock') }}
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          cache-save-if: ${{ github.ref == 'refs/heads/main' }}
+
+      - name: Run tests with ${{ matrix.features.name }}
+        run: |
+          cargo nextest run -p rustfs -p rustfs-protocols ${{ matrix.features.flags }}
+
+      - name: Run clippy with ${{ matrix.features.name }}
+        run: |
+          cargo clippy -p rustfs -p rustfs-protocols --all-targets ${{ matrix.features.flags }} -- -D warnings
+
   build-rustfs-debug-binary:
     name: Build RustFS Debug Binary
     needs: skip-check

crates/checksums/src/base64.rs

@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use base64_simd::STANDARD;
 use std::error::Error;

crates/ecstore/src/data_usage/mod.rs

@@ -14,7 +14,11 @@
 
 pub mod local_snapshot;
 
-use crate::storage_api_contracts::{list::ListOperations as _, object::ObjectIO as _};
+use crate::storage_api_contracts::{
+    bucket::{BucketOperations as _, BucketOptions},
+    list::ListOperations as _,
+    object::ObjectIO as _,
+};
 use crate::{
     bucket::{metadata_sys::get_replication_config, versioning::VersioningApi as _, versioning_sys::BucketVersioningSys},
     config::com::read_config,
@@ -463,7 +467,20 @@ pub async fn compute_bucket_usage(store: Arc<ECStore>, bucket_name: &str) -> Res
 }
 
 pub async fn refresh_versioned_bucket_usage_from_object_layer(store: Arc<ECStore>, data_usage_info: &mut DataUsageInfo) {
-    let buckets = data_usage_info.buckets_usage.keys().cloned().collect::<Vec<String>>();
+    let listed_bucket_names = match store
+        .list_bucket(&BucketOptions {
+            no_metadata: true,
+            ..Default::default()
+        })
+        .await
+    {
+        Ok(buckets) => buckets.into_iter().map(|bucket| bucket.name).collect::<Vec<_>>(),
+        Err(err) => {
+            debug!(error = %err, "failed to list buckets while refreshing versioned bucket usage");
+            Vec::new()
+        }
+    };
+    let buckets = bucket_names_for_versioned_refresh(data_usage_info, listed_bucket_names);
     let mut changed = false;
 
     for bucket in buckets {
@@ -475,6 +492,7 @@ pub async fn refresh_versioned_bucket_usage_from_object_layer(store: Arc<ECStore
             continue;
         }
 
+        let refresh_started_at = SystemTime::now();
         let usage = match compute_bucket_usage(store.clone(), &bucket).await {
             Ok(usage) => usage,
             Err(err) => {
@@ -487,6 +505,7 @@ pub async fn refresh_versioned_bucket_usage_from_object_layer(store: Arc<ECStore
             }
         };
 
+        replace_bucket_usage_memory_from_authoritative(&bucket, usage.clone(), refresh_started_at).await;
         data_usage_info.bucket_sizes.insert(bucket.clone(), usage.size);
         data_usage_info.buckets_usage.insert(bucket, usage);
         changed = true;
@@ -498,6 +517,18 @@ pub async fn refresh_versioned_bucket_usage_from_object_layer(store: Arc<ECStore
     }
 }
 
+fn bucket_names_for_versioned_refresh(
+    data_usage_info: &DataUsageInfo,
+    listed_bucket_names: impl IntoIterator<Item = String>,
+) -> Vec<String> {
+    let mut buckets = data_usage_info.buckets_usage.keys().cloned().collect::<HashSet<String>>();
+    buckets.extend(listed_bucket_names.into_iter().filter(|bucket| !bucket.is_empty()));
+
+    let mut buckets = buckets.into_iter().collect::<Vec<_>>();
+    buckets.sort();
+    buckets
+}
+
 async fn ensure_bucket_usage_cached(bucket: &str) {
     let cache = memory_cache().read().await;
     if cache.contains_key(bucket) {
@@ -540,6 +571,17 @@ fn bucket_usage_counts_match(left: &BucketUsageInfo, right: &BucketUsageInfo) ->
         && left.delete_markers_count == right.delete_markers_count
 }
 
+async fn replace_bucket_usage_memory_from_authoritative(bucket: &str, usage: BucketUsageInfo, refresh_started_at: SystemTime) {
+    let mut cache = memory_cache().write().await;
+    if let Some(existing) = cache.get(bucket)
+        && existing.usage_updated_at > refresh_started_at
+    {
+        return;
+    }
+
+    cache.insert(bucket.to_string(), cached_bucket_usage_from_backend(usage, refresh_started_at));
+}
+
 /// Fast in-memory update for immediate quota and admin usage consistency.
 pub async fn record_bucket_object_write_memory(bucket: &str, previous_current_size: Option<u64>, new_size: u64) {
     record_bucket_object_write_memory_inner(bucket, previous_current_size, new_size, false).await;
@@ -1263,6 +1305,105 @@ mod tests {
         );
     }
 
+    #[test]
+    fn versioned_refresh_bucket_names_include_live_buckets_without_usage_snapshot() {
+        let mut persisted = DataUsageInfo::default();
+        persisted.buckets_usage.insert(
+            "bucket-a".to_string(),
+            BucketUsageInfo {
+                objects_count: 1,
+                versions_count: 1,
+                size: 10,
+                ..Default::default()
+            },
+        );
+
+        let buckets = bucket_names_for_versioned_refresh(&persisted, vec!["bucket-b".to_string(), "bucket-a".to_string()]);
+
+        assert_eq!(buckets, vec!["bucket-a".to_string(), "bucket-b".to_string()]);
+    }
+
+    #[tokio::test]
+    #[serial]
+    async fn authoritative_versioned_refresh_replaces_stale_dirty_memory() {
+        clear_usage_memory_cache_for_test().await;
+
+        let old_persisted = data_usage_info_for_test("bucket-a", 0, 0, SystemTime::now() - Duration::from_secs(10));
+        replace_bucket_usage_memory_from_info(&old_persisted).await;
+        record_bucket_object_write_memory("bucket-a", None, 15).await;
+
+        let authoritative = BucketUsageInfo {
+            objects_count: 1,
+            versions_count: 1,
+            delete_markers_count: 1,
+            size: 10,
+            ..Default::default()
+        };
+        replace_bucket_usage_memory_from_authoritative("bucket-a", authoritative.clone(), SystemTime::now()).await;
+
+        let mut response = old_persisted.clone();
+        response.buckets_usage.insert("bucket-a".to_string(), authoritative);
+        response.bucket_sizes.insert("bucket-a".to_string(), 10);
+        response.calculate_totals();
+
+        apply_bucket_usage_memory_overlay(&mut response).await;
+
+        assert_eq!(response.objects_total_count, 1);
+        assert_eq!(response.versions_total_count, 1);
+        assert_eq!(response.delete_markers_total_count, 1);
+        assert_eq!(response.objects_total_size, 10);
+        assert_eq!(
+            response.buckets_usage.get("bucket-a").map(|usage| (
+                usage.objects_count,
+                usage.versions_count,
+                usage.delete_markers_count,
+                usage.size
+            )),
+            Some((1, 1, 1, 10))
+        );
+    }
+
+    #[tokio::test]
+    #[serial]
+    async fn authoritative_versioned_refresh_preserves_newer_dirty_memory() {
+        clear_usage_memory_cache_for_test().await;
+
+        let old_persisted = data_usage_info_for_test("bucket-a", 0, 0, SystemTime::now() - Duration::from_secs(10));
+        replace_bucket_usage_memory_from_info(&old_persisted).await;
+        let refresh_started = SystemTime::now() - Duration::from_secs(1);
+        record_bucket_object_write_memory("bucket-a", None, 15).await;
+
+        replace_bucket_usage_memory_from_authoritative(
+            "bucket-a",
+            BucketUsageInfo {
+                objects_count: 1,
+                versions_count: 1,
+                delete_markers_count: 1,
+                size: 10,
+                ..Default::default()
+            },
+            refresh_started,
+        )
+        .await;
+
+        let mut response = old_persisted.clone();
+        apply_bucket_usage_memory_overlay(&mut response).await;
+
+        assert_eq!(response.objects_total_count, 1);
+        assert_eq!(response.versions_total_count, 1);
+        assert_eq!(response.delete_markers_total_count, 0);
+        assert_eq!(response.objects_total_size, 15);
+        assert_eq!(
+            response.buckets_usage.get("bucket-a").map(|usage| (
+                usage.objects_count,
+                usage.versions_count,
+                usage.delete_markers_count,
+                usage.size
+            )),
+            Some((1, 1, 0, 15))
+        );
+    }
+
     #[tokio::test]
     #[serial]
     async fn scanner_sync_preserves_dirty_delete_marker_with_later_snapshot() {

crates/ecstore/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up dead code; see https://github.com/rustfs/backlog/issues/742
 // Copyright 2024 RustFS Team
 //
 // Licensed under the Apache License, Version 2.0 (the "License");

crates/obs/src/metrics/collectors/audit.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! Audit metrics collector.
 //!

crates/obs/src/metrics/collectors/cluster_config.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! Cluster config metrics collector.
 //!

crates/obs/src/metrics/collectors/cluster_erasure_set.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! Cluster erasure set metrics collector.
 //!

crates/obs/src/metrics/collectors/cluster_health.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! Cluster health metrics collector.
 //!

crates/obs/src/metrics/collectors/cluster_iam.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! Cluster IAM metrics collector.
 //!

crates/obs/src/metrics/collectors/cluster_usage.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! Cluster usage metrics collector.
 //!

crates/obs/src/metrics/collectors/dial9.rs

@@ -17,7 +17,7 @@
 //! This module provides metrics for monitoring the health and performance
 //! of the dial9 telemetry system itself.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::MetricType;
 use crate::metrics::report::PrometheusMetric;

crates/obs/src/metrics/collectors/ilm.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! ILM (Information Lifecycle Management) metrics collector.
 //!

crates/obs/src/metrics/collectors/notification.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! Notification metrics collector.
 //!

crates/obs/src/metrics/collectors/notification_target.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::metrics::report::PrometheusMetric;
 use crate::metrics::schema::notification_target::{

crates/obs/src/metrics/collectors/replication.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! Replication metrics collector.
 //!

crates/obs/src/metrics/collectors/request.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! API request metrics collector.
 //!

crates/obs/src/metrics/collectors/scanner.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! Scanner metrics collector.
 //!

crates/obs/src/metrics/collectors/system_cpu.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! System CPU metrics collector.
 //!

crates/obs/src/metrics/collectors/system_drive.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! System drive metrics collector.
 //!

crates/obs/src/metrics/collectors/system_gpu.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! System GPU metrics collector.
 //!

crates/obs/src/metrics/collectors/system_memory.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! System memory metrics collector.
 //!

crates/obs/src/metrics/collectors/system_network.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! System network metrics collector.
 //!

crates/obs/src/metrics/collectors/system_process.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! System process metrics collector.
 //!

crates/obs/src/metrics/schema/audit.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/bucket.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, new_histogram_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/bucket_replication.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/cluster.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/cluster_config.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/cluster_erasure_set.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/cluster_health.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/cluster_iam.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_counter_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/cluster_notification.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/cluster_usage.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/ilm.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/node_bucket.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/node_disk.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, MetricSubsystem, new_gauge_md};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/notification_target.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/process_resource.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, MetricSubsystem, new_gauge_md};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/replication.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/request.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, MetricSubsystem, new_counter_md, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/scanner.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/system_cpu.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems};
 /// CPU system-related metric descriptors

crates/obs/src/metrics/schema/system_drive.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/system_gpu.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! GPU-related metric descriptors.
 //!

crates/obs/src/metrics/schema/system_memory.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/system_network.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/system_network_host.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/schema/system_process.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 use crate::{MetricDescriptor, MetricName, new_counter_md, new_gauge_md, subsystems};
 use std::sync::LazyLock;

crates/obs/src/metrics/stats_collector.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+#![warn(dead_code)] // Gradually clean up; see https://github.com/rustfs/backlog/issues/742
 
 //! Statistics collection functions for metrics.
 //!