cargo check

common/protos/src/generated/flatbuffers_generated/models.rs

@@ -1,9 +1,10 @@
 // automatically generated by the FlatBuffers compiler, do not modify
 
+
 // @generated
 
-use core::cmp::Ordering;
 use core::mem;
+use core::cmp::Ordering;
 
 extern crate flatbuffers;
 use self::flatbuffers::{EndianScalar, Follow};
@@ -11,8 +12,8 @@ use self::flatbuffers::{EndianScalar, Follow};
 #[allow(unused_imports, dead_code)]
 pub mod models {
 
-    use core::cmp::Ordering;
   use core::mem;
+  use core::cmp::Ordering;
 
   extern crate flatbuffers;
   use self::flatbuffers::{EndianScalar, Follow};
@@ -28,9 +29,7 @@ pub mod models {
   type Inner = PingBody<'a>;
   #[inline]
   unsafe fn follow(buf: &'a [u8], loc: usize) -> Self::Inner {
-            Self {
+    Self { _tab: flatbuffers::Table::new(buf, loc) }
-                _tab: flatbuffers::Table::new(buf, loc),
-            }
   }
 }
 
@@ -48,30 +47,28 @@ pub mod models {
   #[allow(unused_mut)]
   pub fn create<'bldr: 'args, 'args: 'mut_bldr, 'mut_bldr, A: flatbuffers::Allocator + 'bldr>(
     _fbb: &'mut_bldr mut flatbuffers::FlatBufferBuilder<'bldr, A>,
-            args: &'args PingBodyArgs<'args>,
+    args: &'args PingBodyArgs<'args>
   ) -> flatbuffers::WIPOffset<PingBody<'bldr>> {
     let mut builder = PingBodyBuilder::new(_fbb);
-            if let Some(x) = args.payload {
+    if let Some(x) = args.payload { builder.add_payload(x); }
-                builder.add_payload(x);
-            }
     builder.finish()
   }
 
+
   #[inline]
   pub fn payload(&self) -> Option<flatbuffers::Vector<'a, u8>> {
     // Safety:
     // Created from valid Table for this object
     // which contains a valid value in this slot
-            unsafe {
+    unsafe { self._tab.get::<flatbuffers::ForwardsUOffset<flatbuffers::Vector<'a, u8>>>(PingBody::VT_PAYLOAD, None)}
-                self._tab
-                    .get::<flatbuffers::ForwardsUOffset<flatbuffers::Vector<'a, u8>>>(PingBody::VT_PAYLOAD, None)
-            }
   }
 }
 
 impl flatbuffers::Verifiable for PingBody<'_> {
   #[inline]
-        fn run_verifier(v: &mut flatbuffers::Verifier, pos: usize) -> Result<(), flatbuffers::InvalidFlatbuffer> {
+  fn run_verifier(
+    v: &mut flatbuffers::Verifier, pos: usize
+  ) -> Result<(), flatbuffers::InvalidFlatbuffer> {
     use self::flatbuffers::Verifiable;
     v.visit_table(pos)?
      .visit_field::<flatbuffers::ForwardsUOffset<flatbuffers::Vector<'_, u8>>>("payload", Self::VT_PAYLOAD, false)?
@@ -85,7 +82,9 @@ pub mod models {
 impl<'a> Default for PingBodyArgs<'a> {
   #[inline]
   fn default() -> Self {
-            PingBodyArgs { payload: None }
+    PingBodyArgs {
+      payload: None,
+    }
   }
 }
 
@@ -96,8 +95,7 @@ pub mod models {
 impl<'a: 'b, 'b, A: flatbuffers::Allocator + 'a> PingBodyBuilder<'a, 'b, A> {
   #[inline]
   pub fn add_payload(&mut self, payload: flatbuffers::WIPOffset<flatbuffers::Vector<'b , u8>>) {
-            self.fbb_
+    self.fbb_.push_slot_always::<flatbuffers::WIPOffset<_>>(PingBody::VT_PAYLOAD, payload);
-                .push_slot_always::<flatbuffers::WIPOffset<_>>(PingBody::VT_PAYLOAD, payload);
   }
   #[inline]
   pub fn new(_fbb: &'b mut flatbuffers::FlatBufferBuilder<'a, A>) -> PingBodyBuilder<'a, 'b, A> {
@@ -122,3 +120,4 @@ pub mod models {
   }
 }
 }  // pub mod models
+

ecstore/src/disk/local.rs

@@ -6,8 +6,7 @@ use super::{endpoint::Endpoint, error::DiskError, format::FormatV3};
 use super::{
     os, CheckPartsResp, DeleteOptions, DiskAPI, DiskInfo, DiskInfoOptions, DiskLocation, DiskMetrics, FileInfoVersions,
     FileReader, FileWriter, Info, MetaCacheEntry, ReadMultipleReq, ReadMultipleResp, ReadOptions, RenameDataResp,
-    UpdateMetadataOpts, VolumeInfo, WalkDirOptions, BUCKET_META_PREFIX, FORMAT_CONFIG_FILE, RUSTFS_META_BUCKET,
+    UpdateMetadataOpts, VolumeInfo, WalkDirOptions, BUCKET_META_PREFIX, RUSTFS_META_BUCKET, STORAGE_FORMAT_FILE_BACKUP,
-    STORAGE_FORMAT_FILE_BACKUP,
 };
 use crate::bitrot::bitrot_verify;
 use crate::bucket::metadata_sys::{self};
@@ -51,7 +50,7 @@ use nix::NixPath;
 use path_absolutize::Absolutize;
 use std::collections::{HashMap, HashSet};
 use std::fmt::Debug;
-use std::io::{Cursor, Write};
+use std::io::Cursor;
 use std::os::unix::fs::MetadataExt;
 use std::sync::atomic::{AtomicU32, Ordering};
 use std::sync::Arc;

ecstore/src/heal/heal_ops.rs

@@ -2,7 +2,7 @@ use super::{
     background_heal_ops::HealTask,
     data_scanner::HEAL_DELETE_DANGLING,
     error::ERR_SKIP_FILE,
-    heal_commands::{HealOpts, HealScanMode, HealStopSuccess, HealingDisk, HealingTracker, HEAL_ITEM_BUCKET_METADATA},
+    heal_commands::{HealOpts, HealScanMode, HealStopSuccess, HealingTracker, HEAL_ITEM_BUCKET_METADATA},
 };
 use crate::store_api::StorageAPI;
 use crate::{

ecstore/src/metacache/writer.rs

@@ -1,11 +1,7 @@
 use crate::disk::MetaCacheEntry;
 use crate::error::Error;
 use crate::error::Result;
-use rmp::decode::RmpRead;
-use rmp::encode::RmpWrite;
 use rmp::Marker;
-use std::io::Read;
-use std::io::Write;
 use std::str::from_utf8;
 use tokio::io::AsyncRead;
 use tokio::io::AsyncReadExt;

ecstore/src/notification_sys.rs

@@ -32,7 +32,7 @@ pub struct NotificationSys {
 
 impl NotificationSys {
     pub async fn new(eps: EndpointServerPools) -> Self {
-        let (peer_clients, all_peer_clients) = PeerRestClient::new_clients(&eps).await;
+        let (peer_clients, all_peer_clients) = PeerRestClient::new_clients(eps).await;
         Self {
             peer_clients,
             all_peer_clients,

madmin/Cargo.toml

@@ -18,4 +18,3 @@ psutil = "3.3.0"
 serde.workspace = true
 time.workspace =true
 tracing.workspace = true
-time.workspace =true

rustfs/src/admin/handlers/trace.rs

@@ -29,7 +29,7 @@ impl Operation for Trace {
 
         // let (tx, rx) = mpsc::channel(10000);
         let perrs = match GLOBAL_Endpoints.get() {
-            Some(ep) => PeerRestClient::new_clients(ep).await,
+            Some(ep) => PeerRestClient::new_clients(ep.clone()).await,
             None => (Vec::new(), Vec::new()),
         };
         return Err(s3_error!(NotImplemented));

rustfs/src/main.rs

@@ -211,7 +211,6 @@ async fn run(opt: config::Opt) -> Result<()> {
         .await
         .map_err(|err| {
             error!("ECStore::new {:?}", &err);
-            panic!("{}", err);
             Error::from_string(err.to_string())
         })?;