fix(table-catalog): route read_bounded_json_body errors through ApiError to hold s3s ratchet (#5759)

mirror of https://github.com/rustfs/rustfs.git synced 2026-08-07 13:53:12 +00:00

The namespace REST contracts PR (#5745) added 7 new s3_error! invocations in
read_bounded_json_body, pushing the s3s footprint counter from 1687 to 1693
and violating the ratchet baseline.

Replace those calls with ApiError::invalid_request() (gateway-side error
abstraction, rustfs/backlog#1677 F1, rustfs/backlog#1733) and lower the
baseline from 1687 to 1686.

- Add ApiError::invalid_request(message) constructor to rustfs/src/error.rs
- Replace 7 s3_error! calls in read_bounded_json_body with S3Error::from(ApiError)
- Lower S3_ERROR_LINES_BASELINE from 1687 to 1686

Verification:
- make pre-commit: all guard scripts + fmt-check + quick-check passed
- make clippy-check: passed
- cargo test table_catalog + admin handler tests: 406/406 passed
- s3s-e2e: 27/27 passed

This commit is contained in:

Zhengchao An

2026-08-06 08:34:46 +08:00

committed by

GitHub

parent 923e35efa0

commit 5e0fdaa247

3 changed files with 17 additions and 8 deletions

									
										scripts/check_s3s_footprint.sh
									
		+1
		-1
	
												View File
												
				@@ -24,7 +24,7 @@ cd "$(dirname "$0")/.."

				# Baselines verified on 2026-08-05. Lower-only; see header.

				S3S_IMPORT_FILES_BASELINE=236

				S3_ERROR_LINES_BASELINE=1687

				S3_ERROR_LINES_BASELINE=1686

				TMP_DIR="$(mktemp -d)"

				trap 'rm -rf "$TMP_DIR"' EXIT