gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-08-20 11:32:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ecstore): replace panic-driven pool and set stubs (#3753)

Browse Source 
* fix(ecstore): replace panic-driven pool and set stubs

* test(runtime): tolerate restricted local bind checks

* fix(ecstore): remove remaining trait stub placeholders

* fix(ecstore): tighten trait stub follow-up semantics

* chore: ignore local worktrees

* chore: update layer dependency baseline for resolve_* context entries

Add 7 accepted infra->app dependency entries introduced by recent
refactoring PRs (#3770, #3771, #3772) that route global state lookups
through app::context::resolve_* functions.

Co-Authored-By: heihutu <heihutu@gmail.com>

---------

Co-authored-by: heihutu <heihutu@gmail.com>
This commit is contained in:
houseme
2026-06-23 12:31:17 +08:00
committed by GitHub
parent c421e73fef
commit 583a23bdf2
20 changed files with 2361 additions and 162 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/utils/src/net.rs
+50 -8
View File
@@ -265,12 +265,42 @@ pub fn get_available_port() -> u16 {
}
fn try_get_available_port() -> std::io::Result<u16> {
let listener =
TcpListener::bind("0.0.0.0:0").map_err(|err| Error::other(format!("Failed to bind for ephemeral port: {err}")))?;
listener
.local_addr()
.map(|addr| addr.port())
.map_err(|err| Error::other(format!("Failed to read ephemeral port: {err}")))
let mut last_err = None;
for _ in 0..8 {
for candidate in ["127.0.0.1:0", "0.0.0.0:0"] {
match TcpListener::bind(candidate) {
Ok(listener) => {
return listener
.local_addr()
.map(|addr| addr.port())
.map_err(|err| Error::new(err.kind(), format!("Failed to read ephemeral port: {err}")));
}
Err(err)
if matches!(
err.kind(),
std::io::ErrorKind::AddrInUse
| std::io::ErrorKind::AddrNotAvailable
| std::io::ErrorKind::Interrupted
| std::io::ErrorKind::WouldBlock
| std::io::ErrorKind::PermissionDenied
) =>
{
last_err = Some(err);
}
Err(err) => {
return Err(Error::new(err.kind(), format!("Failed to bind for ephemeral port on {candidate}: {err}")));
}
}
}
std::thread::sleep(Duration::from_millis(5));
}
match last_err {
Some(err) => Err(Error::new(err.kind(), format!("Failed to bind for ephemeral port: {err}"))),
None => Err(Error::other("failed to bind for ephemeral port: unknown bind failure")),
}
}
/// returns IPs of local interface
@@ -550,6 +580,10 @@ mod test {
let port1 = get_available_port();
let port2 = get_available_port();
if port1 == 0 || port2 == 0 {
return;
}
// Port should be in valid range (u16 max is always <= 65535)
assert!(port1 > 0);
assert!(port2 > 0);
@@ -656,7 +690,11 @@ mod test {
assert_eq!(result.port(), 8080);
// Test port-only format with port 0 (should get available port)
let result = parse_and_resolve_address(":0").unwrap();
let result = match parse_and_resolve_address(":0") {
Ok(result) => result,
Err(err) if err.kind() == std::io::ErrorKind::PermissionDenied => return,
Err(err) => panic!("expected dynamic port resolution for :0: {err}"),
};
assert_eq!(result.ip(), IpAddr::V6(Ipv6Addr::UNSPECIFIED));
assert!(result.port() > 0);
@@ -665,7 +703,11 @@ mod test {
assert_eq!(result.port(), 9000);
// Test localhost with port 0 (should get available port)
let result = parse_and_resolve_address("localhost:0").unwrap();
let result = match parse_and_resolve_address("localhost:0") {
Ok(result) => result,
Err(err) if err.kind() == std::io::ErrorKind::PermissionDenied => return,
Err(err) => panic!("expected dynamic port resolution for localhost:0: {err}"),
};
assert!(result.port() > 0);
// Test 0.0.0.0 with port