ci: ratchet ecstore ::other(format!) error construction shrink-only (#6614)

Backlog#1845 step 2. reduce_errs buckets per-disk errors by equality, and Io equality compares the rendered message, so an other(format!(..)) error embedding per-disk detail makes N same-cause failures count as N distinct errors during quorum aggregation. The census that opened the issue counted 1,609 such sites; the production count in crates/ecstore/src is 657 today and was still growing.

Freeze it: scripts/check_error_other_format_ratchet.sh counts ::other(format! sites per file (trailing #[cfg(test)] modules excluded) against a shrink-only per-file baseline, failing on any growth and on stale entries after a shrink, following the layer-dependency-baseline model. Wired into make pre-commit / pre-pr / dev-check and the CI Quick Checks job.

Ref rustfs/backlog#1845
This commit is contained in:
Zhengchao An
2026-08-26 10:21:25 +08:00
committed by GitHub
parent 9db1d6f06b
commit 4f4d268155
5 changed files with 231 additions and 3 deletions
+79
View File
@@ -0,0 +1,79 @@
# `::other(format!` ratchet baseline for crates/ecstore/src (backlog#1845 PR2).
#
# SHRINK-ONLY: entries are `count|file`. A PR may lower a count or drop a file
# (after replacing the call sites with typed variants) by re-running
# scripts/check_error_other_format_ratchet.sh --update-baseline. A PR that
# raises a count or adds a file is introducing a new quorum-bucketing hazard
# and must carry an explicit exemption rationale in its description.
2|crates/ecstore/src/bucket/bucket_target_sys.rs
4|crates/ecstore/src/bucket/lifecycle/bucket_lifecycle_ops.rs
3|crates/ecstore/src/bucket/lifecycle/durable_namespace.rs
2|crates/ecstore/src/bucket/lifecycle/metadata_boundary.rs
4|crates/ecstore/src/bucket/lifecycle/tier_delete_journal.rs
1|crates/ecstore/src/bucket/lifecycle/transition_transaction.rs
27|crates/ecstore/src/bucket/metadata.rs
22|crates/ecstore/src/bucket/metadata_sys.rs
3|crates/ecstore/src/bucket/msgp_decode.rs
1|crates/ecstore/src/bucket/object_lock/objectlock_sys.rs
3|crates/ecstore/src/bucket/quota/reservation.rs
1|crates/ecstore/src/bucket/replication/replication_object_config.rs
2|crates/ecstore/src/bucket/replication/replication_pool.rs
2|crates/ecstore/src/bucket/replication/replication_target_boundary.rs
1|crates/ecstore/src/client/api_put_object_multipart.rs
2|crates/ecstore/src/client/api_put_object_streaming.rs
1|crates/ecstore/src/client/api_s3_datatypes.rs
1|crates/ecstore/src/client/signer_error.rs
5|crates/ecstore/src/client/transition_api.rs
3|crates/ecstore/src/cluster/rpc/http_auth.rs
2|crates/ecstore/src/cluster/rpc/internode_data_transport.rs
17|crates/ecstore/src/cluster/rpc/peer_rest_client.rs
11|crates/ecstore/src/cluster/rpc/peer_s3_client.rs
43|crates/ecstore/src/cluster/rpc/remote_disk.rs
7|crates/ecstore/src/config/com.rs
14|crates/ecstore/src/config/storageclass.rs
185|crates/ecstore/src/core/pools.rs
8|crates/ecstore/src/data_movement/mod.rs
2|crates/ecstore/src/data_usage/local_snapshot.rs
12|crates/ecstore/src/data_usage/mod.rs
1|crates/ecstore/src/diagnostics/admin_server_info.rs
5|crates/ecstore/src/disk/local.rs
1|crates/ecstore/src/disk/mod.rs
5|crates/ecstore/src/erasure/codec/bridge.rs
1|crates/ecstore/src/erasure/coding/decode_reader.rs
10|crates/ecstore/src/erasure/coding/encode.rs
25|crates/ecstore/src/erasure/coding/erasure.rs
4|crates/ecstore/src/layout/disks_layout.rs
2|crates/ecstore/src/layout/endpoint.rs
17|crates/ecstore/src/layout/endpoints.rs
1|crates/ecstore/src/layout/format.rs
1|crates/ecstore/src/layout/pool_space.rs
1|crates/ecstore/src/layout/set_layout.rs
19|crates/ecstore/src/object_api/readers.rs
1|crates/ecstore/src/object_api/types.rs
3|crates/ecstore/src/runtime/sources.rs
4|crates/ecstore/src/services/batch_processor.rs
14|crates/ecstore/src/services/notification_sys.rs
16|crates/ecstore/src/services/rebalance/control.rs
1|crates/ecstore/src/services/rebalance/entry.rs
8|crates/ecstore/src/services/rebalance/meta.rs
8|crates/ecstore/src/services/rebalance/runtime.rs
19|crates/ecstore/src/services/rebalance/worker.rs
33|crates/ecstore/src/services/tier/tier.rs
1|crates/ecstore/src/services/tier/tier_config.rs
1|crates/ecstore/src/services/tier/warm_backend_gcs.rs
1|crates/ecstore/src/services/tier/warm_backend_s3.rs
1|crates/ecstore/src/services/tier/warm_backend_wasabi.rs
7|crates/ecstore/src/set_disk/core/io_primitives.rs
1|crates/ecstore/src/set_disk/mod.rs
3|crates/ecstore/src/set_disk/ops/bitrot_self_verify.rs
2|crates/ecstore/src/set_disk/ops/heal.rs
8|crates/ecstore/src/set_disk/ops/multipart.rs
2|crates/ecstore/src/set_disk/ops/object.rs
3|crates/ecstore/src/set_disk/read.rs
5|crates/ecstore/src/store/bucket.rs
1|crates/ecstore/src/store/heal_walk.rs
12|crates/ecstore/src/store/init.rs
2|crates/ecstore/src/store/init_format.rs
3|crates/ecstore/src/store/multipart.rs
8|crates/ecstore/src/store/object.rs
5|crates/ecstore/src/store/rebalance/support.rs