From 4f0e050b39d0c38227a659cb237ee85bc8c4ed95 Mon Sep 17 00:00:00 2001 From: hector <42570491+majinghe@users.noreply.github.com> Date: Sat, 12 Sep 2026 17:02:28 +0800 Subject: [PATCH] fix(pool): default the node-endpoints fallback to the 4-node fleet (#7696) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit RUSTFS_POOL_NODE_ENDPOINTS has no secret/var configured, so the suite ran with the workflow's inline 3-endpoint fallback and the explicit --node-endpoints flag overrode the script default fixed in rustfs/auto-testing#61 — every dispatch died at startup with 'must provide at least 4 direct node endpoints' (run 34677538650). Add rustfs-node4 to the fallback; explicit secret/var still wins. --- .github/workflows/rustfs-pool-expand-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rustfs-pool-expand-test.yml b/.github/workflows/rustfs-pool-expand-test.yml index e320402fa..f3736675f 100644 --- a/.github/workflows/rustfs-pool-expand-test.yml +++ b/.github/workflows/rustfs-pool-expand-test.yml @@ -83,7 +83,7 @@ jobs: RUSTFS_POOL_PROXY_ENDPOINT: http://127.0.0.1:19000 RUSTFS_POOL_WARP_ENDPOINT: http://127.0.0.1:19000 RUSTFS_SHARED_PROXY_ENDPOINT: ${{ secrets.RUSTFS_API_ENDPOINT || vars.RUSTFS_API_ENDPOINT || vars.RUSTFS_RC_ENDPOINT }} - RUSTFS_POOL_NODE_ENDPOINTS: ${{ secrets.RUSTFS_POOL_NODE_ENDPOINTS || vars.RUSTFS_POOL_NODE_ENDPOINTS || 'http://rustfs-node1:9000 http://rustfs-node2:9000 http://rustfs-node3:9000' }} + RUSTFS_POOL_NODE_ENDPOINTS: ${{ secrets.RUSTFS_POOL_NODE_ENDPOINTS || vars.RUSTFS_POOL_NODE_ENDPOINTS || 'http://rustfs-node1:9000 http://rustfs-node2:9000 http://rustfs-node3:9000 http://rustfs-node4:9000' }} steps: # auto-testing is private: clone it with the dedicated PF token (not # GITHUB_TOKEN) and retry transient GitHub/network failures.