fix: 小优化

ecstore/src/disk/error.rs

@@ -1,4 +1,4 @@
-use crate::error::{Error, Result, StdError};
+use crate::error::{Error, Result};
 
 #[derive(Debug, thiserror::Error)]
 pub enum DiskError {
@@ -34,43 +34,51 @@ pub enum DiskError {
 }
 
 impl DiskError {
-    pub fn check_disk_fatal_errs(errs: &Vec<Option<Error>>) -> Result<()> {
-        if Self::count_errs(errs, &DiskError::UnsupportedDisk) == errs.len() {
+    /// Checks if the given array of errors contains fatal disk errors.
+    /// If all errors are of the same fatal disk error type, returns the corresponding error.
+    /// Otherwise, returns Ok.
+    ///
+    /// # Parameters
+    /// - `errs`: A slice of optional errors.
+    ///
+    /// # Returns
+    /// If all errors are of the same fatal disk error type, returns the corresponding error.
+    /// Otherwise, returns Ok.
+    pub fn check_disk_fatal_errs(errs: &[Option<Error>]) -> Result<()> {
+        if DiskError::UnsupportedDisk.count_errs(errs) == errs.len() {
             return Err(DiskError::UnsupportedDisk.into());
         }
 
-        if Self::count_errs(errs, &DiskError::FileAccessDenied) == errs.len() {
+        if DiskError::FileAccessDenied.count_errs(errs) == errs.len() {
             return Err(DiskError::FileAccessDenied.into());
         }
 
-        if Self::count_errs(errs, &DiskError::DiskNotDir) == errs.len() {
+        if DiskError::DiskNotDir.count_errs(errs) == errs.len() {
             return Err(DiskError::DiskNotDir.into());
         }
 
         Ok(())
     }
 
-    pub fn count_errs(errs: &Vec<Option<Error>>, err: &DiskError) -> usize {
+    pub fn count_errs(&self, errs: &[Option<Error>]) -> usize {
         return errs
             .iter()
-            .filter(|&e| {
-                if e.is_some() {
-                    let e = e.as_ref().unwrap();
-                    let cast = e.downcast_ref::<DiskError>();
-                    if cast.is_some() {
-                        let cast = cast.unwrap();
-                        return cast == err;
-                    }
-                }
-                false
+            .filter(|&err| match err {
+                None => false,
+                Some(e) => self.is(e),
             })
             .count();
     }
 
-    pub fn quorum_unformatted_disks(errs: &Vec<Option<Error>>) -> bool {
-        Self::count_errs(errs, &DiskError::UnformattedDisk) >= (errs.len() / 2) + 1
+    pub fn quorum_unformatted_disks(errs: &[Option<Error>]) -> bool {
+        DiskError::UnformattedDisk.count_errs(errs) > (errs.len() / 2)
     }
 
+    pub fn should_init_erasure_disks(errs: &[Option<Error>]) -> bool {
+        DiskError::UnformattedDisk.count_errs(errs) == errs.len()
+    }
+
+    /// Check if the error is a disk error
     pub fn is(&self, err: &Error) -> bool {
         if let Some(e) = err.downcast_ref::<DiskError>() {
             e == self
@@ -78,18 +86,6 @@ impl DiskError {
             false
         }
     }
-
-    pub fn is_err<T: std::error::Error + ?Sized>(err: &T, disk_err: &DiskError) -> bool {
-        return false;
-        // let cast = err.
-        // if cast.is_none() {
-        //     return false;
-        // }
-
-        // let e = cast.unwrap();
-
-        // e == disk_err
-    }
 }
 
 impl PartialEq for DiskError {