gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-08-31 17:28:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve memory ordering for disk health tracker (#1412)

Browse Source
This commit is contained in:
weisd
2026-01-06 23:59:08 +08:00
committed by GitHub
parent 02f809312b
commit 3ce99939a3
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ecstore/src/disk/disk_store.rs
+5 -5
View File
@@ -95,22 +95,22 @@ impl DiskHealthTracker {
/// Check if disk is faulty /// Check if disk is faulty
pub fn is_faulty(&self) -> bool { pub fn is_faulty(&self) -> bool {
self.status.load(Ordering::Relaxed) == DISK_HEALTH_FAULTY self.status.load(Ordering::Acquire) == DISK_HEALTH_FAULTY
} }
/// Set disk as faulty /// Set disk as faulty
pub fn set_faulty(&self) { pub fn set_faulty(&self) {
self.status.store(DISK_HEALTH_FAULTY, Ordering::Relaxed); self.status.store(DISK_HEALTH_FAULTY, Ordering::Release);
} }
/// Set disk as OK /// Set disk as OK
pub fn set_ok(&self) { pub fn set_ok(&self) {
self.status.store(DISK_HEALTH_OK, Ordering::Relaxed); self.status.store(DISK_HEALTH_OK, Ordering::Release);
} }
pub fn swap_ok_to_faulty(&self) -> bool { pub fn swap_ok_to_faulty(&self) -> bool {
self.status self.status
.compare_exchange(DISK_HEALTH_OK, DISK_HEALTH_FAULTY, Ordering::Relaxed, Ordering::Relaxed) .compare_exchange(DISK_HEALTH_OK, DISK_HEALTH_FAULTY, Ordering::AcqRel, Ordering::Relaxed)
.is_ok() .is_ok()
} }
@@ -131,7 +131,7 @@ impl DiskHealthTracker {
/// Get last success timestamp /// Get last success timestamp
pub fn last_success(&self) -> i64 { pub fn last_success(&self) -> i64 {
self.last_success.load(Ordering::Relaxed) self.last_success.load(Ordering::Acquire)
} }
} }