gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-08-22 20:36:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(rustfs): allow drop_non_drop on dial9 guard for non-Drop feature sets (#4679)

Browse Source 
Under feature sets where the dial9 session guard carries no Drop impl (e.g.
--features sftp, after #4663), `drop(dial9_guard)` in the startup entrypoint
trips clippy::drop_non_drop and fails the sftp Test and Lint job. The drop is
an intentional flush point where the guard does implement Drop; annotate it so
it compiles clean across all feature combinations.
This commit is contained in:
Zhengchao An
2026-07-10 20:00:22 +08:00
committed by GitHub
parent 00536da80c
commit 36428bc490
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rustfs/src/startup_entrypoint.rs
+3 -1
View File
@@ -37,7 +37,9 @@ pub fn run_process() {
// Flush and seal the trace segment before any exit path. `process::exit` // Flush and seal the trace segment before any exit path. `process::exit`
// below does not run destructors, and neither does returning from `main` // below does not run destructors, and neither does returning from `main`
// for a guard held in a `static`. // for a guard held in a `static`. Under feature sets where the dial9 guard
// carries no Drop impl (e.g. `--features sftp`), this is an intentional no-op.
#[allow(clippy::drop_non_drop)]
drop(dial9_guard); drop(dial9_guard);
if let Err(ref e) = result { if let Err(ref e) = result {