mirror of
https://github.com/rustfs/rustfs.git
synced 2026-08-07 05:43:14 +00:00
Replace prints with logs and fix grammar (#437)
* refactor: replace print statements with proper logging and fix grammar - Fix English grammar errors in existing log messages - Add tracing imports where needed - Improve log message clarity and consistency - Follow project logging best practices using tracing crate * fix: resolve clippy warnings and format code - Fix unused import warnings by making test imports conditional with #[cfg(test)] - Fix unused variable warning by prefixing with underscore - Run cargo fmt to fix formatting issues - Ensure all code passes clippy checks with -D warnings flag * refactor: move tracing::debug import into test module Move the tracing::debug import from file-level #[cfg(test)] into the test module itself for better code organization and consistency with other test modules * Checkpoint before follow-up message Co-authored-by: anzhengchao <anzhengchao@gmail.com> * refactor: move tracing::debug import into test module in user_agent.rs Complete the refactoring by moving the tracing::debug import from file-level #[cfg(test)] into the test module for consistency across all test files --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This commit is contained in:
@@ -170,6 +170,7 @@ fn read_stat(file_name: &str) -> std::io::Result<Vec<u64>> {
|
||||
#[cfg(test)]
|
||||
mod test {
|
||||
use super::get_drive_stats;
|
||||
use tracing::debug;
|
||||
|
||||
#[ignore] // FIXME: failed in github actions
|
||||
#[test]
|
||||
@@ -177,6 +178,6 @@ mod test {
|
||||
let major = 7;
|
||||
let minor = 11;
|
||||
let s = get_drive_stats(major, minor).unwrap();
|
||||
println!("{s:?}");
|
||||
debug!("Drive stats for major: {}, minor: {} - {:?}", major, minor, s);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -74,8 +74,7 @@ mod tests {
|
||||
let temp_dir = tempfile::tempdir().unwrap();
|
||||
let info = get_info(temp_dir.path()).unwrap();
|
||||
|
||||
println!("Disk Info: {info:?}");
|
||||
|
||||
// Verify disk info is valid
|
||||
assert!(info.total > 0);
|
||||
assert!(info.free > 0);
|
||||
assert!(info.used > 0);
|
||||
@@ -109,10 +108,9 @@ mod tests {
|
||||
let path1 = temp_dir1.path().to_str().unwrap();
|
||||
let path2 = temp_dir2.path().to_str().unwrap();
|
||||
|
||||
let result = same_disk(path1, path2).unwrap();
|
||||
let _result = same_disk(path1, path2).unwrap();
|
||||
// Since both temporary directories are created in the same file system,
|
||||
// they should be on the same disk in most cases
|
||||
println!("Path1: {path1}, Path2: {path2}, Same disk: {result}");
|
||||
// Test passes if the function doesn't panic - the actual result depends on test environment
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user