chore: converge stale TODOs and apply safe fills (backlog#646) (#4322)

Second TODO-convergence round over the current tree (backlog#646). All
line numbers in the old inventory had gone stale after the set_disk /
diagnostics / cluster refactors, so this re-scans and reduces the marker
count from 144 to 99.

STALE removals (comment describes already-implemented behavior, or dead
commented-out blocks) across ecstore (set_disk ops/core, store,
cluster/rpc, bucket/metadata_sys, services), iam, filemeta, s3select and
rustfs auth/object_usecase. No behavior change.

Safe fills, each verified:
- filemeta: replication_info_equals now also compares
  replication_state_internal (function currently has no callers; adds a
  regression test).
- bitrot: drop the confirmed-unused `_want` parameter from bitrot_verify
  and the now-unused `sum` on LocalDisk::bitrot_verify, removing a
  Bytes::copy_from_slice allocation. Streaming verify uses the file's
  embedded per-shard hash, never the passed sum.
- signer: rename v4_ignored_headers -> V4_IGNORED_HEADERS and drop the
  non_upper_case_globals allow.
- admin/heal: test_decode was #[ignore]d and used serde_urlencoded on a
  JSON body (would panic); rewire to serde_json::from_slice to match the
  production decode path, add assertions, un-ignore.

Verified: cargo fmt; cargo check on touched crates; tests pass
(filemeta, signer, bitrot, heal::test_decode); arch guardrail scripts
pass.

crates/ecstore/src/set_disk/core/io_primitives.rs

@@ -2476,7 +2476,6 @@ impl SetDisks {
 
         let mut futures = Vec::with_capacity(disks.len());
         if let Some(ret_err) = reduce_write_quorum_errs(&errs, OBJECT_OP_IGNORED_ERRS, write_quorum) {
-            // TODO: add concurrency
             for (i, err) in errs.iter().enumerate() {
                 if err.is_some() {
                     continue;
@@ -2562,19 +2561,6 @@ impl SetDisks {
             vec![None; disks.len()]
         };
 
-        // // TODO: reduce_common_data_dir
-        // if let Some(old_dir) = rename_ress
-        //     .iter()
-        //     .filter_map(|v| if v.is_some() { v.as_ref().unwrap().old_data_dir } else { None })
-        //     .map(|v| v.to_string())
-        //     .next()
-        // {
-        //     let cm_errs = self.commit_rename_data_dir(&shuffle_disks, &bucket, &object, &old_dir).await;
-        //     warn!("put_object commit_rename_data_dir:{:?}", &cm_errs);
-        // }
-
-        // self.delete_all(RUSTFS_META_TMP_BUCKET, &tmp_dir).await?;
-
         Ok((online_disks, versions, data_dir, cleanup_disks))
     }
 

crates/ecstore/src/set_disk/mod.rs

@@ -1901,14 +1901,6 @@ impl SetDisks {
 
     //     Ok(())
     // }
-
-    // Shuffle the order
-
-    // Shuffle the order
-
-    // Return shuffled partsMetadata depending on distribution.
-
-    // shuffle_disks TODO: use origin value
 }
 
 fn is_explicit_null_version(version_id: Option<Uuid>) -> bool {

crates/ecstore/src/set_disk/ops/multipart.rs

@@ -1181,8 +1181,6 @@ impl crate::storage_api_contracts::multipart::MultipartOperations for SetDisks {
                 checksum_combined.extend_from_slice(cs.raw.as_slice());
             }
 
-            // TODO: check min part size
-
             object_size += ext_part.size;
             object_actual_size += ext_part.actual_size;
 

crates/ecstore/src/set_disk/ops/object.rs

@@ -783,8 +783,6 @@ impl crate::storage_api_contracts::object::ObjectIO for SetDisks {
                 .try_get_index()
                 .map(crate::io_support::rio::compression_index_storage_bytes);
 
-            //TODO: userDefined
-
             let mut etag = data.stream.try_resolve_etag().unwrap_or_default();
             if let Some(ref tag) = opts.preserve_etag {
                 etag = tag.clone();
@@ -1726,8 +1724,6 @@ impl crate::storage_api_contracts::object::ObjectOperations for SetDisks {
     async fn put_object_metadata(&self, bucket: &str, object: &str, opts: &ObjectOptions) -> Result<ObjectInfo> {
         self.invalidate_get_object_metadata_cache(bucket, object).await;
 
-        // TODO: nslock
-
         // Guard lock for metadata update
         let _lock_guard = if !opts.no_lock {
             Some(self.acquire_write_lock_diag("put_object_metadata", bucket, object).await?)
@@ -2179,11 +2175,8 @@ impl crate::storage_api_contracts::object::ObjectOperations for SetDisks {
 
         fi.metadata.insert(AMZ_OBJECT_TAGGING.to_owned(), tags.to_owned());
 
-        // TODO: userdeefined
-
         self.update_object_meta(bucket, object, fi.clone(), disks.as_slice()).await?;
 
-        // TODO: versioned
         Ok(ObjectInfo::from_file_info(&fi, bucket, object, opts.versioned || opts.version_suspended))
     }