gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-08-31 01:09:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: classify manual transition tier failures (#5335)

Browse Source 
Co-authored-by: heihutu <heihutu@gmail.com>
This commit is contained in:
houseme
2026-07-27 20:49:08 +08:00
committed by GitHub
parent 0a2370c024
commit 300beff970
4 changed files with 208 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ecstore/src/bucket/lifecycle/bucket_lifecycle_ops.rs
+29 -1
View File
@@ -1875,12 +1875,30 @@ fn manual_transition_worker_failure_reason(err: &Error) -> ManualTransitionWorke
if is_slow_down(err) {
return ManualTransitionWorkerFailureReason::SlowDown;
}
if is_network_or_host_down(&err.to_string(), false) {
let message = err.to_string();
if is_remote_tier_permission_denied_error(&message) {
return ManualTransitionWorkerFailureReason::PermissionDenied;
}
if is_remote_tier_network_error(&message) {
return ManualTransitionWorkerFailureReason::Network;
}
ManualTransitionWorkerFailureReason::Unknown
}
fn is_remote_tier_permission_denied_error(message: &str) -> bool {
message.contains("remote tier request failed with status 401")
|| message.contains("remote tier request failed with status 403")
|| message.contains("InvalidAccessKeyId")
|| message.contains("AccessDenied")
|| message.contains("SignatureDoesNotMatch")
}
fn is_remote_tier_network_error(message: &str) -> bool {
message.contains("client error (SendRequest)")
|| message.contains("dispatch failure")
|| is_network_or_host_down(message, false)
}
fn is_err_permission_denied(err: &Error) -> bool {
match err {
Error::VolumeAccessDenied | Error::FileAccessDenied | Error::PrefixAccessDenied(_, _) | Error::DiskAccessDenied => true,
@@ -7740,6 +7758,16 @@ mod tests {
manual_transition_worker_failure_reason(&Error::SlowDown),
ManualTransitionWorkerFailureReason::SlowDown
);
assert_eq!(
manual_transition_worker_failure_reason(&Error::Io(std::io::Error::other(
"remote tier request failed with status 403 Forbidden: InvalidAccessKeyId",
))),
ManualTransitionWorkerFailureReason::PermissionDenied
);
assert_eq!(
manual_transition_worker_failure_reason(&Error::Io(std::io::Error::other("client error (SendRequest)",))),
ManualTransitionWorkerFailureReason::Network
);
assert_eq!(
manual_transition_worker_failure_reason(&Error::MethodNotAllowed),
ManualTransitionWorkerFailureReason::Unknown