fix(lifecycle): prevent eager date-expiry deletion on config update (#2708)

2026-08-18 18:46:17 +00:00 · 2026-04-28 18:26:14 +08:00
parent e0b8c4fd42
commit 2953558f41
28 changed files with 3069 additions and 593 deletions
@@ -0,0 +1,177 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+PROJECT_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+COMPOSE_FILE="${COMPOSE_FILE:-docker-compose-simple.yml}"
+WAIT_TIMEOUT_SECS="${WAIT_TIMEOUT_SECS:-120}"
+KEEP_UP="${KEEP_UP:-false}"
+RUN_S3_TESTS="${RUN_S3_TESTS:-true}"
+BUILD_LOCAL_IMAGE="${BUILD_LOCAL_IMAGE:-true}"
+S3_HOST="${S3_HOST:-127.0.0.1}"
+S3_PORT="${S3_PORT:-9000}"
+
+usage() {
+  cat <<'USAGE'
+Usage:
+  scripts/validate_issue_1365_docker.sh [options]
+
+Options:
+  --compose-file <path>     docker compose file (default: docker-compose-simple.yml)
+  --wait-timeout <secs>     health wait timeout (default: 120)
+  --keep-up                 keep compose services up after the script exits
+  --skip-s3-tests           skip scripts/s3-tests/run.sh
+  --skip-build              skip local Dockerfile.source image build
+  -h, --help                show help
+
+Environment:
+  COMPOSE_FILE
+  WAIT_TIMEOUT_SECS
+  KEEP_UP
+  RUN_S3_TESTS
+  BUILD_LOCAL_IMAGE
+  S3_HOST
+  S3_PORT
+USAGE
+}
+
+log_info() {
+  printf '[INFO] %s\n' "$*"
+}
+
+log_error() {
+  printf '[ERROR] %s\n' "$*" >&2
+}
+
+require_cmd() {
+  if ! command -v "$1" >/dev/null 2>&1; then
+    log_error "command not found: $1"
+    exit 1
+  fi
+}
+
+compose() {
+  local compose_path
+  compose_path="$(resolve_compose_file)"
+  docker compose -f "${compose_path}" "$@"
+}
+
+resolve_compose_file() {
+  if [[ "${COMPOSE_FILE}" = /* ]]; then
+    printf '%s\n' "${COMPOSE_FILE}"
+  else
+    printf '%s\n' "${PROJECT_ROOT}/${COMPOSE_FILE}"
+  fi
+}
+
+cleanup() {
+  if [[ "${KEEP_UP}" == "true" ]]; then
+    log_info "KEEP_UP=true, leaving compose services running"
+    return
+  fi
+
+  log_info "Stopping docker compose services"
+  compose down -v >/dev/null 2>&1 || true
+}
+
+parse_args() {
+  while [[ $# -gt 0 ]]; do
+    case "$1" in
+      --compose-file)
+        COMPOSE_FILE="$2"
+        shift 2
+        ;;
+      --wait-timeout)
+        WAIT_TIMEOUT_SECS="$2"
+        shift 2
+        ;;
+      --keep-up)
+        KEEP_UP=true
+        shift
+        ;;
+      --skip-s3-tests)
+        RUN_S3_TESTS=false
+        shift
+        ;;
+      --skip-build)
+        BUILD_LOCAL_IMAGE=false
+        shift
+        ;;
+      -h|--help)
+        usage
+        exit 0
+        ;;
+      *)
+        log_error "unknown argument: $1"
+        usage
+        exit 1
+        ;;
+    esac
+  done
+}
+
+wait_for_endpoint() {
+  local url="$1"
+  local start now
+  start="$(date +%s)"
+
+  while true; do
+    if curl -fsS --connect-timeout 2 --max-time 3 "${url}" >/dev/null 2>&1; then
+      return 0
+    fi
+
+    now="$(date +%s)"
+    if (( now - start >= WAIT_TIMEOUT_SECS )); then
+      log_error "timed out waiting for ${url}"
+      compose ps || true
+      compose logs rustfs --tail 200 || true
+      return 1
+    fi
+
+    sleep 2
+  done
+}
+
+main() {
+  parse_args "$@"
+  require_cmd docker
+  require_cmd curl
+
+  trap cleanup EXIT INT TERM
+
+  if [[ "${BUILD_LOCAL_IMAGE}" == "true" ]]; then
+    log_info "Building rustfs/rustfs:latest from Dockerfile.source"
+    docker build -f "${PROJECT_ROOT}/Dockerfile.source" -t rustfs/rustfs:latest "${PROJECT_ROOT}"
+  else
+    log_info "Skipping local image build"
+  fi
+
+  if [[ -z "${RUSTFS_UNSAFE_BYPASS_DISK_CHECK+x}" ]]; then
+    export RUSTFS_UNSAFE_BYPASS_DISK_CHECK=true
+    log_info "RUSTFS_UNSAFE_BYPASS_DISK_CHECK not set; defaulting to true for local validation"
+  fi
+
+  log_info "Starting docker compose from $(resolve_compose_file)"
+  compose up -d
+
+  log_info "Waiting for RustFS health endpoint"
+  wait_for_endpoint "http://${S3_HOST}:${S3_PORT}/health"
+
+  log_info "Waiting for RustFS readiness endpoint"
+  wait_for_endpoint "http://${S3_HOST}:${S3_PORT}/health/ready"
+
+  log_info "Docker health checks passed"
+
+  if [[ "${RUN_S3_TESTS}" == "true" ]]; then
+    log_info "Running S3 compatibility tests against the running dockerized service"
+    (
+      cd "${PROJECT_ROOT}"
+      DEPLOY_MODE=existing S3_HOST="${S3_HOST}" S3_PORT="${S3_PORT}" ./scripts/s3-tests/run.sh
+    )
+  else
+    log_info "Skipping S3 compatibility tests"
+  fi
+
+  log_info "Issue 1365 docker validation completed successfully"
+}
+
+main "$@"