refactor: segment external storage api boundaries (#3903)

crates/s3select-api/src/lib.rs

@@ -25,7 +25,7 @@ mod storage_api;
 mod test;
 
 pub type QueryResult<T> = Result<T, QueryError>;
-pub(crate) use storage_api::{
+pub(crate) use storage_api::crate_boundary::{
     SELECT_DEFAULT_READ_BUFFER_SIZE, SelectGetObjectReader, SelectObjectInfo, SelectObjectOptions, SelectStorageError,
     SelectStore, resolve_select_object_store_handle, select_is_err_bucket_not_found, select_is_err_object_not_found,
     select_is_err_version_not_found,

crates/s3select-api/src/object_store.rs

@@ -48,7 +48,7 @@ use tokio::io::{AsyncRead, ReadBuf};
 use tokio_util::io::ReaderStream;
 use transform_stream::AsyncTryStream;
 
-use crate::storage_api::{HTTPRangeSpec, ObjectIO as _, ObjectOperations as _};
+use crate::storage_api::object_store::{HTTPRangeSpec, ObjectIO as _, ObjectOperations as _};
 
 fn select_default_read_buffer_size_u64() -> u64 {
     u64::try_from(SELECT_DEFAULT_READ_BUFFER_SIZE).unwrap_or(u64::MAX)

crates/s3select-api/src/storage_api.rs

@@ -25,6 +25,18 @@ pub(crate) use rustfs_ecstore::api::set_disk::DEFAULT_READ_BUFFER_SIZE as SELECT
 pub(crate) use rustfs_ecstore::api::storage::ECStore as SelectStore;
 pub(crate) use rustfs_storage_api::{HTTPRangeSpec, ObjectIO, ObjectOperations};
 
+pub(crate) mod object_store {
+    pub(crate) use super::{HTTPRangeSpec, ObjectIO, ObjectOperations};
+}
+
+pub(crate) mod crate_boundary {
+    pub(crate) use super::{
+        SELECT_DEFAULT_READ_BUFFER_SIZE, SelectGetObjectReader, SelectObjectInfo, SelectObjectOptions, SelectStorageError,
+        SelectStore, resolve_select_object_store_handle, select_is_err_bucket_not_found, select_is_err_object_not_found,
+        select_is_err_version_not_found,
+    };
+}
+
 pub(crate) type SelectGetObjectReader = <SelectStore as ObjectIO>::GetObjectReader;
 pub(crate) type SelectObjectInfo = <SelectStore as ObjectOperations>::ObjectInfo;
 pub(crate) type SelectObjectOptions = <SelectStore as ObjectOperations>::ObjectOptions;