mirror of
https://github.com/rustfs/rustfs.git
synced 2026-08-21 11:56:38 +00:00
docs(agents): run adversarial review before pre-pr (#6325)
docs(agents): order adversarial review before pre-pr
This commit is contained in:
@@ -127,8 +127,9 @@ the broadest gate. Inspect only the final task-owned diff, classify it by
|
|||||||
behavioral impact rather than line count or path alone, and run the smallest
|
behavioral impact rather than line count or path alone, and run the smallest
|
||||||
set of checks that provides meaningful coverage. Do not let unrelated
|
set of checks that provides meaningful coverage. Do not let unrelated
|
||||||
worktree changes or a generic contributor checklist expand the scope.
|
worktree changes or a generic contributor checklist expand the scope.
|
||||||
Non-exempt changes must also pass Adversarial Validation (next section) before
|
For non-exempt changes, complete the applicable multi-role adversarial review
|
||||||
the checks below count as completion.
|
before running `make pre-pr` (or an equivalent full gate). Resolve or rebut
|
||||||
|
every finding first, then run the gate against the reviewed final diff.
|
||||||
|
|
||||||
### Validation floor
|
### Validation floor
|
||||||
|
|
||||||
@@ -166,8 +167,9 @@ the checks below count as completion.
|
|||||||
dependency set is identifiable, validate those packages and known
|
dependency set is identifiable, validate those packages and known
|
||||||
dependents instead of the whole workspace. Use `make pre-commit` only when
|
dependents instead of the whole workspace. Use `make pre-commit` only when
|
||||||
a repository-wide fast gate adds useful confidence beyond those checks.
|
a repository-wide fast gate adds useful confidence beyond those checks.
|
||||||
4. **Broad or high-risk change:** Run `make pre-pr` only when targeted coverage
|
4. **Broad or high-risk change:** After the applicable adversarial review has
|
||||||
cannot bound the impact, including:
|
completed, run `make pre-pr` only when targeted coverage cannot bound the
|
||||||
|
impact, including:
|
||||||
- dependency, feature, build-script, procedural-macro, code-generation,
|
- dependency, feature, build-script, procedural-macro, code-generation,
|
||||||
toolchain, or CI changes that alter compilation or the test matrix;
|
toolchain, or CI changes that alter compilation or the test matrix;
|
||||||
- cross-crate public APIs, shared foundational code, or broad refactors with
|
- cross-crate public APIs, shared foundational code, or broad refactors with
|
||||||
@@ -287,8 +289,9 @@ High risk: all seven roles.
|
|||||||
- Every testable behavior change has a focused regression check. Exceptions
|
- Every testable behavior change has a focused regression check. Exceptions
|
||||||
follow the validation floor and state why a check is impractical and what
|
follow the validation floor and state why a check is impractical and what
|
||||||
risk remains.
|
risk remains.
|
||||||
- The Verification Before PR gates pass — adversarial review supplements
|
- After the applicable adversarial review has completed, the Verification
|
||||||
those gates, never replaces them.
|
Before PR gates pass; adversarial review supplements those gates, never
|
||||||
|
replaces them.
|
||||||
- High risk only: record a one-line verdict per role in the PR description.
|
- High risk only: record a one-line verdict per role in the PR description.
|
||||||
|
|
||||||
## Git and PR Baseline
|
## Git and PR Baseline
|
||||||
|
|||||||
+6
-4
@@ -91,8 +91,9 @@ A green `make pre-commit` is not enough to open a pull request.
|
|||||||
`make pre-pr` is the **full** gate: it runs all of the guard checks above,
|
`make pre-pr` is the **full** gate: it runs all of the guard checks above,
|
||||||
then `clippy-check` (`cargo clippy --all-targets --all-features -- -D warnings`)
|
then `clippy-check` (`cargo clippy --all-targets --all-features -- -D warnings`)
|
||||||
and `test` (shell script tests, workspace tests excluding `e2e_test`, and doc
|
and `test` (shell script tests, workspace tests excluding `e2e_test`, and doc
|
||||||
tests). Run `make pre-pr` before opening or updating a pull request — this is
|
tests). Complete the applicable multi-role adversarial review described in
|
||||||
what CI enforces.
|
`AGENTS.md` before running `make pre-pr`; then run the gate before opening or
|
||||||
|
updating a pull request. This is what CI enforces.
|
||||||
|
|
||||||
### 🔒 Git Pre-commit Hooks (optional)
|
### 🔒 Git Pre-commit Hooks (optional)
|
||||||
|
|
||||||
@@ -150,8 +151,9 @@ Example output when formatting fails:
|
|||||||
2. **Format your code**: `make fmt` or `cargo fmt --all`
|
2. **Format your code**: `make fmt` or `cargo fmt --all`
|
||||||
3. **Run the fast gate**: `make pre-commit` (no clippy, no tests)
|
3. **Run the fast gate**: `make pre-commit` (no clippy, no tests)
|
||||||
4. **Commit your changes**: `git commit -m "your message"`
|
4. **Commit your changes**: `git commit -m "your message"`
|
||||||
5. **Run the full gate before opening/updating a PR**: `make pre-pr` (clippy + tests)
|
5. **Complete the applicable multi-role adversarial review** for non-exempt changes (see `AGENTS.md`)
|
||||||
6. **Push to your branch**: `git push`
|
6. **Run the full gate before opening/updating a PR**: `make pre-pr` (clippy + tests)
|
||||||
|
7. **Push to your branch**: `git push`
|
||||||
|
|
||||||
### 🛠️ IDE Integration
|
### 🛠️ IDE Integration
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user