From 17ae335313aae6ef36eb8be122f53048a2babf67 Mon Sep 17 00:00:00 2001 From: Zhengchao An Date: Wed, 24 Jun 2026 08:43:05 +0800 Subject: [PATCH] chore: split pre-pr quality gate (#3807) --- .config/make/pre-commit.mak | 8 ++++++-- AGENTS.md | 7 +++++++ Makefile | 4 ++-- 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/.config/make/pre-commit.mak b/.config/make/pre-commit.mak index c816076f4..7665b5229 100644 --- a/.config/make/pre-commit.mak +++ b/.config/make/pre-commit.mak @@ -1,6 +1,6 @@ ## —— Pre Commit Checks ---------------------------------------------------------------------------- -.NOTPARALLEL: pre-commit dev-check +.NOTPARALLEL: pre-commit pre-pr dev-check .PHONY: setup-hooks setup-hooks: ## Set up git hooks @@ -9,9 +9,13 @@ setup-hooks: ## Set up git hooks @echo "✅ Git hooks setup complete!" .PHONY: pre-commit -pre-commit: fmt-check unsafe-code-check architecture-migration-check logging-guardrails-check clippy-check test ## Run full pre-commit checks +pre-commit: fmt-check unsafe-code-check architecture-migration-check logging-guardrails-check quick-check ## Run fast pre-commit checks @echo "✅ All pre-commit checks passed!" +.PHONY: pre-pr +pre-pr: fmt-check unsafe-code-check architecture-migration-check logging-guardrails-check clippy-check test ## Run full pre-PR checks + @echo "✅ All pre-PR checks passed!" + .PHONY: dev-check dev-check: fmt-check unsafe-code-check architecture-migration-check logging-guardrails-check quick-check ## Run fast local development checks @echo "✅ Fast development checks passed!" diff --git a/AGENTS.md b/AGENTS.md index 7951a4b89..821e82375 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -67,6 +67,13 @@ Convert changes into independently verifiable outcomes. Prefer focused tests for For code changes, run and pass the following before opening a PR: +```bash +make pre-pr +``` + +Before committing code changes, prefer focused verification for the touched +surface and use the faster local gate when a broad smoke check is needed: + ```bash make pre-commit ``` diff --git a/Makefile b/Makefile index 42c9949cd..5be3faa7d 100644 --- a/Makefile +++ b/Makefile @@ -66,7 +66,8 @@ How to use me: make fmt # Format code make clippy # Run clippy checks make test # Run tests - make pre-commit # Run all pre-commit checks + make pre-commit # Run fast pre-commit checks + make pre-pr # Run full pre-PR checks 🚀 Quick Start: make build # Build RustFS binary @@ -78,4 +79,3 @@ endef export HEADER -include $(addsuffix /*.mak, $(shell find .config/make -type d)) -