From 12db8f3cfac98026a37b98d0c622359345211adb Mon Sep 17 00:00:00 2001 From: overtrue Date: Sun, 23 Aug 2026 02:21:22 +0800 Subject: [PATCH] fix: resolve clippy warnings in ecstore - Remove unused mut on accounting variable in store/object.rs - Use sort_by_key with Reverse instead of sort_by in rebalance/support.rs --- crates/ecstore/src/store/object.rs | 2 +- crates/ecstore/src/store/rebalance/support.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/ecstore/src/store/object.rs b/crates/ecstore/src/store/object.rs index 79a8232f7..7a8653415 100644 --- a/crates/ecstore/src/store/object.rs +++ b/crates/ecstore/src/store/object.rs @@ -3194,7 +3194,7 @@ impl ECStore { // Default return value let mut del_objects = vec![DeletedObject::default(); objects.len()]; - let mut accounting = vec![None; objects.len()]; + let accounting = vec![None; objects.len()]; let mut del_errs = Vec::with_capacity(objects.len()); for _ in 0..objects.len() { diff --git a/crates/ecstore/src/store/rebalance/support.rs b/crates/ecstore/src/store/rebalance/support.rs index 6e4db41b8..b491e250b 100644 --- a/crates/ecstore/src/store/rebalance/support.rs +++ b/crates/ecstore/src/store/rebalance/support.rs @@ -271,7 +271,7 @@ pub(super) fn resolve_latest_object_info_candidates( .filter(|candidate| latest_candidate_mod_time(candidate) == Some(latest_mod_time)) .collect::>(); - latest_candidates.sort_by(|left, right| right.idx.cmp(&left.idx)); + latest_candidates.sort_by_key(|right| std::cmp::Reverse(right.idx)); let Some(winner) = latest_candidates.first() else { return Err(Error::ErasureReadQuorum);