refactor(concurrency): remove zero-caller facade modules, fix feature build (#4530)

mirror of https://github.com/rustfs/rustfs.git synced 2026-07-26 08:18:18 +00:00

refactor(concurrency): remove zero-caller facade modules and fix no-default-features build (backlog#1025)

The audit in rustfs/backlog#1010 (consistent with #805) established that most of crates/concurrency was a decorative facade with zero production callers; the real runtime concurrency control lives in rustfs/src/storage/*. This deletes the dead facades and keeps only what the workspace actually consumes.

Deleted (zero callers verified by workspace-wide grep):
- manager.rs: ConcurrencyManager, lifecycle start/stop, misleading 'started' lifecycle logs
- config.rs: ConcurrencyConfig, ConcurrencyFeatures, from_env
- timeout.rs: TimeoutManager, TimeoutGuard, TimeoutManagerPolicy
- lock.rs: LockManager, LockScopeGuard, OptimizedLockGuard
- scheduler.rs: SchedulerManager, SchedulerPolicy, IoStrategy
- deadlock.rs facade: DeadlockManager, RequestTracker
- backpressure.rs facade: BackpressureManager, BackpressurePipe
- the prelude module, unused io-core re-exports, and all feature flags

Kept (real callers in ecstore/heal/rustfs):
- workload.rs admission contract types (unchanged)
- workers.rs Workers pool (unchanged, retained per #4498)
- GetObjectQueueSnapshot (moved from manager.rs to new queue.rs)
- PipeBackpressurePolicy (used by rustfs/src/storage/backpressure.rs)
- DeadlockMonitorPolicy (used by rustfs/src/storage/deadlock_detector.rs)
- OperationProgress re-export (used by rustfs/src/storage/timeout_wrapper.rs)

Removing the feature flags fixes the previously broken cargo check -p rustfs-concurrency --no-default-features (E0432). Docs and the logging guardrail file list are updated to match.

Ref: rustfs/backlog#1025

This commit is contained in:

Zhengchao An

2026-07-09 01:12:43 +08:00

committed by

GitHub

parent a7b9659e75

commit 05833063c7

15 changed files with 152 additions and 2022 deletions

									
										ARCHITECTURE.md
									
		+1
		-1
	
												View File
												
				@@ -141,7 +141,7 @@ Depth 8 — TOP:

				| `io-metrics` | 4.5K | I/O operation metrics and counters |

				| `rio` | 6.9K | Composable reader chain (encrypt → compress → hash → limit) |

				| `object-io` | 2.4K | High-level object read/write using rio + ecstore |

				| `concurrency` | 1.8K | Concurrency control wrappers over io-core |

				| `concurrency` | 0.8K | Shared concurrency contract types: workload admission snapshots, worker-slot pool, policy types (runtime control lives in `rustfs/src/storage`) |

				**Storage Engine:**